173515 2017-06-17 12:47:42 -0700 REGRESSION(r218438): Caused imported/w3c/web-platform-tests/media-source/mediasource* tests to fail (Requested by smfr on #webkit). 2017-06-17 23:00:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 173505 1 commit-queue commit-queue jer.noble simon.fraser thorton oldest_to_newest 1320413 0 commit-queue 2017-06-17 12:47:42 -0700 http://trac.webkit.org/changeset/218438 broke the build: Caused imported/w3c/web-platform-tests/media-source/mediasource* tests to fail (Requested by smfr on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1320415 1 313207 commit-queue 2017-06-17 12:47:46 -0700 Created attachment 313207 ROLLOUT of r218438 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1320417 2 313207 simon.fraser 2017-06-17 12:48:37 -0700 Comment on attachment 313207 ROLLOUT of r218438 Failures: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r218438%20(2552)/results.html also affecting EWS 1320420 3 313207 commit-queue 2017-06-17 12:50:54 -0700 Comment on attachment 313207 ROLLOUT of r218438 Clearing flags on attachment: 313207 Committed r218454: <http://trac.webkit.org/changeset/218454> 1320421 4 commit-queue 2017-06-17 12:50:55 -0700 All reviewed patches have been landed. Closing bug. 1320480 5 jer.noble 2017-06-17 22:58:39 -0700 I found the underlying issue behind the test failures, and it has nothing to do with this patch, except in that this patch causes it to happen much more frequently. When a client specifies a timestamp offset, the SourceBuffer code stores the current presentation time as a float (because a MediaTime + float = float). But the sample itself store it as a MediaTime. Generally speaking, we use the sample's presentation time as the key to our storage, but in one instance (the decodeQueue) we are using the local value of presentation time (the float). This leads to a mismatch later when it comes time to remove those samples from the decode queue, so the samples are left in the decode queue, which causes a decode error, which breaks this test. 1320481 6 jer.noble 2017-06-17 22:59:32 -0700 (BTW, I'm pretty sure that this is the cause of some existing flakiness of some of these tests.) 1320482 7 jer.noble 2017-06-17 23:00:01 -0700 Gah, I should really be commenting in the related radar. :( 313207 2017-06-17 12:47:46 -0700 2017-06-17 12:50:54 -0700 ROLLOUT of r218438 bug-173515-20170617154745.patch text/plain 2061 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTcyMjE0ZmEyOWVkMWM5 MjY4NmEzMzY2Y2Q1NzRiNzYwODJlM2Y3MC4uNDJlNmU5MWEwMDE4YzI5ZWU2OWY5MWNhODhmYWVj NDI3ZTI0YTZjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA2LTE3ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMjE4NDM4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTczNTE1CisKKyAgICAgICAgQ2F1c2VkIGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvbWVkaWEtCisgICAgICAgIHNvdXJjZS9tZWRpYXNvdXJjZSogdGVzdHMg dG8gZmFpbCAoUmVxdWVzdGVkIGJ5IHNtZnIgb24KKyAgICAgICAgI3dlYmtpdCkuCisKKyAgICAg ICAgUmV2ZXJ0ZWQgY2hhbmdlc2V0OgorCisgICAgICAgICJbTVNFXSBTZWVraW5nIG9yIGVudGVy aW5nIGZ1bGxzY3JlZW4gY2FuIGNhdXNlIGV4dHJlbWUgQ1BVCisgICAgICAgIHVzYWdlIgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNTA1CisgICAg ICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzIxODQzOAorCiAyMDE3LTA2LTE3 ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBkdWUg dG8gaW5maW5pdGUgcmVjdXJzaW9uIHZpYSBGcmFtZVNlbGVjdGlvbjo6dXBkYXRlQXBwZWFyYW5j ZUFmdGVyTGF5b3V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbSBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1ZmZl clByaXZhdGVBVkZPYmpDLm1tCmluZGV4IDg5OGRkMjdjNjEwNTA2OGNhYjJlYjUyMjM0ZDZkN2Yx YjI5ODEyOGQuLjMwMDgyYjdjZWFmOGJkYjQ0NjkzNDM5OTAyMGM3MGQxOTk1NjlmYjIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L1NvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpD Lm1tCkBAIC0xMDAyLDEyICsxMDAyLDggQEAgdm9pZCBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2Jq Qzo6YnVmZmVyV2FzQ29uc3VtZWQoKQogYm9vbCBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6 aXNSZWFkeUZvck1vcmVTYW1wbGVzKGNvbnN0IEF0b21pY1N0cmluZyYgdHJhY2tJRFN0cmluZykK IHsKICAgICBpbnQgdHJhY2tJRCA9IHRyYWNrSURTdHJpbmcudG9JbnQoKTsKLSAgICBpZiAodHJh Y2tJRCA9PSBtX2VuYWJsZWRWaWRlb1RyYWNrSUQpIHsKLSAgICAgICAgaWYgKG1fZGVjb21wcmVz c2lvblNlc3Npb24pCi0gICAgICAgICAgICByZXR1cm4gbV9kZWNvbXByZXNzaW9uU2Vzc2lvbi0+ aXNSZWFkeUZvck1vcmVNZWRpYURhdGEoKTsKLQotICAgICAgICByZXR1cm4gW21fZGlzcGxheUxh eWVyIGlzUmVhZHlGb3JNb3JlTWVkaWFEYXRhXTsKLSAgICB9CisgICAgaWYgKHRyYWNrSUQgPT0g bV9lbmFibGVkVmlkZW9UcmFja0lEKQorICAgICAgICByZXR1cm4gIW1fZGVjb21wcmVzc2lvblNl c3Npb24gfHwgbV9kZWNvbXByZXNzaW9uU2Vzc2lvbi0+aXNSZWFkeUZvck1vcmVNZWRpYURhdGEo KTsKIAogICAgIGlmIChtX2F1ZGlvUmVuZGVyZXJzLmNvbnRhaW5zKHRyYWNrSUQpKQogICAgICAg ICByZXR1cm4gW21fYXVkaW9SZW5kZXJlcnMuZ2V0KHRyYWNrSUQpIGlzUmVhZHlGb3JNb3JlTWVk aWFEYXRhXTsK