173485 2017-06-16 11:31:13 -0700 DRT fails to reset page visibility between tests 2017-06-16 13:09:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168409 P2 Normal --- 1 cdumez cdumez ap graouts lforschler ryanhaddad simon.fraser oldest_to_newest 1320041 0 cdumez 2017-06-16 11:31:13 -0700 DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility(). Fix this to address flakiness. 1320046 1 313098 cdumez 2017-06-16 11:36:36 -0700 Created attachment 313098 Patch 1320110 2 313098 simon.fraser 2017-06-16 13:07:49 -0700 Comment on attachment 313098 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313098&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1830 > + if (gTestRunner) > + gTestRunner->resetPageVisibility(); > + > if (gTestRunner) { Can't you just have the if (gTestRunner) once? 1320113 3 cdumez 2017-06-16 13:09:28 -0700 Committed r218406: <http://trac.webkit.org/changeset/218406> 313098 2017-06-16 11:36:36 -0700 2017-06-16 13:07:49 -0700 Patch bug-173485-20170616113635.patch text/plain 1908 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MzkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTJkOTE5NDVjNTc2ZTc1ODY2N2Q1MzY1MmJmYjg0ZDky MzdlY2U2ZS4uNDI4NzE2MDI1MWY0MTQ3NzM5M2RmN2EyN2I2NjAzZjIzZjQyYzBkNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE3LTA2LTE2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgRFJUIGZhaWxzIHRvIHJlc2V0IHBhZ2UgdmlzaWJpbGl0eSBiZXR3ZWVuIHRlc3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM0ODUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEUlQgZmFpbHMgdG8g cmVzZXQgcGFnZSB2aXNpYmlsaXR5IGJldHdlZW4gdGVzdHMgYW5kIHJlbGllcyBvbiB0ZXN0cyBj YWxsaW5nIHRlc3RSdW5uZXIucmVzZXRQYWdlVmlzaWJpbGl0eSgpLgorICAgICAgICBGaXggdGhp cyB0byBhZGRyZXNzIGZsYWtpbmVzcy4KKworICAgICAgICBJIGNvbmZpcm1lZCB0aGlzIGJ5IGNv bW1lbnRpbmcgb3V0IHRoZSBjYWxsIHRvIHRlc3RSdW5uZXIucmVzZXRQYWdlVmlzaWJpbGl0eSgp IGluCisgICAgICAgIGZhc3QvZXZlbnRzL3BhZ2UtdmlzaWJpbGl0eS1vbnZpc2liaWxpdHljaGFu Z2UuaHRtbCBhbmQgcnVubmluZyB0aGUgdGVzdCBpbiBhIGxvb3AuCisgICAgICAgIFRoZSB0ZXN0 IGJlY2FtZSBmbGFreSB3aXRob3V0IHRoZSBEUlQgY2hhbmdlIGFuZCB3YXMgbm8gbG9uZ2VyIGZs YWt5IHdpdGggdGhlIERSVAorICAgICAgICBjaGFuZ2UuCisKKyAgICAgICAgV2ViS2l0VGVzdFJ1 bm5lciBhbHJlYWR5IGRvZXMgdGhpcy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9E dW1wUmVuZGVyVHJlZS5tbToKKyAgICAgICAgKHJlc2V0V2ViVmlld1RvQ29uc2lzdGVudFN0YXRl QmVmb3JlVGVzdGluZyk6CisKIDIwMTctMDYtMTUgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dlYlJUQ10gUmVtb3ZpbmcgYSBNZWRpYVN0cmVhbVRyYWNrIGZy b20gYSBNZWRpYVN0cmVhbSByZXBvcnRzIG5vIHJlY29yZGluZyB0byBXZWJLaXQgY2xpZW50cwpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCmluZGV4IDhjZWY2NWRj ZWYxNjdkYTBjNWFmYTljZTBhNTVkZGRkNWM1OWFiNmYuLjQ4NGE4MTljNDg5OWEwNDlhZDg4NWI2 NjJiY2QxNTMxZTZkYTIwN2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9E dW1wUmVuZGVyVHJlZS5tbQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRl clRyZWUubW0KQEAgLTE4MjQsNiArMTgyNCw5IEBAIHN0YXRpYyB2b2lkIHJlc2V0V2ViVmlld1Rv Q29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZyhjb25zdCBUZXN0T3B0aW9ucyYgb3B0aW9uCiAK ICAgICBzZXRsb2NhbGUoTENfQUxMLCAiIik7CiAKKyAgICBpZiAoZ1Rlc3RSdW5uZXIpCisgICAg ICAgIGdUZXN0UnVubmVyLT5yZXNldFBhZ2VWaXNpYmlsaXR5KCk7CisKICAgICBpZiAoZ1Rlc3RS dW5uZXIpIHsKICAgICAgICAgV2ViQ29yZVRlc3RTdXBwb3J0OjpyZXNldEludGVybmFsc09iamVj dChbbWFpbkZyYW1lIGdsb2JhbENvbnRleHRdKTsKICAgICAgICAgLy8gaW4gdGhlIGNhc2UgdGhh dCBhIHRlc3QgdXNpbmcgdGhlIGNocm9tZSBpbnB1dCBmaWVsZCBmYWlsZWQsIGJlIHN1cmUgdG8g Y2xlYW4gdXAgZm9yIHRoZSBuZXh0IHRlc3QK