173481 2017-06-16 11:14:11 -0700 Include a few widespread WTF headers in WebCorePrefix.h 2017-10-03 20:17:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 173494 1 thorton thorton achristensen ap buildbot commit-queue ggaren jlewis3 mitz sam simon.fraser oldest_to_newest 1320030 0 thorton 2017-06-16 11:14:11 -0700 Include a few widespread WTF headers in WebCorePrefix.h 1320031 1 313094 thorton 2017-06-16 11:14:19 -0700 Created attachment 313094 Patch 1320034 2 buildbot 2017-06-16 11:16:26 -0700 Attachment 313094 did not pass style-queue: ERROR: Source/WebCore/WebCorePrefix.h:167: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1320090 3 thorton 2017-06-16 12:45:01 -0700 https://trac.webkit.org/changeset/218402/webkit 1320097 4 thorton 2017-06-16 12:52:23 -0700 Build fix in https://trac.webkit.org/changeset/218404/webkit 1320134 5 commit-queue 2017-06-16 13:44:49 -0700 Re-opened since this is blocked by bug 173494 1320362 6 thorton 2017-06-17 01:22:14 -0700 Ooh! I can reproduce the build failure by building with dSYMs enabled: ./Tools/Scripts/build-webkit --release ARCHS=x86_64 DEBUG_INFORMATION_FORMAT=dwarf-with-dsym /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/dsymutil /Build/Release/WebCore.framework/Versions/A/WebCore -o /Build/Release/WebCore.framework.dSYM LLVM ERROR: IO failure on output stream. Command /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/dsymutil failed with exit code 1 1320371 7 thorton 2017-06-17 03:03:03 -0700 Adding WTFString or Optional by themselves seems to have the same effect 1320372 8 thorton 2017-06-17 03:20:28 -0700 Ditto for StdLibExtras... 1320394 9 simon.fraser 2017-06-17 10:13:26 -0700 How big is the dSYM file before your changes? 1320404 10 thorton 2017-06-17 11:06:52 -0700 1.4GB 1320447 11 thorton 2017-06-17 17:12:38 -0700 It's not about size. I've reduced it down and can reproduce even by just adding: namespace WTF { } to the same spot 1321029 12 thorton 2017-06-20 00:14:32 -0700 I filed https://bugs.llvm.org/show_bug.cgi?id=33520 1355703 13 thorton 2017-10-02 22:03:47 -0700 <rdar://problem/34784096> 1355991 14 322568 thorton 2017-10-03 12:56:44 -0700 Created attachment 322568 Patch 1356038 15 322568 commit-queue 2017-10-03 14:12:42 -0700 Comment on attachment 322568 Patch Clearing flags on attachment: 322568 Committed r222810: <http://trac.webkit.org/changeset/222810> 1356040 16 commit-queue 2017-10-03 14:12:43 -0700 All reviewed patches have been landed. Closing bug. 1356058 17 jlewis3 2017-10-03 14:46:53 -0700 This broke the windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/4908 error: c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\WebCorePrefix.h(171): fatal error C1083: Cannot open type library file: 'c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\derivedsources\forwardingheaders\wtf\fastmalloc.h': Error loading type library/DLL. [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] 1356231 18 thorton 2017-10-03 20:16:21 -0700 On our build bots, this looks like a ~6-7% win, not 9%, but still a decent win. We should do something similar in WebKit and JSC, probably. 1356232 19 thorton 2017-10-03 20:17:00 -0700 (In reply to Tim Horton from comment #18) > On our build bots, this looks like a ~6-7% win, not 9%, but still a decent > win. We should do something similar in WebKit and JSC, probably. 6-7% on WebCore alone, less if you measure the whole project :( 313094 2017-06-16 11:14:19 -0700 2017-10-03 12:56:42 -0700 Patch bug-173481-20170616111419.patch text/plain 1630 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M1NTViYzI1ZDkzYWMw NGQ4NDQ5NGRhNTcyN2FhNWQ0OTFlOGFjMC4uZmZjZGQxODNiNWE2M2ZhYjUxZWExNjY1NjI5NThi ZWRlNGRmOWNjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTE2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEluY2x1ZGUgYSBm ZXcgd2lkZXNwcmVhZCBXVEYgaGVhZGVycyBpbiBXZWJDb3JlUHJlZml4LmgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzQ4MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVByZWZpeC5oOgor ICAgICAgICBUaGVzZSBhcmUgZm91ciBvZiB0aGUgaGVhZGVycyB0aGF0IGNvbnRyaWJ1dGUgdGhl IG1vc3QgcHJlLXByb2Nlc3NlZAorICAgICAgICBzb3VyY2UgdG8gdGhlIFdlYkNvcmUgYnVpbGQu IFRoZXkgKGFuZCB0aGVpciBkZXBlbmRlbnRzKSBjaGFuZ2UgaW5mcmVxdWVudGx5CisgICAgICAg IGVub3VnaCB0aGF0IGEgd29ybGQgcmVidWlsZCBvZiBXZWJDb3JlIHdoZW4gdGhleSBjaGFuZ2Ug c2VlbXMgbGlrZSBhbgorICAgICAgICBhY2NlcHRhYmxlIHRyYWRlb2ZmIGZvciB0aGUgfjklIHJl ZHVjdGlvbiBpbiBXZWJDb3JlIGJ1aWxkIHRpbWUgdGhhdCBJCisgICAgICAgIG1lYXN1cmUgZnJv bSB0aGlzIGNoYW5nZS4KKwogMjAxNy0wNi0xNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFtpT1NdIEdlbmVyYXRlIGEgc2ltdWxhdGVkIGNyYXNoIHdoZW4g dGhlIFdlYlRocmVhZCBzdGFydHMgaW4gTW9iaWxlU2FmYXJpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlUHJlZml4LmggYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgK aW5kZXggZWJmYWNjNmVlZDRmMWEyMDRiNjc1YjYwMjhkYzZiODExNjk3MTY2My4uY2VlZjFiNTg2 YWM5NDA2ZDk1OWY0ZjY5ZWJmODY0NTZkMjNhYzUyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvV2ViQ29yZVByZWZpeC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmVQcmVmaXguaApA QCAtMTYzLDYgKzE2MywxMSBAQAogI2VuZGlmCiAKICNpZmRlZiBfX2NwbHVzcGx1cworI2ltcG9y dCA8d3RmL3RleHQvQXRvbWljU3RyaW5nLmg+CisjaW1wb3J0IDx3dGYvdGV4dC9XVEZTdHJpbmcu aD4KKyNpbXBvcnQgPHd0Zi9PcHRpb25hbC5oPgorI2ltcG9ydCA8d3RmL1N0ZExpYkV4dHJhcy5o PgorCiAjZGVmaW5lIG5ldyAoImlmIHlvdSB1c2UgbmV3L2RlbGV0ZSBtYWtlIHN1cmUgdG8gaW5j bHVkZSBjb25maWcuaCBhdCB0aGUgdG9wIG9mIHRoZSBmaWxlIigpKSAKICNkZWZpbmUgZGVsZXRl ICgiaWYgeW91IHVzZSBuZXcvZGVsZXRlIG1ha2Ugc3VyZSB0byBpbmNsdWRlIGNvbmZpZy5oIGF0 IHRoZSB0b3Agb2YgdGhlIGZpbGUiKCkpIAogI2VuZGlmCg== 322568 2017-10-03 12:56:44 -0700 2017-10-03 14:12:42 -0700 Patch bug-173481-20171003125643.patch text/plain 1810 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQ0ZDFhNDg3ZmYwYTQx OWVhZTAxMDQwYjgzYTRkNGUwNDljM2MzZC4uODg1ZGFkZTU1OTBjM2EyYjEyZDMzZDEzZGIxM2I5 ZDVlNmU5ZjIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTEwLTAzICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEluY2x1ZGUgYSBm ZXcgd2lkZXNwcmVhZCBXVEYgaGVhZGVycyBpbiBXZWJDb3JlUHJlZml4LmgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzQ4MQorCisgICAgICAgIFJl dmlld2VkIGJ5IEFsZXggQ2hyaXN0ZW5zZW4uCisKKyAgICAgICAgKiBXZWJDb3JlUHJlZml4Lmg6 CisgICAgICAgIFRoZXNlIGFyZSBmb3VyIG9mIHRoZSBoZWFkZXJzIHRoYXQgY29udHJpYnV0ZSB0 aGUgbW9zdCBwcmUtcHJvY2Vzc2VkCisgICAgICAgIHNvdXJjZSB0byB0aGUgV2ViQ29yZSBidWls ZC4gVGhleSAoYW5kIHRoZWlyIGRlcGVuZGVudHMpIGNoYW5nZSBpbmZyZXF1ZW50bHkKKyAgICAg ICAgZW5vdWdoIHRoYXQgYSB3b3JsZCByZWJ1aWxkIG9mIFdlYkNvcmUgd2hlbiB0aGV5IGNoYW5n ZSBzZWVtcyBsaWtlIGFuCisgICAgICAgIGFjY2VwdGFibGUgdHJhZGVvZmYgZm9yIHRoZSB+OSUg cmVkdWN0aW9uIGluIFdlYkNvcmUgYnVpbGQgdGltZSB0aGF0IEkKKyAgICAgICAgbWVhc3VyZSBm cm9tIHRoaXMgY2hhbmdlLgorCisgICAgICAgIFdlIGNhbid0IGRvIHRoaXMgb24gbWFjT1MgMTAu MTIgYmVjYXVzZSBvZiBodHRwczovL2J1Z3MubGx2bS5vcmcvc2hvd19idWcuY2dpP2lkPTMzNTIw LgorCiAyMDE3LTEwLTAzICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS10gU3VwcG9ydCB0aGUgInN5c3RlbSIgQ1NTIGZvbnQgZmFtaWx5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlUHJlZml4LmggYi9Tb3VyY2UvV2Vi Q29yZS9XZWJDb3JlUHJlZml4LmgKaW5kZXggNjFhNTlhNWQxNDRhYzU2MzcyNDI5NDE1MTVkZDFm ZDI0MGVjY2MwZC4uYTdiMjZiYTljYjMzNWE0ZmUzMmRlNDMwMmYxYWNhMjRlYzEzMDBlYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZVByZWZpeC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmVQcmVmaXguaApAQCAtMTY2LDYgKzE2NiwxNSBAQAogI2VuZGlmCiAKICNpZmRl ZiBfX2NwbHVzcGx1cworCisjaWYgIVBMQVRGT1JNKE1BQykgfHwgX19NQUNfT1NfWF9WRVJTSU9O X01BWF9BTExPV0VEID49IDEwMTMwMAorI2ltcG9ydCA8d3RmL0Zhc3RNYWxsb2MuaD4KKyNpbXBv cnQgPHd0Zi9PcHRpb25hbC5oPgorI2ltcG9ydCA8d3RmL1N0ZExpYkV4dHJhcy5oPgorI2ltcG9y dCA8d3RmL3RleHQvQXRvbWljU3RyaW5nLmg+CisjaW1wb3J0IDx3dGYvdGV4dC9XVEZTdHJpbmcu aD4KKyNlbmRpZgorCiAjZGVmaW5lIG5ldyAoImlmIHlvdSB1c2UgbmV3L2RlbGV0ZSBtYWtlIHN1 cmUgdG8gaW5jbHVkZSBjb25maWcuaCBhdCB0aGUgdG9wIG9mIHRoZSBmaWxlIigpKSAKICNkZWZp bmUgZGVsZXRlICgiaWYgeW91IHVzZSBuZXcvZGVsZXRlIG1ha2Ugc3VyZSB0byBpbmNsdWRlIGNv bmZpZy5oIGF0IHRoZSB0b3Agb2YgdGhlIGZpbGUiKCkpIAogI2VuZGlmCg==