<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>173470</bug_id>
          
          <creation_ts>2017-06-16 08:22:13 -0700</creation_ts>
          <short_desc>REGRESSION(r166799): LogsPageMessagesToSystemConsoleEnabled corrupts non-ASCII characters</short_desc>
          <delta_ts>2017-06-16 09:08:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Konstantin Tokarev">annulen</reporter>
          <assigned_to name="Konstantin Tokarev">annulen</assigned_to>
          <cc>bburg</cc>
    
    <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>joepeck</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1319956</commentid>
    <comment_count>0</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-06-16 08:22:13 -0700</bug_when>
    <thetext>ConsoleClient::printConsoleMessageWithArguments() incorrectly uses const char* overload of StringBuilder::append() that assummes Latin1 encoding, not UTF8</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319957</commentid>
    <comment_count>1</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-06-16 08:23:51 -0700</bug_when>
    <thetext>Before r166799 this code used

    printf(&quot; %s&quot;, argAsString.utf8().data());

that was correct.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319958</commentid>
    <comment_count>2</comment_count>
      <attachid>313076</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-06-16 08:24:21 -0700</bug_when>
    <thetext>Created attachment 313076
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319966</commentid>
    <comment_count>3</comment_count>
      <attachid>313076</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-16 09:08:34 -0700</bug_when>
    <thetext>Comment on attachment 313076
Patch

Clearing flags on attachment: 313076

Committed r218392: &lt;http://trac.webkit.org/changeset/218392&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319967</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-16 09:08:36 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>313076</attachid>
            <date>2017-06-16 08:24:21 -0700</date>
            <delta_ts>2017-06-16 09:08:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-173470-20170616182420.patch</filename>
            <type>text/plain</type>
            <size>1687</size>
            <attacher name="Konstantin Tokarev">annulen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4Mzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz
ODEwNmFhYmY0YjUzMDg5NTRjZjhiMzFlOTI3NzViNzNjNzI3ZDE5Li4xMTBhNzhmYjA2MjgyYTY5
MjIxM2ZjOTA3YmIyY2JkOGQ1MDBiODI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNyBAQAorMjAxNy0wNi0xNiAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k
ZXgucnU+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTY2Nzk5KTogTG9nc1BhZ2VNZXNzYWdlc1Rv
U3lzdGVtQ29uc29sZUVuYWJsZWQgY29ycnVwdHMgbm9uLUFTQ0lJIGNoYXJhY3RlcnMKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzQ3MAorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbnNvbGVDbGllbnQ6
OnByaW50Q29uc29sZU1lc3NhZ2VXaXRoQXJndW1lbnRzKCkgaW5jb3JyZWN0bHkgdXNlcworICAg
ICAgICBjb25zdCBjaGFyKiBvdmVybG9hZCBvZiBTdHJpbmdCdWlsZGVyOjphcHBlbmQoKSB0aGF0
IGFzc3VtbWVzIExhdGluMQorICAgICAgICBlbmNvZGluZywgbm90IFVURjguCisKKyAgICAgICAg
KiBydW50aW1lL0NvbnNvbGVDbGllbnQuY3BwOgorICAgICAgICAoSlNDOjpDb25zb2xlQ2xpZW50
OjpwcmludENvbnNvbGVNZXNzYWdlV2l0aEFyZ3VtZW50cyk6CisKIDIwMTctMDYtMTUgIE1hcmsg
TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIEpTUnVuTG9vcFRpbWVy
IHJlZ2lzdHJ5IGluIFZNLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp
bWUvQ29uc29sZUNsaWVudC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25z
b2xlQ2xpZW50LmNwcAppbmRleCA2OGQ3MWMzMWI1MWY5NTYwMTJlMDBkZjEyZDIwMDdmYWU0M2Vl
ODY1Li5kM2ZhY2RiOGVkYmQxYjA2MjQ0NTg5YzljOTNkZjAxMTVkNTRkY2NkIDEwMDY0NAotLS0g
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zb2xlQ2xpZW50LmNwcAorKysgYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zb2xlQ2xpZW50LmNwcApAQCAtMTY1LDcg
KzE2NSw3IEBAIHZvaWQgQ29uc29sZUNsaWVudDo6cHJpbnRDb25zb2xlTWVzc2FnZVdpdGhBcmd1
bWVudHMoTWVzc2FnZVNvdXJjZSBzb3VyY2UsIE1lc3NhCiAgICAgZm9yIChzaXplX3QgaSA9IDA7
IGkgPCBhcmd1bWVudHMtPmFyZ3VtZW50Q291bnQoKTsgKytpKSB7CiAgICAgICAgIFN0cmluZyBh
cmdBc1N0cmluZyA9IGFyZ3VtZW50cy0+YXJndW1lbnRBdChpKS50b1N0cmluZyhhcmd1bWVudHMt
Pmdsb2JhbFN0YXRlKCkpOwogICAgICAgICBidWlsZGVyLmFwcGVuZCgnICcpOwotICAgICAgICBi
dWlsZGVyLmFwcGVuZChhcmdBc1N0cmluZy51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgYnVpbGRl
ci5hcHBlbmQoYXJnQXNTdHJpbmcpOwogICAgIH0KIAogICAgIFdURkxvZ0Fsd2F5cygiJXMiLCBi
dWlsZGVyLnRvU3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>