173464 2017-06-16 02:48:20 -0700 REGRESSION(r218253): Infinite animated gifs no longer loop 2017-06-18 22:23:06 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=172502 Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned achristensen bugs-noreply clopez magomez mcatanzaro sabouhallawa oldest_to_newest 1319909 0 cgarcia 2017-06-16 02:48:20 -0700 Even with bug #173403 fixed, we still see that infinite gifs only play once. Now the repetition counts is correctly used, but after the first loop iteration we keep rendering the same frame all the time, so it looks like if the animation stopped. This is because in r218253 we changed to use SharedBuffer instead of a Vector in ImageBackingStore, but we are not correctly copying the data in the copy constructor. We are using SharedBuffer::copy() that doesn't actually copy the data of the segments. I'm not sure if that's on purpose or a regression of bug #170956. 1319911 1 313067 cgarcia 2017-06-16 02:51:10 -0700 Created attachment 313067 Patch 1319930 2 313067 clopez 2017-06-16 06:16:54 -0700 Comment on attachment 313067 Patch Maybe is a good idea to create some test for this? 1319932 3 313067 cgarcia 2017-06-16 06:26:54 -0700 Comment on attachment 313067 Patch Thanks for the review, let's not push this for now, because I'm still not sure if it's a bug in SharedBuffer::copy(). I'll check existing tests to see if we can add a test for this too. 1319936 4 mcatanzaro 2017-06-16 07:15:45 -0700 Does this fix imgur gifs? We have another bug for that.... 1319941 5 cgarcia 2017-06-16 07:19:10 -0700 What other bug? This is a very recent regression anyway, so maybe imgur is fixed by bug #173403. 1319944 6 mcatanzaro 2017-06-16 07:25:11 -0700 Bug #161963. I guess it's unrelated. There's also bug #109395 which is also quite bad. 1320601 7 cgarcia 2017-06-18 22:23:06 -0700 Committed r218472: <http://trac.webkit.org/changeset/218472> 313067 2017-06-16 02:51:10 -0700 2017-06-16 06:26:54 -0700 Patch wcore-animated-gif.diff text/plain 1881 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MWY2ZmVmYTIzOS4uMzViOWU3MjA3ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNy0wNi0xNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTihyMjE4MjUzKTogSW5maW5pdGUgYW5pbWF0 ZWQgZ2lmcyBubyBsb25nZXIgbG9vcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTczNDY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWZ0ZXIgdGhlIGZpcnN0IGxvb3AgaXRlcmF0aW9uIHdlIGtlZXAgcmVu ZGVyaW5nIHRoZSBzYW1lIGZyYW1lIGFsbCB0aGUgdGltZSwgc28gaXQgbG9va3MgbGlrZSBpZiB0 aGUgYW5pbWF0aW9uCisgICAgICAgIHN0b3BwZWQuIFRoaXMgaXMgYmVjYXVzZSBpbiByMjE4MjUz IHdlIGNoYW5nZWQgdG8gdXNlIFNoYXJlZEJ1ZmZlciBpbnN0ZWFkIG9mIGEgVmVjdG9yIGluIElt YWdlQmFja2luZ1N0b3JlLCBidXQKKyAgICAgICAgd2UgYXJlIG5vdCBjb3JyZWN0bHkgY29weWlu ZyB0aGUgZGF0YSBpbiB0aGUgY29weSBjb25zdHJ1Y3Rvci4gV2UgYXJlIHVzaW5nIFNoYXJlZEJ1 ZmZlcjo6Y29weSgpIHRoYXQgZG9lc24ndAorICAgICAgICBhY3R1YWxseSBjb3B5IHRoZSBkYXRh IG9mIHRoZSBzZWdtZW50cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQmFj a2luZ1N0b3JlLmg6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJhY2tpbmdTdG9yZTo6SW1hZ2VC YWNraW5nU3RvcmUpOiBDb3B5IHRoZSBkYXRhIG9mIHRoZSBvdGhlciBTaGFyZWRCdWZmZXIuCisK KzIwMTctMDYtMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CiAgICAgICAgIFtHU3RyZWFtZXJdIE1haW5UaHJlYWROb3RpZmllciBBU1NFUlRJT04gRkFJTEVE OiBtX2JvdW5kVGhyZWFkID09IGN1cnJlbnRUaHJlYWQoKSBpbiBfV2ViS2l0V2ViU3JjUHJpdmF0 ZTo6fl9XZWJLaXRXZWJTcmNQcml2YXRlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTIwNDMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvSW1hZ2VCYWNraW5nU3RvcmUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0ltYWdlQmFja2luZ1N0b3JlLmgKaW5kZXggMDFiNTI4ZTk5ODIuLmM4ZGRl NTgzODBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFn ZUJhY2tpbmdTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0lt YWdlQmFja2luZ1N0b3JlLmgKQEAgLTE4OSw3ICsxODksNyBAQCBwcml2YXRlOgogICAgICAgICAs IG1fcHJlbXVsdGlwbHlBbHBoYShvdGhlci5tX3ByZW11bHRpcGx5QWxwaGEpCiAgICAgewogICAg ICAgICBBU1NFUlQoIW1fc2l6ZS5pc0VtcHR5KCkgJiYgIWlzT3ZlclNpemUobV9zaXplKSk7Ci0g ICAgICAgIG1fcGl4ZWxzID0gb3RoZXIubV9waXhlbHMtPmNvcHkoKTsKKyAgICAgICAgbV9waXhl bHMgPSBTaGFyZWRCdWZmZXI6OmNyZWF0ZShvdGhlci5tX3BpeGVscy0+ZGF0YSgpLCBvdGhlci5t X3BpeGVscy0+c2l6ZSgpKTsKICAgICAgICAgbV9waXhlbHNQdHIgPSByZWludGVycHJldF9jYXN0 PFJHQkEzMio+KGNvbnN0X2Nhc3Q8Y2hhcio+KG1fcGl4ZWxzLT5kYXRhKCkpKTsKICAgICB9CiAK