173443 2017-06-15 15:48:51 -0700 Implement basic authentication in MiniBrowser 2017-06-16 12:21:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen sam thorton oldest_to_newest 1319749 0 achristensen 2017-06-15 15:48:51 -0700 Implement basic authentication in MiniBrowser 1319751 1 313019 achristensen 2017-06-15 15:49:13 -0700 Created attachment 313019 Patch 1319757 2 313019 sam 2017-06-15 16:19:50 -0700 Comment on attachment 313019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313019&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:670 > + [alert beginSheetModalForWindow:self.window completionHandler:^void(NSModalResponse response) I don't think the void is necessary. > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:671 > + { This should go on the previous line. 1319795 3 313035 achristensen 2017-06-15 17:52:19 -0700 Created attachment 313035 Patch 1319802 4 achristensen 2017-06-15 18:09:18 -0700 It would be nice if hitting tab from the user input field would take the focus to the password input field...but as-is this already helps me debug things much more effectively. 1320067 5 thorton 2017-06-16 12:15:08 -0700 (In reply to Alex Christensen from comment #4) > It would be nice if hitting tab from the user input field would take the > focus to the password input field...but as-is this already helps me debug > things much more effectively. setNextKeyView 1320072 6 achristensen 2017-06-16 12:21:37 -0700 Also added a setInitialFirstResponder. https://trac.webkit.org/changeset/218401/webkit 313019 2017-06-15 15:49:13 -0700 2017-06-15 17:52:17 -0700 Patch bug-173443-20170615154913.patch text/plain 2951 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxODM2NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTA2LTE1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgSW1wbGVtZW50IGJhc2ljIGF1dGhlbnRpY2F0aW9uIGluIE1p bmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzM0NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIE1pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5tOgorICAgICAg ICAoLVtXSzJCcm93c2VyV2luZG93Q29udHJvbGxlciB3ZWJWaWV3OmRpZFJlY2VpdmVBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZTpjb21wbGV0aW9uSGFuZGxlcjpdKToKKwogMjAxNy0wNi0xNSAgSmVy IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViUlRDXSBSZW1vdmlu ZyBhIE1lZGlhU3RyZWFtVHJhY2sgZnJvbSBhIE1lZGlhU3RyZWFtIHJlcG9ydHMgbm8gcmVjb3Jk aW5nIHRvIFdlYktpdCBjbGllbnRzCkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJv d3NlcldpbmRvd0NvbnRyb2xsZXIubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9t YWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQkocmV2aXNpb24gMjE4Mjg1KQorKysgVG9v bHMvTWluaUJyb3dzZXIvbWFjL1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0JKHdvcmtpbmcg Y29weSkKQEAgLTY1NCw2ICs2NTQsMzAgQEAgLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3 ZWJWaWV3IGRpZAogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZFJlY2Vp dmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTooTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSAq KWNoYWxsZW5nZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNVUkxTZXNzaW9uQXV0aENo YWxsZW5nZURpc3Bvc2l0aW9uIGRpc3Bvc2l0aW9uLCBOU1VSTENyZWRlbnRpYWwgKl9fbnVsbGFi bGUgY3JlZGVudGlhbCkpY29tcGxldGlvbkhhbmRsZXIKIHsKICAgICBMT0coQCJkaWRSZWNlaXZl QXV0aGVudGljYXRpb25DaGFsbGVuZ2U6ICVAIiwgY2hhbGxlbmdlKTsKKyAgICBpZiAoW2NoYWxs ZW5nZS5wcm90ZWN0aW9uU3BhY2UuYXV0aGVudGljYXRpb25NZXRob2QgaXNFcXVhbFRvU3RyaW5n Ok5TVVJMQXV0aGVudGljYXRpb25NZXRob2RIVFRQQmFzaWNdKSB7CisgICAgICAgIE5TQWxlcnQg KmFsZXJ0ID0gW1tOU0FsZXJ0IGFsbG9jXSBpbml0XTsKKyAgICAgICAgTlNWaWV3ICpjb250YWlu ZXIgPSBbW1tOU1ZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCAyMDAs IDQ4KV0gYXV0b3JlbGVhc2VdOworICAgICAgICBOU1RleHRGaWVsZCAqdXNlcklucHV0ID0gW1tb TlNUZXh0RmllbGQgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAyNCwgMjAwLCAy NCldIGF1dG9yZWxlYXNlXTsKKyAgICAgICAgTlNUZXh0RmllbGQgKnBhc3N3b3JkSW5wdXQgPSBb W1tOU1NlY3VyZVRleHRGaWVsZCBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAs IDIwMCwgMjQpXSBhdXRvcmVsZWFzZV07CisgICAgICAgIAorICAgICAgICBbYWxlcnQgc2V0TWVz c2FnZVRleHQ6W05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJMb2cgaW4gdG8gJUA6JWx1LiIs IGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UuaG9zdCwgY2hhbGxlbmdlLnByb3RlY3Rpb25TcGFj ZS5wb3J0XV07CisgICAgICAgIFthbGVydCBhZGRCdXR0b25XaXRoVGl0bGU6QCJMb2cgaW4iXTsK KyAgICAgICAgW2FsZXJ0IGFkZEJ1dHRvbldpdGhUaXRsZTpAIkNhbmNlbCJdOworICAgICAgICBb Y29udGFpbmVyIGFkZFN1YnZpZXc6dXNlcklucHV0XTsKKyAgICAgICAgW2NvbnRhaW5lciBhZGRT dWJ2aWV3OnBhc3N3b3JkSW5wdXRdOworICAgICAgICBbYWxlcnQgc2V0QWNjZXNzb3J5Vmlldzpj b250YWluZXJdOworICAgICAgICAKKyAgICAgICAgW2FsZXJ0IGJlZ2luU2hlZXRNb2RhbEZvcldp bmRvdzpzZWxmLndpbmRvdyBjb21wbGV0aW9uSGFuZGxlcjpedm9pZChOU01vZGFsUmVzcG9uc2Ug cmVzcG9uc2UpCisgICAgICAgIHsKKyAgICAgICAgICAgIFt1c2VySW5wdXQgdmFsaWRhdGVFZGl0 aW5nXTsKKyAgICAgICAgICAgIGlmIChyZXNwb25zZSA9PSBOU0FsZXJ0Rmlyc3RCdXR0b25SZXR1 cm4pCisgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoTlNVUkxTZXNzaW9uQXV0aENo YWxsZW5nZVVzZUNyZWRlbnRpYWwsIFtbW05TVVJMQ3JlZGVudGlhbCBhbGxvY10gaW5pdFdpdGhV c2VyOlt1c2VySW5wdXQgc3RyaW5nVmFsdWVdIHBhc3N3b3JkOltwYXNzd29yZElucHV0IHN0cmlu Z1ZhbHVlXSBwZXJzaXN0ZW5jZTpOU1VSTENyZWRlbnRpYWxQZXJzaXN0ZW5jZUZvclNlc3Npb25d IGF1dG9yZWxlYXNlXSk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgY29tcGxl dGlvbkhhbmRsZXIoTlNVUkxTZXNzaW9uQXV0aENoYWxsZW5nZVJlamVjdFByb3RlY3Rpb25TcGFj ZSwgbmlsKTsKKyAgICAgICAgICAgIFthbGVydCByZWxlYXNlXTsKKyAgICAgICAgfV07CisgICAg ICAgIHJldHVybjsKKyAgICB9CiAgICAgY29tcGxldGlvbkhhbmRsZXIoTlNVUkxTZXNzaW9uQXV0 aENoYWxsZW5nZVJlamVjdFByb3RlY3Rpb25TcGFjZSwgbmlsKTsKIH0KIAo= 313035 2017-06-15 17:52:19 -0700 2017-06-16 12:14:07 -0700 Patch bug-173443-20170615175217.patch text/plain 2938 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxODM2NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTA2LTE1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgSW1wbGVtZW50IGJhc2ljIGF1dGhlbnRpY2F0aW9uIGluIE1p bmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzM0NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIE1pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5tOgorICAgICAg ICAoLVtXSzJCcm93c2VyV2luZG93Q29udHJvbGxlciB3ZWJWaWV3OmRpZFJlY2VpdmVBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZTpjb21wbGV0aW9uSGFuZGxlcjpdKToKKwogMjAxNy0wNi0xNSAgSmVy IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViUlRDXSBSZW1vdmlu ZyBhIE1lZGlhU3RyZWFtVHJhY2sgZnJvbSBhIE1lZGlhU3RyZWFtIHJlcG9ydHMgbm8gcmVjb3Jk aW5nIHRvIFdlYktpdCBjbGllbnRzCkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJv d3NlcldpbmRvd0NvbnRyb2xsZXIubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9t YWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQkocmV2aXNpb24gMjE4Mjg1KQorKysgVG9v bHMvTWluaUJyb3dzZXIvbWFjL1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0JKHdvcmtpbmcg Y29weSkKQEAgLTY1NCw2ICs2NTQsMjkgQEAgLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3 ZWJWaWV3IGRpZAogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZFJlY2Vp dmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTooTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSAq KWNoYWxsZW5nZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNVUkxTZXNzaW9uQXV0aENo YWxsZW5nZURpc3Bvc2l0aW9uIGRpc3Bvc2l0aW9uLCBOU1VSTENyZWRlbnRpYWwgKl9fbnVsbGFi bGUgY3JlZGVudGlhbCkpY29tcGxldGlvbkhhbmRsZXIKIHsKICAgICBMT0coQCJkaWRSZWNlaXZl QXV0aGVudGljYXRpb25DaGFsbGVuZ2U6ICVAIiwgY2hhbGxlbmdlKTsKKyAgICBpZiAoW2NoYWxs ZW5nZS5wcm90ZWN0aW9uU3BhY2UuYXV0aGVudGljYXRpb25NZXRob2QgaXNFcXVhbFRvU3RyaW5n Ok5TVVJMQXV0aGVudGljYXRpb25NZXRob2RIVFRQQmFzaWNdKSB7CisgICAgICAgIE5TQWxlcnQg KmFsZXJ0ID0gW1tOU0FsZXJ0IGFsbG9jXSBpbml0XTsKKyAgICAgICAgTlNWaWV3ICpjb250YWlu ZXIgPSBbW1tOU1ZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCAyMDAs IDQ4KV0gYXV0b3JlbGVhc2VdOworICAgICAgICBOU1RleHRGaWVsZCAqdXNlcklucHV0ID0gW1tb TlNUZXh0RmllbGQgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAyNCwgMjAwLCAy NCldIGF1dG9yZWxlYXNlXTsKKyAgICAgICAgTlNUZXh0RmllbGQgKnBhc3N3b3JkSW5wdXQgPSBb W1tOU1NlY3VyZVRleHRGaWVsZCBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAs IDIwMCwgMjQpXSBhdXRvcmVsZWFzZV07CisgICAgICAgIAorICAgICAgICBbYWxlcnQgc2V0TWVz c2FnZVRleHQ6W05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJMb2cgaW4gdG8gJUA6JWx1LiIs IGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UuaG9zdCwgY2hhbGxlbmdlLnByb3RlY3Rpb25TcGFj ZS5wb3J0XV07CisgICAgICAgIFthbGVydCBhZGRCdXR0b25XaXRoVGl0bGU6QCJMb2cgaW4iXTsK KyAgICAgICAgW2FsZXJ0IGFkZEJ1dHRvbldpdGhUaXRsZTpAIkNhbmNlbCJdOworICAgICAgICBb Y29udGFpbmVyIGFkZFN1YnZpZXc6dXNlcklucHV0XTsKKyAgICAgICAgW2NvbnRhaW5lciBhZGRT dWJ2aWV3OnBhc3N3b3JkSW5wdXRdOworICAgICAgICBbYWxlcnQgc2V0QWNjZXNzb3J5Vmlldzpj b250YWluZXJdOworICAgICAgICAKKyAgICAgICAgW2FsZXJ0IGJlZ2luU2hlZXRNb2RhbEZvcldp bmRvdzpzZWxmLndpbmRvdyBjb21wbGV0aW9uSGFuZGxlcjpeKE5TTW9kYWxSZXNwb25zZSByZXNw b25zZSkgeworICAgICAgICAgICAgW3VzZXJJbnB1dCB2YWxpZGF0ZUVkaXRpbmddOworICAgICAg ICAgICAgaWYgKHJlc3BvbnNlID09IE5TQWxlcnRGaXJzdEJ1dHRvblJldHVybikKKyAgICAgICAg ICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihOU1VSTFNlc3Npb25BdXRoQ2hhbGxlbmdlVXNlQ3Jl ZGVudGlhbCwgW1tbTlNVUkxDcmVkZW50aWFsIGFsbG9jXSBpbml0V2l0aFVzZXI6W3VzZXJJbnB1 dCBzdHJpbmdWYWx1ZV0gcGFzc3dvcmQ6W3Bhc3N3b3JkSW5wdXQgc3RyaW5nVmFsdWVdIHBlcnNp c3RlbmNlOk5TVVJMQ3JlZGVudGlhbFBlcnNpc3RlbmNlRm9yU2Vzc2lvbl0gYXV0b3JlbGVhc2Vd KTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihO U1VSTFNlc3Npb25BdXRoQ2hhbGxlbmdlUmVqZWN0UHJvdGVjdGlvblNwYWNlLCBuaWwpOworICAg ICAgICAgICAgW2FsZXJ0IHJlbGVhc2VdOworICAgICAgICB9XTsKKyAgICAgICAgcmV0dXJuOwor ICAgIH0KICAgICBjb21wbGV0aW9uSGFuZGxlcihOU1VSTFNlc3Npb25BdXRoQ2hhbGxlbmdlUmVq ZWN0UHJvdGVjdGlvblNwYWNlLCBuaWwpOwogfQogCg==