173439 2017-06-15 14:27:23 -0700 Modern media controls tests error in Button.js 2017-06-15 16:34:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173059 P2 Normal --- 1 jlewis3 graouts commit-queue dino graouts ryanhaddad oldest_to_newest 1319711 0 jlewis3 2017-06-15 14:27:23 -0700 media/modern-media-controls/buttons-container/buttons-container-constructor.html is a flaky failure on Sierra WK2 Debug, El Capitan WK1 Debug, and iOS Simulator Release WK1 according to the Flakiness Dashboard. the test was re-baselined and re-enabled with: https://trac.webkit.org/changeset/217891/webkit The test seems to have been flaky after additional test were re-enabled and re-baselined: https://trac.webkit.org/changeset/217941/webkit https://trac.webkit.org/changeset/217940/webkit https://trac.webkit.org/changeset/217939/webkit https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r218344%20(1568)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1568 Diff: --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/buttons-container/buttons-container-constructor-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/buttons-container/buttons-container-constructor-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 155: TypeError: null is not an object (evaluating 'this._imageSource.src') Testing the ButtonsContainer constructor. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". 1319739 1 graouts 2017-06-15 15:17:09 -0700 Similar failure for media/modern-media-controls/buttons-container/buttons-container-buttons-property.html here: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r218342%20(1567)/media/modern-media-controls/buttons-container/buttons-container-buttons-property-pretty-diff.html 1319740 2 graouts 2017-06-15 15:18:26 -0700 and for forward-button.html here: https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK1%20(Tests)/r218333%20(2122)/media/modern-media-controls/forward-button/forward-button-pretty-diff.html 1319743 3 313018 graouts 2017-06-15 15:31:38 -0700 Created attachment 313018 Patch 1319763 4 313018 commit-queue 2017-06-15 16:34:19 -0700 Comment on attachment 313018 Patch Clearing flags on attachment: 313018 Committed r218367: <http://trac.webkit.org/changeset/218367> 1319764 5 commit-queue 2017-06-15 16:34:21 -0700 All reviewed patches have been landed. Closing bug. 313018 2017-06-15 15:31:38 -0700 2017-06-15 16:34:19 -0700 Patch bug-173439-20170615153138.patch text/plain 2297 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGJhOTA4ZmFlZDlkZjZj NDA2ZWQ4MmNiNWZjYWQzYzRhNjAxOTA4Zi4uMWNhMDYzYjUyZDVmMjIyMmI0MDg1OGMxZDY5MTk0 YzYyYTlkZTIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA2LTE1ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTW9kZXJuIG1lZGlhIGNv bnRyb2xzIHRlc3RzIGVycm9yIGluIEJ1dHRvbi5qcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNDM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgd291bGQgc29tZXRpbWUgeWllbGQgYW4gZXJy b3Igd2hlbiBjb21taXQoKSB3b3VsZCBiZSBjYWxsZWQgYW5kIHRoZSBfaW1hZ2VTb3VyY2UKKyAg ICAgICAgaXZhciBoYWRuJ3QgYmVlbiBzZXQuIFRvIG1vcmUgc2FmZWx5IGNvbW1pdCB0aGUgbWFz ayBpbWFnZSB3aGVuIGl0J3MgbG9hZGVkLCB3ZSBub3cgdXNlCisgICAgICAgIGEgbWFya0RpcnR5 UHJvcGVydHkoKSBjYWxsIGFuZCBhIGNvbW1pdFByb3BlcnR5KCkgb3ZlcnJpZGUgdG8gZW5zdXJl IHRoYXQgd2UgY292ZXIgdGhlCisgICAgICAgIGNhc2Ugd2hlcmUgd2Ugd2FudCB0byBjb21taXQg dGhlIG1hc2sgaW1hZ2UsIGFuZCBmb3Igb3RoZXIgY29tbWl0cyBub3QgdG8gaGF2ZSB0byB3b3Jy eQorICAgICAgICBhYm91dCB0aGUgbWFzayBpbWFnZSBiZWluZyBkZWZpbmVkLgorCisgICAgICAg ICogTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvYnV0dG9uLmpzOgorICAg ICAgICAoQnV0dG9uLnByb3RvdHlwZS5jb21taXRQcm9wZXJ0eSk6CisgICAgICAgIChCdXR0b24u cHJvdG90eXBlLl91cGRhdGVJbWFnZSk6CisgICAgICAgIChCdXR0b24ucHJvdG90eXBlLmNvbW1p dCk6IERlbGV0ZWQuCisKIDIwMTctMDYtMTQgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxl LmNvbT4KIAogICAgICAgICBSZWJhc2VsaW5lIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9t ZWRpYS1kb2N1bWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJu LW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL2J1dHRvbi5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL2J1dHRvbi5qcwppbmRleCBlMmMyZjE3 MjliYzJhYzg5MDM4NDc1NjRhMDhiZmMyNTU1MDJlMzFiLi5jMzg2Y2MzYmU0MzBlMDQxNTBkOGRk N2Q3MWM1ZDg2YWYyMjRlODc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21v ZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9idXR0b24uanMKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvYnV0dG9uLmpzCkBAIC0x NDgsMTEgKzE0OCwxMiBAQCBjbGFzcyBCdXR0b24gZXh0ZW5kcyBMYXlvdXRJdGVtCiAgICAgICAg ICAgICB0aGlzLl9ub3RpZnlEZWxlZ2F0ZU9mQWN0aXZhdGlvbigpOwogICAgIH0KIAotICAgIGNv bW1pdCgpCisgICAgY29tbWl0UHJvcGVydHkocHJvcGVydHlOYW1lKQogICAgIHsKLSAgICAgICAg c3VwZXIuY29tbWl0KCk7Ci0KLSAgICAgICAgdGhpcy5pbWFnZS5lbGVtZW50LnN0eWxlLndlYmtp dE1hc2tJbWFnZSA9IGB1cmwoJHt0aGlzLl9pbWFnZVNvdXJjZS5zcmN9KWA7CisgICAgICAgIGlm IChwcm9wZXJ0eU5hbWUgPT09ICJtYXNrSW1hZ2UiKQorICAgICAgICAgICAgdGhpcy5pbWFnZS5l bGVtZW50LnN0eWxlLndlYmtpdE1hc2tJbWFnZSA9IGB1cmwoJHt0aGlzLl9pbWFnZVNvdXJjZS5z cmN9KWA7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHN1cGVyLmNvbW1pdFByb3BlcnR5KHBy b3BlcnR5TmFtZSk7CiAgICAgfQogCiAgICAgLy8gUHJpdmF0ZQpAQCAtMTg4LDcgKzE4OSw3IEBA IGNsYXNzIEJ1dHRvbiBleHRlbmRzIExheW91dEl0ZW0KIAogICAgIF91cGRhdGVJbWFnZSgpCiAg ICAgewotICAgICAgICB0aGlzLm5lZWRzTGF5b3V0ID0gdHJ1ZTsKKyAgICAgICAgdGhpcy5tYXJr RGlydHlQcm9wZXJ0eSgibWFza0ltYWdlIik7CiAKICAgICAgICAgdGhpcy5fdXBkYXRlSW1hZ2VN ZXRyaWNzKCk7CiAgICAgfQo=