173438 2017-06-15 14:24:10 -0700 Web Inspector: Search highlight doesn't show up in resources when paused 2017-06-15 15:33:22 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1319708 0 joepeck 2017-06-15 14:24:10 -0700 Summary: Search highlight doesn't show up in resources when paused Steps to reproduce: 1. Inspect <http://bogojoker.com/shell/> 2. Set a breakpoint on: easySlider.min.js:56:21 3. Trigger pause (by clicking down arrow on the page) 4. Global Search for "empty" 5. Click on results in jquery => No highlight Notes: - TextEditor.js bails in highlighting if paused and !executionLineNumber. That seems wrong. 1319709 1 webkit-bug-importer 2017-06-15 14:24:29 -0700 <rdar://problem/32800114> 1319712 2 313006 joepeck 2017-06-15 14:28:03 -0700 Created attachment 313006 [PATCH] Proposed Fix 1319717 3 313006 mattbaker 2017-06-15 14:34:25 -0700 Comment on attachment 313006 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=313006&action=review r=me with a nit > Source/WebInspectorUI/ChangeLog:13 > + not have the active callframe. Relax this and make it match the intended behavior Correct grammar: "that not have" -> "that does not have" 1319720 4 313009 joepeck 2017-06-15 14:35:48 -0700 Created attachment 313009 [PATCH] For Landing 1319732 5 313009 commit-queue 2017-06-15 14:50:40 -0700 Comment on attachment 313009 [PATCH] For Landing Clearing flags on attachment: 313009 Committed r218359: <http://trac.webkit.org/changeset/218359> 313006 2017-06-15 14:28:03 -0700 2017-06-15 14:35:35 -0700 [PATCH] Proposed Fix highlight-1.patch text/plain 2072 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIyNWE1MjEzYTk2Li5kNDEyODdjODNkOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTctMDYtMTUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBTZWFyY2ggaGlnaGxpZ2h0IGRvZXNuJ3Qgc2hvdyB1cCBpbiByZXNvdXJjZXMgd2hlbiBwYXVz ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzQz OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzI4MDAxMTQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRF ZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUucmV2 ZWFsUG9zaXRpb24ucmV2ZWFsQW5kSGlnaGxpZ2h0TGluZSk6CisgICAgICAgIFByZXZpb3VzbHkg d2Ugd2VyZSBiYWlsaW5nIGlmIGV4ZWN1dGlvbkxpbmVOdW1iZXIgd2FzIE5hTiwgd2hpY2ggbWVh bnMgdGhhdCB3aGVuCisgICAgICAgIHdlIHdlcmUgcGF1c2VkIHdlIHdlcmUgaW5jb3JyZWN0bHkg ZGlzYWJsaW5nIGhpZ2hsaWdodHMgaW4gYW55IHJlc291cmNlIHRoYXQgCisgICAgICAgIG5vdCBo YXZlIHRoZSBhY3RpdmUgY2FsbGZyYW1lLiBSZWxheCB0aGlzIGFuZCBtYWtlIGl0IG1hdGNoIHRo ZSBpbnRlbmRlZCBiZWhhdmlvcgorICAgICAgICBvZiBvbmx5IGRpc2FibGluZyBoaWdobGlnaHRz IGlmIHRoZSBoaWdobGlnaHQgbGluZSBtYXRjaGVzIHRoZSBleGVjdXRpb24gbGluZS4KKworMjAx Ny0wNi0xNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAg IFVuY2F1Z2h0IEV4Y2VwdGlvbjogVHlwZUVycm9yOiBudWxsIGlzIG5vdCBhbiBvYmplY3QgKGV2 YWx1YXRpbmcgJ3RoaXMuY29udGVudEJyb3dzZXIuY29udGVudFZpZXdGb3JSZXByZXNlbnRlZE9i amVjdCcpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzM0MjUKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyNzQ0MTcyPgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKaW5k ZXggNGE0ZjdhNGRmZTAuLjY0MmU5N2FjZDRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKQEAgLTUxOSw3ICs1 MTksNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0ZW5k cyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAg ICAgLy8gQXZvaWQgaGlnaGxpZ2h0aW5nIHRoZSBleGVjdXRpb24gbGluZSB3aGlsZSBkZWJ1Z2dp bmcuCi0gICAgICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFuYWdlci5wYXVzZWQg JiYgKCF0aGlzLl9leGVjdXRpb25MaW5lTnVtYmVyIHx8IGxpbmUgPT09IHRoaXMuX2V4ZWN1dGlv bkxpbmVOdW1iZXIpKQorICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFn ZXIucGF1c2VkICYmIGxpbmUgPT09IHRoaXMuX2V4ZWN1dGlvbkxpbmVOdW1iZXIpCiAgICAgICAg ICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgICAgICB0aGlzLl9jb2RlTWlycm9yLmFkZExpbmVD bGFzcyhsaW5lSGFuZGxlLCAid3JhcCIsIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLkhpZ2hsaWdo dGVkU3R5bGVDbGFzc05hbWUpOwo= 313009 2017-06-15 14:35:48 -0700 2017-06-15 14:50:40 -0700 [PATCH] For Landing for-landing-1.patch text/plain 2072 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIyNWE1MjEzYTk2Li5jNGNkMDYwMjRjYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTctMDYtMTUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBTZWFyY2ggaGlnaGxpZ2h0IGRvZXNuJ3Qgc2hvdyB1cCBpbiByZXNvdXJjZXMgd2hlbiBwYXVz ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzQz OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzI4MDAxMTQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTWF0dCBCYWtlci4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRv ci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZS5yZXZlYWxQ b3NpdGlvbi5yZXZlYWxBbmRIaWdobGlnaHRMaW5lKToKKyAgICAgICAgUHJldmlvdXNseSB3ZSB3 ZXJlIGJhaWxpbmcgaWYgZXhlY3V0aW9uTGluZU51bWJlciB3YXMgTmFOLCB3aGljaCBtZWFucyB0 aGF0IHdoZW4KKyAgICAgICAgd2Ugd2VyZSBwYXVzZWQgd2Ugd2VyZSBpbmNvcnJlY3RseSBkaXNh YmxpbmcgaGlnaGxpZ2h0cyBpbiBhbnkgcmVzb3VyY2UgdGhhdCBkb2VzCisgICAgICAgIG5vdCBo YXZlIHRoZSBhY3RpdmUgY2FsbGZyYW1lLiBSZWxheCB0aGlzIGFuZCBtYWtlIGl0IG1hdGNoIHRo ZSBpbnRlbmRlZCBiZWhhdmlvcgorICAgICAgICBvZiBvbmx5IGRpc2FibGluZyBoaWdobGlnaHRz IGlmIHRoZSBoaWdobGlnaHQgbGluZSBtYXRjaGVzIHRoZSBleGVjdXRpb24gbGluZS4KKworMjAx Ny0wNi0xNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAg IFVuY2F1Z2h0IEV4Y2VwdGlvbjogVHlwZUVycm9yOiBudWxsIGlzIG5vdCBhbiBvYmplY3QgKGV2 YWx1YXRpbmcgJ3RoaXMuY29udGVudEJyb3dzZXIuY29udGVudFZpZXdGb3JSZXByZXNlbnRlZE9i amVjdCcpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzM0MjUKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyNzQ0MTcyPgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKaW5k ZXggNGE0ZjdhNGRmZTAuLjY0MmU5N2FjZDRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKQEAgLTUxOSw3ICs1 MTksNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0ZW5k cyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAg ICAgLy8gQXZvaWQgaGlnaGxpZ2h0aW5nIHRoZSBleGVjdXRpb24gbGluZSB3aGlsZSBkZWJ1Z2dp bmcuCi0gICAgICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFuYWdlci5wYXVzZWQg JiYgKCF0aGlzLl9leGVjdXRpb25MaW5lTnVtYmVyIHx8IGxpbmUgPT09IHRoaXMuX2V4ZWN1dGlv bkxpbmVOdW1iZXIpKQorICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFn ZXIucGF1c2VkICYmIGxpbmUgPT09IHRoaXMuX2V4ZWN1dGlvbkxpbmVOdW1iZXIpCiAgICAgICAg ICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgICAgICB0aGlzLl9jb2RlTWlycm9yLmFkZExpbmVD bGFzcyhsaW5lSGFuZGxlLCAid3JhcCIsIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLkhpZ2hsaWdo dGVkU3R5bGVDbGFzc05hbWUpOwo=