173435 2017-06-15 14:17:39 -0700 Web Inspector: Group Inspector Style Sheets as part of the Stylesheets folder 2017-07-05 20:42:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes joepeck nvasilyev oldest_to_newest 1319701 0 hi 2017-06-15 14:17:39 -0700 Currently, Inspector Style Sheet resources are only visible in the "All Resources" option. 1319727 1 313012 hi 2017-06-15 14:39:35 -0700 Created attachment 313012 Patch 1320776 2 313012 nvasilyev 2017-06-19 12:21:56 -0700 Comment on attachment 313012 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313012&action=review > Source/WebInspectorUI/ChangeLog:4 > + Web Inspector: Group Inspector Style Sheets as part of the Stylesheets folder > + https://bugs.webkit.org/show_bug.cgi?id=173435 Would be nice to add a comment to make it clear it's Stylesheets folder in the *Resources* tab. > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:230 > + if (treeElement instanceof WebInspector.CSSStyleSheetTreeElement) > + return selectedScopeBarItem[WebInspector.ResourceSidebarPanel.ResourceTypeSymbol] === WebInspector.Resource.Type.Stylesheet; > + Non Web Inspector created stylesheets go through the code path a few lines below: return treeElement.resource.type === selectedScopeBarItem[WebInspector.ResourceSidebarPanel.ResourceTypeSymbol]; Since a Web Inspector created stylesheet doesn't have treeElement.resource.type, we need a special case. Did I understand it correctly? 1325905 3 313012 joepeck 2017-07-05 20:14:37 -0700 Comment on attachment 313012 Patch This seems fine. 1325911 4 313012 commit-queue 2017-07-05 20:42:32 -0700 Comment on attachment 313012 Patch Clearing flags on attachment: 313012 Committed r219185: <http://trac.webkit.org/changeset/219185> 1325912 5 commit-queue 2017-07-05 20:42:34 -0700 All reviewed patches have been landed. Closing bug. 313012 2017-06-15 14:39:35 -0700 2017-07-05 20:42:32 -0700 Patch 173435.diff text/plain 1868 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk3YTFiMTljYTNlLi45MGJiOWI3NGMyNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDYtMTUgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEdy b3VwIEluc3BlY3RvciBTdHlsZSBTaGVldHMgYXMgcGFydCBvZiB0aGUgU3R5bGVzaGVldHMgZm9s ZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM0 MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyUGFuZWwucHJvdG90eXBlLm1hdGNoVHJlZUVsZW1lbnRB Z2FpbnN0Q3VzdG9tRmlsdGVycy5tYXRjaCk6CisgICAgICAgIEFkZCBzcGVjaWFsIGNhc2UgZm9y IENTU1N0eWxlU2hlZXRUcmVlRWxlbWVudC4KKwogMjAxNy0wNi0xMCAgRGFuIEJlcm5zdGVpbiAg PG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmVydGVkIHIyMTgwNTYgYmVjYXVzZSBpdCBt YWRlIHRoZSBJREUgcmVpbmRleCBjb25zdGFudGx5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFyUGFuZWwuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVNpZGViYXJQ YW5lbC5qcwppbmRleCA0ZWNkOGUzYTRhNC4uN2JhMDg2ZTNhOGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVs LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291 cmNlU2lkZWJhclBhbmVsLmpzCkBAIC0yMjUsNiArMjI1LDkgQEAgV2ViSW5zcGVjdG9yLlJlc291 cmNlU2lkZWJhclBhbmVsID0gY2xhc3MgUmVzb3VyY2VTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJ bnNwZWMKICAgICAgICAgICAgIGlmICh0cmVlRWxlbWVudCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rv ci5TY3JpcHRUcmVlRWxlbWVudCkKICAgICAgICAgICAgICAgICByZXR1cm4gc2VsZWN0ZWRTY29w ZUJhckl0ZW1bV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBhbmVsLlJlc291cmNlVHlwZVN5 bWJvbF0gPT09IFdlYkluc3BlY3Rvci5SZXNvdXJjZS5UeXBlLlNjcmlwdDsKIAorICAgICAgICAg ICAgaWYgKHRyZWVFbGVtZW50IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkNTU1N0eWxlU2hlZXRU cmVlRWxlbWVudCkKKyAgICAgICAgICAgICAgICByZXR1cm4gc2VsZWN0ZWRTY29wZUJhckl0ZW1b V2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBhbmVsLlJlc291cmNlVHlwZVN5bWJvbF0gPT09 IFdlYkluc3BlY3Rvci5SZXNvdXJjZS5UeXBlLlN0eWxlc2hlZXQ7CisKICAgICAgICAgICAgIGNv bnNvbGUuYXNzZXJ0KHRyZWVFbGVtZW50IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlJlc291cmNl VHJlZUVsZW1lbnQsICJVbmtub3duIHRyZWVFbGVtZW50IiwgdHJlZUVsZW1lbnQpOwogICAgICAg ICAgICAgaWYgKCEodHJlZUVsZW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuUmVzb3VyY2VU cmVlRWxlbWVudCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo=