<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>173433</bug_id>
          
          <creation_ts>2017-06-15 14:13:15 -0700</creation_ts>
          <short_desc>REGRESSION(r218344): [WPE] Thousands of layout test crashes</short_desc>
          <delta_ts>2017-06-19 06:09:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>173483</dependson>
          <blocked>173061</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1319698</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-06-15 14:13:15 -0700</bug_when>
    <thetext>r218344 &lt;http://trac.webkit.org/changeset/218344&gt; caused thousands of layout test crashes due to the update on WPEBackend-mesa on the JHBuild.

My guess is that something is setting a DISPLAY environment there (perhaps the tool driver) and confusing the check for X11.

The bot itself doesn&apos;t set that variable.

https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Tests%29/builds/874/steps/layout-test/logs/stdio</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319703</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-06-15 14:19:20 -0700</bug_when>
    <thetext>Committed r218355: &lt;http://trac.webkit.org/changeset/218355&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319799</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-06-15 17:59:22 -0700</bug_when>
    <thetext>I reverted the update on WPEBackend-mesa that triggered this issue. Layout tests are working back as expected on WPE.


Also I identified the issue: we are setting always a DISPLAY environment variable on Tools/Scripts/webkitpy/port/base.py (even when the user environment doesn&apos;t have one).


I will upload ASAP a patch to fix this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1320054</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-06-16 11:44:08 -0700</bug_when>
    <thetext>Proposed patch at: bug 173483</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1320671</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-06-19 06:09:54 -0700</bug_when>
    <thetext>Committed r218491: &lt;http://trac.webkit.org/changeset/218491&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>