173428 2017-06-15 12:25:55 -0700 [cmake] ADD_PRECOMPILED_HEADER should append OBJECT_DEPENDS, not overwrite it 2017-06-15 14:36:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen lforschler mcatanzaro oldest_to_newest 1319657 0 annulen 2017-06-15 12:25:55 -0700 Right now, if any of source files that are passed to ADD_PRECOMPILED_HEADER have non-empty OBJECT_DEPENDS property (e.g. changed with ADD_SOURCE_DEPENDENCIES call), its value is lost. 1319661 1 312999 annulen 2017-06-15 12:30:13 -0700 Created attachment 312999 Patch 1319721 2 312999 annulen 2017-06-15 14:35:59 -0700 Comment on attachment 312999 Patch Clearing flags on attachment: 312999 Committed r218357: <http://trac.webkit.org/changeset/218357> 1319722 3 annulen 2017-06-15 14:36:04 -0700 All reviewed patches have been landed. Closing bug. 312999 2017-06-15 12:30:13 -0700 2017-06-15 14:35:59 -0700 Patch bug-173428-20170615223012.patch text/plain 1816 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQppbmRleCBh MGU4MWVlNTBkZGQ0MGNlNTY0NDI2M2I0NTkzYjVkMTA5NGM0MGE2Li43MTM5MjdlN2I1NTYwNjFl NzQ2YzMzNjdmMDM1ODdlNjJlNjcxOTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTM4 LDggKzM4LDEyIEBAIG1hY3JvKEFERF9QUkVDT01QSUxFRF9IRUFERVIgX2hlYWRlciBfY3BwIF9z b3VyY2UpCiAgICAgICAgICAgICBQUk9QRVJUSUVTIENPTVBJTEVfRkxBR1MgIi9ZY1wiJHtfaGVh ZGVyfVwiIC9GcFwiJHtQcmVjb21waWxlZEJpbmFyeX1cIiIKICAgICAgICAgICAgIE9CSkVDVF9P VVRQVVRTICIke1ByZWNvbXBpbGVkQmluYXJ5fSIpCiAgICAgICAgIHNldF9zb3VyY2VfZmlsZXNf cHJvcGVydGllcygke19zb3VyY2VzfQotICAgICAgICAgICAgUFJPUEVSVElFUyBDT01QSUxFX0ZM QUdTICIvWXVcIiR7X2hlYWRlcn1cIiAvRklcIiR7X2hlYWRlcn1cIiAvRnBcIiR7UHJlY29tcGls ZWRCaW5hcnl9XCIiCi0gICAgICAgICAgICBPQkpFQ1RfREVQRU5EUyAiJHtQcmVjb21waWxlZEJp bmFyeX0iKQorICAgICAgICAgICAgUFJPUEVSVElFUyBDT01QSUxFX0ZMQUdTICIvWXVcIiR7X2hl YWRlcn1cIiAvRklcIiR7X2hlYWRlcn1cIiAvRnBcIiR7UHJlY29tcGlsZWRCaW5hcnl9XCIiKQor CisgICAgICAgIGZvcmVhY2ggKF9zcmMgJHtfc291cmNlc30pCisgICAgICAgICAgICBBRERfU09V UkNFX0RFUEVOREVOQ0lFUygke19zcmN9ICR7UHJlY29tcGlsZWRCaW5hcnl9KQorICAgICAgICBl bmRmb3JlYWNoICgpCisKICAgICAgICAgbGlzdChBUFBFTkQgJHtfc291cmNlfSAke19jcHB9KQog ICAgIGVuZGlmICgpCiAgICAgI0ZJWE1FOiBBZGQgc3VwcG9ydCBmb3IgWGNvZGUuCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZjUwYjg2OGY4NmU1YWVmNTkyNzE1NzY1 ODNmYjcyOWJhZjJhNmIyNy4uYjA4OGU5Y2ViNmQzMGNlZGIzZjdlZmM4OTAyNWMxYmQ1OTUzNTE2 MiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDE3LTA2LTE1ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKwor ICAgICAgICBbY21ha2VdIEFERF9QUkVDT01QSUxFRF9IRUFERVIgc2hvdWxkIGFwcGVuZCBPQkpF Q1RfREVQRU5EUywgbm90IG92ZXJ3cml0ZSBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNDI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmlnaHQgbm93LCBpZiBhbnkgb2Ygc291cmNlIGZpbGVzIHRo YXQgYXJlIHBhc3NlZCB0bworICAgICAgICBBRERfUFJFQ09NUElMRURfSEVBREVSIGhhdmUgbm9u LWVtcHR5IE9CSkVDVF9ERVBFTkRTIHByb3BlcnR5IChlLmcuCisgICAgICAgIGNoYW5nZWQgd2l0 aCBBRERfU09VUkNFX0RFUEVOREVOQ0lFUyBjYWxsKSwgaXRzIHZhbHVlIGlzIGxvc3QuCisKKyAg ICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlOgorCiAyMDE3LTA2LTE1ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RL XSBEbyBub3QgdXNlIHRoZSBDIEFQSSBpbiBXZWJHdGtFeHRlbnNpb25NYW5hZ2VyCg==