173416 2017-06-15 05:38:06 -0700 [JSC] Add fast path for Object.assign 2017-06-17 00:18:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 173414 1 ysuzuki ysuzuki buildbot commit-queue fpizlo keith_miller mark.lam msaboff saam sam oldest_to_newest 1319545 0 ysuzuki 2017-06-15 05:38:06 -0700 Unless observable behavior happens, we can avoid GetOwnProperty for each key to ensure the key is still enumerable. 1320137 1 313125 ysuzuki 2017-06-16 13:45:59 -0700 Created attachment 313125 Patch 1320138 2 ysuzuki 2017-06-16 13:46:27 -0700 Basic idea is similar to https://bugs.webkit.org/show_bug.cgi?id=163305 1320149 3 313125 mark.lam 2017-06-16 13:59:29 -0700 Comment on attachment 313125 Patch r=me 1320155 4 313125 ysuzuki 2017-06-16 14:03:42 -0700 Comment on attachment 313125 Patch Thank you! 1320179 5 313125 commit-queue 2017-06-16 14:32:56 -0700 Comment on attachment 313125 Patch Clearing flags on attachment: 313125 Committed r218415: <http://trac.webkit.org/changeset/218415> 1320180 6 commit-queue 2017-06-16 14:32:57 -0700 All reviewed patches have been landed. Closing bug. 1320355 7 ysuzuki 2017-06-17 00:18:45 -0700 https://perf.webkit.org/v3/#/charts?since=1496979192778&paneList=((18-906-27907411-null-(5-2.5-500))) Go further! 313125 2017-06-16 13:45:59 -0700 2017-06-16 14:32:56 -0700 Patch bug-173416-20170617054558.patch text/plain 6978 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MzM4NzYzMDVmODMwNWYxMTBlZGZjNzEzNzIyMmEyYzhjMGZiNmY4Li43ZDY3ZDM0ZWU5NWUxNmVl YWU1M2YxZDU0MzYyN2ViMTZjZjkxYjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxNy0wNi0xNiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBBZGQgZmFzdCBwYXRoIGZvciBPYmplY3QuYXNzaWduCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM0MTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBPYmplY3Qu YXNzaWduIGltcGxlbWVudGF0aW9uLCB3ZSBuZWVkIHRvIGVuc3VyZSB0aGF0IGdpdmVuIGtleSBp cyBzdGlsbCBlbnVtZXJhYmxlIG93biBrZXkuCisgICAgICAgIFRoaXMgc2VlbXMgZHVwbGljYXRl IGxvb2sgdXAuIEFuZCB3ZSB3YW50IHRvIGF2b2lkIHRoaXMuIEhvd2V2ZXIsIHdlIHN0aWxsIG5l ZWQgdG8gcGVyZm9ybSB0aGlzCisgICAgICAgIGNoZWNrIGluIHRoZSBmYWNlIG9mIFByb3h5LiBQ cm94eSBjYW4gb2JzZXJ2ZSB0aGF0IHRoaXMgY2hlY2sgaXMgZG9uZSBjb3JyZWN0bHkuCisKKyAg ICAgICAgSW4gYWxtb3N0IGFsbCB0aGUgY2FzZXMsIHRoZSBhYm92ZSBjaGVjayBpcyBkdXBsaWNh dGUgdG8gdGhlIHN1YnNlcXVlbnQgW1tHZXRdXSBvcGVyYXRpb24uCisgICAgICAgIEluIHRoaXMg cGF0Y2gsIHdlIHBlcmZvcm0gdGhpcyBjaGVjay4gQnV0IGF0IHRoYXQgdGltZSwgd2UgaW52ZXN0 aWdhdGUgYGlzVGFpbnRlZEJ5T3BhcXVlT2JqZWN0KClgLgorICAgICAgICBJZiBpdCBpcyBmYWxz ZSwgd2UgY2FuIHNheSB0aGF0IGdldE93blByb3BlcnR5U2xvdCBpcyBwdXJlLiBJbiB0aGF0IGNh c2UsIHdlIGNhbiBqdXN0IHJldHJpZXZlIHRoZQorICAgICAgICB2YWx1ZSBieSBjYWxsaW5nIGBz bG90LmdldFZhbHVlKClgLgorCisgICAgICAgIFRoaXMgZnVydGhlciBpbXByb3ZlcyBwZXJmb3Jt YW5jZSBvZiBPYmplY3QuYXNzaWduLgorCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgYmFzZWxpbmUgICAgICAgICAgICAgICAgICBwYXRjaGVkCisKKyAgICAgICAgICAg IG9iamVjdC1hc3NpZ24uZXM2ICAgICAgMzYzLjY3MDYrLTYuNDM4MSAgICAgXiAgICAzMjQuMTc2 OSstNi45NjI0ICAgICAgICBeIGRlZmluaXRlbHkgMS4xMjE4eCBmYXN0ZXIKKworICAgICAgICAq IHJ1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpvYmplY3RDb25z dHJ1Y3RvckFzc2lnbik6CisKIDIwMTctMDYtMTYgIE1hdHQgTGV3aXMgIDxqbGV3aXMzQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjE4Mzc2LgpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwCmlu ZGV4IDU1MTZjNTJlNTM1OWY0Y2JlOWM3Mjc3OTdiYzNlZGVkOWNiZWMyOWUuLjIxYzkzM2JhOTBh OTM3ZWQzOTIyMDUyYmQzMjk2MmJmM2MxNWViZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVjdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHAKQEAgLTMzMCwxNSArMzMwLDE3 IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgb2JqZWN0Q29uc3RydWN0b3JBc3NpZ24o RXhlY1N0YXRlKiBleGVjKQogICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB7IH0p OwogCiAgICAgICAgIGF1dG8gYXNzaWduID0gWyZdIChQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1l KSB7Ci0gICAgICAgICAgICAvLyBGSVhNRTogV2UgY2FuIGF2b2lkIHRoaXMgZW51bWVyYWJsZSBs b29rIHVwIGJ5IGNoZWNraW5nIFN0cnVjdHVyZSdzIHN0YXR1cy4KLSAgICAgICAgICAgIC8vIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM0MTYKICAgICAgICAgICAg IFByb3BlcnR5U2xvdCBzbG90KHNvdXJjZSwgUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5 cGU6OkdldE93blByb3BlcnR5KTsKICAgICAgICAgICAgIGlmICghc291cmNlLT5tZXRob2RUYWJs ZSh2bSktPmdldE93blByb3BlcnR5U2xvdChzb3VyY2UsIGV4ZWMsIHByb3BlcnR5TmFtZSwgc2xv dCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgaWYgKHNsb3QuYXR0cmli dXRlcygpICYgRG9udEVudW0pCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgICAg ICBKU1ZhbHVlIHZhbHVlID0gc291cmNlLT5nZXQoZXhlYywgcHJvcGVydHlOYW1lKTsKKyAgICAg ICAgICAgIEpTVmFsdWUgdmFsdWU7CisgICAgICAgICAgICBpZiAoTElLRUxZKCFzbG90LmlzVGFp bnRlZEJ5T3BhcXVlT2JqZWN0KCkpKQorICAgICAgICAgICAgICAgIHZhbHVlID0gc2xvdC5nZXRW YWx1ZShleGVjLCBwcm9wZXJ0eU5hbWUpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAg ICAgIHZhbHVlID0gc291cmNlLT5nZXQoZXhlYywgcHJvcGVydHlOYW1lKTsKICAgICAgICAgICAg IFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIHZvaWQoKSk7CiAKICAgICAgICAgICAgIFB1dFBy b3BlcnR5U2xvdCBwdXRQcm9wZXJ0eVNsb3QodGFyZ2V0LCB0cnVlKTsKZGlmZiAtLWdpdCBhL0pT VGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzIwZGQ0YmJlNTAwYWEy MzFmMWFjYjU0ODJlMmFiMjk5Y2NmY2I0Yy4uMjk0Y2E1OTRmMjY4ZDE0YjAzY2RmNTZjMTZjYzVk ODJhNDU1MGU2YyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxNy0wNi0xNiAgWXVzdWtlIFN1enVraSAgPHV0 YXRhbmUudGVhQGdtYWlsLmNvbT4KKworICAgICAgICBbSlNDXSBBZGQgZmFzdCBwYXRoIGZvciBP YmplY3QuYXNzaWduCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzM0MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHN0cmVzcy9vYmplY3QtYXNzaWduLWNoYW5naW5nLXByb3BlcnRpZXMuanM6IEFkZGVk LgorICAgICAgICAoc2hvdWxkQmUpOgorICAgICAgICAodGhyb3cubmV3LkVycm9yLmxldC5zb3Vy Y2UuZ2V0IHgpOgorICAgICAgICAodGhyb3cubmV3LkVycm9yKToKKyAgICAgICAgKHNob3VsZEJl LmxldC5zb3VyY2UuZ2V0IHgpOgorICAgICAgICAoc2hvdWxkQmUubGV0LnRhcmdldC5zZXQgeCk6 CisgICAgICAgIChzaG91bGRCZS5sZXQudGFyZ2V0LmdldCB4KToKKyAgICAgICAgKiBzdHJlc3Mv b2JqZWN0LWFzc2lnbi1wcm94eS5qczogQWRkZWQuCisgICAgICAgIChzaG91bGRCZSk6CisgICAg ICAgICh0aHJvdy5uZXcuRXJyb3IubGV0LmhhbmRsZXIuZ2V0IG9yZGVyKToKKwogMjAxNy0wNi0x NSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlND XSBJbXBsZW1lbnQgT2JqZWN0LmFzc2lnbiBpbiBDKysKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3Ry ZXNzL29iamVjdC1hc3NpZ24tY2hhbmdpbmctcHJvcGVydGllcy5qcyBiL0pTVGVzdHMvc3RyZXNz L29iamVjdC1hc3NpZ24tY2hhbmdpbmctcHJvcGVydGllcy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43MDU2OTE4 ZjllM2RiOTRkMTgyYjE1N2FiZDM5NDRlNjc1ODcwOWY3Ci0tLSAvZGV2L251bGwKKysrIGIvSlNU ZXN0cy9zdHJlc3Mvb2JqZWN0LWFzc2lnbi1jaGFuZ2luZy1wcm9wZXJ0aWVzLmpzCkBAIC0wLDAg KzEsODAgQEAKK2Z1bmN0aW9uIHNob3VsZEJlKGFjdHVhbCwgZXhwZWN0ZWQpCit7CisgICAgaWYg KGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93IG5ldyBFcnJvcignYmFkIHZhbHVl OiAnICsgYWN0dWFsKTsKK30KKworeworICAgIGxldCBzb3VyY2UgPSB7CisgICAgICAgIGdldCB4 KCkgeworICAgICAgICAgICAgZGVsZXRlIHRoaXMueTsKKyAgICAgICAgICAgIHJldHVybiA0MjsK KyAgICAgICAgfSwKKyAgICAgICAgeTogNDIKKyAgICB9OworICAgIGxldCByZXN1bHQgPSBPYmpl Y3QuYXNzaWduKHt9LCBzb3VyY2UpOworICAgIHNob3VsZEJlKHJlc3VsdC54LCA0Mik7CisgICAg c2hvdWxkQmUocmVzdWx0Lmhhc093blByb3BlcnR5KCd5JyksIGZhbHNlKTsKK30KKworeworICAg IGxldCBzb3VyY2UgPSB7CisgICAgICAgIGdldCB4KCkgeworICAgICAgICAgICAgcmV0dXJuIDQy OworICAgICAgICB9LAorICAgICAgICB5OiA0MgorICAgIH07CisgICAgdmFyIHN0b3JlID0gMDsK KyAgICBsZXQgdGFyZ2V0ID0geworICAgICAgICBzZXQgeCh2YWx1ZSkgeworICAgICAgICAgICAg c3RvcmUgPSB2YWx1ZTsKKyAgICAgICAgICAgIGRlbGV0ZSBzb3VyY2UueTsKKyAgICAgICAgfSwK KyAgICAgICAgZ2V0IHgoKSB7CisgICAgICAgICAgICByZXR1cm4gc3RvcmU7CisgICAgICAgIH0s CisgICAgfTsKKyAgICBsZXQgcmVzdWx0ID0gT2JqZWN0LmFzc2lnbih0YXJnZXQsIHNvdXJjZSk7 CisgICAgc2hvdWxkQmUocmVzdWx0LngsIDQyKTsKKyAgICBzaG91bGRCZShyZXN1bHQuaGFzT3du UHJvcGVydHkoJ3knKSwgZmFsc2UpOworfQorCisKK3sKKyAgICBsZXQgc291cmNlID0geworICAg ICAgICBnZXQgeCgpIHsKKyAgICAgICAgICAgIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShzb3VyY2Us ICd5JywgeworICAgICAgICAgICAgICAgIGVudW1lcmFibGU6IGZhbHNlCisgICAgICAgICAgICB9 KTsKKyAgICAgICAgICAgIHJldHVybiA0MjsKKyAgICAgICAgfSwKKyAgICAgICAgeTogNDIKKyAg ICB9OworICAgIGxldCByZXN1bHQgPSBPYmplY3QuYXNzaWduKHt9LCBzb3VyY2UpOworICAgIHNo b3VsZEJlKHJlc3VsdC54LCA0Mik7CisgICAgc2hvdWxkQmUocmVzdWx0Lmhhc093blByb3BlcnR5 KCd5JyksIGZhbHNlKTsKK30KKworeworICAgIGxldCBzb3VyY2UgPSB7CisgICAgICAgIGdldCB4 KCkgeworICAgICAgICAgICAgcmV0dXJuIDQyOworICAgICAgICB9LAorICAgICAgICB5OiA0Mgor ICAgIH07CisgICAgdmFyIHN0b3JlID0gMDsKKyAgICBsZXQgdGFyZ2V0ID0geworICAgICAgICBz ZXQgeCh2YWx1ZSkgeworICAgICAgICAgICAgc3RvcmUgPSB2YWx1ZTsKKyAgICAgICAgICAgIE9i amVjdC5kZWZpbmVQcm9wZXJ0eShzb3VyY2UsICd5JywgeworICAgICAgICAgICAgICAgIGVudW1l cmFibGU6IGZhbHNlCisgICAgICAgICAgICB9KTsKKyAgICAgICAgfSwKKyAgICAgICAgZ2V0IHgo KSB7CisgICAgICAgICAgICByZXR1cm4gc3RvcmU7CisgICAgICAgIH0sCisgICAgfTsKKyAgICBs ZXQgcmVzdWx0ID0gT2JqZWN0LmFzc2lnbih0YXJnZXQsIHNvdXJjZSk7CisgICAgc2hvdWxkQmUo cmVzdWx0LngsIDQyKTsKKyAgICBzaG91bGRCZShyZXN1bHQuaGFzT3duUHJvcGVydHkoJ3knKSwg ZmFsc2UpOworfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3Mvb2JqZWN0LWFzc2lnbi1wcm94 eS5qcyBiL0pTVGVzdHMvc3RyZXNzL29iamVjdC1hc3NpZ24tcHJveHkuanMKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ZDBiMGUzYjRkNWY0OTBhYjkzMjk5ZGIyMjI3ZTEyMDBkNjU4NjU3OAotLS0gL2Rldi9udWxsCisr KyBiL0pTVGVzdHMvc3RyZXNzL29iamVjdC1hc3NpZ24tcHJveHkuanMKQEAgLTAsMCArMSwzMSBA QAorZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1YWwg IT09IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ2JhZCB2YWx1ZTogJyArIGFj dHVhbCk7Cit9CisKK3sKKyAgICB2YXIgb3JkZXIgPSBbXTsKKyAgICBsZXQgdGFyZ2V0ID0ge3g6 IDIwLCB5OjQyfTsKKyAgICBsZXQgaGFuZGxlciA9IHsKKyAgICAgICAgZ2V0T3duUHJvcGVydHlE ZXNjcmlwdG9yKHRoZVRhcmdldCwgcHJvcE5hbWUpCisgICAgICAgIHsKKyAgICAgICAgICAgIG9y ZGVyLnB1c2goYGdldE93blByb3BlcnR5RGVzY3JpcHRvciAke3Byb3BOYW1lfWApOworICAgICAg ICAgICAgcmV0dXJuIHsKKyAgICAgICAgICAgICAgICBlbnVtZXJhYmxlOiB0cnVlLAorICAgICAg ICAgICAgICAgIGNvbmZpZ3VyYWJsZTogdHJ1ZSwKKyAgICAgICAgICAgICAgICB2YWx1ZTogNDIK KyAgICAgICAgICAgIH07CisgICAgICAgIH0sCisgICAgICAgIGdldCh0aGVUYXJnZXQsIHByb3BO YW1lLCByZWNlaXZlcikKKyAgICAgICAgeworICAgICAgICAgICAgb3JkZXIucHVzaChgZ2V0ICR7 cHJvcE5hbWV9YCk7CisgICAgICAgICAgICByZXR1cm4gNDI7CisgICAgICAgIH0KKyAgICB9Owor CisgICAgbGV0IHByb3h5ID0gbmV3IFByb3h5KHRhcmdldCwgaGFuZGxlcik7CisgICAgdmFyIHJl c3VsdCA9IE9iamVjdC5hc3NpZ24oe30sIHByb3h5KTsKKyAgICBzaG91bGRCZShyZXN1bHQueCwg NDIpOworICAgIHNob3VsZEJlKHJlc3VsdC55LCA0Mik7CisgICAgc2hvdWxkQmUob3JkZXIuam9p bignLCcpLCBgZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yIHgsZ2V0IHgsZ2V0T3duUHJvcGVydHlE ZXNjcmlwdG9yIHksZ2V0IHlgKTsKK30K