173410 2017-06-15 04:56:58 -0700 [GStreamer] fast/canvas/canvas-createPattern-video-loading.html is failing since r218170 2021-04-09 02:30:02 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 172427 1 magomez pnormand bugs-noreply calvaris cgarcia csaavedra eric.carlson ews-watchlist glenn gustavo jer.noble menard Ms2ger philipj pnormand sergio vjaquez yoon zan oldest_to_newest 1319531 0 magomez 2017-06-15 04:56:58 -0700 fast/canvas/canvas-createPattern-video-loading.html [ Failure ] 1337396 1 Ms2ger 2017-08-10 05:28:03 -0700 The test fails because drawImageToCanvasAndCheckPixels only find transparent black on the canvas when called from the "playing" callback. The issue is that MediaPlayerPrivateGStreamerBase::m_sample is set to nullptr in the newly added flushCurrentBuffer() method, called in response to a GST_EVENT_FLUSH_START event. The paint() method then returns early because GST_IS_SAMPLE(m_sample.get()) is false, and the CanvasPattern ends up transparent black. 1395840 2 csaavedra 2018-02-02 06:48:58 -0800 This started failing recently in Wayland and WPE as well: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcanvas%2Fcanvas-createPattern-video-modify.html 1395841 3 csaavedra 2018-02-02 06:49:29 -0800 Ah, sorry. Different test. :/ 1402554 4 pnormand 2018-02-28 02:13:50 -0800 (In reply to Ms2ger from comment #1) > The test fails because drawImageToCanvasAndCheckPixels only find transparent > black on the canvas when called from the "playing" callback. > > The issue is that MediaPlayerPrivateGStreamerBase::m_sample is set to > nullptr in the newly added flushCurrentBuffer() method, called in response > to a GST_EVENT_FLUSH_START event. The paint() method then returns early > because GST_IS_SAMPLE(m_sample.get()) is false, and the CanvasPattern ends > up transparent black. Yes and because no texture copy is done when flushing the sample. The m_platformLayerProxy->dropCurrentBufferWhilePreservingTexture() call has no effect, because it's done outside of the texturemapper code path. 1746787 5 425097 pnormand 2021-04-03 10:16:44 -0700 Created attachment 425097 Patch 1748671 6 ews-feeder 2021-04-09 02:29:58 -0700 Committed r275755 (236333@main): <https://commits.webkit.org/236333@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425097. 425097 2021-04-03 10:16:44 -0700 2021-04-09 02:30:00 -0700 Patch bug-173410-20210403101643.patch text/plain 5065 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA5ZmRjYzBkZWVkYmI0 NDFlOGI3MWEyZTliYjQ5OTliY2IwZjQ2Ni4uYmNkMDZmNzljZTEzNDU3MGViNDU1NWFhNDQ5ODJl YzJlNDkxZjBlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA0LTAzICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBmYXN0L2NhbnZhcy9jYW52YXMtY3JlYXRlUGF0dGVybi12aWRlby1sb2FkaW5nLmh0bWwgaXMg ZmFpbGluZyBzaW5jZSByMjE4MTcwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzM0MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXaGVuIGEgZmx1c2ggaGFzIGJlZW4gcmVxdWVzdGVkIGJ5IHRoZSBHTCB2 aWRlbyBzaW5rLCBhbGxvY2F0ZSBhIG5ldyBjb3B5IG9mIHRoZSBzYW1wbGUKKyAgICAgICAgd2hp Y2ggaGFzIHRvIGJlIHJlbGVhc2VkLiBUaGUgY29weSBpcyBuZWNlc3Nhcnkgc28gdGhhdCB0aGUg dmlkZW8gZGltZW5zaW9ucyBjYW4gc3RpbGwgYmUKKyAgICAgICAgZmV0Y2hlZCBhbmQgYWxzbyBm b3IgY2FudmFzIHJlbmRlcmluZy4gVGhlIHJlbGVhc2UgaXMgbmVjZXNzYXJ5IGJlY2F1c2UgdGhl IHNhbXBsZSBtaWdodAorICAgICAgICBoYXZlIGJlZW4gYWxsb2NhdGVkIGJ5IGEgaGFyZHdhcmUg ZGVjb2RlciBhbmQgbWVtb3J5IG1pZ2h0IGhhdmUgdG8gYmUgcmVjbGFpbWVkIGJ5IGEKKyAgICAg ICAgbm9uLXN5c21lbSBidWZmZXIgcG9vbC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpmbHVzaEN1cnJlbnRCdWZmZXIpOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpwYWludCk6CisK IDIwMjEtMDQtMDIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UGVuZGluZ0ltYWdlQml0bWFwIGdldHMgY3JlYXRlZCBvbiBhIHN0b3BwZWQgc2NyaXB0IGV4ZWN1 dGlvbiBjb250ZXh0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyLmNwcAppbmRleCBjNjkxMjg0NjVlOGZkZTMwNjFjZGE1ZDQ0OTg0NTg4NTM5NWRjM2VhLi45 MWFhMmRiOWFjMDcwNjc4YTBkYzFiZTQxNWE4ZDAwMzFhMTIxNjQxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMzEzOCwxMCArMzEzOCwx MyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Zmx1c2hDdXJyZW50QnVmZmVy KCkKICAgICBhdXRvIHNhbXBsZUxvY2tlciA9IGhvbGRMb2NrKG1fc2FtcGxlTXV0ZXgpOwogCiAg ICAgaWYgKG1fc2FtcGxlKSB7Ci0gICAgICAgIC8vIFJlcGxhY2UgYnkgYSBuZXcgc2FtcGxlIGhh dmluZyBvbmx5IHRoZSBjYXBzLCBzbyB0aGlzIGR1bW15IHNhbXBsZSBpcyBzdGlsbCB1c2VmdWwg dG8gZ2V0IHRoZSBkaW1lbnNpb25zLgotICAgICAgICAvLyBUaGlzIHByZXZlbnRzIHJlc2l6aW5n IHByb2JsZW1zIHdoZW4gdGhlIHZpZGVvIGNoYW5nZXMgaXRzIHF1YWxpdHkgYW5kIGEgRFJBSU4g aXMgcGVyZm9ybWVkLgorICAgICAgICAvLyBBbGxvY2F0ZSBhIG5ldyBjb3B5IG9mIHRoZSBzYW1w bGUgd2hpY2ggaGFzIHRvIGJlIHJlbGVhc2VkLiBUaGUgY29weSBpcyBuZWNlc3Nhcnkgc28gdGhh dAorICAgICAgICAvLyB0aGUgdmlkZW8gZGltZW5zaW9ucyBjYW4gc3RpbGwgYmUgZmV0Y2hlZCBh bmQgYWxzbyBmb3IgY2FudmFzIHJlbmRlcmluZy4gVGhlIHJlbGVhc2UgaXMKKyAgICAgICAgLy8g bmVjZXNzYXJ5IGJlY2F1c2UgdGhlIHNhbXBsZSBtaWdodCBoYXZlIGJlZW4gYWxsb2NhdGVkIGJ5 IGEgaGFyZHdhcmUgZGVjb2RlciBhbmQgbWVtb3J5CisgICAgICAgIC8vIG1pZ2h0IGhhdmUgdG8g YmUgcmVjbGFpbWVkIGJ5IGEgbm9uLXN5c21lbSBidWZmZXIgcG9vbC4KICAgICAgICAgY29uc3Qg R3N0U3RydWN0dXJlKiBpbmZvID0gZ3N0X3NhbXBsZV9nZXRfaW5mbyhtX3NhbXBsZS5nZXQoKSk7 Ci0gICAgICAgIG1fc2FtcGxlID0gYWRvcHRHUmVmKGdzdF9zYW1wbGVfbmV3KG51bGxwdHIsIGdz dF9zYW1wbGVfZ2V0X2NhcHMobV9zYW1wbGUuZ2V0KCkpLAorICAgICAgICBhdXRvIGJ1ZmZlciA9 IGFkb3B0R1JlZihnc3RfYnVmZmVyX2NvcHlfZGVlcChnc3Rfc2FtcGxlX2dldF9idWZmZXIobV9z YW1wbGUuZ2V0KCkpKSk7CisgICAgICAgIG1fc2FtcGxlID0gYWRvcHRHUmVmKGdzdF9zYW1wbGVf bmV3KGJ1ZmZlci5nZXQoKSwgZ3N0X3NhbXBsZV9nZXRfY2FwcyhtX3NhbXBsZS5nZXQoKSksCiAg ICAgICAgICAgICBnc3Rfc2FtcGxlX2dldF9zZWdtZW50KG1fc2FtcGxlLmdldCgpKSwgaW5mbyA/ IGdzdF9zdHJ1Y3R1cmVfY29weShpbmZvKSA6IG51bGxwdHIpKTsKICAgICB9CiAKQEAgLTMyMzAs NyArMzIzMyw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpwYWludChHcmFw aGljc0NvbnRleHQmIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjCiAgICAgaWYgKCFnc3RJbWFnZSkK ICAgICAgICAgcmV0dXJuOwogCi0gICAgY29udGV4dC5kcmF3SW1hZ2UoZ3N0SW1hZ2UtPmltYWdl KCksIHJlY3QsIGdzdEltYWdlLT5yZWN0KCksIHsgQ29tcG9zaXRlT3BlcmF0b3I6OkNvcHksIG1f Y2FuUmVuZGVyaW5nQmVBY2NlbGVyYXRlZCA/IG1fdmlkZW9Tb3VyY2VPcmllbnRhdGlvbiA6IElt YWdlT3JpZW50YXRpb24oKSB9KTsKKyAgICBjb250ZXh0LmRyYXdJbWFnZShnc3RJbWFnZS0+aW1h Z2UoKSwgcmVjdCwgZ3N0SW1hZ2UtPnJlY3QoKSwgeyBDb21wb3NpdGVPcGVyYXRvcjo6Q29weSwg bV9zaG91bGRIYW5kbGVPcmllbnRhdGlvblRhZ3MgPyBtX3ZpZGVvU291cmNlT3JpZW50YXRpb24g OiBJbWFnZU9yaWVudGF0aW9uKCkgfSk7CiB9CiAKICNpZiBVU0UoR1NUUkVBTUVSX0dMKQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IGQyMjA0MjkwZWU3YmZiYTcxZTFiMjNmYWI3OTY5MmNjODA2MWY0YmIuLjI4ZGRlYmI1NTgw N2M0MjYyMDkyMGU3MDM1YWMwY2M1ZjVhOWNmMjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAy MS0wNC0wMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAg ICAgW0dTdHJlYW1lcl0gZmFzdC9jYW52YXMvY2FudmFzLWNyZWF0ZVBhdHRlcm4tdmlkZW8tbG9h ZGluZy5odG1sIGlzIGZhaWxpbmcgc2luY2UgcjIxODE3MAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczNDEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u czogVW5mbGFnIG5vdy1wYXNzaW5nIHRlc3QuCisKIDIwMjEtMDQtMDIgIEFtaXIgTWFyayBKciAg PGFtaXJfbWFya0BhcHBsZS5jb20+CiAKICAgICAgICAgWyBNYWNPUyBdIG1lZGlhL21vZGVybi1t ZWRpYS1jb250cm9scy9tYWNvcy1pbmxpbmUtbWVkaWEtY29udHJvbHMvbWFjb3MtaW5saW5lLW1l ZGlhLWRyb3BwaW5nLWNvbnRyb2xzLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDZkY2NlMDM2YTFjYWY0MjkwMDNh ZmU2ZmI4YjVhYWI2Y2M0NDk4MmMuLjQzZTY0NmU1OGM0ZTkzYmIzMTg4MTEwZTU5MzYwOTI3ZGYy NzZjNDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0y MjE5LDggKzIyMTksNiBAQCB3ZWJraXQub3JnL2IvMTcyODExIGZhc3QvZm9ybXMvbnVtYmVyL251 bWJlci1hcHBlYXJhbmNlLXJ0bC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTcyODEx IGZhc3QvZm9ybXMvbnVtYmVyL251bWJlci1hcHBlYXJhbmNlLXNwaW5idXR0b24tZGlzYWJsZWQt cmVhZG9ubHkuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE3MjgxMSBmYXN0L2Zvcm1z L251bWJlci9udW1iZXItYXBwZWFyYW5jZS1zcGluYnV0dG9uLWxheWVyLmh0bWwgWyBGYWlsdXJl IF0KIAotd2Via2l0Lm9yZy9iLzE3MzQxMCBmYXN0L2NhbnZhcy9jYW52YXMtY3JlYXRlUGF0dGVy bi12aWRlby1sb2FkaW5nLmh0bWwgWyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE3MzQxMyBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2Zvcm1zL3RleHRm aWVsZHNlbGVjdGlvbi9zZWxlY3Rpb24tYWZ0ZXItY29udGVudC1jaGFuZ2UuaHRtbCBbIEZhaWx1 cmUgXQogCiB3ZWJraXQub3JnL2IvMTQzNzAyIG1lZGlhL3Byb2dyZXNzLWV2ZW50cy1nZW5lcmF0 ZWQtY29ycmVjdGx5Lmh0bWwgWyBUaW1lb3V0IEZhaWx1cmUgUGFzcyBDcmFzaCBdCg==