173406 2017-06-15 01:41:37 -0700 [GTK] Enable GStreamer GL by default on production builds 2017-06-23 17:22:13 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1319500 0 magomez 2017-06-15 01:41:37 -0700 Enable GStreamer GL by default on production builds, only if the gstreamer version is higher than 1.10. 1319502 1 cgarcia 2017-06-15 01:51:32 -0700 (In reply to Miguel Gomez from comment #0) > Enable GStreamer GL by default on production builds, only if the gstreamer > version is higher than 1.10. or equal, no? 1319504 2 312961 magomez 2017-06-15 01:57:17 -0700 Created attachment 312961 Patch 1319505 3 312962 magomez 2017-06-15 02:01:26 -0700 Created attachment 312962 Patch 1319506 4 magomez 2017-06-15 02:02:23 -0700 (In reply to Carlos Garcia Campos from comment #1) > (In reply to Miguel Gomez from comment #0) > > Enable GStreamer GL by default on production builds, only if the gstreamer > > version is higher than 1.10. > > or equal, no? Yep. Corrected the comment in the patch, as I was already checking for >= 1.10. 1319508 5 312962 cgarcia 2017-06-15 02:06:53 -0700 Comment on attachment 312962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312962&action=review > Source/cmake/OptionsGTK.cmake:95 > -WEBKIT_OPTION_DEFINE(USE_GSTREAMER_GL "Whether to enable support for GStreamer GL" PRIVATE OFF) > +WEBKIT_OPTION_DEFINE(USE_GSTREAMER_GL "Whether to enable support for GStreamer GL" PRIVATE ON) I think we will have to make this public, because we will require users to pass USE_GSTREAMER_GL=OFF if they are building with gst < 1.10. Or maybe we should not make this fatal and simply enable/disable it depending on the gst version. This is different than libnotify or libhyphen in that the dep is not missing but old. What do you think? 1319553 6 magomez 2017-06-15 06:12:14 -0700 (In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 312962 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312962&action=review > > > Source/cmake/OptionsGTK.cmake:95 > > -WEBKIT_OPTION_DEFINE(USE_GSTREAMER_GL "Whether to enable support for GStreamer GL" PRIVATE OFF) > > +WEBKIT_OPTION_DEFINE(USE_GSTREAMER_GL "Whether to enable support for GStreamer GL" PRIVATE ON) > > I think we will have to make this public, because we will require users to > pass USE_GSTREAMER_GL=OFF if they are building with gst < 1.10. Or maybe we > should not make this fatal and simply enable/disable it depending on the gst > version. This is different than libnotify or libhyphen in that the dep is > not missing but old. What do you think? I would make it public. Even if we default to ON, there could be distros that meet the dependencies but wanted to keep it disabled. 1319634 7 312962 mcatanzaro 2017-06-15 11:45:18 -0700 Comment on attachment 312962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312962&action=review Awesome! Thanks Miguel. I don't think it should be public. GStreamer is an old requirement and OpenGL is an old requirement. They can both be disabled via other flags. It already has dependencies on ENABLE_OPENGL and ENABLE_VIDEO, so just changing the flag to ON should make it good to go. I have no clue why a distro would want to keep it disabled. We should keep all distros using the default flags, or this isn't going to be maintainable. > Source/cmake/OptionsGTK.cmake:368 > + if (PC_GSTREAMER_VERSION VERSION_LESS "1.10") > + message(FATAL_ERROR "GStreamer 1.10 is required to use USE_GSTREAMER_GL.") > + endif () I would silently disable it in this case. I don't normally approve of silently disabling features, because it's easy to miss a dependency that needs to be installed and therefore miss the feature. But in this case, it's just a version check, and there's no way you want GStreamerGL if you have older GStreamer, so I think this is fine. 1319923 8 magomez 2017-06-16 05:04:41 -0700 > I would silently disable it in this case. I don't normally approve of > silently disabling features, because it's easy to miss a dependency that > needs to be installed and therefore miss the feature. But in this case, it's > just a version check, and there's no way you want GStreamerGL if you have > older GStreamer, so I think this is fine. Sounds good. I'll follow that approach then. But I'll wait a bit for it, as I found that there are problems with gl rendering in wayland, and if we enabled gst-gl, video rendering will break there. I'll fix the gl issue first, then update this. 1321448 9 313504 magomez 2017-06-21 03:43:52 -0700 Created attachment 313504 Patch 1321460 10 313504 commit-queue 2017-06-21 05:33:20 -0700 Comment on attachment 313504 Patch Clearing flags on attachment: 313504 Committed r218630: <http://trac.webkit.org/changeset/218630> 1321461 11 commit-queue 2017-06-21 05:33:22 -0700 All reviewed patches have been landed. Closing bug. 1322517 12 mcatanzaro 2017-06-23 17:22:13 -0700 Awesome, thanks Miguel! (I notice now that I wrote this a couple comments up, but I forgot about this bug, and this really is pretty great, so I'm going to write it here again.) 312961 2017-06-15 01:57:17 -0700 2017-06-15 02:01:21 -0700 Patch bug-173406-20170615105715.patch text/plain 2016 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGRmMzA5 NjJlNmY5N2UwMzk2N2ZmY2QzMGFmYWQwZjEyNDQwNmE2NmUuLjBhOTEwMDA4MzdjMmVhMGIwZDU2 NjFlNThlZTFiYzM0YzY0NmM3ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC05Miw3ICs5Miw3 IEBAIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9MSUJTRUNSRVQgIldoZXRoZXIgdG8gZW5hYmxl IHRoZSBwZXJzaXN0ZW50IGNyZWRlbnRpYWwKIAogIyBQcml2YXRlIG9wdGlvbnMgc3BlY2lmaWMg dG8gdGhlIEdUSysgcG9ydC4gQ2hhbmdpbmcgdGhlc2Ugb3B0aW9ucyBpcwogIyBjb21wbGV0ZWx5 IHVuc3VwcG9ydGVkLiBUaGV5IGFyZSBpbnRlbmRlZCBmb3IgdXNlIG9ubHkgYnkgV2ViS2l0IGRl dmVsb3BlcnMuCi1XRUJLSVRfT1BUSU9OX0RFRklORShVU0VfR1NUUkVBTUVSX0dMICJXaGV0aGVy IHRvIGVuYWJsZSBzdXBwb3J0IGZvciBHU3RyZWFtZXIgR0wiIFBSSVZBVEUgT0ZGKQorV0VCS0lU X09QVElPTl9ERUZJTkUoVVNFX0dTVFJFQU1FUl9HTCAiV2hldGhlciB0byBlbmFibGUgc3VwcG9y dCBmb3IgR1N0cmVhbWVyIEdMIiBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNF X0dTVFJFQU1FUl9NUEVHVFMgIldoZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIE1QRUctVFMi IFBSSVZBVEUgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1JFRElSRUNURURfWENPTVBP U0lURV9XSU5ET1cgIldoZXRoZXIgdG8gdXNlIGEgUmVkaXJlY3RlZCBYQ29tcG9zaXRlIFdpbmRv dyBmb3IgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaW4gWDExLiIgUFJJVkFURSBPTikKIApAQCAt MzYzLDYgKzM2Myw5IEBAIGlmIChFTkFCTEVfVklERU8gT1IgRU5BQkxFX1dFQl9BVURJTykKICAg ICAgICAgaWYgKE5PVCBQQ19HU1RSRUFNRVJfR0xfRk9VTkQpCiAgICAgICAgICAgICBtZXNzYWdl KEZBVEFMX0VSUk9SICJHU3RyZWFtZXJHTCBpcyBuZWVkZWQgZm9yIFVTRV9HU1RSRUFNRVJfR0wu IikKICAgICAgICAgZW5kaWYgKCkKKyAgICAgICAgaWYgKFBDX0dTVFJFQU1FUl9WRVJTSU9OIFZF UlNJT05fTEVTUyAiMS4xMCIpCisgICAgICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJHU3Ry ZWFtZXIgMS4xMCBpcyByZXF1aXJlZCB0byB1c2UgVVNFX0dTVFJFQU1FUl9HTC4iKQorICAgICAg ICBlbmRpZiAoKQogICAgIGVuZGlmICgpCiAKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChV U0VfR1NUUkVBTUVSIFRSVUUpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5k ZXggM2YxMDQ1Y2JjM2JhNWMzOTBhNTM2ZDJhYzBhOGRjZDQxZjk0YjE1Zi4uNTY1NDg3MGIyMDU2 ODI4NDJkNjE0ZWQyODA1MjNhZGU3MTIxNDlmNiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBi L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA2LTE1ICBNaWd1ZWwgR29tZXogIDxt YWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRW5hYmxlIEdTdHJlYW1lciBHTCBi eSBkZWZhdWx0IG9uIHByb2R1Y3Rpb24gYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM0MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgR1N0cmVhbWVyIEdMIGJ5IGRlZmF1bHQgd2hl biB0aGUgR1N0cmVhbWVyIHZlcnNpb24gPiAxLjEwLgorCisgICAgICAgICogU291cmNlL2NtYWtl L09wdGlvbnNHVEsuY21ha2U6CisKIDIwMTctMDYtMDkgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNl a0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEVuYWJsZSBFTkNSWVBURURfTUVESUEgZm9y IGJ1aWxkLXdlYmtpdCBidWlsZHMK 312962 2017-06-15 02:01:26 -0700 2017-06-21 03:43:47 -0700 Patch bug-173406-20170615110124.patch text/plain 2017 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGRmMzA5 NjJlNmY5N2UwMzk2N2ZmY2QzMGFmYWQwZjEyNDQwNmE2NmUuLjBhOTEwMDA4MzdjMmVhMGIwZDU2 NjFlNThlZTFiYzM0YzY0NmM3ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC05Miw3ICs5Miw3 IEBAIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9MSUJTRUNSRVQgIldoZXRoZXIgdG8gZW5hYmxl IHRoZSBwZXJzaXN0ZW50IGNyZWRlbnRpYWwKIAogIyBQcml2YXRlIG9wdGlvbnMgc3BlY2lmaWMg dG8gdGhlIEdUSysgcG9ydC4gQ2hhbmdpbmcgdGhlc2Ugb3B0aW9ucyBpcwogIyBjb21wbGV0ZWx5 IHVuc3VwcG9ydGVkLiBUaGV5IGFyZSBpbnRlbmRlZCBmb3IgdXNlIG9ubHkgYnkgV2ViS2l0IGRl dmVsb3BlcnMuCi1XRUJLSVRfT1BUSU9OX0RFRklORShVU0VfR1NUUkVBTUVSX0dMICJXaGV0aGVy IHRvIGVuYWJsZSBzdXBwb3J0IGZvciBHU3RyZWFtZXIgR0wiIFBSSVZBVEUgT0ZGKQorV0VCS0lU X09QVElPTl9ERUZJTkUoVVNFX0dTVFJFQU1FUl9HTCAiV2hldGhlciB0byBlbmFibGUgc3VwcG9y dCBmb3IgR1N0cmVhbWVyIEdMIiBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNF X0dTVFJFQU1FUl9NUEVHVFMgIldoZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIE1QRUctVFMi IFBSSVZBVEUgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1JFRElSRUNURURfWENPTVBP U0lURV9XSU5ET1cgIldoZXRoZXIgdG8gdXNlIGEgUmVkaXJlY3RlZCBYQ29tcG9zaXRlIFdpbmRv dyBmb3IgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaW4gWDExLiIgUFJJVkFURSBPTikKIApAQCAt MzYzLDYgKzM2Myw5IEBAIGlmIChFTkFCTEVfVklERU8gT1IgRU5BQkxFX1dFQl9BVURJTykKICAg ICAgICAgaWYgKE5PVCBQQ19HU1RSRUFNRVJfR0xfRk9VTkQpCiAgICAgICAgICAgICBtZXNzYWdl KEZBVEFMX0VSUk9SICJHU3RyZWFtZXJHTCBpcyBuZWVkZWQgZm9yIFVTRV9HU1RSRUFNRVJfR0wu IikKICAgICAgICAgZW5kaWYgKCkKKyAgICAgICAgaWYgKFBDX0dTVFJFQU1FUl9WRVJTSU9OIFZF UlNJT05fTEVTUyAiMS4xMCIpCisgICAgICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJHU3Ry ZWFtZXIgMS4xMCBpcyByZXF1aXJlZCB0byB1c2UgVVNFX0dTVFJFQU1FUl9HTC4iKQorICAgICAg ICBlbmRpZiAoKQogICAgIGVuZGlmICgpCiAKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChV U0VfR1NUUkVBTUVSIFRSVUUpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5k ZXggM2YxMDQ1Y2JjM2JhNWMzOTBhNTM2ZDJhYzBhOGRjZDQxZjk0YjE1Zi4uNzhhYTY5ZmE3ZTVk NWRkZjdjZDQ5Yzk1Y2ExNzhjNGZlMGMwMTA0MCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBi L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA2LTE1ICBNaWd1ZWwgR29tZXogIDxt YWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRW5hYmxlIEdTdHJlYW1lciBHTCBi eSBkZWZhdWx0IG9uIHByb2R1Y3Rpb24gYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM0MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgR1N0cmVhbWVyIEdMIGJ5IGRlZmF1bHQgd2hl biB0aGUgR1N0cmVhbWVyIHZlcnNpb24gPj0gMS4xMC4KKworICAgICAgICAqIFNvdXJjZS9jbWFr ZS9PcHRpb25zR1RLLmNtYWtlOgorCiAyMDE3LTA2LTA5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJz ZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBFbmFibGUgRU5DUllQVEVEX01FRElBIGZv ciBidWlsZC13ZWJraXQgYnVpbGRzCg== 313504 2017-06-21 03:43:52 -0700 2017-06-21 05:33:20 -0700 Patch bug-173406-20170621124351.patch text/plain 2100 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDAyZDgz ZmQ2NjE2OTVmNWU5ZTdkYmU1NGQ5ZGU5MWQ5OWZhNjMxYzcuLjJiZjlhYmNmZDAyZjFjYTUwNmE5 OGYzZDUzNWVjN2Y0NzQxOGY5NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC05Miw3ICs5Miw3 IEBAIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9MSUJTRUNSRVQgIldoZXRoZXIgdG8gZW5hYmxl IHRoZSBwZXJzaXN0ZW50IGNyZWRlbnRpYWwKIAogIyBQcml2YXRlIG9wdGlvbnMgc3BlY2lmaWMg dG8gdGhlIEdUSysgcG9ydC4gQ2hhbmdpbmcgdGhlc2Ugb3B0aW9ucyBpcwogIyBjb21wbGV0ZWx5 IHVuc3VwcG9ydGVkLiBUaGV5IGFyZSBpbnRlbmRlZCBmb3IgdXNlIG9ubHkgYnkgV2ViS2l0IGRl dmVsb3BlcnMuCi1XRUJLSVRfT1BUSU9OX0RFRklORShVU0VfR1NUUkVBTUVSX0dMICJXaGV0aGVy IHRvIGVuYWJsZSBzdXBwb3J0IGZvciBHU3RyZWFtZXIgR0wiIFBSSVZBVEUgT0ZGKQorV0VCS0lU X09QVElPTl9ERUZJTkUoVVNFX0dTVFJFQU1FUl9HTCAiV2hldGhlciB0byBlbmFibGUgc3VwcG9y dCBmb3IgR1N0cmVhbWVyIEdMIiBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNF X0dTVFJFQU1FUl9NUEVHVFMgIldoZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIE1QRUctVFMi IFBSSVZBVEUgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1JFRElSRUNURURfWENPTVBP U0lURV9XSU5ET1cgIldoZXRoZXIgdG8gdXNlIGEgUmVkaXJlY3RlZCBYQ29tcG9zaXRlIFdpbmRv dyBmb3IgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaW4gWDExLiIgUFJJVkFURSBPTikKIApAQCAt MzY3LDYgKzM2NywxMCBAQCBpZiAoRU5BQkxFX1ZJREVPIE9SIEVOQUJMRV9XRUJfQVVESU8pCiAg ICAgICAgIGlmIChOT1QgUENfR1NUUkVBTUVSX0dMX0ZPVU5EKQogICAgICAgICAgICAgbWVzc2Fn ZShGQVRBTF9FUlJPUiAiR1N0cmVhbWVyR0wgaXMgbmVlZGVkIGZvciBVU0VfR1NUUkVBTUVSX0dM LiIpCiAgICAgICAgIGVuZGlmICgpCisgICAgICAgIGlmIChQQ19HU1RSRUFNRVJfVkVSU0lPTiBW RVJTSU9OX0xFU1MgIjEuMTAiKQorICAgICAgICAgICAgc2V0KFVTRV9HU1RSRUFNRVJfR0wgT0ZG KQorICAgICAgICAgICAgbWVzc2FnZShTVEFUVVMgIkRpc2FibGluZyBHU1RSRUFNRVJfR0wgYXMg dGhlIEdTdHJlYW1lciB2ZXJzaW9uIGlzIG9sZGVyIHRoYW4gMS4xMC4iKQorICAgICAgICBlbmRp ZiAoKQogICAgIGVuZGlmICgpCiAKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfR1NU UkVBTUVSIFRSVUUpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggOTBk ZjgyZThhN2ZjZTQ2MTI5ZWFiZDViOTI5OTM2M2FjNGM2NTMxNy4uMmEyMDg1NjI0NWYzYTA3NjM5 OWQ5YjlkNTk1M2VmNDlhNGMyNTMxZSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA2LTIxICBNaWd1ZWwgR29tZXogIDxtYWdvbWV6 QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRW5hYmxlIEdTdHJlYW1lciBHTCBieSBkZWZh dWx0IG9uIHByb2R1Y3Rpb24gYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzM0MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBFbmFibGUgR1N0cmVhbWVyIEdMIGJ5IGRlZmF1bHQgd2hlbiB0aGUg R1N0cmVhbWVyIHZlcnNpb24gPj0gMS4xMC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRp b25zR1RLLmNtYWtlOgorCiAyMDE3LTA2LTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBNb3ZlIFdlYkd0a0V4dGVuc2lvbk1hbmFn ZXIgYW5kIFdlYkd0a0luamVjdGVkQnVuZGxlTWFpbiB0byBnbGliIEFQSSBkaXIK