17340 2008-02-13 02:32:44 -0800 WebCore/platform/Timer.cpp fails to build with gcc 4.3 2008-02-13 04:28:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 bero darin oldest_to_newest 70498 0 bero 2008-02-13 02:32:44 -0800 ../../../WebCore/platform/Timer.cpp: In function 'bool WebCore::operator<(const WebCore::TimerHeapElement&, const WebCore::TimerHeapElement&)': ../../../WebCore/platform/Timer.cpp:107: error: 'UINT_MAX' was not declared in this scope make[1]: *** [tmp/Timer.o] Error 1 UINT_MAX is defined in <limits.h>, which isn't being #included. 70499 1 bero 2008-02-13 02:33:28 -0800 This happens to work with older versions of gcc because #include <limits> used to #include <climits> as well. gcc 4.3 trims down on header interdependencies 70500 2 19108 bero 2008-02-13 02:36:02 -0800 Created attachment 19108 fix 70509 3 19108 darin 2008-02-13 04:12:58 -0800 Comment on attachment 19108 fix We would use <limits.h> rather that <climits>. 70510 4 darin 2008-02-13 04:28:27 -0800 Again had to remove tabs and apply the patch by hand. Committed revision 30193. 19108 2008-02-13 02:36:02 -0800 2008-02-13 04:12:58 -0800 fix WebCore-gcc-4.3.patch text/plain 542 bero LS0tIFdlYkNvcmUvQ2hhbmdlTG9nLmFyawkyMDA4LTAyLTEzIDExOjMzOjE0LjAwMDAwMDAwMCAr MDEwMAorKysgV2ViQ29yZS9DaGFuZ2VMb2cJMjAwOC0wMi0xMyAxMTozMzozNS4wMDAwMDAwMDAg KzAxMDAKQEAgLTAsMCArMSw0IEBACisyMDA4LTAyLTEyICBCZXJuaGFyZCBSb3NlbmtyYWVuemVy ICA8YmVyb0BhcmtsaW51eC5vcmc+CisKKwkqIHBsYXRmb3JtL1RpbWVyLmNwcDogTWFrZSBpdCBj b21waWxlIHdpdGggZ2NjIDQuMworCi0tLSBXZWJDb3JlL3BsYXRmb3JtL1RpbWVyLmNwcC5hcmsJ MjAwOC0wMi0xMyAxMTozMTowMy4wMDAwMDAwMDAgKzAxMDAKKysrIFdlYkNvcmUvcGxhdGZvcm0v VGltZXIuY3BwCTIwMDgtMDItMTMgMTE6MzM6MDUuMDAwMDAwMDAwICswMTAwCkBAIC0zMCw2ICsz MCw3IEBACiAjaW5jbHVkZSAiU3lzdGVtVGltZS5oIgogI2luY2x1ZGUgPG1hdGguaD4KICNpbmNs dWRlIDxsaW1pdHM+CisjaW5jbHVkZSA8Y2xpbWl0cz4KICNpbmNsdWRlIDx3dGYvSGFzaFNldC5o PgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAo=