<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>17339</bug_id>
          
          <creation_ts>2008-02-13 01:51:05 -0800</creation_ts>
          <short_desc>JavaScriptCore svn fails to build with gcc 4.3</short_desc>
          <delta_ts>2008-02-13 04:10:42 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Bernhard Rosenkraenzer">bero</reporter>
          <assigned_to name="Darin Adler">darin</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>70494</commentid>
    <comment_count>0</comment_count>
    <who name="Bernhard Rosenkraenzer">bero</who>
    <bug_when>2008-02-13 01:51:05 -0800</bug_when>
    <thetext>JavaScriptCore/kjs/interpreter.cpp complains about using the undefined function getpid() -- getpid() is defined in unistd.h which isn&apos;t being included.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70495</commentid>
    <comment_count>1</comment_count>
      <attachid>19107</attachid>
    <who name="Bernhard Rosenkraenzer">bero</who>
    <bug_when>2008-02-13 01:53:29 -0800</bug_when>
    <thetext>Created attachment 19107
fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70507</commentid>
    <comment_count>2</comment_count>
      <attachid>19107</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-02-13 04:06:34 -0800</bug_when>
    <thetext>Comment on attachment 19107
fix

I don&apos;t think PLATFORM(UNIX) is right for this. We probably want this on Mac OS X too. It should be #if !PLATFORM(WIN_OS), as it is in TCMalloc.cpp, and to match the #if in Interpreter::evaluate.

I&apos;ll take care of this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70508</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-02-13 04:10:42 -0800</bug_when>
    <thetext>I had to get rid of a tab that was in the patch. Also, svn-apply-patch didn&apos;t understand the patch file so I had to do it by hand.

Committed revision 30192.
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>19107</attachid>
            <date>2008-02-13 01:53:29 -0800</date>
            <delta_ts>2008-02-13 04:06:34 -0800</delta_ts>
            <desc>fix</desc>
            <filename>WebKit-compile.patch</filename>
            <type>text/plain</type>
            <size>624</size>
            <attacher name="Bernhard Rosenkraenzer">bero</attacher>
            
              <data encoding="base64">LS0tIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZy5hcmsJMjAwOC0wMi0xMyAxMDo0Njo0Ny4wMDAw
MDAwMDAgKzAxMDAKKysrIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkyMDA4LTAyLTEzIDEwOjQ3
OjU2LjAwMDAwMDAwMCArMDEwMApAQCAtMCwwICsxLDUgQEAKKzIwMDgtMDItMTMgIEJlcm5oYXJk
IFJvc2Vua3JhZW56ZXIgIDxiZXJvQGFya2xpbnV4Lm9yZz4KKworCSoga2pzL2ludGVycHJldGVy
LmNwcDogTWFrZSBpdCBidWlsZCB3aXRoIGdjYyA0LjMgKGdldHBpZCgpIG5lZWRzCisJICA8dW5p
c3RkLmg+KQorCi0tLSBKYXZhU2NyaXB0Q29yZS9ranMvaW50ZXJwcmV0ZXIuY3BwLmFyawkyMDA4
LTAyLTEzIDEwOjM5OjU3LjAwMDAwMDAwMCArMDEwMAorKysgSmF2YVNjcmlwdENvcmUva2pzL2lu
dGVycHJldGVyLmNwcAkyMDA4LTAyLTEzIDEwOjQ2OjIyLjAwMDAwMDAwMCArMDEwMApAQCAtNTEs
NiArNTEsOSBAQAogI2luY2x1ZGUgPG1hdGguaD4KICNpbmNsdWRlIDxzaWduYWwuaD4KICNpbmNs
dWRlIDxzdGRpby5oPgorI2lmIFBMQVRGT1JNKFVOSVgpCisjaW5jbHVkZSA8dW5pc3RkLmg+Cisj
ZW5kaWYKICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogCiBuYW1lc3BhY2UgS0pTIHsK
</data>
<flag name="review"
          id="8348"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>