173385 2017-06-14 14:36:47 -0700 Implement FALLTHROUGH macro for compilers other than Clang 2017-06-15 09:14:28 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen benjamin buildbot cdumez cmarcelo darin dbates joepeck mcatanzaro oldest_to_newest 1319331 0 annulen 2017-06-14 14:36:47 -0700 FALLTHROUGH should be able to use [[gnu::fallthrough]] attribute of GCC, and [[fallthrough]] from C++17, whichever is available. 1319332 1 312921 annulen 2017-06-14 14:39:11 -0700 Created attachment 312921 Patch 1319333 2 buildbot 2017-06-14 14:40:22 -0700 Attachment 312921 did not pass style-queue: ERROR: Source/WTF/wtf/Compiler.h:208: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WTF/wtf/Compiler.h:212: Extra space before [. [whitespace/brackets] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1319435 3 312921 mcatanzaro 2017-06-14 20:28:11 -0700 Comment on attachment 312921 Patch All the EWS bots are red, fix it please: In file included from ../../Source/WTF/wtf/Platform.h:32:0, from ../../Source/WTF/wtf/ExportMacros.h:32, from ../../Source/JavaScriptCore/runtime/JSExportMacros.h:32, from ../../Source/JavaScriptCore/config.h:26, from /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:27: ../../Source/WTF/wtf/Compiler.h:209:32: error: missing ')' after "__has_attribute" #elif __has_cpp_attribute(clang::fallthrough) ^ ../../Source/WTF/wtf/Compiler.h:209:33: error: ':' without preceding '?' #elif __has_cpp_attribute(clang::fallthrough) ^ ../../Source/WTF/wtf/Compiler.h:211:30: error: missing ')' after "__has_attribute" #elif __has_cpp_attribute(gnu::fallthrough) ^ ../../Source/WTF/wtf/Compiler.h:211:31: error: ':' without preceding '?' #elif __has_cpp_attribute(gnu::fallthrough) ^ 1319501 4 312960 annulen 2017-06-15 01:48:48 -0700 Created attachment 312960 Patch 1319503 5 buildbot 2017-06-15 01:54:20 -0700 Attachment 312960 did not pass style-queue: ERROR: Source/WTF/wtf/Compiler.h:208: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WTF/wtf/Compiler.h:212: Extra space before [. [whitespace/brackets] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1319591 6 312960 annulen 2017-06-15 09:14:23 -0700 Comment on attachment 312960 Patch Clearing flags on attachment: 312960 Committed r218333: <http://trac.webkit.org/changeset/218333> 1319592 7 annulen 2017-06-15 09:14:28 -0700 All reviewed patches have been landed. Closing bug. 312921 2017-06-14 14:39:11 -0700 2017-06-15 01:48:44 -0700 Patch bug-173385-20170615003910.patch text/plain 2278 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVlNDJjMTNhZjlmMjQ0ZTc4Yzk1YjIz MmU2NGYyMWY3MmIzZTM0ZjMuLjFkM2UzOGEyZWRmOTg0ZDFhMmIyNDhlNWI0ODEyMzhiMjNiYTY2 ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDYtMTQgIEtvbnN0YW50aW4gVG9rYXJldiAg PGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIEltcGxlbWVudCBGQUxMVEhST1VHSCBtYWNy byBmb3IgY29tcGlsZXJzIG90aGVyIHRoYW4gQ2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzM4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZBTExUSFJPVUdIIHNob3VsZCBiZSBhYmxlIHRvIHVz ZSBbW2dudTo6ZmFsbHRocm91Z2hdXSBhdHRyaWJ1dGUgb2YKKyAgICAgICAgR0NDLCBhbmQgW1tm YWxsdGhyb3VnaF1dIGZyb20gQysrMTcsIHdoaWNoZXZlciBpcyBhdmFpbGFibGUuCisKKyAgICAg ICAgKiB3dGYvQ29tcGlsZXIuaDoKKwogMjAxNy0wNi0xNCAgTmFlbCBPdWVkcmFvZ28gIDxuYWVs Lm91ZWRyYW9nb0BjcmYuY2Fub24uZnI+CiAKICAgICAgICAgTWVkaWFTb3VyY2UgZHVyYXRpb24g YXR0cmlidXRlIHNob3VsZCBub3QgYmUgZXF1YWwgdG8gSW5maW5pdHkgd2hlbiBzZXQgdG8gYSB2 YWx1ZSBncmVhdGVyIHRoYW4gMl42NApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ29tcGls ZXIuaCBiL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKaW5kZXggOTcyMDc1ZWJmZWI1ZDk0YmUz MmJkZGE2MmU3Yjc0MjY1N2RjMTgyZi4uODNkNTgzYmI5YmYxY2ZiY2Q0MDM3YzRmYTFlMzk3NWMx OTJhZmFjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9Db21waWxlci5oCkBAIC02Nyw3ICs2Nyw2IEBACiAjZGVmaW5lIFdURl9DT01Q SUxFUl9TVVBQT1JUU19CTE9DS1MgQ09NUElMRVJfSEFTX0NMQU5HX0ZFQVRVUkUoYmxvY2tzKQog I2RlZmluZSBXVEZfQ09NUElMRVJfU1VQUE9SVFNfQ19TVEFUSUNfQVNTRVJUIENPTVBJTEVSX0hB U19DTEFOR19GRUFUVVJFKGNfc3RhdGljX2Fzc2VydCkKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NV UFBPUlRTX0NYWF9SRUZFUkVOQ0VfUVVBTElGSUVEX0ZVTkNUSU9OUyBDT01QSUxFUl9IQVNfQ0xB TkdfRkVBVFVSRShjeHhfcmVmZXJlbmNlX3F1YWxpZmllZF9mdW5jdGlvbnMpCi0jZGVmaW5lIFdU Rl9DT01QSUxFUl9TVVBQT1JUU19GQUxMVEhST1VHSF9XQVJOSU5HUyBDT01QSUxFUl9IQVNfQ0xB TkdfRkVBVFVSRShjeHhfYXR0cmlidXRlcykgJiYgX19oYXNfd2FybmluZygiLVdpbXBsaWNpdC1m YWxsdGhyb3VnaCIpCiAjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfRVhDRVBUSU9O UyBDT01QSUxFUl9IQVNfQ0xBTkdfRkVBVFVSRShjeHhfZXhjZXB0aW9ucykKICNkZWZpbmUgV1RG X0NPTVBJTEVSX1NVUFBPUlRTX0JVSUxUSU5fSVNfVFJJVklBTExZX0NPUFlBQkxFIENPTVBJTEVS X0hBU19DTEFOR19GRUFUVVJFKGlzX3RyaXZpYWxseV9jb3B5YWJsZSkKIApAQCAtMjAzLDEwICsy MDIsMTggQEAKIAogLyogRkFMTFRIUk9VR0ggKi8KIAotI2lmICFkZWZpbmVkKEZBTExUSFJPVUdI KSAmJiBDT01QSUxFUl9TVVBQT1JUUyhGQUxMVEhST1VHSF9XQVJOSU5HUykgJiYgQ09NUElMRVIo Q0xBTkcpCisjaWYgIWRlZmluZWQoRkFMTFRIUk9VR0gpICYmIGRlZmluZWQoX19oYXNfY3BwX2F0 dHJpYnV0ZSkKKworI2lmIF9faGFzX2NwcF9hdHRyaWJ1dGUoZmFsbHRocm91Z2gpCisjZGVmaW5l IEZBTExUSFJPVUdIIFtbZmFsbHRocm91Z2hdXQorI2VsaWYgX19oYXNfY3BwX2F0dHJpYnV0ZShj bGFuZzo6ZmFsbHRocm91Z2gpCiAjZGVmaW5lIEZBTExUSFJPVUdIIFtbY2xhbmc6OmZhbGx0aHJv dWdoXV0KKyNlbGlmIF9faGFzX2NwcF9hdHRyaWJ1dGUoZ251OjpmYWxsdGhyb3VnaCkKKyNkZWZp bmUgRkFMTFRIUk9VR0ggW1tnbnU6OmZhbGx0aHJvdWdoXV0KICNlbmRpZgogCisjZW5kaWYgLy8g IWRlZmluZWQoRkFMTFRIUk9VR0gpICYmIGRlZmluZWQoX19oYXNfY3BwX2F0dHJpYnV0ZSkKKwog I2lmICFkZWZpbmVkKEZBTExUSFJPVUdIKQogI2RlZmluZSBGQUxMVEhST1VHSAogI2VuZGlmCg== 312960 2017-06-15 01:48:48 -0700 2017-06-15 09:14:23 -0700 Patch bug-173385-20170615114847.patch text/plain 2326 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVlNDJjMTNhZjlmMjQ0ZTc4Yzk1YjIz MmU2NGYyMWY3MmIzZTM0ZjMuLjFkM2UzOGEyZWRmOTg0ZDFhMmIyNDhlNWI0ODEyMzhiMjNiYTY2 ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDYtMTQgIEtvbnN0YW50aW4gVG9rYXJldiAg PGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIEltcGxlbWVudCBGQUxMVEhST1VHSCBtYWNy byBmb3IgY29tcGlsZXJzIG90aGVyIHRoYW4gQ2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzM4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZBTExUSFJPVUdIIHNob3VsZCBiZSBhYmxlIHRvIHVz ZSBbW2dudTo6ZmFsbHRocm91Z2hdXSBhdHRyaWJ1dGUgb2YKKyAgICAgICAgR0NDLCBhbmQgW1tm YWxsdGhyb3VnaF1dIGZyb20gQysrMTcsIHdoaWNoZXZlciBpcyBhdmFpbGFibGUuCisKKyAgICAg ICAgKiB3dGYvQ29tcGlsZXIuaDoKKwogMjAxNy0wNi0xNCAgTmFlbCBPdWVkcmFvZ28gIDxuYWVs Lm91ZWRyYW9nb0BjcmYuY2Fub24uZnI+CiAKICAgICAgICAgTWVkaWFTb3VyY2UgZHVyYXRpb24g YXR0cmlidXRlIHNob3VsZCBub3QgYmUgZXF1YWwgdG8gSW5maW5pdHkgd2hlbiBzZXQgdG8gYSB2 YWx1ZSBncmVhdGVyIHRoYW4gMl42NApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ29tcGls ZXIuaCBiL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKaW5kZXggOTcyMDc1ZWJmZWI1ZDk0YmUz MmJkZGE2MmU3Yjc0MjY1N2RjMTgyZi4uY2I2Zjg5YWYzY2YzMTRiMDdjNDA3MjljM2I2Mjg0MWZk YmU4OWNjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9Db21waWxlci5oCkBAIC02Nyw3ICs2Nyw2IEBACiAjZGVmaW5lIFdURl9DT01Q SUxFUl9TVVBQT1JUU19CTE9DS1MgQ09NUElMRVJfSEFTX0NMQU5HX0ZFQVRVUkUoYmxvY2tzKQog I2RlZmluZSBXVEZfQ09NUElMRVJfU1VQUE9SVFNfQ19TVEFUSUNfQVNTRVJUIENPTVBJTEVSX0hB U19DTEFOR19GRUFUVVJFKGNfc3RhdGljX2Fzc2VydCkKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NV UFBPUlRTX0NYWF9SRUZFUkVOQ0VfUVVBTElGSUVEX0ZVTkNUSU9OUyBDT01QSUxFUl9IQVNfQ0xB TkdfRkVBVFVSRShjeHhfcmVmZXJlbmNlX3F1YWxpZmllZF9mdW5jdGlvbnMpCi0jZGVmaW5lIFdU Rl9DT01QSUxFUl9TVVBQT1JUU19GQUxMVEhST1VHSF9XQVJOSU5HUyBDT01QSUxFUl9IQVNfQ0xB TkdfRkVBVFVSRShjeHhfYXR0cmlidXRlcykgJiYgX19oYXNfd2FybmluZygiLVdpbXBsaWNpdC1m YWxsdGhyb3VnaCIpCiAjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfRVhDRVBUSU9O UyBDT01QSUxFUl9IQVNfQ0xBTkdfRkVBVFVSRShjeHhfZXhjZXB0aW9ucykKICNkZWZpbmUgV1RG X0NPTVBJTEVSX1NVUFBPUlRTX0JVSUxUSU5fSVNfVFJJVklBTExZX0NPUFlBQkxFIENPTVBJTEVS X0hBU19DTEFOR19GRUFUVVJFKGlzX3RyaXZpYWxseV9jb3B5YWJsZSkKIApAQCAtMjAzLDEwICsy MDIsMTggQEAKIAogLyogRkFMTFRIUk9VR0ggKi8KIAotI2lmICFkZWZpbmVkKEZBTExUSFJPVUdI KSAmJiBDT01QSUxFUl9TVVBQT1JUUyhGQUxMVEhST1VHSF9XQVJOSU5HUykgJiYgQ09NUElMRVIo Q0xBTkcpCisjaWYgIWRlZmluZWQoRkFMTFRIUk9VR0gpICYmIGRlZmluZWQoX19jcGx1c3BsdXMp ICYmIGRlZmluZWQoX19oYXNfY3BwX2F0dHJpYnV0ZSkKKworI2lmIF9faGFzX2NwcF9hdHRyaWJ1 dGUoZmFsbHRocm91Z2gpCisjZGVmaW5lIEZBTExUSFJPVUdIIFtbZmFsbHRocm91Z2hdXQorI2Vs aWYgX19oYXNfY3BwX2F0dHJpYnV0ZShjbGFuZzo6ZmFsbHRocm91Z2gpCiAjZGVmaW5lIEZBTExU SFJPVUdIIFtbY2xhbmc6OmZhbGx0aHJvdWdoXV0KKyNlbGlmIF9faGFzX2NwcF9hdHRyaWJ1dGUo Z251OjpmYWxsdGhyb3VnaCkKKyNkZWZpbmUgRkFMTFRIUk9VR0ggW1tnbnU6OmZhbGx0aHJvdWdo XV0KICNlbmRpZgogCisjZW5kaWYgLy8gIWRlZmluZWQoRkFMTFRIUk9VR0gpICYmIGRlZmluZWQo X19jcGx1c3BsdXMpICYmIGRlZmluZWQoX19oYXNfY3BwX2F0dHJpYnV0ZSkKKwogI2lmICFkZWZp bmVkKEZBTExUSFJPVUdIKQogI2RlZmluZSBGQUxMVEhST1VHSAogI2VuZGlmCg==