173378 2017-06-14 12:33:24 -0700 [WK2][iOS] Remove dead-code "import "removed-dev-nodes.sb” from sandboxes 2017-06-14 14:06:44 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham ap commit-queue webkit-bug-importer oldest_to_newest 1319276 0 bfulgham 2017-06-14 12:33:24 -0700 For historical reasons, our sandboxes imported "removed-dev-nodes.sb”, which no longer does anything. Let's get rid of this useless import. 1319277 1 webkit-bug-importer 2017-06-14 12:33:41 -0700 <rdar://problem/32773230> 1319286 2 bfulgham 2017-06-14 12:38:32 -0700 Note: instruments-support is also a no-op in 2017, so let's get rid of it, too. 1319289 3 312914 bfulgham 2017-06-14 12:49:06 -0700 Created attachment 312914 Patch 1319300 4 312914 ap 2017-06-14 13:06:40 -0700 Comment on attachment 312914 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312914&action=review > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:-31 > -(import "removed-dev-nodes.sb") Do we need any of those on iOS 10 still? 1319303 5 bfulgham 2017-06-14 13:09:32 -0700 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 312914 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312914&action=review > > > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:-31 > > -(import "removed-dev-nodes.sb") > > Do we need any of those on iOS 10 still? No -- they haven't been needed since before iOS 10. 1319314 6 312914 ap 2017-06-14 13:33:36 -0700 Comment on attachment 312914 Patch Okay. So I take it "instruments-support is also a no-op in 2017" should read "instruments-support is also a no-op in 2016". I'm curious about what change to make instruments-support unnecessary. 1319316 7 ap 2017-06-14 13:45:12 -0700 I'm curious about what change *made* instruments-support unnecessary. 1319324 8 bfulgham 2017-06-14 13:51:42 -0700 (In reply to Alexey Proskuryakov from comment #7) > I'm curious about what change *made* instruments-support unnecessary. They migrated the logic previously in "instruments-support" to the "debugging-support", function. Since that is triggered by "common-rules", which gets invoked when you import "common.sb", there was no need for a separate function. 1319325 9 312914 commit-queue 2017-06-14 14:06:43 -0700 Comment on attachment 312914 Patch Clearing flags on attachment: 312914 Committed r218292: <http://trac.webkit.org/changeset/218292> 1319326 10 commit-queue 2017-06-14 14:06:44 -0700 All reviewed patches have been landed. Closing bug. 312914 2017-06-14 12:49:06 -0700 2017-06-14 14:06:43 -0700 Patch bug-173378-20170614124906.patch text/plain 3088 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODI4NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA2LTE0ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW2lPU10gUmVtb3Zl IGRlYWQtY29kZSAiaW1wb3J0ICJyZW1vdmVkLWRldi1ub2Rlcy5zYuKAnSBmcm9tIHNhbmRib3hl cyAoMTczMzc4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTczMzc4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjc3MzIzMD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbiB1cCB0aGUgc2FuZGJv eGVzIHRvIHJlbW92ZSBhIGNvdXBsZSBvZiBkZWFkIGZ1bmN0aW9ucyAoYW5kIGltcG9ydHMpOgor ICAgICAgICAxLiBSZW1vdmUgdGhlIGltcG9ydCAicmVtb3ZlZC1kZXYtbm9kZXMuc2IiIGZyb20g dGhlIHNhbmRib3gsIHNpbmNlIHRoaXMgZmlsZSBpcyBub3cgZW1wdHkuCisgICAgICAgIDIuIEFs c28gcmVtb3ZlIHRoZSBjYWxsIHRvICJpbnN0cnVtZW50cy1zdXBwb3J0IiBhcyB0aGlzIGlzIGEg bm8tb3AgZnVuY3Rpb24gaW4gbW9kZXJuIGlPUy4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuRGF0YWJhc2VzLnNiOgorICAgICAgICAq IFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2lu Zy5zYjoKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUu V2ViS2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMTctMDYtMTQgIEpvbmF0aGFuIEJlZGFyZCAgPGpi ZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIENvbmZpZ3VyZSBzY3JlZW4gc2NhbGUgZm9yIHJ1 bm5pbmcgbGF5b3V0IHRlc3RzIG9uIHBsdXMgZGV2aWNlcwpJbmRleDogU291cmNlL1dlYktpdDIv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5EYXRhYmFzZXMu c2IKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxl cy9pb3MvY29tLmFwcGxlLldlYktpdC5EYXRhYmFzZXMuc2IJKHJldmlzaW9uIDIxODIyMCkKKysr IFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuRGF0YWJhc2VzLnNiCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw3ICsyOCw2IEBACiAoZGVu eSBtYWNoLWxvb2t1cCAoeHBjLXNlcnZpY2UtbmFtZS1wcmVmaXggIiIpKQogCiAoaW1wb3J0ICJj b21tb24uc2IiKQotKGltcG9ydCAicmVtb3ZlZC1kZXYtbm9kZXMuc2IiKQogCiAoYWxsb3cgZmls ZS1yZWFkKiBmaWxlLXdyaXRlKiAoZXh0ZW5zaW9uICJjb20uYXBwbGUuYXBwLXNhbmRib3gucmVh ZC13cml0ZSIpKQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9SZXNvdXJjZXMvU2FuZGJveFByb2Zp bGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2IKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5OZXR3b3JraW5nLnNiCShyZXZpc2lvbiAyMTgyMjApCisrKyBTb3VyY2UvV2ViS2l0Mi9SZXNv dXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2IJ KHdvcmtpbmcgY29weSkKQEAgLTI4LDcgKzI4LDYgQEAKIChkZW55IG1hY2gtbG9va3VwICh4cGMt c2VydmljZS1uYW1lLXByZWZpeCAiIikpCiAKIChpbXBvcnQgImNvbW1vbi5zYiIpCi0oaW1wb3J0 ICJyZW1vdmVkLWRldi1ub2Rlcy5zYiIpCiAKIChkZW55IHN5c2N0bCopCiAoYWxsb3cgc3lzY3Rs LXJlYWQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9z L2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQuc2IJKHJldmlzaW9uIDIxODIyMCkKKysrIFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9T YW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgkod29ya2lu ZyBjb3B5KQpAQCAtMjgsNyArMjgsNiBAQAogKGRlbnkgbWFjaC1sb29rdXAgKHhwYy1zZXJ2aWNl LW5hbWUtcHJlZml4ICIiKSkKIAogKGltcG9ydCAiVUlLaXQtYXBwcy5zYiIpCi0oaW1wb3J0ICJy ZW1vdmVkLWRldi1ub2Rlcy5zYiIpCiAKICh1aWtpdC1hcHAgJ3dpdGgtb3BlbmdsICd3aXRoLWxv Y2F0aW9uLXNlcnZpY2VzKQogCkBAIC03Myw5ICs3Miw2IEBACiAgICAgKGV4dGVuc2lvbiAiY29t LmFwcGxlLmFwcC1zYW5kYm94LnJlYWQtd3JpdGUiKQogICAgIChleHRlbnNpb24tY2xhc3MgImNv bS5hcHBsZS5uc3VybHN0b3JhZ2UuZXh0ZW5zaW9uLWNhY2hlIikpKQogCi07OyBBbGxvdyB0aGUg T3BlbkdMIFByb2ZpbGVyIHRvIGF0dGFjaC4KLShpbnN0cnVtZW50cy1zdXBwb3J0KSAgICA7IEZv ciA8cmRhcjovL3Byb2JsZW0vNzkzMTk1Mj4KLQogOzsgTWVkaWFBY2Nlc3NpYmlsaXR5CiAobW9i aWxlLXByZWZlcmVuY2VzLXJlYWQgImNvbS5hcHBsZS5tZWRpYWFjY2Vzc2liaWxpdHkiKQogKG1v YmlsZS1wcmVmZXJlbmNlcy1yZWFkLXdyaXRlICJjb20uYXBwbGUubWVkaWFhY2Nlc3NpYmlsaXR5 LnB1YmxpYyIpCg==