173374 2017-06-14 11:05:09 -0700 WKContentViewEditingActions API test always fails 2017-06-14 11:22:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton jlewis3 ryanhaddad wenson_hsieh oldest_to_newest 1319226 0 thorton 2017-06-14 11:05:09 -0700 WKContentViewEditingActions API test always fails 1319228 1 312907 thorton 2017-06-14 11:05:46 -0700 Created attachment 312907 Patch 1319243 2 312907 wenson_hsieh 2017-06-14 11:12:50 -0700 Comment on attachment 312907 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312907&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:70 > + if ([[[UIPasteboard generalPasteboard] string] isEqualToString:@"Hello world"]) Nit - could we make this always set done = true here, and then check that [[[UIPasteboard generalPasteboard] string] isEqualToString:@"Hello world"] after TestWebKitAPI::Util::run(&done) using EXPECT_WK_STREQ? This way, if the strings don't match, it'll print out the expected vs. observed values instead of timing out. 1319250 3 thorton 2017-06-14 11:20:07 -0700 Seems reasonable! 1319251 4 thorton 2017-06-14 11:22:53 -0700 https://trac.webkit.org/changeset/218276/webkit 312907 2017-06-14 11:05:46 -0700 2017-06-14 11:12:50 -0700 Patch bug-173374-20170614110545.patch text/plain 2895 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWNiZWM3NzM4YmM1NmRkN2I0ZDFiMGQ0YzI3MTA0YjE4 MGRhMGNhYy4uNzhmYThhZDA0MDI1ZTljNGNkODczMDczYjJkNDY2NWY4ODU4ZGQzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE3LTA2LTE0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIFdLQ29udGVudFZpZXdFZGl0aW5nQWN0aW9ucyBBUEkgdGVzdCBhbHdheXMgZmFp bHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzM3 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvV0tDb250ZW50Vmlld0VkaXRpbmdBY3Rpb25z Lm1tOgorICAgICAgICAoVEVTVCk6CisgICAgICAgIHNlbGVjdEFsbCBpc24ndCB3b3JraW5nLCBi ZWNhdXNlIGNhblBlcmZvcm1BY3Rpb24gZm9yIHNlbGVjdEFsbCByZXR1cm5zIE5PCisgICAgICAg IGlmIHNlbGVjdGlvbklzTm9uZSAod2hpY2ggaXMgdHJ1ZSBpbiB0aGUgbm9uLWNvbnRlbnRlZGl0 YWJsZSBjYXNlKS4KKyAgICAgICAgSW5zdGVhZCwgbWFrZSB1c2Ugb2YgcjIxODE4MCdzIHRlc3Qg cGFnZSwgd2hpY2gga25vd3MgaG93IHRvIHNlbGVjdCBpdHNlbGYuCisgICAgICAgIEFsc28sIHJl c2V0IHRoZSBwYXN0ZWJvYXJkIGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIHRlc3QgdG8gcmVkdWNl IGNvbmZ1c2lvbgorICAgICAgICAoSSBsYW5kZWQgdGhlIHRlc3QgYnJva2VuIGJlY2F1c2UgbXkg c2ltdWxhdG9yIGhhZCB0aGUgY29ycmVjdCB0ZXh0CisgICAgICAgIHN0dWNrIGluIGl0cyBwYXN0 ZWJvYXJkKS4KKwogMjAxNy0wNi0xMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQmxvYiBkb3dubG9hZCBkb2Vzbid0IHdvcmsKZGlm ZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1dLQ29udGVu dFZpZXdFZGl0aW5nQWN0aW9ucy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 MkNvY29hL1dLQ29udGVudFZpZXdFZGl0aW5nQWN0aW9ucy5tbQppbmRleCAzNDI0OTQ1ZmM5MGY0 NzM5ZDY5OTUwMTRkODBjNWY1MmFiZWVlYjJhLi4zYTA2YzkzODk1NTRlYjYwNTEyNjQ3MmUxYzky Y2UyNjk0MmYyMGU3IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dDJDb2NvYS9XS0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KKysrIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvV0tDb250ZW50Vmlld0VkaXRpbmdBY3Rpb25zLm1t CkBAIC01MCwyNSArNTAsMjkgQEAgc3RhdGljIFVJVmlldyAqcmVjdXJzaXZlRmluZFdLQ29udGVu dFZpZXcoVUlWaWV3ICp2aWV3KQogCiBURVNUKFdlYktpdDIsIFdLQ29udGVudFZpZXdFZGl0aW5n QWN0aW9ucykKIHsKKyAgICBbVUlQYXN0ZWJvYXJkIGdlbmVyYWxQYXN0ZWJvYXJkXS5pdGVtcyA9 IEBbXTsKKwogICAgIFJldGFpblB0cjxUZXN0V0tXZWJWaWV3PiB3ZWJWaWV3ID0gYWRvcHROUyhb W1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAs IDYwMCldKTsKIAotICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpA InNpbXBsZSJdOworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpA InJpY2gtYW5kLXBsYWluLXRleHQiXTsKKworICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGlu Z0phdmFTY3JpcHQ6QCJzZWxlY3RQbGFpblRleHQoKSJdOwogCiAgICAgVUlWaWV3ICpjb250ZW50 VmlldyA9IHJlY3Vyc2l2ZUZpbmRXS0NvbnRlbnRWaWV3KHdlYlZpZXcuZ2V0KCkpOwogCi0gICAg aWYgKFtjb250ZW50VmlldyBjYW5QZXJmb3JtQWN0aW9uOkBzZWxlY3RvcihzZWxlY3RBbGw6KSB3 aXRoU2VuZGVyOm5pbF0pCi0gICAgICAgIFtjb250ZW50VmlldyBzZWxlY3RBbGw6bmlsXTsKKyAg ICBfX2Jsb2NrIGJvb2wgZG9uZSA9IGZhbHNlOworCiAgICAgW3dlYlZpZXcgX2RvQWZ0ZXJOZXh0 UHJlc2VudGF0aW9uVXBkYXRlOl4gewogICAgICAgICBpZiAoW2NvbnRlbnRWaWV3IGNhblBlcmZv cm1BY3Rpb246QHNlbGVjdG9yKGNvcHk6KSB3aXRoU2VuZGVyOm5pbF0pCiAgICAgICAgICAgICBb Y29udGVudFZpZXcgY29weTpuaWxdOworCisgICAgICAgIFt3ZWJWaWV3IF9kb0FmdGVyTmV4dFBy ZXNlbnRhdGlvblVwZGF0ZTpeIHsKKyAgICAgICAgICAgIGlmIChbW1tVSVBhc3RlYm9hcmQgZ2Vu ZXJhbFBhc3RlYm9hcmRdIHN0cmluZ10gaXNFcXVhbFRvU3RyaW5nOkAiSGVsbG8gd29ybGQiXSkK KyAgICAgICAgICAgICAgICBkb25lID0gdHJ1ZTsKKyAgICAgICAgfV07CiAgICAgfV07CiAKLSAg ICB3aGlsZSAoMSkgewotICAgICAgICBbW05TUnVuTG9vcCBjdXJyZW50UnVuTG9vcF0gcnVuTW9k ZTpOU0RlZmF1bHRSdW5Mb29wTW9kZSBiZWZvcmVEYXRlOltOU0RhdGUgZGlzdGFudFBhc3RdXTsK LSAgICAgICAgaWYgKFtbW1VJUGFzdGVib2FyZCBnZW5lcmFsUGFzdGVib2FyZF0gc3RyaW5nXSBp c0VxdWFsVG9TdHJpbmc6QCJTaW1wbGUgSFRNTCBmaWxlLiJdKQotICAgICAgICAgICAgYnJlYWs7 Ci0gICAgICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNsZWVwKDAuMDEpOwotICAgIH0KKyAgICBU ZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOwogfQogCiAjZW5kaWYK