173361 2017-06-14 03:55:49 -0700 [Win] DRT should not use disk cache. 2018-07-31 12:45:49 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 173399 1 pvollan pvollan achristensen basuke bfulgham darin lforschler oldest_to_newest 1319089 0 pvollan 2017-06-14 03:55:49 -0700 Like on macOS/iOS, DRT on Windows should only use memory cache. 1319090 1 312883 pvollan 2017-06-14 03:57:41 -0700 Created attachment 312883 Patch 1319113 2 312883 darin 2017-06-14 07:37:20 -0700 Comment on attachment 312883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312883&action=review > Tools/DumpRenderTree/win/DumpRenderTree.cpp:1469 > + RetainPtr<CFURLCacheRef> newCache = adoptCF(CFURLCacheCreate(kCFAllocatorDefault, 1024 * 1024, 0, nullptr)); I suggest using auto here, or just putting this inside the function call. 1319117 3 pvollan 2017-06-14 07:52:14 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 312883 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312883&action=review > > > Tools/DumpRenderTree/win/DumpRenderTree.cpp:1469 > > + RetainPtr<CFURLCacheRef> newCache = adoptCF(CFURLCacheCreate(kCFAllocatorDefault, 1024 * 1024, 0, nullptr)); > > I suggest using auto here, or just putting this inside the function call. Thanks for reviewing! I will update the patch before landing. 1319120 4 pvollan 2017-06-14 07:58:28 -0700 Committed r218255: <https://trac.webkit.org/changeset/218255/webkit> 1445576 5 basuke 2018-07-26 15:44:56 -0700 Per Arne, What is the source of this decision? We have an cache implementation in WebKitLegacy and wanna test it. So I am very curious what causes this patch. 1446565 6 pvollan 2018-07-31 09:26:43 -0700 (In reply to Basuke Suzuki from comment #5) > Per Arne, > What is the source of this decision? We have an cache implementation in > WebKitLegacy and wanna test it. So I am very curious what causes this patch. I believe we turned off the disk cache because macOS turned it off. You can probably enable it for WinCairo to test the cache implementation. 1446642 7 basuke 2018-07-31 12:45:49 -0700 (In reply to Per Arne Vollan from comment #6) > (In reply to Basuke Suzuki from comment #5) > > Per Arne, > > What is the source of this decision? We have an cache implementation in > > WebKitLegacy and wanna test it. So I am very curious what causes this patch. Can you check AppleWin support disk cache or not? Does CFNetwork itself has disk cache feature? I guess that's why there's no need to test'em explicitly with DRT. > I believe we turned off the disk cache because macOS turned it off. You can > probably enable it for WinCairo to test the cache implementation. Yes, we are thinking about that. The code was old and we don't currently maintain them well, but without test, we can't touch them. 312883 2017-06-14 03:57:41 -0700 2017-06-14 07:37:20 -0700 Patch bug-173361-20170614035740.patch text/plain 2118 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxODI1MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTA2LTE0ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBEUlQgc2hvdWxkIG5vdCB1c2UgZGlzayBjYWNoZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzM2MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExpa2Ugb24gbWFjT1Mv aU9TLCBEUlQgb24gV2luZG93cyBzaG91bGQgb25seSB1c2UgbWVtb3J5IGNhY2hlLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHNl dERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzRm9yVGVzdGluZyk6CisgICAgICAgIChwcmVwYXJl Q29uc2lzdGVudFRlc3RpbmdFbnZpcm9ubWVudCk6CisKIDIwMTctMDYtMTQgIE5hZWwgT3VlZHJh b2dvICA8bmFlbC5vdWVkcmFvZ29AY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIE1lZGlhU291cmNl IGR1cmF0aW9uIGF0dHJpYnV0ZSBzaG91bGQgbm90IGJlIGVxdWFsIHRvIEluZmluaXR5IHdoZW4g c2V0IHRvIGEgdmFsdWUgZ3JlYXRlciB0aGFuIDJeNjQKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJU cmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRl clRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkocmV2aXNpb24gMjE4MjQzKQorKysgVG9vbHMv RHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAt OTMwLDkgKzkzMCw2IEBAIHN0YXRpYyB2b2lkIHNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWUK ICAgICBDRlByZWZlcmVuY2VzU2V0QXBwVmFsdWUoV2ViRGF0YWJhc2VEaXJlY3RvcnlEZWZhdWx0 c0tleSwgV2ViQ29yZTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KGxpYnJhcnlQYXRoLCAiRGF0 YWJhc2VzIikuY3JlYXRlQ0ZTdHJpbmcoKS5nZXQoKSwgYXBwSWQuZ2V0KCkpOwogICAgIENGUHJl ZmVyZW5jZXNTZXRBcHBWYWx1ZShXZWJTdG9yYWdlRGlyZWN0b3J5RGVmYXVsdHNLZXksIFdlYkNv cmU6OnBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChsaWJyYXJ5UGF0aCwgIkxvY2FsU3RvcmFnZSIp LmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCksIGFwcElkLmdldCgpKTsKICAgICBDRlByZWZlcmVuY2Vz U2V0QXBwVmFsdWUoV2ViS2l0TG9jYWxDYWNoZURlZmF1bHRzS2V5LCBXZWJDb3JlOjpwYXRoQnlB cHBlbmRpbmdDb21wb25lbnQobGlicmFyeVBhdGgsICJMb2NhbENhY2hlIikuY3JlYXRlQ0ZTdHJp bmcoKS5nZXQoKSwgYXBwSWQuZ2V0KCkpOwotCi0gICAgLy8gQ3JlYXRlIHNlcGFyYXRlIGNhY2hl IGZvciBlYWNoIERSVCBpbnN0YW5jZQotICAgIHNldENhY2hlRm9sZGVyKCk7CiAjZW5kaWYKIH0K IApAQCAtMTQ2OSw2ICsxNDY2LDkgQEAgc3RhdGljIHZvaWQgcHJlcGFyZUNvbnNpc3RlbnRUZXN0 aW5nRW52aQogICAgIEFTU0VSVChzdGFuZGFyZFByZWZlcmVuY2VzUHJpdmF0ZSk7CiAgICAgc3Rh bmRhcmRQcmVmZXJlbmNlcy0+c2V0QXV0b3NhdmVzKEZBTFNFKTsKIAorICAgIFJldGFpblB0cjxD RlVSTENhY2hlUmVmPiBuZXdDYWNoZSA9IGFkb3B0Q0YoQ0ZVUkxDYWNoZUNyZWF0ZShrQ0ZBbGxv Y2F0b3JEZWZhdWx0LCAxMDI0ICogMTAyNCwgMCwgbnVsbHB0cikpOworICAgIENGVVJMQ2FjaGVT ZXRTaGFyZWRVUkxDYWNoZShuZXdDYWNoZS5nZXQoKSk7CisKICAgICBDT01QdHI8SVdlYlByZWZl cmVuY2VzUHJpdmF0ZTQ+IHByZWZzUHJpdmF0ZTQoUXVlcnksIHN0YW5kYXJkUHJlZmVyZW5jZXMp OwogICAgIHByZWZzUHJpdmF0ZTQtPnN3aXRjaE5ldHdvcmtMb2FkZXJUb05ld1Rlc3RpbmdTZXNz aW9uKCk7CiAK