173356 2017-06-14 01:59:13 -0700 [GTK] integer expression expected if running Tools/gtk/install-dependencies 2017-06-14 21:01:20 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela tpopela bugs-noreply mcatanzaro oldest_to_newest 1319058 0 tpopela 2017-06-14 01:59:13 -0700 If the Tools/gtk/install-dependencies script is ran on the unsupported platform (anything with yum like CentOS 7, RHEL 7) there is a warning about wrong syntax: Tools/gtk/install-dependencies: line 40: [: Linux: integer expression expected as the "eq" operand is expected an integer and not a string comparison. 1319060 1 312870 tpopela 2017-06-14 02:01:27 -0700 Created attachment 312870 Patch 1319131 2 312870 mcatanzaro 2017-06-14 08:34:57 -0700 Comment on attachment 312870 Patch I hate bash 1319441 3 312870 tpopela 2017-06-14 21:01:15 -0700 Comment on attachment 312870 Patch Clearing flags on attachment: 312870 Committed r218314: <http://trac.webkit.org/changeset/218314> 1319442 4 tpopela 2017-06-14 21:01:20 -0700 All reviewed patches have been landed. Closing bug. 312870 2017-06-14 02:01:27 -0700 2017-06-14 21:01:15 -0700 Patch bug-173356-20170614110125.patch text/plain 1122 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MTc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjM3NjI2MDAzMDI5MzkwNzQ3YmM0NTZkNmY5YTUzMjFi MDM2MDlmYy4uYjQ1MTFiZGExMzMxODljN2RlYmIxZTQ0YmNjYTc4YTA3Yzk2ZGI5MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE3LTA2LTE0ICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAg ICAgICAgW0dUS10gaW50ZWdlciBleHByZXNzaW9uIGV4cGVjdGVkIGlmIHJ1bm5pbmcgVG9vbHMv Z3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzMzNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVc2UgdGhlIGNvcnJlY3Qgb3BlcmF0b3IgdG8gY29tcGFyZSB0aGUg c3RyaW5ncy4KKworICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczoKKwogMjAxNy0w Ni0xMyAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CiAKICAgICAgICAgQVg6 IFtBVEtdIEltcGxlbWVudCBtaXNzaW5nIEF0a1JlbGF0aW9uIHR5cGVzCmRpZmYgLS1naXQgYS9U b29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRl bmNpZXMKaW5kZXggNTNjM2VkMmJjOTFhYzA3Y2ExYThmNWQ1M2ExZGU5YmFmYjYwY2E5Mi4uMDA2 NzY2YzUwY2YwZWNkYjY2Nzc4YWQ1NmNjNjFmYzY4NWQ0MDA1MCAxMDA3NTUKLS0tIGEvVG9vbHMv Z3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCisrKyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVu Y2llcwpAQCAtMzcsNyArMzcsNyBAQCBmdW5jdGlvbiBjaGVja0luc3RhbGxlciB7CiAgICAgICAg IGV4aXQgMAogICAgIGZpCiAKLSAgICBpZiBbIGB1bmFtZWAgLWVxICJEYXJ3aW4iIF07IHRoZW4K KyAgICBpZiBbIGB1bmFtZWAgPSAiRGFyd2luIiBdOyB0aGVuCiAgICAgICAgaW5zdGFsbERlcGVu ZGVuY2llc1dpdGhCcmV3CiAgICAgICAgZXhpdCAwCiAgICAgZmkK