173355 2017-06-14 01:11:54 -0700 [GTK] Use API::InjectedBundle::EditorClient in WebKitWebEditor 2017-06-14 16:34:18 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply darin mcatanzaro zan oldest_to_newest 1319043 0 cgarcia 2017-06-14 01:11:54 -0700 Instead of the C API. 1319044 1 312869 cgarcia 2017-06-14 01:13:08 -0700 Created attachment 312869 Patch 1319078 2 312869 zan 2017-06-14 02:40:58 -0700 Comment on attachment 312869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312869&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:85 > + void didChangeSelection(WebPage&, StringImpl* /*notificationName*/) override Consider UNUSED_PARAM(notificationName), or just not listing the argument name. 1319082 3 cgarcia 2017-06-14 03:49:29 -0700 Committed r218251: <http://trac.webkit.org/changeset/218251> 1319114 4 312869 darin 2017-06-14 07:39:19 -0700 Comment on attachment 312869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312869&action=review >> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:85 >> + void didChangeSelection(WebPage&, StringImpl* /*notificationName*/) override > > Consider UNUSED_PARAM(notificationName), or just not listing the argument name. For what it’s worth, I consider commenting out the name to be better than UNUSED_PARAM. I see UNUSED_PARAM as a necessary evil that we try to avoid, since it doesn’t even work -- it silences the warning, but doesn’t prevent use of the thing it marks as "unused"! But maybe we don’t have consensus on that. 1319141 5 mcatanzaro 2017-06-14 08:48:35 -0700 UNUSED_PARAM should be used in cases where the parameter is used in one preprocessor conditional but not another. Otherwise, it's better to either comment out or omit the name. 1319364 6 darin 2017-06-14 16:34:18 -0700 (In reply to Michael Catanzaro from comment #5) > UNUSED_PARAM should be used in cases where the parameter is used in one > preprocessor conditional but not another. Otherwise, it's better to either > comment out or omit the name. Yes, I agree with that. 312869 2017-06-14 01:13:08 -0700 2017-06-14 02:40:58 -0700 Patch wk2-gtk-editor-client.diff text/plain 3015 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZDAzNDg4NmQ0YS4uMmY3ODY5ODg4ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNy0wNi0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gVXNlIEFQSTo6SW5qZWN0ZWRCdW5kbGU6OkVkaXRv ckNsaWVudCBpbiBXZWJLaXRXZWJFZGl0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3MzM1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluc3RlYWQgb2YgdGhlIEMgQVBJLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL1dlYktpdFdlYkVkaXRvci5jcHA6CisgICAg ICAgICh3ZWJraXRXZWJFZGl0b3JDcmVhdGUpOgorICAgICAgICAoZGlkQ2hhbmdlU2VsZWN0aW9u KTogRGVsZXRlZC4KKworMjAxNy0wNi0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gVXNlIEFQSTo6SW5qZWN0ZWRCdW5kbGVDbGll bnQgaW4gV2ViS2l0SW5qZWN0ZWRCdW5kbGVDbGllbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzM1MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvV2ViS2l0V2ViRWRpdG9yLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJL aXRXZWJFZGl0b3IuY3BwCmluZGV4IDExMDUwOTFlNzVhLi5mZDU1NDlkMTcxMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL1dlYktp dFdlYkVkaXRvci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvZ3RrL1dlYktpdFdlYkVkaXRvci5jcHAKQEAgLTIzLDcgKzIzLDYgQEAKICNpbmNs dWRlICJXZWJLaXRQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2ViS2l0V2ViRWRpdG9yUHJpdmF0ZS5o IgogI2luY2x1ZGUgIldlYktpdFdlYlBhZ2VQcml2YXRlLmgiCi0jaW5jbHVkZSAiV0tCdW5kbGVB UElDYXN0LmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKQEAgLTc1LDM1ICs3NCwyNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2VkaXRvcl9j bGFzc19pbml0KFdlYktpdFdlYkVkaXRvckNsYXNzKiBrbGFzcykKICAgICAgICAgR19UWVBFX05P TkUsIDApOwogfQogCi1zdGF0aWMgdm9pZCBkaWRDaGFuZ2VTZWxlY3Rpb24oV0tCdW5kbGVQYWdl UmVmLCBXS1N0cmluZ1JlZiAvKiBub3RpZmljYXRpb25OYW1lICovLCBjb25zdCB2b2lkKiBjbGll bnRJbmZvKQotewotICAgIGdfc2lnbmFsX2VtaXQoV0VCS0lUX1dFQl9FRElUT1IoY2xpZW50SW5m byksIHNpZ25hbHNbU0VMRUNUSU9OX0NIQU5HRURdLCAwKTsKLX0KK2NsYXNzIFBhZ2VFZGl0b3JD bGllbnQgZmluYWwgOiBwdWJsaWMgQVBJOjpJbmplY3RlZEJ1bmRsZTo6RWRpdG9yQ2xpZW50IHsK K3B1YmxpYzoKKyAgICBleHBsaWNpdCBQYWdlRWRpdG9yQ2xpZW50KFdlYktpdFdlYkVkaXRvciog ZWRpdG9yKQorICAgICAgICA6IG1fZWRpdG9yKGVkaXRvcikKKyAgICB7CisgICAgfQorCitwcml2 YXRlOgorICAgIHZvaWQgZGlkQ2hhbmdlU2VsZWN0aW9uKFdlYlBhZ2UmLCBTdHJpbmdJbXBsKiAv Km5vdGlmaWNhdGlvbk5hbWUqLykgb3ZlcnJpZGUKKyAgICB7CisgICAgICAgIGdfc2lnbmFsX2Vt aXQobV9lZGl0b3IsIHNpZ25hbHNbU0VMRUNUSU9OX0NIQU5HRURdLCAwKTsKKyAgICB9CisKKyAg ICBXZWJLaXRXZWJFZGl0b3IqIG1fZWRpdG9yOworfTsKIAogV2ViS2l0V2ViRWRpdG9yKiB3ZWJr aXRXZWJFZGl0b3JDcmVhdGUoV2ViS2l0V2ViUGFnZSogd2ViUGFnZSkKIHsKICAgICBXZWJLaXRX ZWJFZGl0b3IqIGVkaXRvciA9IFdFQktJVF9XRUJfRURJVE9SKGdfb2JqZWN0X25ldyhXRUJLSVRf VFlQRV9XRUJfRURJVE9SLCBudWxscHRyKSk7CiAgICAgZWRpdG9yLT5wcml2LT53ZWJQYWdlID0g d2ViUGFnZTsKLQotICAgIFdLQnVuZGxlUGFnZUVkaXRvckNsaWVudFYwIGVkaXRvckNsaWVudCA9 IHsKLSAgICAgICAgewotICAgICAgICAgICAgMCwgLy8gdmVyc2lvbgotICAgICAgICAgICAgZWRp dG9yLCAvLyBjbGllbnRJbmZvCi0gICAgICAgIH0sCi0gICAgICAgIG51bGxwdHIsIC8vIHNob3Vs ZEJlZ2luRWRpdGluZwotICAgICAgICBudWxscHRyLCAvLyBzaG91bGRFbmRFZGl0aW5nCi0gICAg ICAgIG51bGxwdHIsIC8vIHNob3VsZEluc2VydE5vZGUKLSAgICAgICAgbnVsbHB0ciwgLy8gc2hv dWxkSW5zZXJ0VGV4dAotICAgICAgICBudWxscHRyLCAvLyBzaG91bGREZWxldGVSYW5nZQotICAg ICAgICBudWxscHRyLCAvLyBzaG91bGRDaGFuZ2VTZWxlY3RlZFJhbmdlCi0gICAgICAgIG51bGxw dHIsIC8vIHNob3VsZEFwcGx5U3R5bGUKLSAgICAgICAgbnVsbHB0ciwgLy8gZGlkQmVnaW5FZGl0 aW5nCi0gICAgICAgIG51bGxwdHIsIC8vIGRpZEVuZEVkaXRpbmcKLSAgICAgICAgbnVsbHB0ciwg Ly8gZGlkQ2hhbmdlCi0gICAgICAgIGRpZENoYW5nZVNlbGVjdGlvbgotICAgIH07Ci0gICAgV0tC dW5kbGVQYWdlU2V0RWRpdG9yQ2xpZW50KHRvQVBJKHdlYmtpdFdlYlBhZ2VHZXRQYWdlKHdlYlBh Z2UpKSwgJmVkaXRvckNsaWVudC5iYXNlKTsKLQorICAgIHdlYmtpdFdlYlBhZ2VHZXRQYWdlKHdl YlBhZ2UpLT5zZXRJbmplY3RlZEJ1bmRsZUVkaXRvckNsaWVudChzdGQ6Om1ha2VfdW5pcXVlPFBh Z2VFZGl0b3JDbGllbnQ+KGVkaXRvcikpOwogICAgIHJldHVybiBlZGl0b3I7CiB9CiAK