173352 2017-06-14 00:45:04 -0700 [Win] WebKit shouldn't include the forwarding header of WebKit itself 2017-11-23 18:57:22 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179960 P2 Normal --- 1 fujii fujii achristensen bfulgham commit-queue pvollan oldest_to_newest 1319038 0 fujii 2017-06-14 00:45:04 -0700 [Win] WebKit shouldn't include the forwarding header of WebKit itself In June 6th, I observed weird build errors on wincairo-2 build bot. https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/2980 > FAILED: Source/WebKit/CMakeFiles/WebKit.dir/win/WebView.cpp.obj > "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\cl.exe" /nologo /TP @Source\WebKit\CMakeFiles\WebKit.dir\win\WebView.cpp.obj.rsp /showIncludes /FoSource\WebKit\CMakeFiles\WebKit.dir\win\WebView.cpp.obj /FdSource\WebKit\CMakeFiles\WebKit.dir\ /FS -c ..\..\Source\WebKit\win\WebView.cpp > ..\..\Source\WebKit\win\WebView.cpp(5283): error C2039: 'mediaPreloadingEnabled': is not a member of 'IWebPreferencesPrivate4' > C:\WebKit-BuildSlave\win-cairo-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebKit/WebKit.h(33171): note: see declaration of 'IWebPreferencesPrivate4' > [1403/1497] Building CXX object Source\WebCore\CMakeFiles\WebCoreTestSupport.dir\testing\Internals.cpp.obj > C:\WebKit-BuildSlave\win-cairo-release\build\WebKitLibraries\win\include\unicode/ucasemap.h(93): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc This was happened because generated WebKit.h is obsolete after a IDL file was modified in Bug 172501. The problem here seems that the forwarding header of WebKit (ForwardingHeaders\WebKit/WebKit.h) is included in WebView.cpp. https://trac.webkit.org/changeset/30186 seems the revision the include has been introduced. 1319041 1 312868 fujii 2017-06-14 00:51:10 -0700 Created attachment 312868 Patch 1319425 2 312947 fujii 2017-06-14 19:40:51 -0700 Created attachment 312947 Patch 1319725 3 312947 commit-queue 2017-06-15 14:38:52 -0700 Comment on attachment 312947 Patch Clearing flags on attachment: 312947 Committed r218358: <http://trac.webkit.org/changeset/218358> 1319726 4 commit-queue 2017-06-15 14:38:54 -0700 All reviewed patches have been landed. Closing bug. 312868 2017-06-14 00:51:10 -0700 2017-06-14 19:40:48 -0700 Patch bug-173352-20170614165109.patch text/plain 1182 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggMmZlYTZlY2I3 ZDA4NTgzYTI1YTE4Njc3YTFhNDk0NjAxODQ0Nzk1Ny4uZmI0ZTZkZWI4ZDgxYjNlMTg3YmEwYjM1 NTkzZjQ3NWM1YjIxZThkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3 LTA2LTE0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAg ICAgIFtXaW5dIFdlYktpdCBzaG91bGRuJ3QgaW5jbHVkZSB0aGUgZm9yd2FyZGluZyBoZWFkZXIg b2YgV2ViS2l0IGl0c2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTczMzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJLaXRQcmVmaXguaDogSW5jbHVkZSA8d2luZG93cy5oPiBpbnN0ZWFkIG9m IDxXZWJLaXQvV2ViS2l0Lmg+LgorCiAyMDE3LTA2LTEzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgVzNDIFNlY3VyZSBDb250ZXh0cyBEcmFm dCBTcGVjaWZpY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJLaXRQcmVm aXguaCBiL1NvdXJjZS9XZWJLaXQvd2luL1dlYktpdFByZWZpeC5oCmluZGV4IGJjMzY5ZGM1N2Zj MmFjODcyMTBjYzA2MWVhMTdmNTkwODM3YTlhMzQuLjMzY2FiNWI1ZDQ4NDM3NGYxZDMyOTY2YjY0 NDZjYzdjOGJjMmM2YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvd2luL1dlYktpdFByZWZp eC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL1dlYktpdFByZWZpeC5oCkBAIC00MCw3ICs0MCw3 IEBACiAjZW5kaWYKIAogI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NvcmVGb3VuZGF0aW9uLmg+ Ci0jaW5jbHVkZSA8V2ViS2l0L1dlYktpdC5oPgorI2luY2x1ZGUgPHdpbmRvd3MuaD4KICNpbmNs dWRlICJjb25maWcuaCIKIAogLy8gV2ViS2l0LmRsbCBpcyBleHBlY3RlZCB0byBleHBvcnQgdGhl IHN5bWJvbHMgaW4gV2ViQ29yZSB0aGF0IGhhdmUgYmVlbiBtYXJrZWQK 312947 2017-06-14 19:40:51 -0700 2017-06-15 14:38:52 -0700 Patch bug-173352-20170615114049.patch text/plain 1245 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggMGM4ODAzY2Y4 ZTI1ODQzYTkxOTcxYWNmNmQ0NWE5NTMyZTYzNjRmZi4uNDg2NjdjNzEyZDBhOTk4N2ZiNzQ1NTli YjI4ZGQ3NGIzNTUxYzRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3 LTA2LTE0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAg ICAgIFtXaW5dIFdlYktpdCBzaG91bGRuJ3QgaW5jbHVkZSB0aGUgZm9yd2FyZGluZyBoZWFkZXIg b2YgV2ViS2l0IGl0c2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTczMzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJLaXRQcmVmaXguaDogSW5jbHVkZSBXZWJLaXQuaCBvZiBEZXJpdmVkU291 cmNlcy9XZWJLaXQgaW5zdGVhZCBvZiBEZXJpdmVkU291cmNlcy9Gb3J3YXJkaW5nSGVhZGVycy4K KwogMjAxNy0wNi0xNCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW1dpbl0gV2ViS2l0IGZhaWxzIHRvIHBhaW50IHRoZSBib3R0b20gbGluZXMgb2YgdGhl IHdpbmRvdyBhdCAxMjUlIHNjYWxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC93aW4vV2Vi S2l0UHJlZml4LmggYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJLaXRQcmVmaXguaAppbmRleCBiYzM2 OWRjNTdmYzJhYzg3MjEwY2MwNjFlYTE3ZjU5MDgzN2E5YTM0Li4xNTk2YWUyNDI3NTRjNjUxNjRl NzkyZGVmNzg0M2M2NGU5YjBlNTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJL aXRQcmVmaXguaAorKysgYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJLaXRQcmVmaXguaApAQCAtNDAs NyArNDAsNyBAQAogI2VuZGlmCiAKICNpbmNsdWRlIDxDb3JlRm91bmRhdGlvbi9Db3JlRm91bmRh dGlvbi5oPgotI2luY2x1ZGUgPFdlYktpdC9XZWJLaXQuaD4KKyNpbmNsdWRlIDxXZWJLaXQuaD4K ICNpbmNsdWRlICJjb25maWcuaCIKIAogLy8gV2ViS2l0LmRsbCBpcyBleHBlY3RlZCB0byBleHBv cnQgdGhlIHN5bWJvbHMgaW4gV2ViQ29yZSB0aGF0IGhhdmUgYmVlbiBtYXJrZWQK