173349 2017-06-14 00:26:32 -0700 REGRESSION: 15 new jsc failures in WPE and GTK+ 2017-06-14 23:24:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 csaavedra csaavedra commit-queue jfbastien ossy oldest_to_newest 1319030 0 csaavedra 2017-06-14 00:26:32 -0700 The following tests started failing recently: wasm.yaml/wasm/function-tests/memory-alignment.js.default-wasm wasm.yaml/wasm/function-tests/memory-alignment.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/memory-alignment.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/memory-alignment.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/memory-alignment.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/align.wast.js.default-wasm wasm.yaml/wasm/spec-tests/align.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/align.wast.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/align.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/align.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/memory.wast.js.default-wasm wasm.yaml/wasm/spec-tests/memory.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/memory.wast.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/memory.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/memory.wast.js.wasm-no-tls-context The failures seem to have been introduced after https://trac.webkit.org/changeset/218216/webkit 1319153 1 jfbastien 2017-06-14 09:23:24 -0700 Interesting. What happens when you run the tests manually? Something like: cd JSTests/wasm && jsc -m function-tests/memory-alignment.js I definitely fixed alignment checking in that patch, but it should all pass! 1319155 2 csaavedra 2017-06-14 09:27:27 -0700 $ ../../WebKitBuild/Release/bin/jsc -m function-tests/memory-alignment.js Exception: Error: Expected to throw a CompileError with message "WebAssembly.Module doesn't parse at byte 5 / 8: byte alignment 2 exceeds load's natural alignment 1, in function at index 0" _fail@/home/claudio/git/metrological/WebKit/JSTests/wasm/assert.js:27:20 _throws@/home/claudio/git/metrological/WebKit/JSTests/wasm/assert.js:135:10 module code@/home/claudio/git/metrological/WebKit/JSTests/wasm/function-tests/memory-alignment.js:45:26 evaluate@[native code] moduleEvaluation@[native code] [native code] promiseReactionJob@[native code] 1319160 3 jfbastien 2017-06-14 09:37:50 -0700 That's odd, this part of the change should handle that failing case: https://trac.webkit.org/changeset/218216/webkit#file66 Maybe the bots didn't re-generateWasmOps.h during incremental build? Maybe the cmake build is missing a dependency on generateWasm.py. 1319168 4 csaavedra 2017-06-14 09:44:13 -0700 I removed WasmOps.h and after building, the generated file was different. Now running the same test has no output, so I assume it's passing. You're probably right that a dependency is missing. 1319178 5 jfbastien 2017-06-14 09:52:35 -0700 (In reply to Claudio Saavedra from comment #4) > I removed WasmOps.h and after building, the generated file was different. > Now running the same test has no output, so I assume it's passing. You're > probably right that a dependency is missing. Ah good. Could you take a look at the cmake dependency issue? The system I'm on right now is unhappy with cmake so I can't test it. 1319188 6 csaavedra 2017-06-14 09:59:06 -0700 Yes, I'm doing that. 1319190 7 jfbastien 2017-06-14 10:05:44 -0700 (In reply to Claudio Saavedra from comment #6) > Yes, I'm doing that. Actually it looks like it's not only a cmake problem: https://bugs.webkit.org/show_bug.cgi?id=173287 I think Source/JavaScriptCore/DerivedSources.make has an issue (but maybe Source/JavaScriptCore/CMakeLists.txt does too). 1319197 8 312902 csaavedra 2017-06-14 10:13:02 -0700 Created attachment 312902 Patch 1319198 9 csaavedra 2017-06-14 10:14:01 -0700 (In reply to JF Bastien from comment #7) > (In reply to Claudio Saavedra from comment #6) > > Yes, I'm doing that. > > I think Source/JavaScriptCore/DerivedSources.make has an issue (but maybe > Source/JavaScriptCore/CMakeLists.txt does too). The above patch seems enough to fix the issue in CMake. 1319200 10 312902 jfbastien 2017-06-14 10:17:35 -0700 Comment on attachment 312902 Patch Great, thanks! 1319229 11 jfbastien 2017-06-14 11:06:23 -0700 Ossy, could you wipe WasmOps.h from all Linux bots? They'll fail until at least this file is rebuilt. 1319239 12 312902 commit-queue 2017-06-14 11:09:39 -0700 Comment on attachment 312902 Patch Clearing flags on attachment: 312902 Committed r218272: <http://trac.webkit.org/changeset/218272> 1319240 13 commit-queue 2017-06-14 11:09:40 -0700 All reviewed patches have been landed. Closing bug. 1319275 14 csaavedra 2017-06-14 12:32:07 -0700 (In reply to JF Bastien from comment #11) > Ossy, could you wipe WasmOps.h from all Linux bots? They'll fail until at > least this file is rebuilt. We did for the GTK+ and WPE bots already. 1319467 15 ossy 2017-06-14 23:24:48 -0700 (In reply to JF Bastien from comment #11) > Ossy, could you wipe WasmOps.h from all Linux bots? They'll fail until at > least this file is rebuilt. I triggered clean build on the AArch64 bot, it is happy now, thanks. 312902 2017-06-14 10:13:02 -0700 2017-06-14 11:09:39 -0700 Patch bug-173349-20170614201301.patch text/plain 2967 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ODBjNThkNWM2YzFmYWI3MTUzNTM2ZGI3MmZhZTMwOWI5ZTFiMjY3Li43YmY0M2JlYmQzNDYxMWIy OTI3NzRjMTY0ODJiZWI3MzA2OWI3YzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0wNi0xNCAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IDE1IG5ldyBqc2MgZmFpbHVyZXMgaW4gV1BF IGFuZCBHVEsrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzMzNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZWNlbnQgY2hhbmdlcyB0byBnZW5lcmF0ZVdhc20ucHkgYXJlIG5vdCBhY2NvdW50ZWQgZm9y IGZyb20KKyAgICAgICAgQ01ha2UsIHdoaWNoIGxlYWRzIHRvIFdhc21PcHMuaCBub3QgYmVpbmcg cmVnZW5lcmF0ZWQgaW4gcGFydGlhbAorICAgICAgICBidWlsZHMuIE1ha2UgZ2VuZXJhdGVXYXNt LnB5IGFuIGFkZGl0aW9uYWwgZGVwZW5kZW5jeS4KKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoK KwogMjAxNy0wNi0xMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAg ICAgICAgIERlYnVnZ2VyIGhhcyB1bmV4cGVjdGVkIGVmZmVjdCBvbiBwcm9ncmFtIGNvcnJlY3Ru ZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggOGJkMzU0MDQzNjc2YzFl ZjFmZTQ5MjZlYWYzMmE3ZTM2ODEzZmVmMi4uM2Y0YTk3ZDY3YjI5NzNiYjgxZTBiZTI3NDM4MGEz OTIwMTNhYjMyNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMu dHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTIyOCwx OSArMTIyOCwxOSBAQCBlbmRpZiAoKQogCiAjIFdlYkFzc2VtYmx5IGdlbmVyYXRvcgogCi1tYWNy byhHRU5FUkFURV9QWVRIT04gX2dlbmVyYXRvciBfaW5wdXQgX291dHB1dCkKK21hY3JvKEdFTkVS QVRFX1BZVEhPTiBfZ2VuZXJhdG9yIF9hZGRpdGlvbmFsX2RlcHMgX2lucHV0IF9vdXRwdXQpCiAg ICAgYWRkX2N1c3RvbV9jb21tYW5kKAogICAgICAgICBPVVRQVVQgJHtfb3V0cHV0fQogICAgICAg ICBNQUlOX0RFUEVOREVOQ1kgJHtfZ2VuZXJhdG9yfQotICAgICAgICBERVBFTkRTICR7X2lucHV0 fQorICAgICAgICBERVBFTkRTICR7X2lucHV0fSAke19hZGRpdGlvbmFsX2RlcHN9CiAgICAgICAg IENPTU1BTkQgJHtQWVRIT05fRVhFQ1VUQUJMRX0gJHtfZ2VuZXJhdG9yfSAke19pbnB1dH0gJHtf b3V0cHV0fQogICAgICAgICBWRVJCQVRJTSkKICAgICBsaXN0KEFQUEVORCBKYXZhU2NyaXB0Q29y ZV9IRUFERVJTICR7X291dHB1dH0pCiAgICAgQUREX1NPVVJDRV9ERVBFTkRFTkNJRVMoJHtfaW5w dXR9ICR7X291dHB1dH0pCiBlbmRtYWNybygpCi1HRU5FUkFURV9QWVRIT04oJHtDTUFLRV9DVVJS RU5UX1NPVVJDRV9ESVJ9L3dhc20vZ2VuZXJhdGVXYXNtT3BzSGVhZGVyLnB5ICR7Q01BS0VfQ1VS UkVOVF9TT1VSQ0VfRElSfS93YXNtL3dhc20uanNvbiAke0RFUklWRURfU09VUkNFU19KQVZBU0NS SVBUQ09SRV9ESVJ9L1dhc21PcHMuaCkKLUdFTkVSQVRFX1BZVEhPTigke0NNQUtFX0NVUlJFTlRf U09VUkNFX0RJUn0vd2FzbS9nZW5lcmF0ZVdhc21WYWxpZGF0ZUlubGluZXNIZWFkZXIucHkgJHtD TUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L3dhc20vd2FzbS5qc29uICR7REVSSVZFRF9TT1VSQ0VT X0pBVkFTQ1JJUFRDT1JFX0RJUn0vV2FzbVZhbGlkYXRlSW5saW5lcy5oKQotR0VORVJBVEVfUFlU SE9OKCR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS93YXNtL2dlbmVyYXRlV2FzbUIzSVJHZW5l cmF0b3JJbmxpbmVzSGVhZGVyLnB5ICR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS93YXNtL3dh c20uanNvbiAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L1dhc21CM0lSR2Vu ZXJhdG9ySW5saW5lcy5oKQorR0VORVJBVEVfUFlUSE9OKCR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0Vf RElSfS93YXNtL2dlbmVyYXRlV2FzbU9wc0hlYWRlci5weSAke0NNQUtFX0NVUlJFTlRfU09VUkNF X0RJUn0vd2FzbS9nZW5lcmF0ZVdhc20ucHkgJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L3dh c20vd2FzbS5qc29uICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vV2FzbU9w cy5oKQorR0VORVJBVEVfUFlUSE9OKCR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS93YXNtL2dl bmVyYXRlV2FzbVZhbGlkYXRlSW5saW5lc0hlYWRlci5weSAke0NNQUtFX0NVUlJFTlRfU09VUkNF X0RJUn0vd2FzbS9nZW5lcmF0ZVdhc20ucHkgJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L3dh c20vd2FzbS5qc29uICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vV2FzbVZh bGlkYXRlSW5saW5lcy5oKQorR0VORVJBVEVfUFlUSE9OKCR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0Vf RElSfS93YXNtL2dlbmVyYXRlV2FzbUIzSVJHZW5lcmF0b3JJbmxpbmVzSGVhZGVyLnB5ICR7Q01B S0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS93YXNtL2dlbmVyYXRlV2FzbS5weSAke0NNQUtFX0NVUlJF TlRfU09VUkNFX0RJUn0vd2FzbS93YXNtLmpzb24gJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQ VENPUkVfRElSfS9XYXNtQjNJUkdlbmVyYXRvcklubGluZXMuaCkKIAogIyBMVVQgZ2VuZXJhdG9y CiAK