173315 2017-06-13 08:57:18 -0700 [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests 2017-06-13 10:49:00 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned achristensen bugs-noreply csaavedra darin lforschler oldest_to_newest 1318656 0 cgarcia 2017-06-13 08:57:18 -0700 This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been destroyed. Thread 1 (Thread 0x7fafced2af00 (LWP 31298)): #0 0x0000000000000041 in ?? () #1 0x00007fafde78baa2 in WebKit::WebGeolocationManagerProxy::~WebGeolocationManagerProxy() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007fafde7c7d56 in WebKit::WebProcessPool::~WebProcessPool() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007fafde7c8639 in WebKit::WebProcessPool::~WebProcessPool() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007fafe10b2019 in WTR::TestController::generatePageConfiguration(OpaqueWKContextConfiguration const*) () #5 0x00007fafe10b7d6b in WTR::TestController::createWebViewWithOptions(WTR::TestOptions const&) () #6 0x00007fafe10b8223 in WTR::TestController::ensureViewSupportsOptionsForTest(WTR::TestInvocation const&) () #7 0x00007fafe10b8421 in WTR::TestController::configureViewForTest(WTR::TestInvocation const&) () #8 0x00007fafe10c0a31 in WTR::TestInvocation::invoke() () #9 0x00007fafe10b369c in WTR::TestController::runTest(char const*) () #10 0x00007fafe10b386b in WTR::TestController::runTestingServerLoop() () #11 0x00007fafe10b6038 in WTR::TestController::TestController(int, char const**) () #12 0x00007fafe10acf9c in main () 1318657 1 312775 cgarcia 2017-06-13 09:00:43 -0700 Created attachment 312775 Patch 1318713 2 cgarcia 2017-06-13 10:49:00 -0700 Committed r218183: <http://trac.webkit.org/changeset/218183> 312775 2017-06-13 09:00:43 -0700 2017-06-13 09:26:38 -0700 Patch wtr-geolocation-crash.diff text/plain 2923 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2Mzc2 MjYwMDMwMi4uOTBkNDVmZjk2N2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxNy0wNi0xMyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dUUl0gQ3Jhc2ggaW4g V2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHk6On5XZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eSgp IHdoZW4gcnVubmluZyBzZXZlcmFsIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMzMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGhhcyBzdGFydGVkIHRvIGhhcHBlbiBhZnRlciByMjE4 MTY1LCBidXQgSSBkb24ndCB0aGluayBpdCdzIGEgcmVncmVzc2lvbiwgYnV0IHRoYXQgcjIxODE2 NSByZXZlYWxlZCB0aGUgYnVnCisgICAgICAgIHNvbWVob3cgaW4gV1RSLiBUaGUgcHJvYmxlbSBp cyB0aGF0IEdlb2xvY2F0aW9uUHJvdmlkZXJNb2NrIGtlZXBzIGEgcG9pbnRlciB0byB0aGUgV0tH ZW9sb2NhdGlvbk1hbmFnZXJSZWYKKyAgICAgICAgcmV0dXJuZWQgYnkgV0tDb250ZXh0R2V0R2Vv bG9jYXRpb25NYW5hZ2VyLiBCdXQgaW4gVGVzdENvbnRyb2xsZXI6OmdlbmVyYXRlUGFnZUNvbmZp Z3VyYXRpb24oKSB0aGUgY29udGV4dCBpcworICAgICAgICBmcmVlZCBiZWZvcmUgdGhlIEdlb2xv Y2F0aW9uUHJvdmlkZXJNb2NrLiBXaGVuIHRoZSBHZW9sb2NhdGlvblByb3ZpZGVyTW9jayBpcyB0 aGVuIGRlc3Ryb3llZCwgaXQgY2FsbHMKKyAgICAgICAgV0tHZW9sb2NhdGlvbk1hbmFnZXJTZXRQ cm92aWRlcihtX2dlb2xvY2F0aW9uTWFuYWdlciwgMCk7IGJ1dCB0aGUgV0tHZW9sb2NhdGlvbk1h bmFnZXJSZWYgaGFzIGFscmVhZHkgYmVlbgorICAgICAgICBkZXN0cm95ZWQuIEdlb2xvY2F0aW9u UHJvdmlkZXJNb2NrIHNob3VsZCBrZWVwIGEgcmVmZXJlbmNlIHRvIHRoZSBXS0NvbnRleHQgdG8g ZW5zdXJlIHRoZQorICAgICAgICBXS0dlb2xvY2F0aW9uTWFuYWdlclJlZiBpcyBub3QgZGVzdHJv eWVkLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9HZW9sb2NhdGlvblByb3ZpZGVyTW9j ay5jcHA6CisgICAgICAgIChXVFI6Okdlb2xvY2F0aW9uUHJvdmlkZXJNb2NrOjpHZW9sb2NhdGlv blByb3ZpZGVyTW9jayk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9HZW9sb2NhdGlvblBy b3ZpZGVyTW9jay5oOgorCiAyMDE3LTA2LTEzICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdh bGlhLmNvbT4KIAogICAgICAgICBBWDogW0FUS10gSW1wbGVtZW50IG1pc3NpbmcgQXRrUmVsYXRp b24gdHlwZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR2VvbG9jYXRpb25Q cm92aWRlck1vY2suY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HZW9sb2NhdGlvblByb3Zp ZGVyTW9jay5jcHAKaW5kZXggYWQ0MTY0OTY2ZDIuLjNhMThkMGJhZjQ0IDEwMDY0NAotLS0gYS9U b29scy9XZWJLaXRUZXN0UnVubmVyL0dlb2xvY2F0aW9uUHJvdmlkZXJNb2NrLmNwcAorKysgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL0dlb2xvY2F0aW9uUHJvdmlkZXJNb2NrLmNwcApAQCAtNDYs MTEgKzQ2LDkgQEAgc3RhdGljIHZvaWQgc3RvcFVwZGF0aW5nQ2FsbGJhY2soV0tHZW9sb2NhdGlv bk1hbmFnZXJSZWYgZ2VvbG9jYXRpb25NYW5hZ2VyLCBjb24KIH0KIAogR2VvbG9jYXRpb25Qcm92 aWRlck1vY2s6Okdlb2xvY2F0aW9uUHJvdmlkZXJNb2NrKFdLQ29udGV4dFJlZiBjb250ZXh0KQot ICAgIDogbV9pc0FjdGl2ZShmYWxzZSkKLSAgICAsIG1faGFzRXJyb3IoZmFsc2UpCisgICAgOiBt X2NvbnRleHQoY29udGV4dCkKKyAgICAsIG1fZ2VvbG9jYXRpb25NYW5hZ2VyKFdLQ29udGV4dEdl dEdlb2xvY2F0aW9uTWFuYWdlcihjb250ZXh0KSkKIHsKLSAgICBtX2dlb2xvY2F0aW9uTWFuYWdl ciA9IFdLQ29udGV4dEdldEdlb2xvY2F0aW9uTWFuYWdlcihjb250ZXh0KTsKLQogICAgIFdLR2Vv bG9jYXRpb25Qcm92aWRlclYxIHByb3ZpZGVyQ2FsbGJhY2s7CiAgICAgbWVtc2V0KCZwcm92aWRl ckNhbGxiYWNrLCAwLCBzaXplb2YoV0tHZW9sb2NhdGlvblByb3ZpZGVyVjEpKTsKICAgICBwcm92 aWRlckNhbGxiYWNrLmJhc2UudmVyc2lvbiA9IDE7CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL0dlb2xvY2F0aW9uUHJvdmlkZXJNb2NrLmggYi9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL0dlb2xvY2F0aW9uUHJvdmlkZXJNb2NrLmgKaW5kZXggODAyMjIzZWMzNjUuLjk1MGZjNjky OGNiIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dlb2xvY2F0aW9uUHJvdmlk ZXJNb2NrLmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HZW9sb2NhdGlvblByb3ZpZGVy TW9jay5oCkBAIC00NywxMiArNDcsMTMgQEAgcHJpdmF0ZToKICAgICB2b2lkIHNlbmRQb3NpdGlv bklmTmVlZGVkKCk7CiAgICAgdm9pZCBzZW5kRXJyb3JJZk5lZWRlZCgpOwogCisgICAgV0tSZXRh aW5QdHI8V0tDb250ZXh0UmVmPiBtX2NvbnRleHQ7CiAgICAgV0tHZW9sb2NhdGlvbk1hbmFnZXJS ZWYgbV9nZW9sb2NhdGlvbk1hbmFnZXI7Ci0gICAgYm9vbCBtX2lzQWN0aXZlOworICAgIGJvb2wg bV9pc0FjdGl2ZSB7IGZhbHNlIH07CiAKICAgICBXS1JldGFpblB0cjxXS0dlb2xvY2F0aW9uUG9z aXRpb25SZWY+IG1fcG9zaXRpb247CiAKLSAgICBib29sIG1faGFzRXJyb3I7CisgICAgYm9vbCBt X2hhc0Vycm9yIHsgZmFsc2UgfTsKICAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gbV9lcnJv ck1lc3NhZ2U7CiB9OwogCg==