<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>173308</bug_id>
          
          <creation_ts>2017-06-13 02:28:55 -0700</creation_ts>
          <short_desc>[Win64] Fails to build Asm.lib (PaintHooks.asm) since Bug 173132</short_desc>
          <delta_ts>2017-06-16 17:22:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>173132</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>pvollan</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1318610</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-06-13 02:28:55 -0700</bug_when>
    <thetext>WinCairo build fails.
trunk@217994

https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/3095

&gt; [1/907] Building ASM_MASM object Source\WebKit\CMakeFiles\Asm.dir\win\Plugins\PaintHooks.asm.obj
&gt; MASM : warning A4018:invalid command-line option : /wd4018
&gt; MASM : warning A4018:invalid command-line option : /wd4068
&gt; MASM : warning A4018:invalid command-line option : /wd4099
&gt; MASM : warning A4018:invalid command-line option : /wd4100
&gt; MASM : warning A4018:invalid command-line option : /wd4127
&gt; MASM : warning A4018:invalid command-line option : /wd4138
&gt; MASM : warning A4018:invalid command-line option : /wd4146
&gt; MASM : warning A4018:invalid command-line option : /wd4180
&gt; MASM : warning A4018:invalid command-line option : /wd4189
&gt; MASM : warning A4018:invalid command-line option : /wd4201
&gt; MASM : warning A4018:invalid command-line option : /wd4206
&gt; MASM : warning A4018:invalid command-line option : /wd4244
&gt; MASM : warning A4018:invalid command-line option : /wd4251
&gt; MASM : warning A4018:invalid command-line option : /wd4267
&gt; MASM : warning A4018:invalid command-line option : /wd4275
&gt; MASM : warning A4018:invalid command-line option : /wd4288
&gt; MASM : warning A4018:invalid command-line option : /wd4291
&gt; MASM : warning A4018:invalid command-line option : /wd4305
&gt; MASM : warning A4018:invalid command-line option : /wd4309
&gt; MASM : warning A4018:invalid command-line option : /wd4344
&gt; MASM : warning A4018:invalid command-line option : /wd4355
&gt; MASM : warning A4018:invalid command-line option : /wd4389
&gt; MASM : warning A4018:invalid command-line option : /wd4396
&gt; MASM : warning A4018:invalid command-line option : /wd4456
&gt; MASM : warning A4018:invalid command-line option : /wd4457
&gt; MASM : warning A4018:invalid command-line option : /wd4458
&gt; MASM : warning A4018:invalid command-line option : /wd4459
&gt; MASM : warning A4018:invalid command-line option : /wd4481
&gt; MASM : warning A4018:invalid command-line option : /wd4503
&gt; MASM : warning A4018:invalid command-line option : /wd4505
&gt; MASM : warning A4018:invalid command-line option : /wd4510
&gt; MASM : warning A4018:invalid command-line option : /wd4512
&gt; MASM : warning A4018:invalid command-line option : /wd4530
&gt; MASM : warning A4018:invalid command-line option : /wd4610
&gt; MASM : warning A4018:invalid command-line option : /wd4611
&gt; MASM : warning A4018:invalid command-line option : /wd4646
&gt; MASM : warning A4018:invalid command-line option : /wd4702
&gt; MASM : warning A4018:invalid command-line option : /wd4706
&gt; MASM : warning A4018:invalid command-line option : /wd4722
&gt; MASM : warning A4018:invalid command-line option : /wd4800
&gt; MASM : warning A4018:invalid command-line option : /wd4819
&gt; MASM : warning A4018:invalid command-line option : /wd4951
&gt; MASM : warning A4018:invalid command-line option : /wd4952
&gt; MASM : warning A4018:invalid command-line option : /wd4996
&gt; MASM : warning A4018:invalid command-line option : /wd6011
&gt; MASM : warning A4018:invalid command-line option : /wd6031
&gt; MASM : warning A4018:invalid command-line option : /wd6211
&gt; MASM : warning A4018:invalid command-line option : /wd6246
&gt; MASM : warning A4018:invalid command-line option : /wd6255
&gt; MASM : warning A4018:invalid command-line option : /wd6387
&gt; MASM : warning A4018:invalid command-line option : /GS
&gt; MASM : warning A4018:invalid command-line option : /EHa-
&gt; MASM : warning A4018:invalid command-line option : /EHc-
&gt; MASM : warning A4018:invalid command-line option : /EHs-
&gt; MASM : warning A4018:invalid command-line option : /fp:except-
&gt; MASM : warning A4018:invalid command-line option : /analyze-
&gt; MASM : warning A4018:invalid command-line option : /bigobj
&gt; MASM : warning A4018:invalid command-line option : /openmp-
&gt; MASM : warning A4018:invalid command-line option : /GF-
&gt; MASM : warning A4018:invalid command-line option : /Oy-
&gt;  Assembling: ..\..\Source\WebKit\win\Plugins\PaintHooks.asm
&gt; Microsoft (R) Macro Assembler (x64) Version 14.10.25019.0
&gt; Copyright (C) Microsoft Corporation.  All rights reserved.
&gt; [3/907] Linking ASM_MASM static library lib64\Asm.lib
&gt; FAILED: lib64/Asm.lib 
&gt; cmd.exe /C &quot;cd . &amp;&amp; &quot;&quot; cr lib64\Asm.lib /machine:x64 Source\WebKit\CMakeFiles\Asm.dir\win\Plugins\PaintHooks.asm.obj  &amp;&amp; &quot;&quot; lib64\Asm.lib  &amp;&amp; cd .&quot;
&gt; &apos;&quot;&quot;&apos; is not recognized as an internal or external command,
&gt; operable program or batch file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1318616</commentid>
    <comment_count>1</comment_count>
      <attachid>312762</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-06-13 03:02:11 -0700</bug_when>
    <thetext>Created attachment 312762
WIP patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1318622</commentid>
    <comment_count>2</comment_count>
      <attachid>312764</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-06-13 03:31:40 -0700</bug_when>
    <thetext>Created attachment 312764
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1318641</commentid>
    <comment_count>3</comment_count>
      <attachid>312764</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-06-13 07:16:18 -0700</bug_when>
    <thetext>Comment on attachment 312764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312764&amp;action=review

&gt; Source/WebKit/PlatformWin.cmake:257
&gt; +    if (MSVC)

In JSC CMakeLists.txt, we have enable_langualge(ASM_MASM). Is it unnecessary?

&gt; Source/WebKit/PlatformWin.cmake:259
&gt; +        set(LLINT_MASM_FLAGS /c /Fo)

It&apos;s not related to LLINT. Let&apos;s rename the other one, like, MASM_FLAGS.

&gt; Source/WebKit/PlatformWin.cmake:263
&gt; +            COMMAND ${MASM_EXECUTABLE} ${LLINT_MASM_FLAGS}

Ditto.

&gt; Source/WebKit/PlatformWin.cmake:269
&gt; +        list(APPEND WebKit_SOURCES
&gt; +            ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/PaintHooks.obj
&gt; +        )

Is it correct? I think SOURCES are for source files basically.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1318686</commentid>
    <comment_count>4</comment_count>
      <attachid>312764</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2017-06-13 09:53:16 -0700</bug_when>
    <thetext>Comment on attachment 312764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312764&amp;action=review

&gt; Source/WebKit/PlatformWin.cmake:261
&gt; +            OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/PaintHooks.obj

https://trac.webkit.org/changeset/216332/webkit uses a derived sources directory.  This should do the same.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1318977</commentid>
    <comment_count>5</comment_count>
      <attachid>312764</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-06-13 20:01:14 -0700</bug_when>
    <thetext>Comment on attachment 312764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312764&amp;action=review

Thank you for the review, Yusuke and Alex.

&gt;&gt; Source/WebKit/PlatformWin.cmake:257
&gt;&gt; +    if (MSVC)
&gt; 
&gt; In JSC CMakeLists.txt, we have enable_langualge(ASM_MASM). Is it unnecessary?

I shouldn&apos;t remove it. It is required for non MSVC case.

&gt;&gt; Source/WebKit/PlatformWin.cmake:269
&gt;&gt; +        )
&gt; 
&gt; Is it correct? I think SOURCES are for source files basically.

There are the same questions around the world. It seems that this is the common way in CMake.

https://stackoverflow.com/questions/38609303/how-to-add-prebuilt-object-files-to-executable-in-cmake/38610428
https://cmake.org/pipermail/cmake/2010-September/039458.html
https://cmake.org/pipermail/cmake/2009-September/032278.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1318986</commentid>
    <comment_count>6</comment_count>
      <attachid>312852</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-06-13 20:34:44 -0700</bug_when>
    <thetext>Created attachment 312852
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319145</commentid>
    <comment_count>7</comment_count>
      <attachid>312852</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-14 09:01:59 -0700</bug_when>
    <thetext>Comment on attachment 312852
Patch

Clearing flags on attachment: 312852

Committed r218258: &lt;http://trac.webkit.org/changeset/218258&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319146</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-14 09:02:01 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319148</commentid>
    <comment_count>9</comment_count>
      <attachid>312852</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-06-14 09:06:08 -0700</bug_when>
    <thetext>Comment on attachment 312852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312852&amp;action=review

&gt; Source/WebKit/PlatformWin.cmake:261
&gt; +            OUTPUT ${DERIVED_SOURCES_WEBKIT_DIR}/PaintHooks.obj

This is a wrong place for object file. You can use e.g. ${CMAKE_CURRENT_BINARY_DIR}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319150</commentid>
    <comment_count>10</comment_count>
      <attachid>312764</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-06-14 09:14:58 -0700</bug_when>
    <thetext>Comment on attachment 312764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312764&amp;action=review

&gt;&gt;&gt; Source/WebKit/PlatformWin.cmake:257
&gt;&gt;&gt; +    if (MSVC)
&gt;&gt; 
&gt;&gt; In JSC CMakeLists.txt, we have enable_langualge(ASM_MASM). Is it unnecessary?
&gt; 
&gt; I shouldn&apos;t remove it. It is required for non MSVC case.

Out of curiosity, what does &quot;non MSVC case&quot; mean here? Functions from PaintHooks.asm are needed only under condition !COMPILER(GCC) &amp;&amp; !defined(_M_IX86)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319420</commentid>
    <comment_count>11</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-06-14 19:28:36 -0700</bug_when>
    <thetext>Thank you for reviewing my patch, Konstantin.

(In reply to Konstantin Tokarev from comment #9)
&gt; This is a wrong place for object file. You can use e.g.
&gt; ${CMAKE_CURRENT_BINARY_DIR}

See Alex&apos;s comment (Comment 4). I think he prefer consistency.

And, it&apos;s important for PS4 port to use ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR} because it uses CMake VS generator without build-webkit script which creates separate build directories for Debug and Release build configurations.


(In reply to Konstantin Tokarev from comment #10)
&gt; Out of curiosity, what does &quot;non MSVC case&quot; mean here? Functions from
&gt; PaintHooks.asm are needed only under condition !COMPILER(GCC) &amp;&amp;
&gt; !defined(_M_IX86)

I mean the following else case.

&gt;     if (MSVC)
&gt;       [...]
&gt;     else ()
&gt;         enable_language(ASM_MASM)
&gt;         list(APPEND WebKit_SOURCES
&gt;             win/plugins/PaintHooks.asm
&gt;         )
&gt;     endif ()

I have preserved this code for ports building for Windows with other than MSVC.
Is this useless?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1320254</commentid>
    <comment_count>12</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2017-06-16 17:22:00 -0700</bug_when>
    <thetext>I followed up in http://trac.webkit.org/r218430
If we find we want to get rid of the non-msvc path then we can.  People work on MinGW and clang occasionally.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>312762</attachid>
            <date>2017-06-13 03:02:11 -0700</date>
            <delta_ts>2017-06-13 03:31:36 -0700</delta_ts>
            <desc>WIP patch</desc>
            <filename>a.diff</filename>
            <type>text/plain</type>
            <size>1309</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UgYi9Tb3VyY2UvV2Vi
S2l0L1BsYXRmb3JtV2luLmNtYWtlCmluZGV4IDc3OGY1NDZhZGU0Li44OGU4NjkyMDhiYyAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdpbi5jbWFrZQorKysgYi9Tb3VyY2UvV2Vi
S2l0L1BsYXRmb3JtV2luLmNtYWtlCkBAIC0yNTQsMTMgKzI1NCwyNCBAQCBsaXN0KEFQUEVORCBX
ZWJLaXRfU09VUkNFU19XZWJDb3JlU3VwcG9ydAogKQogCiBpZiAoQ01BS0VfU0laRU9GX1ZPSURf
UCBFUVVBTCA4KQotICAgIGVuYWJsZV9sYW5ndWFnZShBU01fTUFTTSkKLSAgICBhZGRfbGlicmFy
eShBc20gU1RBVElDCi0gICAgICAgICJ3aW4vcGx1Z2lucy9QYWludEhvb2tzLmFzbSIKLSAgICAp
Ci0gICAgbGlzdChBUFBFTkQgV2ViS2l0X0xJQlJBUklFUwotICAgICAgICBQUklWQVRFIEFzbQot
ICAgICkKKyAgICBpZiAoTVNWQykKKyAgICAgICAgc2V0KE1BU01fRVhFQ1VUQUJMRSBtbDY0KQor
ICAgICAgICBzZXQoTExJTlRfTUFTTV9GTEFHUyAvYyAvRm8pCisgICAgICAgIGFkZF9jdXN0b21f
Y29tbWFuZCgKKyAgICAgICAgICAgIE9VVFBVVCAke0NNQUtFX0NVUlJFTlRfQklOQVJZX0RJUn0v
JHtDTUFLRV9DRkdfSU5URElSfS9QYWludEhvb2tzLm9iagorICAgICAgICAgICAgTUFJTl9ERVBF
TkRFTkNZIHdpbi9wbHVnaW5zL1BhaW50SG9va3MuYXNtCisgICAgICAgICAgICBDT01NQU5EICR7
TUFTTV9FWEVDVVRBQkxFfSAke0xMSU5UX01BU01fRkxBR1N9CisgICAgICAgICAgICAgICAgJHtD
TUFLRV9DVVJSRU5UX0JJTkFSWV9ESVJ9LyR7Q01BS0VfQ0ZHX0lOVERJUn0vUGFpbnRIb29rcy5v
YmoKKyAgICAgICAgICAgICAgICAke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vd2luL3BsdWdp
bnMvUGFpbnRIb29rcy5hc20KKyAgICAgICAgICAgIFZFUkJBVElNKQorICAgICAgICBsaXN0KEFQ
UEVORCBXZWJLaXRfU09VUkNFUworICAgICAgICAgICAgJHtDTUFLRV9DVVJSRU5UX0JJTkFSWV9E
SVJ9LyR7Q01BS0VfQ0ZHX0lOVERJUn0vUGFpbnRIb29rcy5vYmoKKyAgICAgICAgKQorICAgIGVs
c2UgKCkKKyAgICAgICAgbGlzdChBUFBFTkQgV2ViS2l0X1NPVVJDRVMKKyAgICAgICAgICAgIHdp
bi9wbHVnaW5zL1BhaW50SG9va3MuYXNtCisgICAgICAgICkKKyAgICBlbmRpZiAoKQogZW5kaWYg
KCkKIAogbGlzdChBUFBFTkQgV2ViS2l0X1NPVVJDRVMgJHtXZWJLaXRfSU5DTFVERVN9ICR7V2Vi
S2l0X1NPVVJDRVNfQ2xhc3Nlc30gJHtXZWJLaXRfU09VUkNFU19XZWJDb3JlU3VwcG9ydH0pCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>312764</attachid>
            <date>2017-06-13 03:31:40 -0700</date>
            <delta_ts>2017-06-13 20:34:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-173308-20170613193139.patch</filename>
            <type>text/plain</type>
            <size>2139</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc2MjYzYjU4ZTM5N2VmMmQ3
NjM5NTUxYTJmOThiMzQ4ODgxYWQ3MWEuLjVkNmFmMDc2YzA4MTVjYmQ4YzAxYjQzZjJjNDgzOWE3
MDhmNjUzOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDYtMTMgIEZ1amlpIEhp
cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbjY0XSBGYWls
cyB0byBidWlsZCBBc20ubGliIChQYWludEhvb2tzLmFzbSkgc2luY2UgQnVnIDE3MzEzMgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMzA4CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRoZSBzYW1l
IG1ldGhvZCB0byBwcm9jZXNzIGFzbSBmaWxlIGFzIHdlbGwgYXMgSlNDIGRvZXMgKEJ1ZyAxNzA4
MzMpLgorCisgICAgICAgICogUGxhdGZvcm1XaW4uY21ha2U6IFVzZSBhZGRfY3VzdG9tX2NvbW1h
bmQgdG8gYXNzZW1ibGUgUGFpbnRIb29rcy5hc20uCisKIDIwMTctMDYtMDkgIFBlciBBcm5lIFZv
bGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW42NF0gQnVpbGQgZXJyb3Ig
d2hlbiBjb21waWxpbmcgUGFpbnRIb29rcy5hc20uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L1BsYXRmb3JtV2luLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdpbi5jbWFrZQppbmRl
eCA3NzhmNTQ2YWRlNDJhYzg0NTA5NTQzOGQ4M2MxMmZjYmE4ZTg1NjkzLi44OGU4NjkyMDhiYzQw
NmRlMmE3YjYzMTBiNzE2MDg4MTM3YzM1YzZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Bs
YXRmb3JtV2luLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UKQEAg
LTI1NCwxMyArMjU0LDI0IEBAIGxpc3QoQVBQRU5EIFdlYktpdF9TT1VSQ0VTX1dlYkNvcmVTdXBw
b3J0CiApCiAKIGlmIChDTUFLRV9TSVpFT0ZfVk9JRF9QIEVRVUFMIDgpCi0gICAgZW5hYmxlX2xh
bmd1YWdlKEFTTV9NQVNNKQotICAgIGFkZF9saWJyYXJ5KEFzbSBTVEFUSUMKLSAgICAgICAgIndp
bi9wbHVnaW5zL1BhaW50SG9va3MuYXNtIgotICAgICkKLSAgICBsaXN0KEFQUEVORCBXZWJLaXRf
TElCUkFSSUVTCi0gICAgICAgIFBSSVZBVEUgQXNtCi0gICAgKQorICAgIGlmIChNU1ZDKQorICAg
ICAgICBzZXQoTUFTTV9FWEVDVVRBQkxFIG1sNjQpCisgICAgICAgIHNldChMTElOVF9NQVNNX0ZM
QUdTIC9jIC9GbykKKyAgICAgICAgYWRkX2N1c3RvbV9jb21tYW5kKAorICAgICAgICAgICAgT1VU
UFVUICR7Q01BS0VfQ1VSUkVOVF9CSU5BUllfRElSfS8ke0NNQUtFX0NGR19JTlRESVJ9L1BhaW50
SG9va3Mub2JqCisgICAgICAgICAgICBNQUlOX0RFUEVOREVOQ1kgd2luL3BsdWdpbnMvUGFpbnRI
b29rcy5hc20KKyAgICAgICAgICAgIENPTU1BTkQgJHtNQVNNX0VYRUNVVEFCTEV9ICR7TExJTlRf
TUFTTV9GTEFHU30KKyAgICAgICAgICAgICAgICAke0NNQUtFX0NVUlJFTlRfQklOQVJZX0RJUn0v
JHtDTUFLRV9DRkdfSU5URElSfS9QYWludEhvb2tzLm9iagorICAgICAgICAgICAgICAgICR7Q01B
S0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS93aW4vcGx1Z2lucy9QYWludEhvb2tzLmFzbQorICAgICAg
ICAgICAgVkVSQkFUSU0pCisgICAgICAgIGxpc3QoQVBQRU5EIFdlYktpdF9TT1VSQ0VTCisgICAg
ICAgICAgICAke0NNQUtFX0NVUlJFTlRfQklOQVJZX0RJUn0vJHtDTUFLRV9DRkdfSU5URElSfS9Q
YWludEhvb2tzLm9iagorICAgICAgICApCisgICAgZWxzZSAoKQorICAgICAgICBsaXN0KEFQUEVO
RCBXZWJLaXRfU09VUkNFUworICAgICAgICAgICAgd2luL3BsdWdpbnMvUGFpbnRIb29rcy5hc20K
KyAgICAgICAgKQorICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCiBsaXN0KEFQUEVORCBXZWJLaXRf
U09VUkNFUyAke1dlYktpdF9JTkNMVURFU30gJHtXZWJLaXRfU09VUkNFU19DbGFzc2VzfSAke1dl
YktpdF9TT1VSQ0VTX1dlYkNvcmVTdXBwb3J0fSkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>312852</attachid>
            <date>2017-06-13 20:34:44 -0700</date>
            <delta_ts>2017-06-14 09:01:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-173308-20170614123443.patch</filename>
            <type>text/plain</type>
            <size>2108</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc2MjYzYjU4ZTM5N2VmMmQ3
NjM5NTUxYTJmOThiMzQ4ODgxYWQ3MWEuLjVkNmFmMDc2YzA4MTVjYmQ4YzAxYjQzZjJjNDgzOWE3
MDhmNjUzOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDYtMTMgIEZ1amlpIEhp
cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbjY0XSBGYWls
cyB0byBidWlsZCBBc20ubGliIChQYWludEhvb2tzLmFzbSkgc2luY2UgQnVnIDE3MzEzMgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMzA4CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRoZSBzYW1l
IG1ldGhvZCB0byBwcm9jZXNzIGFzbSBmaWxlIGFzIHdlbGwgYXMgSlNDIGRvZXMgKEJ1ZyAxNzA4
MzMpLgorCisgICAgICAgICogUGxhdGZvcm1XaW4uY21ha2U6IFVzZSBhZGRfY3VzdG9tX2NvbW1h
bmQgdG8gYXNzZW1ibGUgUGFpbnRIb29rcy5hc20uCisKIDIwMTctMDYtMDkgIFBlciBBcm5lIFZv
bGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW42NF0gQnVpbGQgZXJyb3Ig
d2hlbiBjb21waWxpbmcgUGFpbnRIb29rcy5hc20uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L1BsYXRmb3JtV2luLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdpbi5jbWFrZQppbmRl
eCA3NzhmNTQ2YWRlNDJhYzg0NTA5NTQzOGQ4M2MxMmZjYmE4ZTg1NjkzLi5mZDk4Y2IwNzA1Nzcy
ODY5NWZhODJlMzE1ZmFhNzEyMWNjOWIzZTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Bs
YXRmb3JtV2luLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UKQEAg
LTI1NCwxMyArMjU0LDI1IEBAIGxpc3QoQVBQRU5EIFdlYktpdF9TT1VSQ0VTX1dlYkNvcmVTdXBw
b3J0CiApCiAKIGlmIChDTUFLRV9TSVpFT0ZfVk9JRF9QIEVRVUFMIDgpCi0gICAgZW5hYmxlX2xh
bmd1YWdlKEFTTV9NQVNNKQotICAgIGFkZF9saWJyYXJ5KEFzbSBTVEFUSUMKLSAgICAgICAgIndp
bi9wbHVnaW5zL1BhaW50SG9va3MuYXNtIgotICAgICkKLSAgICBsaXN0KEFQUEVORCBXZWJLaXRf
TElCUkFSSUVTCi0gICAgICAgIFBSSVZBVEUgQXNtCi0gICAgKQorICAgIGlmIChNU1ZDKQorICAg
ICAgICBzZXQoTUFTTV9FWEVDVVRBQkxFIG1sNjQpCisgICAgICAgIHNldChNQVNNX0ZMQUdTIC9j
IC9GbykKKyAgICAgICAgYWRkX2N1c3RvbV9jb21tYW5kKAorICAgICAgICAgICAgT1VUUFVUICR7
REVSSVZFRF9TT1VSQ0VTX1dFQktJVF9ESVJ9L1BhaW50SG9va3Mub2JqCisgICAgICAgICAgICBN
QUlOX0RFUEVOREVOQ1kgd2luL3BsdWdpbnMvUGFpbnRIb29rcy5hc20KKyAgICAgICAgICAgIENP
TU1BTkQgJHtNQVNNX0VYRUNVVEFCTEV9ICR7TUFTTV9GTEFHU30KKyAgICAgICAgICAgICAgICAk
e0RFUklWRURfU09VUkNFU19XRUJLSVRfRElSfS9QYWludEhvb2tzLm9iagorICAgICAgICAgICAg
ICAgICR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS93aW4vcGx1Z2lucy9QYWludEhvb2tzLmFz
bQorICAgICAgICAgICAgVkVSQkFUSU0pCisgICAgICAgIGxpc3QoQVBQRU5EIFdlYktpdF9TT1VS
Q0VTCisgICAgICAgICAgICAke0RFUklWRURfU09VUkNFU19XRUJLSVRfRElSfS9QYWludEhvb2tz
Lm9iagorICAgICAgICApCisgICAgZWxzZSAoKQorICAgICAgICBlbmFibGVfbGFuZ3VhZ2UoQVNN
X01BU00pCisgICAgICAgIGxpc3QoQVBQRU5EIFdlYktpdF9TT1VSQ0VTCisgICAgICAgICAgICB3
aW4vcGx1Z2lucy9QYWludEhvb2tzLmFzbQorICAgICAgICApCisgICAgZW5kaWYgKCkKIGVuZGlm
ICgpCiAKIGxpc3QoQVBQRU5EIFdlYktpdF9TT1VSQ0VTICR7V2ViS2l0X0lOQ0xVREVTfSAke1dl
YktpdF9TT1VSQ0VTX0NsYXNzZXN9ICR7V2ViS2l0X1NPVVJDRVNfV2ViQ29yZVN1cHBvcnR9KQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>