173306 2017-06-13 01:19:43 -0700 [GStreamer] Spreaker live shows won't play 2017-06-22 09:43:57 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 agomez cturner bugs-noreply calvaris cgarcia commit-queue cturner eocanha oldest_to_newest 1318599 0 agomez 2017-06-13 01:19:43 -0700 I'm using WebKitGtk+ with my own JHBuild setting: https://github.com/tanty/jhbuild-epiphany/tree/master WebKit 2.17.3. The compilation was done with CMake args: '-DPORT=GTK -DCMAKE_BUILD_TYPE=Release -DENABLE_MINIBROWSER=ON -DCMAKE_C_FLAGS_RELEASE="-O0 -g -DNDEBUG -DG_DISABLE_CAST_CHECKS" -DCMAKE_CXX_FLAGS_RELEASE="-O0 -g -DNDEBUG -DG_DISABLE_CAST_CHECKS"' Open MiniBrowser and go to, for example: http://www.spreaker.com/user/radiocable For this show, they are live at 08:30-09:30 C(S)ET. You can choose another show at another time, if preferred. When clicking on the play button for the live show to play nothing is played and a banner is shown: "This episode is not available, please try again in a few minutes." This works well with, at least, Firefox. 1321185 1 313420 cturner 2017-06-20 12:06:38 -0700 Created attachment 313420 Patch 1321186 2 cturner 2017-06-20 12:07:52 -0700 One further problem (or perhaps exposed problem) after this patch is that sometimes you will hear some garbled audio before the stream starts properly. This looks like something to do with a PAUSED->PLAYING transition happening too early, but it's a separate issue. 1321858 3 313420 calvaris 2017-06-22 07:12:00 -0700 Comment on attachment 313420 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313420&action=review The problem of this structure is that there is going to be the case of (parsedIcyMetaInt && metadataInterval > 0) being false and you want to set the caps to nullptr there too. You need to rework this to avoid it. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:956 > + String icyMetaInt = response.httpHeaderField(HTTPHeaderName::IcyMetaInt); icyMetaInt -> metadataIntervalAsString > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:958 > + bool parsedIcyMetaInt; isMetatadaIntervalParsed > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:959 > + gint metadataInterval = icyMetaInt.toInt(&parsedIcyMetaInt); Please use plain int. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:962 > + GRefPtr<GstCaps> caps = adoptGRef( > + gst_caps_new_simple("application/x-icy", "metadata-interval", G_TYPE_INT, metadataInterval, nullptr)); You can have this in just one line. No problem with long lines in WK. 1321865 4 313619 cturner 2017-06-22 07:42:19 -0700 Created attachment 313619 Patch 1321879 5 313619 calvaris 2017-06-22 08:12:15 -0700 Comment on attachment 313619 Patch I can give you the r+ now but I am not totally convince of the structure. I would either: bool areCapsSet = false; ... if (!areCapsSet) gst_app_src_set_caps(priv->appsrc, nullptr); or even GRefPtr<GstCaps> caps; ... gst_app_src_set_caps(priv->appsrc, caps.get()); 1321910 6 313633 cturner 2017-06-22 09:00:16 -0700 Created attachment 313633 Patch 1321934 7 313633 commit-queue 2017-06-22 09:43:55 -0700 Comment on attachment 313633 Patch Clearing flags on attachment: 313633 Committed r218703: <http://trac.webkit.org/changeset/218703> 1321935 8 commit-queue 2017-06-22 09:43:57 -0700 All reviewed patches have been landed. Closing bug. 313420 2017-06-20 12:06:38 -0700 2017-06-22 07:42:16 -0700 Patch bug-173306-20170620200637.patch text/plain 2758 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU4Y2M2ODAxZjA5YmFm NzFiM2ZjMmY0NmYwOTdjNDg2OWVjNDQyMi4uMzdlZTlkYTE4NzE4YTAxOWU1N2Q3NDgyN2M4Yjdh ZjgxOGMzNWEwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA2LTIwICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTcHJlYWtl ciBsaXZlIHNob3dzIHdvbid0IHBsYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MzMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgd2FzIGR1ZSB0byByZW1vdmluZyB0aGUgY29kZSB0aGF0IG5l Z290aWF0ZWQgY2FwcyBmb3IgSWNlY2FzdAorICAgICAgICBzdHJlYW1zIGJhc2VkIG9uIHRoZSBy ZXNwb25zZSBoZWFkZXJzIGluIHIxOTE5NDcuIFRoZSBwcm9ibGVtIGlzIHRoYXQKKyAgICAgICAg dGhlIHR5cGVmaW5kIGVsZW1lbnQgY2FuIHNvbWV0aW1lcyBzcXVpbnQgaGFyZCBlbm91Z2ggYW5k IHNlZSBhbiBNUDMKKyAgICAgICAgc3RyZWFtIGFuZCBhdHRlbXB0IHRvIHBsYXkgaXQsIHJlc3Vs dGluZyBpbiBnYXJibGVkIGF1ZGlvIHBsYXliYWNrLiBNb3JlCisgICAgICAgIGNvbW1vbmx5IHR5 cGVmaW5kIGZhaWxzIHRvIHJlY29nbml6ZSB0aGUgSWNlY2FzdCBzdHJlYW0gYW5kIGJhaWxzLAor ICAgICAgICByZXN1bHRpbmcgaW4gbm8gcGxheWJhY2sgYXQgYWxsLgorCisgICAgICAgIHIxOTE5 NDcgYWxzbyByZW1vdmVkIHRoZSBlbWlzc2lvbiBvZiBtZXRhZGF0YSBpbnRvIHRoZSBwaXBlbGlu ZS4gVGhpcworICAgICAgICBwYXRjaCBhbHNvIGxlYXZlcyB0aGF0IG91dCBzaW5jZSB3ZSBoYXZl IG5vIHVzZSBmb3IgaXQgd2l0aGluIFdlYktpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoU3Ry ZWFtaW5nQ2xpZW50OjpoYW5kbGVSZXNwb25zZVJlY2VpdmVkKToKKwogMjAxNy0wNi0xOCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdoZW4gcmUtZW50 ZXJpbmcgTWVkaWFEZXZpY2VzRW51bWVyYXRpb25SZXF1ZXN0OjpjYW5jZWwoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNv dXJjZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCBjOWFkZjhjMDA4NDAxOTcy ZjU4ZmU4MGMzNDU0N2U3ZTMxNWEzYzYwLi5jMjM4MjI1MDA1ZjAxM2M4YzAxY2RmYTBjNTgwMDk5 OWU1Y2U5MjgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNw cApAQCAtOTUyLDcgKzk1MiwxOCBAQCB2b2lkIFN0cmVhbWluZ0NsaWVudDo6aGFuZGxlUmVzcG9u c2VSZWNlaXZlZChjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKICAgICB9IGVsc2UK ICAgICAgICAgZ3N0X2FwcF9zcmNfc2V0X3NpemUocHJpdi0+YXBwc3JjLCAtMSk7CiAKLSAgICBn c3RfYXBwX3NyY19zZXRfY2Fwcyhwcml2LT5hcHBzcmMsIG51bGxwdHIpOworICAgIC8vIFNpZ25h bCB0byBkb3duc3RyZWFtIGlmIHRoaXMgaXMgYW4gSWNlY2FzdCBzdHJlYW0uCisgICAgU3RyaW5n IGljeU1ldGFJbnQgPSByZXNwb25zZS5odHRwSGVhZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6Oklj eU1ldGFJbnQpOworICAgIGlmICghaWN5TWV0YUludC5pc0VtcHR5KCkpIHsKKyAgICAgICAgYm9v bCBwYXJzZWRJY3lNZXRhSW50OworICAgICAgICBnaW50IG1ldGFkYXRhSW50ZXJ2YWwgPSBpY3lN ZXRhSW50LnRvSW50KCZwYXJzZWRJY3lNZXRhSW50KTsKKyAgICAgICAgaWYgKHBhcnNlZEljeU1l dGFJbnQgJiYgbWV0YWRhdGFJbnRlcnZhbCA+IDApIHsKKyAgICAgICAgICAgIEdSZWZQdHI8R3N0 Q2Fwcz4gY2FwcyA9IGFkb3B0R1JlZigKKyAgICAgICAgICAgICAgICBnc3RfY2Fwc19uZXdfc2lt cGxlKCJhcHBsaWNhdGlvbi94LWljeSIsICJtZXRhZGF0YS1pbnRlcnZhbCIsIEdfVFlQRV9JTlQs IG1ldGFkYXRhSW50ZXJ2YWwsIG51bGxwdHIpKTsKKyAgICAgICAgICAgIGdzdF9hcHBfc3JjX3Nl dF9jYXBzKHByaXYtPmFwcHNyYywgY2Fwcy5nZXQoKSk7CisgICAgICAgIH0KKyAgICB9IGVsc2UK KyAgICAgICAgZ3N0X2FwcF9zcmNfc2V0X2NhcHMocHJpdi0+YXBwc3JjLCBudWxscHRyKTsKIAog ICAgIC8vIEVtaXQgYSBHU1RfRVZFTlRfQ1VTVE9NX0RPV05TVFJFQU1fU1RJQ0tZIGV2ZW50IHRv IGxldCBHU3RyZWFtZXIga25vdyBhYm91dCB0aGUgSFRUUCBoZWFkZXJzIHNlbnQgYW5kIHJlY2Vp dmVkLgogICAgIEdzdFN0cnVjdHVyZSogaHR0cEhlYWRlcnMgPSBnc3Rfc3RydWN0dXJlX25ld19l bXB0eSgiaHR0cC1oZWFkZXJzIik7Cg== 313619 2017-06-22 07:42:19 -0700 2017-06-22 09:00:12 -0700 Patch bug-173306-20170622154218.patch text/plain 2868 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU4Y2M2ODAxZjA5YmFm NzFiM2ZjMmY0NmYwOTdjNDg2OWVjNDQyMi4uMzdlZTlkYTE4NzE4YTAxOWU1N2Q3NDgyN2M4Yjdh ZjgxOGMzNWEwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA2LTIwICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTcHJlYWtl ciBsaXZlIHNob3dzIHdvbid0IHBsYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MzMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgd2FzIGR1ZSB0byByZW1vdmluZyB0aGUgY29kZSB0aGF0IG5l Z290aWF0ZWQgY2FwcyBmb3IgSWNlY2FzdAorICAgICAgICBzdHJlYW1zIGJhc2VkIG9uIHRoZSBy ZXNwb25zZSBoZWFkZXJzIGluIHIxOTE5NDcuIFRoZSBwcm9ibGVtIGlzIHRoYXQKKyAgICAgICAg dGhlIHR5cGVmaW5kIGVsZW1lbnQgY2FuIHNvbWV0aW1lcyBzcXVpbnQgaGFyZCBlbm91Z2ggYW5k IHNlZSBhbiBNUDMKKyAgICAgICAgc3RyZWFtIGFuZCBhdHRlbXB0IHRvIHBsYXkgaXQsIHJlc3Vs dGluZyBpbiBnYXJibGVkIGF1ZGlvIHBsYXliYWNrLiBNb3JlCisgICAgICAgIGNvbW1vbmx5IHR5 cGVmaW5kIGZhaWxzIHRvIHJlY29nbml6ZSB0aGUgSWNlY2FzdCBzdHJlYW0gYW5kIGJhaWxzLAor ICAgICAgICByZXN1bHRpbmcgaW4gbm8gcGxheWJhY2sgYXQgYWxsLgorCisgICAgICAgIHIxOTE5 NDcgYWxzbyByZW1vdmVkIHRoZSBlbWlzc2lvbiBvZiBtZXRhZGF0YSBpbnRvIHRoZSBwaXBlbGlu ZS4gVGhpcworICAgICAgICBwYXRjaCBhbHNvIGxlYXZlcyB0aGF0IG91dCBzaW5jZSB3ZSBoYXZl IG5vIHVzZSBmb3IgaXQgd2l0aGluIFdlYktpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoU3Ry ZWFtaW5nQ2xpZW50OjpoYW5kbGVSZXNwb25zZVJlY2VpdmVkKToKKwogMjAxNy0wNi0xOCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdoZW4gcmUtZW50 ZXJpbmcgTWVkaWFEZXZpY2VzRW51bWVyYXRpb25SZXF1ZXN0OjpjYW5jZWwoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNv dXJjZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCBjOWFkZjhjMDA4NDAxOTcy ZjU4ZmU4MGMzNDU0N2U3ZTMxNWEzYzYwLi5iY2JjOWY0M2RjYWRhMGExMGUzZTM4NjlhYjFkYzhj ZWY0OTRlOGY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNw cApAQCAtOTUyLDcgKzk1MiwxOCBAQCB2b2lkIFN0cmVhbWluZ0NsaWVudDo6aGFuZGxlUmVzcG9u c2VSZWNlaXZlZChjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKICAgICB9IGVsc2UK ICAgICAgICAgZ3N0X2FwcF9zcmNfc2V0X3NpemUocHJpdi0+YXBwc3JjLCAtMSk7CiAKLSAgICBn c3RfYXBwX3NyY19zZXRfY2Fwcyhwcml2LT5hcHBzcmMsIG51bGxwdHIpOworICAgIC8vIFNpZ25h bCB0byBkb3duc3RyZWFtIGlmIHRoaXMgaXMgYW4gSWNlY2FzdCBzdHJlYW0uCisgICAgU3RyaW5n IG1ldGFkYXRhSW50ZXJ2YWxBc1N0cmluZyA9IHJlc3BvbnNlLmh0dHBIZWFkZXJGaWVsZChIVFRQ SGVhZGVyTmFtZTo6SWN5TWV0YUludCk7CisgICAgaWYgKCFtZXRhZGF0YUludGVydmFsQXNTdHJp bmcuaXNFbXB0eSgpKSB7CisgICAgICAgIGJvb2wgaXNNZXRhZGF0YUludGVydmFsUGFyc2VkOwor ICAgICAgICBpbnQgbWV0YWRhdGFJbnRlcnZhbCA9IG1ldGFkYXRhSW50ZXJ2YWxBc1N0cmluZy50 b0ludCgmaXNNZXRhZGF0YUludGVydmFsUGFyc2VkKTsKKyAgICAgICAgaWYgKGlzTWV0YWRhdGFJ bnRlcnZhbFBhcnNlZCAmJiBtZXRhZGF0YUludGVydmFsID4gMCkgeworICAgICAgICAgICAgR1Jl ZlB0cjxHc3RDYXBzPiBjYXBzID0gYWRvcHRHUmVmKGdzdF9jYXBzX25ld19zaW1wbGUoImFwcGxp Y2F0aW9uL3gtaWN5IiwgIm1ldGFkYXRhLWludGVydmFsIiwgR19UWVBFX0lOVCwgbWV0YWRhdGFJ bnRlcnZhbCwgbnVsbHB0cikpOworICAgICAgICAgICAgZ3N0X2FwcF9zcmNfc2V0X2NhcHMocHJp di0+YXBwc3JjLCBjYXBzLmdldCgpKTsKKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBnc3Rf YXBwX3NyY19zZXRfY2Fwcyhwcml2LT5hcHBzcmMsIG51bGxwdHIpOworICAgIH0gZWxzZQorICAg ICAgICBnc3RfYXBwX3NyY19zZXRfY2Fwcyhwcml2LT5hcHBzcmMsIG51bGxwdHIpOwogCiAgICAg Ly8gRW1pdCBhIEdTVF9FVkVOVF9DVVNUT01fRE9XTlNUUkVBTV9TVElDS1kgZXZlbnQgdG8gbGV0 IEdTdHJlYW1lciBrbm93IGFib3V0IHRoZSBIVFRQIGhlYWRlcnMgc2VudCBhbmQgcmVjZWl2ZWQu CiAgICAgR3N0U3RydWN0dXJlKiBodHRwSGVhZGVycyA9IGdzdF9zdHJ1Y3R1cmVfbmV3X2VtcHR5 KCJodHRwLWhlYWRlcnMiKTsK 313633 2017-06-22 09:00:16 -0700 2017-06-22 09:43:55 -0700 Patch bug-173306-20170622170014.patch text/plain 2736 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4NDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU4Y2M2ODAxZjA5YmFm NzFiM2ZjMmY0NmYwOTdjNDg2OWVjNDQyMi4uMzdlZTlkYTE4NzE4YTAxOWU1N2Q3NDgyN2M4Yjdh ZjgxOGMzNWEwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA2LTIwICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTcHJlYWtl ciBsaXZlIHNob3dzIHdvbid0IHBsYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MzMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgd2FzIGR1ZSB0byByZW1vdmluZyB0aGUgY29kZSB0aGF0IG5l Z290aWF0ZWQgY2FwcyBmb3IgSWNlY2FzdAorICAgICAgICBzdHJlYW1zIGJhc2VkIG9uIHRoZSBy ZXNwb25zZSBoZWFkZXJzIGluIHIxOTE5NDcuIFRoZSBwcm9ibGVtIGlzIHRoYXQKKyAgICAgICAg dGhlIHR5cGVmaW5kIGVsZW1lbnQgY2FuIHNvbWV0aW1lcyBzcXVpbnQgaGFyZCBlbm91Z2ggYW5k IHNlZSBhbiBNUDMKKyAgICAgICAgc3RyZWFtIGFuZCBhdHRlbXB0IHRvIHBsYXkgaXQsIHJlc3Vs dGluZyBpbiBnYXJibGVkIGF1ZGlvIHBsYXliYWNrLiBNb3JlCisgICAgICAgIGNvbW1vbmx5IHR5 cGVmaW5kIGZhaWxzIHRvIHJlY29nbml6ZSB0aGUgSWNlY2FzdCBzdHJlYW0gYW5kIGJhaWxzLAor ICAgICAgICByZXN1bHRpbmcgaW4gbm8gcGxheWJhY2sgYXQgYWxsLgorCisgICAgICAgIHIxOTE5 NDcgYWxzbyByZW1vdmVkIHRoZSBlbWlzc2lvbiBvZiBtZXRhZGF0YSBpbnRvIHRoZSBwaXBlbGlu ZS4gVGhpcworICAgICAgICBwYXRjaCBhbHNvIGxlYXZlcyB0aGF0IG91dCBzaW5jZSB3ZSBoYXZl IG5vIHVzZSBmb3IgaXQgd2l0aGluIFdlYktpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoU3Ry ZWFtaW5nQ2xpZW50OjpoYW5kbGVSZXNwb25zZVJlY2VpdmVkKToKKwogMjAxNy0wNi0xOCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdoZW4gcmUtZW50 ZXJpbmcgTWVkaWFEZXZpY2VzRW51bWVyYXRpb25SZXF1ZXN0OjpjYW5jZWwoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNv dXJjZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCBjOWFkZjhjMDA4NDAxOTcy ZjU4ZmU4MGMzNDU0N2U3ZTMxNWEzYzYwLi45YTJhMTczMzg0YTQ5MjkwMWMxNjQyMDBkMGE0ZWRj ODQyN2NlMGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNw cApAQCAtOTUyLDcgKzk1MiwxNiBAQCB2b2lkIFN0cmVhbWluZ0NsaWVudDo6aGFuZGxlUmVzcG9u c2VSZWNlaXZlZChjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKICAgICB9IGVsc2UK ICAgICAgICAgZ3N0X2FwcF9zcmNfc2V0X3NpemUocHJpdi0+YXBwc3JjLCAtMSk7CiAKLSAgICBn c3RfYXBwX3NyY19zZXRfY2Fwcyhwcml2LT5hcHBzcmMsIG51bGxwdHIpOworICAgIC8vIFNpZ25h bCB0byBkb3duc3RyZWFtIGlmIHRoaXMgaXMgYW4gSWNlY2FzdCBzdHJlYW0uCisgICAgR1JlZlB0 cjxHc3RDYXBzPiBjYXBzOworICAgIFN0cmluZyBtZXRhZGF0YUludGVydmFsQXNTdHJpbmcgPSBy ZXNwb25zZS5odHRwSGVhZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6OkljeU1ldGFJbnQpOworICAg IGlmICghbWV0YWRhdGFJbnRlcnZhbEFzU3RyaW5nLmlzRW1wdHkoKSkgeworICAgICAgICBib29s IGlzTWV0YWRhdGFJbnRlcnZhbFBhcnNlZDsKKyAgICAgICAgaW50IG1ldGFkYXRhSW50ZXJ2YWwg PSBtZXRhZGF0YUludGVydmFsQXNTdHJpbmcudG9JbnQoJmlzTWV0YWRhdGFJbnRlcnZhbFBhcnNl ZCk7CisgICAgICAgIGlmIChpc01ldGFkYXRhSW50ZXJ2YWxQYXJzZWQgJiYgbWV0YWRhdGFJbnRl cnZhbCA+IDApCisgICAgICAgICAgICBjYXBzID0gYWRvcHRHUmVmKGdzdF9jYXBzX25ld19zaW1w bGUoImFwcGxpY2F0aW9uL3gtaWN5IiwgIm1ldGFkYXRhLWludGVydmFsIiwgR19UWVBFX0lOVCwg bWV0YWRhdGFJbnRlcnZhbCwgbnVsbHB0cikpOworICAgIH0KKyAgICBnc3RfYXBwX3NyY19zZXRf Y2Fwcyhwcml2LT5hcHBzcmMsIGNhcHMuZ2V0KCkpOwogCiAgICAgLy8gRW1pdCBhIEdTVF9FVkVO VF9DVVNUT01fRE9XTlNUUkVBTV9TVElDS1kgZXZlbnQgdG8gbGV0IEdTdHJlYW1lciBrbm93IGFi b3V0IHRoZSBIVFRQIGhlYWRlcnMgc2VudCBhbmQgcmVjZWl2ZWQuCiAgICAgR3N0U3RydWN0dXJl KiBodHRwSGVhZGVycyA9IGdzdF9zdHJ1Y3R1cmVfbmV3X2VtcHR5KCJodHRwLWhlYWRlcnMiKTsK