173299 2017-06-12 19:32:31 -0700 Include PID in some UIProcess-side release logging that relates to a particular WebProcess 2022-03-01 02:37:08 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen beidson ggaren kling koivisto rniwa sam oldest_to_newest 1318541 0 cdumez 2017-06-12 19:32:31 -0700 Include PID in some UIProcess-side release logging that relates to a particular WebProcess. 1318542 1 312742 cdumez 2017-06-12 19:33:01 -0700 Created attachment 312742 Patch 1318804 2 312742 rniwa 2017-06-13 13:55:22 -0700 Comment on attachment 312742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312742&action=review > Source/WebKit2/UIProcess/WebProcessProxy.cpp:1217 > + RELEASE_LOG_ERROR(PerformanceLogging, "%p - WebProcessProxy::didExceedActiveMemoryLimit() Terminating WebProcess with pid %d that has exceeded the active memory limit", this, processIdentifier()); Can we be consist and use (pid: %d)? 1318806 3 cdumez 2017-06-13 13:58:20 -0700 Committed r218201: <http://trac.webkit.org/changeset/218201> 312742 2017-06-12 19:33:01 -0700 2022-03-01 02:37:08 -0800 Patch bug-173299-20170612193300.patch text/plain 5774 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWEyZjQxYzEzNzc3ZTA3 N2NjYzJhMDRjNDE4YWZiMTU5ODZmMGUxYS4uMjkwNTIzNDBlNDczNWNjYmYzNTY4ZGRlM2MwZjhi OWRjNTJjNzFmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSW5jbHVkZSBQSUQgaW4gc29t ZSBVSVByb2Nlc3Mtc2lkZSByZWxlYXNlIGxvZ2dpbmcgdGhhdCByZWxhdGVzIHRvIGEgcGFydGlj dWxhciBXZWJQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzMyOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9CYWNrZ3JvdW5kUHJvY2Vzc1Jlc3BvbnNpdmVuZXNzVGltZXIu Y3BwOgorICAgICAgICAoV2ViS2l0OjpCYWNrZ3JvdW5kUHJvY2Vzc1Jlc3BvbnNpdmVuZXNzVGlt ZXI6OnNldFJlc3BvbnNpdmUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHku Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmRpZEV4Y2VlZEFjdGl2ZU1l bW9yeUxpbWl0KToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5OjpkaWRFeGNlZWRJ bmFjdGl2ZU1lbW9yeUxpbWl0KToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5Ojpk aWRFeGNlZWRDUFVMaW1pdCk6CisKIDIwMTctMDYtMTIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPUyBXSzJdIFBlZWtpbmcgb24gYW4gaW1hZ2Ug Y291bGQgcmVzdWx0IGluIGEgcHJldmlldyBhdCB0aGUgd3Jvbmcgc2l6ZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0JhY2tncm91bmRQcm9jZXNzUmVzcG9uc2l2ZW5lc3NU aW1lci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQmFja2dyb3VuZFByb2Nlc3NSZXNw b25zaXZlbmVzc1RpbWVyLmNwcAppbmRleCBjODE0NGUxOWI4YmVkYzk3N2JjZDM3ZDRmZGI5M2E0 ODljYTkxODAxLi43N2UyOThmNDJlYTEwMDgzOTViZjBjOGE3MjMzNDliZmM5MjJmOWUxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQmFja2dyb3VuZFByb2Nlc3NSZXNwb25z aXZlbmVzc1RpbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQmFja2dyb3Vu ZFByb2Nlc3NSZXNwb25zaXZlbmVzc1RpbWVyLmNwcApAQCAtMTIxLDEwICsxMjEsMTAgQEAgdm9p ZCBCYWNrZ3JvdW5kUHJvY2Vzc1Jlc3BvbnNpdmVuZXNzVGltZXI6OnNldFJlc3BvbnNpdmUoYm9v bCBpc1Jlc3BvbnNpdmUpCiAgICAgY2xpZW50KCkuZGlkQ2hhbmdlSXNSZXNwb25zaXZlKCk7CiAK ICAgICBpZiAobV9pc1Jlc3BvbnNpdmUpIHsKLSAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoUGVy Zm9ybWFuY2VMb2dnaW5nLCAiTm90aWZ5aW5nIHRoZSBjbGllbnQgdGhhdCBhIGJhY2tncm91bmQg V2ViUHJvY2VzcyBoYXMgYmVjb21lIHJlc3BvbnNpdmUgYWdhaW4iKTsKKyAgICAgICAgUkVMRUFT RV9MT0dfRVJST1IoUGVyZm9ybWFuY2VMb2dnaW5nLCAiTm90aWZ5aW5nIHRoZSBjbGllbnQgdGhh dCBhIGJhY2tncm91bmQgV2ViUHJvY2VzcyAocGlkOiAlZCkgaGFzIGJlY29tZSByZXNwb25zaXZl IGFnYWluIiwgbV93ZWJQcm9jZXNzUHJveHkucHJvY2Vzc0lkZW50aWZpZXIoKSk7CiAgICAgICAg IGNsaWVudCgpLmRpZEJlY29tZVJlc3BvbnNpdmUoKTsKICAgICB9IGVsc2UgewotICAgICAgICBS RUxFQVNFX0xPR19FUlJPUihQZXJmb3JtYW5jZUxvZ2dpbmcsICJOb3RpZnlpbmcgdGhlIGNsaWVu dCB0aGF0IGEgYmFja2dyb3VuZCBXZWJQcm9jZXNzIGhhcyBiZWNvbWUgdW5yZXNwb25zaXZlIik7 CisgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFBlcmZvcm1hbmNlTG9nZ2luZywgIk5vdGlmeWlu ZyB0aGUgY2xpZW50IHRoYXQgYSBiYWNrZ3JvdW5kIFdlYlByb2Nlc3MgKHBpZDogJWQpIGhhcyBi ZWNvbWUgdW5yZXNwb25zaXZlIiwgbV93ZWJQcm9jZXNzUHJveHkucHJvY2Vzc0lkZW50aWZpZXIo KSk7CiAgICAgICAgIGNsaWVudCgpLmRpZEJlY29tZVVucmVzcG9uc2l2ZSgpOwogICAgIH0KIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKaW5kZXggNTQ4 ZmM5YTVlY2M5ZmM3ZmUxMDBkZjlhMTVmNThhNzE2NDQzZTVjMC4uZjkzMzMxYmFkOGZiZDUxNTU4 MmZmMTg2OTVlYThjNDk2NTRmNjllNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlByb2Nlc3NQcm94eS5jcHAKQEAgLTEyMTQsMTQgKzEyMTQsMTQgQEAgdm9pZCBXZWJQcm9jZXNz UHJveHk6OmRpZEV4Y2VlZEluYWN0aXZlTWVtb3J5TGltaXRXaGlsZUFjdGl2ZSgpCiAKIHZvaWQg V2ViUHJvY2Vzc1Byb3h5OjpkaWRFeGNlZWRBY3RpdmVNZW1vcnlMaW1pdCgpCiB7Ci0gICAgUkVM RUFTRV9MT0dfRVJST1IoUGVyZm9ybWFuY2VMb2dnaW5nLCAiJXAgLSBXZWJQcm9jZXNzUHJveHk6 OmRpZEV4Y2VlZEFjdGl2ZU1lbW9yeUxpbWl0KCkgVGVybWluYXRpbmcgV2ViUHJvY2VzcyB0aGF0 IGhhcyBleGNlZWRlZCB0aGUgYWN0aXZlIG1lbW9yeSBsaW1pdCIsIHRoaXMpOworICAgIFJFTEVB U0VfTE9HX0VSUk9SKFBlcmZvcm1hbmNlTG9nZ2luZywgIiVwIC0gV2ViUHJvY2Vzc1Byb3h5Ojpk aWRFeGNlZWRBY3RpdmVNZW1vcnlMaW1pdCgpIFRlcm1pbmF0aW5nIFdlYlByb2Nlc3Mgd2l0aCBw aWQgJWQgdGhhdCBoYXMgZXhjZWVkZWQgdGhlIGFjdGl2ZSBtZW1vcnkgbGltaXQiLCB0aGlzLCBw cm9jZXNzSWRlbnRpZmllcigpKTsKICAgICBsb2dEaWFnbm9zdGljTWVzc2FnZUZvclJlc291cmNl TGltaXRUZXJtaW5hdGlvbihEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmV4Y2VlZGVkQWN0aXZlTWVt b3J5TGltaXRLZXkoKSk7CiAgICAgcmVxdWVzdFRlcm1pbmF0aW9uKFByb2Nlc3NUZXJtaW5hdGlv blJlYXNvbjo6RXhjZWVkZWRNZW1vcnlMaW1pdCk7CiB9CiAKIHZvaWQgV2ViUHJvY2Vzc1Byb3h5 OjpkaWRFeGNlZWRJbmFjdGl2ZU1lbW9yeUxpbWl0KCkKIHsKLSAgICBSRUxFQVNFX0xPR19FUlJP UihQZXJmb3JtYW5jZUxvZ2dpbmcsICIlcCAtIFdlYlByb2Nlc3NQcm94eTo6ZGlkRXhjZWVkSW5h Y3RpdmVNZW1vcnlMaW1pdCgpIFRlcm1pbmF0aW5nIFdlYlByb2Nlc3MgdGhhdCBoYXMgZXhjZWVk ZWQgdGhlIGluYWN0aXZlIG1lbW9yeSBsaW1pdCIsIHRoaXMpOworICAgIFJFTEVBU0VfTE9HX0VS Uk9SKFBlcmZvcm1hbmNlTG9nZ2luZywgIiVwIC0gV2ViUHJvY2Vzc1Byb3h5OjpkaWRFeGNlZWRJ bmFjdGl2ZU1lbW9yeUxpbWl0KCkgVGVybWluYXRpbmcgV2ViUHJvY2VzcyB3aXRoIHBpZCAlZCB0 aGF0IGhhcyBleGNlZWRlZCB0aGUgaW5hY3RpdmUgbWVtb3J5IGxpbWl0IiwgdGhpcywgcHJvY2Vz c0lkZW50aWZpZXIoKSk7CiAgICAgbG9nRGlhZ25vc3RpY01lc3NhZ2VGb3JSZXNvdXJjZUxpbWl0 VGVybWluYXRpb24oRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpleGNlZWRlZEluYWN0aXZlTWVtb3J5 TGltaXRLZXkoKSk7CiAgICAgcmVxdWVzdFRlcm1pbmF0aW9uKFByb2Nlc3NUZXJtaW5hdGlvblJl YXNvbjo6RXhjZWVkZWRNZW1vcnlMaW1pdCk7CiB9CkBAIC0xMjMwLDEyICsxMjMwLDEyIEBAIHZv aWQgV2ViUHJvY2Vzc1Byb3h5OjpkaWRFeGNlZWRDUFVMaW1pdCgpCiB7CiAgICAgZm9yIChhdXRv JiBwYWdlIDogcGFnZXMoKSkgewogICAgICAgICBpZiAocGFnZS0+aXNQbGF5aW5nQXVkaW8oKSkg ewotICAgICAgICAgICAgUkVMRUFTRV9MT0coUGVyZm9ybWFuY2VMb2dnaW5nLCAiJXAgLSBXZWJQ cm9jZXNzUHJveHk6OmRpZEV4Y2VlZENQVUxpbWl0KCkgV2ViUHJvY2VzcyBoYXMgZXhjZWVkZWQg dGhlIGJhY2tncm91bmQgQ1BVIGxpbWl0IGJ1dCB3ZSBhcmUgbm90IHRlcm1pbmF0aW5nIGl0IGJl Y2F1c2UgdGhlcmUgaXMgYXVkaW8gcGxheWluZyIsIHRoaXMpOworICAgICAgICAgICAgUkVMRUFT RV9MT0coUGVyZm9ybWFuY2VMb2dnaW5nLCAiJXAgLSBXZWJQcm9jZXNzUHJveHk6OmRpZEV4Y2Vl ZENQVUxpbWl0KCkgV2ViUHJvY2VzcyB3aXRoIHBpZCAlZCBoYXMgZXhjZWVkZWQgdGhlIGJhY2tn cm91bmQgQ1BVIGxpbWl0IGJ1dCB3ZSBhcmUgbm90IHRlcm1pbmF0aW5nIGl0IGJlY2F1c2UgdGhl cmUgaXMgYXVkaW8gcGxheWluZyIsIHRoaXMsIHByb2Nlc3NJZGVudGlmaWVyKCkpOwogICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKHBhZ2UtPmhhc0FjdGl2ZUF1 ZGlvU3RyZWFtKCkgfHwgcGFnZS0+aGFzQWN0aXZlVmlkZW9TdHJlYW0oKSkgewotICAgICAgICAg ICAgUkVMRUFTRV9MT0coUGVyZm9ybWFuY2VMb2dnaW5nLCAiJXAgLSBXZWJQcm9jZXNzUHJveHk6 OmRpZEV4Y2VlZENQVUxpbWl0KCkgV2ViUHJvY2VzcyBoYXMgZXhjZWVkZWQgdGhlIGJhY2tncm91 bmQgQ1BVIGxpbWl0IGJ1dCB3ZSBhcmUgbm90IHRlcm1pbmF0aW5nIGl0IGJlY2F1c2UgaXQgaXMg Y2FwdHVyaW5nIGF1ZGlvIC8gdmlkZW8iLCB0aGlzKTsKKyAgICAgICAgICAgIFJFTEVBU0VfTE9H KFBlcmZvcm1hbmNlTG9nZ2luZywgIiVwIC0gV2ViUHJvY2Vzc1Byb3h5OjpkaWRFeGNlZWRDUFVM aW1pdCgpIFdlYlByb2Nlc3Mgd2l0aCBwaWQgJWQgaGFzIGV4Y2VlZGVkIHRoZSBiYWNrZ3JvdW5k IENQVSBsaW1pdCBidXQgd2UgYXJlIG5vdCB0ZXJtaW5hdGluZyBpdCBiZWNhdXNlIGl0IGlzIGNh cHR1cmluZyBhdWRpbyAvIHZpZGVvIiwgdGhpcywgcHJvY2Vzc0lkZW50aWZpZXIoKSk7CiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICB9CkBAIC0xMjUyLDcgKzEyNTIsNyBAQCB2 b2lkIFdlYlByb2Nlc3NQcm94eTo6ZGlkRXhjZWVkQ1BVTGltaXQoKQogICAgIGlmIChoYXNWaXNp YmxlUGFnZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgUkVMRUFTRV9MT0dfRVJST1IoUGVyZm9y bWFuY2VMb2dnaW5nLCAiJXAgLSBXZWJQcm9jZXNzUHJveHk6OmRpZEV4Y2VlZENQVUxpbWl0KCkg VGVybWluYXRpbmcgYmFja2dyb3VuZCBXZWJQcm9jZXNzIHRoYXQgaGFzIGV4Y2VlZGVkIHRoZSBi YWNrZ3JvdW5kIENQVSBsaW1pdCIsIHRoaXMpOworICAgIFJFTEVBU0VfTE9HX0VSUk9SKFBlcmZv cm1hbmNlTG9nZ2luZywgIiVwIC0gV2ViUHJvY2Vzc1Byb3h5OjpkaWRFeGNlZWRDUFVMaW1pdCgp IFRlcm1pbmF0aW5nIGJhY2tncm91bmQgV2ViUHJvY2VzcyB3aXRoIHBpZCAlZCB0aGF0IGhhcyBl eGNlZWRlZCB0aGUgYmFja2dyb3VuZCBDUFUgbGltaXQiLCB0aGlzLCBwcm9jZXNzSWRlbnRpZmll cigpKTsKICAgICBsb2dEaWFnbm9zdGljTWVzc2FnZUZvclJlc291cmNlTGltaXRUZXJtaW5hdGlv bihEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmV4Y2VlZGVkQmFja2dyb3VuZENQVUxpbWl0S2V5KCkp OwogICAgIHJlcXVlc3RUZXJtaW5hdGlvbihQcm9jZXNzVGVybWluYXRpb25SZWFzb246OkV4Y2Vl ZGVkQ1BVTGltaXQpOwogfQo=