173267 2017-06-12 10:51:35 -0700 Regression(r217867): Legacy SessionHistoryEntryData format should not change 2017-06-12 11:55:38 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 173033 1 cdumez cdumez andersca beidson ggaren sam simon.fraser webkit-bug-importer oldest_to_newest 1318287 0 cdumez 2017-06-12 10:51:35 -0700 Legacy SessionHistoryEntryData format should not change, to preserve compatibility. 1318288 1 cdumez 2017-06-12 10:51:51 -0700 <rdar://problem/32701257> 1318290 2 312678 cdumez 2017-06-12 10:54:35 -0700 Created attachment 312678 Patch 1318301 3 312678 simon.fraser 2017-06-12 11:24:09 -0700 Comment on attachment 312678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312678&action=review > Source/WebKit2/ChangeLog:10 > + as this apparently breaks compatiblity. Would be nice to explain a little more why. 1318313 4 312678 cdumez 2017-06-12 11:54:42 -0700 Comment on attachment 312678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312678&action=review >> Source/WebKit2/ChangeLog:10 >> + as this apparently breaks compatiblity. > > Would be nice to explain a little more why. I cc'd Sam and Anders to see if they can educate me. What I saw is that the legacy session state encoding / decoding code has quite a few "Encode / decode unused X field here to maintain format compatibility". So clearly, keeping the exact same format is important. Note that there is versioning but I tried bumping the version number and it did not help. My assumption is that the client (Safari?) relies on our current format somehow. 1318316 5 312678 cdumez 2017-06-12 11:55:36 -0700 Comment on attachment 312678 Patch Clearing flags on attachment: 312678 Committed r218121: <http://trac.webkit.org/changeset/218121> 1318317 6 cdumez 2017-06-12 11:55:38 -0700 All reviewed patches have been landed. Closing bug. 312678 2017-06-12 10:54:35 -0700 2017-06-12 11:55:36 -0700 Patch bug-173267-20170612105434.patch text/plain 6322 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTc0N2JmMDRiYjQ4OWZh ZWZkZTQ0MzUwZjU4ZDVkOWEzMWMxZGVlMC4uYzczM2NlNTU5ZTQ3MjkyYzc5YmY5YjM1NDA2ZmI1 NTE0NmM3YjBlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjE3ODY3 KTogTGVnYWN5IFNlc3Npb25IaXN0b3J5RW50cnlEYXRhIGZvcm1hdCBzaG91bGQgbm90IGNoYW5n ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMjY3 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjcwMTI1Nz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZlcnQgY2hhbmdlcyB0byBMZWdhY3kgU2Vz c2lvbkhpc3RvcnlFbnRyeURhdGEgZm9ybWF0IHRoYXQgd2VyZSBtYWRlIGluIHIyMTc4NjcsCisg ICAgICAgIGFzIHRoaXMgYXBwYXJlbnRseSBicmVha3MgY29tcGF0aWJsaXR5LgorCisgICAgICAg ICogVUlQcm9jZXNzL21hYy9MZWdhY3lTZXNzaW9uU3RhdGVDb2RpbmcuY3BwOgorICAgICAgICAo V2ViS2l0OjplbmNvZGVGcmFtZVN0YXRlTm9kZSk6CisgICAgICAgIChXZWJLaXQ6OmRlY29kZUJh Y2tGb3J3YXJkVHJlZU5vZGUpOgorCiAyMDE3LTA2LTEyICBEYWV3b29uZyBKYW5nICA8ZGFld29v bmcuamFuZ0BuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIFtDb29yZGluYXRlZEdyYXBoaWNzXSBC ZWhhdmlvciBjaGFuZ2Ugb2YgRHJhd2luZ0FyZWFJbXBsIGFmdGVyIHIyMTc3NzkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvTGVnYWN5U2Vzc2lvblN0YXRlQ29kaW5n LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvTGVnYWN5U2Vzc2lvblN0YXRlQ29k aW5nLmNwcAppbmRleCA1NGIyODEyYzMzZTBlMGQzN2M4N2VmZTcxYjY5ZjM2Y2ZjYzUwMjkxLi4x N2Y2NmI3MTc3OWMwNTQ5Y2Y2OGFlMjgxNjU4MThhNzI5ZDY2M2ZlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL0xlZ2FjeVNlc3Npb25TdGF0ZUNvZGluZy5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9MZWdhY3lTZXNzaW9uU3RhdGVDb2Rpbmcu Y3BwCkBAIC0zNDYsNyArMzQ2LDYgQEAgc3RhdGljIHZvaWQgZW5jb2RlRnJhbWVTdGF0ZU5vZGUo SGlzdG9yeUVudHJ5RGF0YUVuY29kZXImIGVuY29kZXIsIGNvbnN0IEZyYW1lU3QKICAgICBlbmNv ZGVyIDw8IGZyYW1lU3RhdGUuc2Nyb2xsUG9zaXRpb24ueCgpOwogICAgIGVuY29kZXIgPDwgZnJh bWVTdGF0ZS5zY3JvbGxQb3NpdGlvbi55KCk7CiAKLSAgICBlbmNvZGVyIDw8IGZyYW1lU3RhdGUu c2hvdWxkUmVzdG9yZVNjcm9sbFBvc2l0aW9uOwogICAgIGVuY29kZXIgPDwgZnJhbWVTdGF0ZS5w YWdlU2NhbGVGYWN0b3I7CiAKICAgICBlbmNvZGVyIDw8ICEhZnJhbWVTdGF0ZS5zdGF0ZU9iamVj dERhdGE7CkBAIC05MjksNyArOTI4LDYgQEAgc3RhdGljIHZvaWQgZGVjb2RlQmFja0ZvcndhcmRU cmVlTm9kZShIaXN0b3J5RW50cnlEYXRhRGVjb2RlciYgZGVjb2RlciwgRnJhbWVTdGEKIAogICAg IGZyYW1lU3RhdGUuc2Nyb2xsUG9zaXRpb24gPSBXZWJDb3JlOjpJbnRQb2ludChzY3JvbGxQb3Np dGlvblgsIHNjcm9sbFBvc2l0aW9uWSk7CiAKLSAgICBkZWNvZGVyID4+IGZyYW1lU3RhdGUuc2hv dWxkUmVzdG9yZVNjcm9sbFBvc2l0aW9uOwogICAgIGRlY29kZXIgPj4gZnJhbWVTdGF0ZS5wYWdl U2NhbGVGYWN0b3I7CiAKICAgICBib29sIGhhc1N0YXRlT2JqZWN0OwpkaWZmIC0tZ2l0IGEvVG9v bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGY0NGVlNjk1OGI1NDViOGJiZjcx ZTBjMGRkNDYyNWFjMjNjNmQwZDUuLjY5NzdkOTI5MWNhNmUyMDhmOGQyZTRmYjZlNWI3NTNkYmEx YTNiYTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwyMCBAQAorMjAxNy0wNi0xMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgorCisgICAgICAgIFJlZ3Jlc3Npb24ocjIxNzg2Nyk6IExlZ2FjeSBTZXNzaW9uSGlzdG9y eUVudHJ5RGF0YSBmb3JtYXQgc2hvdWxkIG5vdCBjaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzI2NworICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzI3MDEyNTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVzdHJpY3QgdGVzdCB0byBzdG9wIGNvdmVyaW5nIHNhdmluZyAvIHJlc3RvcmUgb2Yg c2Nyb2xsUmVzdG9yYXRpb24gdmlhIHRoZSBsZWdhY3kKKyAgICAgICAgU2Vzc2lvbkhpc3RvcnlF bnRyeURhdGEuIE1haW50YWluIGNvdmVyYWdlIGZvciB0aGUgZGVmYXVsdCB2YWx1ZSBvZiBzY3Jv bGxSZXN0b3JhdGlvbgorICAgICAgICB0aG91Z2ggYXMgdGhpcyBjb3ZlcnMgdGhlIGNyYXNoIHRo YXQgcjIxNzg2NyB3YXMgZml4aW5nLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXQyL1Jlc3RvcmVTZXNzaW9uU3RhdGUuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6 Y3JlYXRlU2Vzc2lvblN0YXRlRGF0YSk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToK KyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OmNyZWF0ZVNlc3Npb25TdGF0ZURhdGFDb250YWluaW5n U2Nyb2xsUmVzdG9yYXRpb24pOiBEZWxldGVkLgorCiAyMDE3LTA2LTEyICBNaWd1ZWwgR29tZXog IDxtYWdvbWV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBFbmFibGUgR1N0cmVh bWVyIEdMIG9uIGRldmVsb3BtZW50IGJ1aWxkcwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXQyL1Jlc3RvcmVTZXNzaW9uU3RhdGUuY3BwIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXQyL1Jlc3RvcmVTZXNzaW9uU3RhdGUuY3BwCmluZGV4IDNjYTk4 OTEzMmRhNmZhZDFhOGRiNmRmYmVmM2U0ZWQyZWVkOTMxZDEuLjM1NmI4ZTM1NmFjY2UyMDNhYTUx OGUxZjhiMmFmZDMzNzVhZTI5OWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Mi9SZXN0b3JlU2Vzc2lvblN0YXRlLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdDIvUmVzdG9yZVNlc3Npb25TdGF0ZS5jcHAKQEAgLTUzLDcgKzUzLDcg QEAgc3RhdGljIHZvaWQgc2V0UGFnZUxvYWRlckNsaWVudChXS1BhZ2VSZWYgcGFnZSkKICAgICBX S1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KHBhZ2UsICZsb2FkZXJDbGllbnQuYmFzZSk7CiB9CiAK LXN0YXRpYyBXS1JldGFpblB0cjxXS0RhdGFSZWY+IGNyZWF0ZVNlc3Npb25TdGF0ZURhdGFDb250 YWluaW5nU2Nyb2xsUmVzdG9yYXRpb24oV0tDb250ZXh0UmVmIGNvbnRleHQsIHN0ZDo6ZnVuY3Rp b248dm9pZChXS1BhZ2VSZWYpPiBhcHBseSkKK3N0YXRpYyBXS1JldGFpblB0cjxXS0RhdGFSZWY+ IGNyZWF0ZVNlc3Npb25TdGF0ZURhdGEoV0tDb250ZXh0UmVmIGNvbnRleHQpCiB7CiAgICAgUGxh dGZvcm1XZWJWaWV3IHdlYlZpZXcoY29udGV4dCk7CiAgICAgc2V0UGFnZUxvYWRlckNsaWVudCh3 ZWJWaWV3LnBhZ2UoKSk7CkBAIC02Miw1MiArNjIsMTAgQEAgc3RhdGljIFdLUmV0YWluUHRyPFdL RGF0YVJlZj4gY3JlYXRlU2Vzc2lvblN0YXRlRGF0YUNvbnRhaW5pbmdTY3JvbGxSZXN0b3JhdGlv bigKICAgICBVdGlsOjpydW4oJmRpZEZpbmlzaExvYWQpOwogICAgIGRpZEZpbmlzaExvYWQgPSBm YWxzZTsKIAotICAgIGFwcGx5KHdlYlZpZXcucGFnZSgpKTsKLQogICAgIGF1dG8gc2Vzc2lvblN0 YXRlID0gYWRvcHRXSyhzdGF0aWNfY2FzdDxXS1Nlc3Npb25TdGF0ZVJlZj4oV0tQYWdlQ29weVNl c3Npb25TdGF0ZSh3ZWJWaWV3LnBhZ2UoKSwgcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oMSksIG51 bGxwdHIpKSk7CiAgICAgcmV0dXJuIGFkb3B0V0soV0tTZXNzaW9uU3RhdGVDb3B5RGF0YShzZXNz aW9uU3RhdGUuZ2V0KCkpKTsKIH0KIAotVEVTVChXZWJLaXQyLCBSZXN0b3JlU2Vzc2lvblN0YXRl Q29udGFpbmluZ1Njcm9sbFJlc3RvcmF0aW9uTWFudWFsKQotewotICAgIFdLUmV0YWluUHRyPFdL Q29udGV4dFJlZj4gY29udGV4dChBZG9wdFdLLCBXS0NvbnRleHRDcmVhdGUoKSk7Ci0KLSAgICBQ bGF0Zm9ybVdlYlZpZXcgd2ViVmlldyhjb250ZXh0LmdldCgpKTsKLSAgICBzZXRQYWdlTG9hZGVy Q2xpZW50KHdlYlZpZXcucGFnZSgpKTsKLQotICAgIFdLUmV0YWluUHRyPFdLRGF0YVJlZj4gZGF0 YSA9IGNyZWF0ZVNlc3Npb25TdGF0ZURhdGFDb250YWluaW5nU2Nyb2xsUmVzdG9yYXRpb24oY29u dGV4dC5nZXQoKSwgW10oV0tQYWdlUmVmIHBhZ2UpIHsKLSAgICAgICAgRVhQRUNUX0pTX0VRKHBh Z2UsICJoaXN0b3J5LnNjcm9sbFJlc3RvcmF0aW9uID0gJ21hbnVhbCciLCAibWFudWFsIik7Ci0g ICAgfSk7Ci0gICAgRVhQRUNUX05PVF9OVUxMKGRhdGEpOwotCi0gICAgYXV0byBzZXNzaW9uU3Rh dGUgPSBhZG9wdFdLKFdLU2Vzc2lvblN0YXRlQ3JlYXRlRnJvbURhdGEoZGF0YS5nZXQoKSkpOwot ICAgIFdLUGFnZVJlc3RvcmVGcm9tU2Vzc2lvblN0YXRlKHdlYlZpZXcucGFnZSgpLCBzZXNzaW9u U3RhdGUuZ2V0KCkpOwotCi0gICAgVXRpbDo6cnVuKCZkaWRGaW5pc2hMb2FkKTsKLQotICAgIEVY UEVDVF9KU19FUSh3ZWJWaWV3LnBhZ2UoKSwgImhpc3Rvcnkuc2Nyb2xsUmVzdG9yYXRpb24iLCAi bWFudWFsIik7Ci19Ci0KLVRFU1QoV2ViS2l0MiwgUmVzdG9yZVNlc3Npb25TdGF0ZUNvbnRhaW5p bmdTY3JvbGxSZXN0b3JhdGlvbkF1dG8pCi17Ci0gICAgV0tSZXRhaW5QdHI8V0tDb250ZXh0UmVm PiBjb250ZXh0KEFkb3B0V0ssIFdLQ29udGV4dENyZWF0ZSgpKTsKLQotICAgIFBsYXRmb3JtV2Vi VmlldyB3ZWJWaWV3KGNvbnRleHQuZ2V0KCkpOwotICAgIHNldFBhZ2VMb2FkZXJDbGllbnQod2Vi Vmlldy5wYWdlKCkpOwotCi0gICAgV0tSZXRhaW5QdHI8V0tEYXRhUmVmPiBkYXRhID0gY3JlYXRl U2Vzc2lvblN0YXRlRGF0YUNvbnRhaW5pbmdTY3JvbGxSZXN0b3JhdGlvbihjb250ZXh0LmdldCgp LCBbXShXS1BhZ2VSZWYgcGFnZSkgewotICAgICAgICBFWFBFQ1RfSlNfRVEocGFnZSwgImhpc3Rv cnkuc2Nyb2xsUmVzdG9yYXRpb24gPSAnYXV0byciLCAiYXV0byIpOwotICAgIH0pOwotICAgIEVY UEVDVF9OT1RfTlVMTChkYXRhKTsKLQotICAgIGF1dG8gc2Vzc2lvblN0YXRlID0gYWRvcHRXSyhX S1Nlc3Npb25TdGF0ZUNyZWF0ZUZyb21EYXRhKGRhdGEuZ2V0KCkpKTsKLSAgICBXS1BhZ2VSZXN0 b3JlRnJvbVNlc3Npb25TdGF0ZSh3ZWJWaWV3LnBhZ2UoKSwgc2Vzc2lvblN0YXRlLmdldCgpKTsK LQotICAgIFV0aWw6OnJ1bigmZGlkRmluaXNoTG9hZCk7Ci0KLSAgICBFWFBFQ1RfSlNfRVEod2Vi Vmlldy5wYWdlKCksICJoaXN0b3J5LnNjcm9sbFJlc3RvcmF0aW9uIiwgImF1dG8iKTsKLX0KLQog VEVTVChXZWJLaXQyLCBSZXN0b3JlU2Vzc2lvblN0YXRlQ29udGFpbmluZ1Njcm9sbFJlc3RvcmF0 aW9uRGVmYXVsdCkKIHsKICAgICBXS1JldGFpblB0cjxXS0NvbnRleHRSZWY+IGNvbnRleHQoQWRv cHRXSywgV0tDb250ZXh0Q3JlYXRlKCkpOwpAQCAtMTE1LDggKzczLDcgQEAgVEVTVChXZWJLaXQy LCBSZXN0b3JlU2Vzc2lvblN0YXRlQ29udGFpbmluZ1Njcm9sbFJlc3RvcmF0aW9uRGVmYXVsdCkK ICAgICBQbGF0Zm9ybVdlYlZpZXcgd2ViVmlldyhjb250ZXh0LmdldCgpKTsKICAgICBzZXRQYWdl TG9hZGVyQ2xpZW50KHdlYlZpZXcucGFnZSgpKTsKIAotICAgIFdLUmV0YWluUHRyPFdLRGF0YVJl Zj4gZGF0YSA9IGNyZWF0ZVNlc3Npb25TdGF0ZURhdGFDb250YWluaW5nU2Nyb2xsUmVzdG9yYXRp b24oY29udGV4dC5nZXQoKSwgW10oV0tQYWdlUmVmKSB7Ci0gICAgfSk7CisgICAgV0tSZXRhaW5Q dHI8V0tEYXRhUmVmPiBkYXRhID0gY3JlYXRlU2Vzc2lvblN0YXRlRGF0YShjb250ZXh0LmdldCgp KTsKICAgICBFWFBFQ1RfTk9UX05VTEwoZGF0YSk7CiAKICAgICBhdXRvIHNlc3Npb25TdGF0ZSA9 IGFkb3B0V0soV0tTZXNzaW9uU3RhdGVDcmVhdGVGcm9tRGF0YShkYXRhLmdldCgpKSk7Cg==