173264 2017-06-12 09:21:41 -0700 Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqlite is initialized 2017-06-13 09:21:37 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue darin ggaren kling rniwa webkit-bug-importer oldest_to_newest 1318250 0 cdumez 2017-06-12 09:21:41 -0700 Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqlite is initialized. 1318252 1 312672 cdumez 2017-06-12 09:28:52 -0700 Created attachment 312672 Patch 1318253 2 cdumez 2017-06-12 09:29:13 -0700 <rdar://problem/30780050> 1318270 3 312672 rniwa 2017-06-12 10:13:57 -0700 Comment on attachment 312672 Patch Okay. Let's try this fix. 1318276 4 312672 cdumez 2017-06-12 10:28:44 -0700 Comment on attachment 312672 Patch Clearing flags on attachment: 312672 Committed r218108: <http://trac.webkit.org/changeset/218108> 1318277 5 cdumez 2017-06-12 10:28:46 -0700 All reviewed patches have been landed. Closing bug. 1318658 6 312672 darin 2017-06-13 09:02:09 -0700 Comment on attachment 312672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312672&action=review > Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:43 > +static bool isSQLiteMemoryPressureHandlerRegisted { false }; Typo here: "registed" instead of "registered". 1318666 7 cdumez 2017-06-13 09:21:37 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 312672 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312672&action=review > > > Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:43 > > +static bool isSQLiteMemoryPressureHandlerRegisted { false }; > > Typo here: "registed" instead of "registered". Thanks, I have fixed the typo in <http://trac.webkit.org/changeset/218178>. 312672 2017-06-12 09:28:52 -0700 2017-06-12 10:28:44 -0700 Patch bug-173264-20170612092851.patch text/plain 4020 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQyM2MxY2Q1MjliZTNh MDMyZjk3ODkzNTE3NWU5NTdhMGUyMGZmMy4uMTk2NDBlYTlhMDI3NDA5N2NhMDkxN2U0MmExZTgy NDJkYTJmZTgxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA2LTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FsbCBfc3FsaXRlM19wdXJn ZUVsaWdpYmxlUGFnZXJDYWNoZU1lbW9yeSgpIG9uIG1lbW9yeSBwcmVzc3VyZSBvbmx5IGlmIHNx bGl0ZSBpcyBpbml0aWFsaXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTczMjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2FsbCBfc3FsaXRlM19wdXJnZUVsaWdpYmxlUGFnZXJDYWNoZU1lbW9yeSgp IG9uIG1lbW9yeSBwcmVzc3VyZSBvbmx5IGlmIHNxbGl0ZSBpcyBpbml0aWFsaXplZC4KKyAgICAg ICAgT3RoZXJ3aXNlLCBub3Qgb25seSBpcyBpdCBubyBuZWVkZWQsIGl0IGlzIGFsc28gcG90ZW50 aWFsbHkgdW5zYWZlLgorCisgICAgICAgICogcGFnZS9NZW1vcnlSZWxlYXNlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OnJlZ2lzdGVyU1FMaXRlTWVtb3J5UHJlc3N1cmVIYW5kbGVyKToKKyAgICAg ICAgKiBwYWdlL01lbW9yeVJlbGVhc2UuaDoKKyAgICAgICAgKiBwYWdlL2NvY29hL01lbW9yeVJl bGVhc2VDb2NvYS5tbToKKyAgICAgICAgKFdlYkNvcmU6OnBsYXRmb3JtUmVsZWFzZU1lbW9yeSk6 CisgICAgICAgIChXZWJDb3JlOjpyZWdpc3RlclNRTGl0ZU1lbW9yeVByZXNzdXJlSGFuZGxlcik6 CisgICAgICAgICogcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmluaXRpYWxpemVTUUxpdGVJZk5lY2Vzc2FyeSk6CisKIDIwMTctMDYtMTIgIFphbiBE b2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHQ3J5cHRdIFVzZSB1 dGlsaXR5IGZ1bmN0aW9ucyBpbiBDcnlwdG9LZXlFQywgQ3J5cHRvS2V5UlNBCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL01lbW9yeVJlbGVhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9NZW1vcnlSZWxlYXNlLmNwcAppbmRleCAzNzMwODhiMzEwMzg1OWM1NWNjYTA0MDA3MTAw MWZiMTc2MGZjN2JkLi44MTA4ZjY1ZmMwNDgyYjQzZWU2MmFmNDEzNjUxZTcxOGVlN2YxY2MyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL01lbW9yeVJlbGVhc2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvTWVtb3J5UmVsZWFzZS5jcHAKQEAgLTE5MCw2ICsxOTAsNyBAQCB2 b2lkIGxvZ01lbW9yeVN0YXRpc3RpY3NBdFRpbWVPZkRlYXRoKCkKIHZvaWQgcGxhdGZvcm1SZWxl YXNlTWVtb3J5KENyaXRpY2FsKSB7IH0KIHZvaWQgamV0dGlzb25FeHBlbnNpdmVPYmplY3RzT25U b3BMZXZlbE5hdmlnYXRpb24oKSB7IH0KIHZvaWQgcmVnaXN0ZXJNZW1vcnlSZWxlYXNlTm90aWZ5 Q2FsbGJhY2tzKCkgeyB9Cit2b2lkIHJlZ2lzdGVyU1FMaXRlTWVtb3J5UHJlc3N1cmVIYW5kbGVy KCkgeyB9CiAjZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9NZW1vcnlSZWxlYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL01l bW9yeVJlbGVhc2UuaAppbmRleCBhMzcyYTVkYzZjMjkxZjc0N2JkOGM1YWMxN2I2OTc1NDIxZjQx ODI1Li41NGVkZTQwZWE5YWM5ZWZmYzc5NjQ4ODY3NDAxNjU1NzZiZWNhY2M2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL01lbW9yeVJlbGVhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL01lbW9yeVJlbGVhc2UuaApAQCAtMzQsNSArMzQsNiBAQCB2b2lkIHBsYXRmb3JtUmVs ZWFzZU1lbW9yeShDcml0aWNhbCk7CiB2b2lkIGpldHRpc29uRXhwZW5zaXZlT2JqZWN0c09uVG9w TGV2ZWxOYXZpZ2F0aW9uKCk7CiBXRUJDT1JFX0VYUE9SVCB2b2lkIHJlZ2lzdGVyTWVtb3J5UmVs ZWFzZU5vdGlmeUNhbGxiYWNrcygpOwogV0VCQ09SRV9FWFBPUlQgdm9pZCBsb2dNZW1vcnlTdGF0 aXN0aWNzQXRUaW1lT2ZEZWF0aCgpOwordm9pZCByZWdpc3RlclNRTGl0ZU1lbW9yeVByZXNzdXJl SGFuZGxlcigpOwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL2NvY29hL01lbW9yeVJlbGVhc2VDb2NvYS5tbSBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvY29jb2EvTWVtb3J5UmVsZWFzZUNvY29hLm1tCmluZGV4IGQ3OTMyZWVhYTc5NTY5ZjZk MGY1MDExMDdjYTgxZTllYzk2YTIzYzQuLmY4YjY0YTc3OGU4MWQ4MjAzZDk0NzM3NDJiMzA1ZmY0 OTNlMzM0NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvY29jb2EvTWVtb3J5UmVs ZWFzZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvY29jb2EvTWVtb3J5UmVsZWFz ZUNvY29hLm1tCkBAIC00MCw2ICs0MCw4IEBACiAKIGV4dGVybiAiQyIgdm9pZCBfc3FsaXRlM19w dXJnZUVsaWdpYmxlUGFnZXJDYWNoZU1lbW9yeSh2b2lkKTsKIAorc3RhdGljIGJvb2wgaXNTUUxp dGVNZW1vcnlQcmVzc3VyZUhhbmRsZXJSZWdpc3RlZCB7IGZhbHNlIH07CisKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogdm9pZCBwbGF0Zm9ybVJlbGVhc2VNZW1vcnkoQ3JpdGljYWwpCkBAIC00OCw3 ICs1MCw4IEBAIHZvaWQgcGxhdGZvcm1SZWxlYXNlTWVtb3J5KENyaXRpY2FsKQogICAgIEdTRm9u dFB1cmdlRm9udENhY2hlKCk7CiAjZW5kaWYKIAotICAgIF9zcWxpdGUzX3B1cmdlRWxpZ2libGVQ YWdlckNhY2hlTWVtb3J5KCk7CisgICAgaWYgKGlzU1FMaXRlTWVtb3J5UHJlc3N1cmVIYW5kbGVy UmVnaXN0ZWQpCisgICAgICAgIF9zcWxpdGUzX3B1cmdlRWxpZ2libGVQYWdlckNhY2hlTWVtb3J5 KCk7CiAKICAgICBmb3IgKGF1dG8mIHBvb2wgOiBMYXllclBvb2w6OmFsbExheWVyUG9vbHMoKSkK ICAgICAgICAgcG9vbC0+ZHJhaW4oKTsKQEAgLTEwMCw0ICsxMDMsOSBAQCB2b2lkIHJlZ2lzdGVy TWVtb3J5UmVsZWFzZU5vdGlmeUNhbGxiYWNrcygpCiAgICAgfSk7CiB9CiAKK3ZvaWQgcmVnaXN0 ZXJTUUxpdGVNZW1vcnlQcmVzc3VyZUhhbmRsZXIoKQoreworICAgIGlzU1FMaXRlTWVtb3J5UHJl c3N1cmVIYW5kbGVyUmVnaXN0ZWQgPSB0cnVlOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNwcAppbmRl eCBkMDNkYzBlNDkwYTJhOGZhZTZkNmY0MGZmMTE3ZDhkNDYzN2Y2ZmJhLi44NmM0ZDdhODI5NGY5 YmI5OTI4Nzc5NDI2NWI2Y2NhYjYyNDNkNWU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHAKQEAgLTI5LDYgKzI5LDcgQEAKIAogI2luY2x1ZGUg IkRhdGFiYXNlQXV0aG9yaXplci5oIgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKKyNpbmNsdWRlICJN ZW1vcnlSZWxlYXNlLmgiCiAjaW5jbHVkZSAiU1FMaXRlRmlsZVN5c3RlbS5oIgogI2luY2x1ZGUg IlNRTGl0ZVN0YXRlbWVudC5oIgogI2luY2x1ZGUgPG11dGV4PgpAQCAtNjYsNiArNjcsNyBAQCBz dGF0aWMgdm9pZCBpbml0aWFsaXplU1FMaXRlSWZOZWNlc3NhcnkoKQogI2VuZGlmCiAgICAgICAg ICAgICBDUkFTSCgpOwogICAgICAgICB9CisgICAgICAgIHJlZ2lzdGVyU1FMaXRlTWVtb3J5UHJl c3N1cmVIYW5kbGVyKCk7CiAgICAgfSk7CiB9CiAK