173258 2017-06-12 05:05:43 -0700 [GTK] fast/scrolling/scrolling-tree-includes-frame.html expected to fail 2017-06-12 20:10:29 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1318175 0 cturner 2017-06-12 05:05:43 -0700 fast/scrolling/scrolling-tree-includes-frame.html will only pass when PLATFORM(ios) is defined from what I can tell. Mark as expected failure in GTK. 1318186 1 312655 cturner 2017-06-12 05:30:37 -0700 Created attachment 312655 Patch 1318188 2 312655 mcatanzaro 2017-06-12 05:48:31 -0700 Comment on attachment 312655 Patch Thanks. First off, notice that you put it in the section of the TestExpectations file for passing tests (section 10), it should instead go in the section for expected failures (section 2). If this test can only pass on iOS, then it should be marked as an expected failure in the global TestExpectations file, and marked as a Pass in the iOS expectations file. In that case, it should already be marked as Failure in the Mac expectations, so you'll have to remove it from there too. Lastly, don't include a link to a bug report, since that's to be used for actual problems with reports that are to be left open until resolved, but if in this case it's expected that the test fails and we don't ever want to make it pass, that's not appropriate. Just leave a one-line comment explaining why the test is expected to fail. 1318209 3 cturner 2017-06-12 06:52:19 -0700 Oops, thanks for pointing that out. It looks like it passes on Sierra too. I will investigate a bit more deeply to find out if it should be disabled in global expectations file. I don't have Mac to test on unfortunately. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=fast%2Fscrolling%2Fscrolling-tree-includes-frame.html 1318227 4 cturner 2017-06-12 08:17:40 -0700 I got some extra clarification on this. It seems like GTK does not support the scrolling tree so this test isn't relevant to our port, or WK1. There's an empty text reference for WK1 (https://trac.webkit.org/browser/webkit/trunk/LayoutTests/platform/mac-wk1/fast/scrolling/scrolling-tree-includes-frame-expected.txt?rev=217730) should we do the same for GTK, or mark it as expected fail? 1318230 5 cgarcia 2017-06-12 08:24:42 -0700 I think we should skip it. 1318234 6 312665 cturner 2017-06-12 08:39:18 -0700 Created attachment 312665 Patch 1318293 7 312665 mcatanzaro 2017-06-12 11:03:46 -0700 Comment on attachment 312665 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312665&action=review OK except for the debugging code > Source/WebCore/html/HTMLMediaElement.cpp:1183 > + CRASH(); Remove this debugging code 1318303 8 312679 cturner 2017-06-12 11:28:42 -0700 Created attachment 312679 Patch 1318304 9 cturner 2017-06-12 11:29:24 -0700 Sorry about that Michael :( -- dirtied my tree by mistake. 1318546 10 312679 commit-queue 2017-06-12 20:10:27 -0700 Comment on attachment 312679 Patch Clearing flags on attachment: 312679 Committed r218162: <http://trac.webkit.org/changeset/218162> 1318547 11 commit-queue 2017-06-12 20:10:29 -0700 All reviewed patches have been landed. Closing bug. 312655 2017-06-12 05:30:37 -0700 2017-06-12 08:39:14 -0700 Patch bug-173258-20170612133036.patch text/plain 1715 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDk1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjQ4M2Y2NDQ1NzQ5NWQzYTBkYzM3 NzkyMmQ3MTA4ODdlNzUxMTc0OS4uYzgxYzQ3ZTY0ZjI4YmJmMDUxM2M0YTY3ZDZiMTlhMGI1Nzhj NzljMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTA2LTEyICBDaGFybGllIFR1cm5lciAg PGN0dXJuZXJAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBmYXN0L3Njcm9sbGluZy9zY3Jv bGxpbmctdHJlZS1pbmNsdWRlcy1mcmFtZS5odG1sIGV4cGVjdGVkIHRvIGZhaWwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzI1OAorCisgICAgICAg IFVucmV2aWV3ZWQgZ2FyZGVuaW5nLgorCisgICAgICAgIFRlc3Qgb25seSBwYXNzZXMgd2hlbiBT Y3JvbGxpbmdUcmVlSW5jbHVkZXNGcmFtZXM9dHJ1ZSBhbmQgdGhhdCdzIG9ubHkgc2V0IHdoZW4K KyAgICAgICAgUExBVEZPUk0oSU9TKSBpcyB0cnVlLiBFeHBlY3RlZCBmYWlsIG9uIEdUSy4gU2Vl IGFsc28gcjIxNzczMC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z OgorCisyMDE3LTA2LTEyICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKwog ICAgICAgICBNYXJrIGZhc3QvbWVkaWFzdHJlYW0vZ2V0VXNlck1lZGlhLWdyYW50LXBlcnNpc3Rl bmN5My5odG1sIGFzIGZsYWt5LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTczMjU3CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3Rh dGlvbnMKaW5kZXggMDI5OWUzMDEyNjFkMmQ3MDk3OGEyMThkOTg0YzJkZWNlMWJiMjJkZS4uODc0 ZGFkOTI4ZmM4MTA4ZjRmMWY1NTBmZmZjMjk0Yzg3NDQ3YTQ4NCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM0ODgsNiArMzQ4OCw4IEBAIGZhc3Qvc2Ny b2xsaW5nL3J0bC1zY3JvbGxiYXJzLWFsdGVybmF0ZS1ib2R5LWRpci1hdHRyLWRvZXMtbm90LXVw ZGF0ZS1zY3JvbGxiYXItCiBmYXN0L3Njcm9sbGluZy9ydGwtc2Nyb2xsYmFycy1hbHRlcm5hdGUt Ym9keS1kaXItYXR0ci1kb2VzLW5vdC11cGRhdGUtc2Nyb2xsYmFyLXBsYWNlbWVudC0yLmh0bWwg WyBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xNTY0MzcgZmFzdC9zY3JvbGxpbmcvcnRsLXNjcm9sbGJh cnMtbGlzdGJveC1zY3JvbGwuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCiAKK3dlYmtp dC5vcmcvYi8xNzMyNTggZmFzdC9zY3JvbGxpbmcvc2Nyb2xsaW5nLXRyZWUtaW5jbHVkZXMtZnJh bWUuaHRtbCBbIEZhaWx1cmUgXQorCiAjIFdlIGRvbid0IHN1cHBvcnQgZW1vamkgZ2VuZGVycywg YnV0IGhhbGYgdGhlIHJlZnRlc3RzIHBhc3MgYW55d2F5LgogZmFzdC90ZXh0L2Vtb2ppLWdlbmRl ci0yLTMuaHRtbCBbIFBhc3MgXQogZmFzdC90ZXh0L2Vtb2ppLWdlbmRlci0yLTQuaHRtbCBbIFBh c3MgXQo= 312665 2017-06-12 08:39:18 -0700 2017-06-12 11:28:39 -0700 Patch bug-173258-20170612163916.patch text/plain 2123 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcAppbmRleCAzMGMyMjllZTViNzdiZDcxZTI3M2IxN2NhY2ZlNmU5YTViYWM2ODJj Li4yZWEwMzg3ZmVmMGIzYmY5ZmU2YjY0OTQ3NjU4N2RjMmI5NThhODkyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTExODAsNiArMTE4MCw3IEBAIHZvaWQg SFRNTE1lZGlhRWxlbWVudDo6cHJlcGFyZUZvckxvYWQoKQogICAgIG1fbG9hZFN0YXRlID0gV2Fp dGluZ0ZvclNvdXJjZTsKICAgICBtX2N1cnJlbnRTb3VyY2VOb2RlID0gbnVsbHB0cjsKIAorICAg IENSQVNIKCk7CiAgICAgY3JlYXRlTWVkaWFQbGF5ZXIoKTsKIAogICAgIC8vIDIgLSBMZXQgcGVu ZGluZyB0YXNrcyBiZSBhIGxpc3Qgb2YgYWxsIHRhc2tzIGZyb20gdGhlIG1lZGlhIGVsZW1lbnQn cyBtZWRpYSBlbGVtZW50IGV2ZW50IHRhc2sgc291cmNlIGluIG9uZSBvZiB0aGUgdGFzayBxdWV1 ZXMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggYjQ4M2Y2NDQ1NzQ5NWQzYTBkYzM3NzkyMmQ3MTA4ODdlNzUxMTc0OS4uNjUz MTY1ZTAxYzYxOWFiNzljODA3MzVhNmUzNzgwZGZlY2NjOTlhMSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDE3LTA2LTEyICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KIAor ICAgICAgICBbR1RLXSBza2lwIGZhc3Qvc2Nyb2xsaW5nL3Njcm9sbGluZy10cmVlLWluY2x1ZGVz LWZyYW1lLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MzI1OAorCisgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLgorCisgICAgICAgIEdU SyBkb2Vzbid0IGFwcGVhciB0byB1c2UgdGhlIHNjcm9sbGluZyB0cmVlLCBvbmx5IFdLMiBNYWMg YW5kIGlPUyBkby4gU2tpcCBpdCBoZXJlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnM6CisKKzIwMTctMDYtMTIgIENoYXJsaWUgVHVybmVyICA8Y3R1cm5lckBpZ2Fs aWEuY29tPgorCiAgICAgICAgIE1hcmsgZmFzdC9tZWRpYXN0cmVhbS9nZXRVc2VyTWVkaWEtZ3Jh bnQtcGVyc2lzdGVuY3kzLmh0bWwgYXMgZmxha3kuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMyNTcKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv VGVzdEV4cGVjdGF0aW9ucwppbmRleCAwMjk5ZTMwMTI2MWQyZDcwOTc4YTIxOGQ5ODRjMmRlY2Ux YmIyMmRlLi4xZTg0MTQyZGY0NWUwMTljM2MwNDZjZDk1YjM5MGY4NzNkODBiMTg1IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTI3Myw2ICsxMjczLDkg QEAgZmFzdC9jYW52YXMvd2ViZ3B1IFsgU2tpcCBdCiAjIFdlIGRvbid0IHN1cHBvcnQgQVBQTEVf UEFZLgogaHR0cC90ZXN0cy9zc2wvYXBwbGVwYXkgWyBTa2lwIF0KIAorIyBHVEsgcG9ydCBkb2Vz bid0IHVzZSB0aGUgc2Nyb2xsaW5nIHRyZWUKK2Zhc3Qvc2Nyb2xsaW5nL3Njcm9sbGluZy10cmVl LWluY2x1ZGVzLWZyYW1lLmh0bWwgWyBTa2lwIF0KKwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8KICMgRW5kIG9mIEV4cGVjdGVkIGZhaWx1cmVzCiAjLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLwo= 312679 2017-06-12 11:28:42 -0700 2017-06-12 20:10:27 -0700 Patch bug-173258-20170612192841.patch text/plain 1520 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDk1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjQ4M2Y2NDQ1NzQ5NWQzYTBkYzM3 NzkyMmQ3MTA4ODdlNzUxMTc0OS4uNjUzMTY1ZTAxYzYxOWFiNzljODA3MzVhNmUzNzgwZGZlY2Nj OTlhMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTA2LTEyICBDaGFybGllIFR1cm5lciAg PGN0dXJuZXJAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBza2lwIGZhc3Qvc2Nyb2xsaW5n L3Njcm9sbGluZy10cmVlLWluY2x1ZGVzLWZyYW1lLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzI1OAorCisgICAgICAgIFVucmV2aWV3ZWQg Z2FyZGVuaW5nLgorCisgICAgICAgIEdUSyBkb2Vzbid0IGFwcGVhciB0byB1c2UgdGhlIHNjcm9s bGluZyB0cmVlLCBvbmx5IFdLMiBNYWMgYW5kIGlPUyBkby4gU2tpcCBpdCBoZXJlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKKzIwMTctMDYtMTIgIENoYXJs aWUgVHVybmVyICA8Y3R1cm5lckBpZ2FsaWEuY29tPgorCiAgICAgICAgIE1hcmsgZmFzdC9tZWRp YXN0cmVhbS9nZXRVc2VyTWVkaWEtZ3JhbnQtcGVyc2lzdGVuY3kzLmh0bWwgYXMgZmxha3kuCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMyNTcKIApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAwMjk5ZTMwMTI2 MWQyZDcwOTc4YTIxOGQ5ODRjMmRlY2UxYmIyMmRlLi4xZTg0MTQyZGY0NWUwMTljM2MwNDZjZDk1 YjM5MGY4NzNkODBiMTg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0 aW9ucwpAQCAtMTI3Myw2ICsxMjczLDkgQEAgZmFzdC9jYW52YXMvd2ViZ3B1IFsgU2tpcCBdCiAj IFdlIGRvbid0IHN1cHBvcnQgQVBQTEVfUEFZLgogaHR0cC90ZXN0cy9zc2wvYXBwbGVwYXkgWyBT a2lwIF0KIAorIyBHVEsgcG9ydCBkb2Vzbid0IHVzZSB0aGUgc2Nyb2xsaW5nIHRyZWUKK2Zhc3Qv c2Nyb2xsaW5nL3Njcm9sbGluZy10cmVlLWluY2x1ZGVzLWZyYW1lLmh0bWwgWyBTa2lwIF0KKwog Iy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIEV4cGVjdGVkIGZhaWx1 cmVzCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwo=