173245 2017-06-11 15:55:28 -0700 [Mac] Unaligned pointers in static CMBufferCallbacks structs defined in WebCoreDecompressionSession.mm 2017-06-11 18:57:36 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz buildbot commit-queue sam oldest_to_newest 1318064 0 mitz 2017-06-11 15:55:28 -0700 When building WebCore with the Xcode 9 public beta, the linker warns that pointers in the CMBufferCallbacks structs defined in WebCoreDecompressionSession are not 8-byte aligned. 1318072 1 312625 mitz 2017-06-11 16:03:28 -0700 Created attachment 312625 Align the structs 1318073 2 mitz 2017-06-11 16:05:26 -0700 (In reply to mitz from comment #0) > Xcode 9 public beta Mean to say developer beta. 1318074 3 buildbot 2017-06-11 16:05:41 -0700 Attachment 312625 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:137: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:158: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1318083 4 312625 sam 2017-06-11 16:27:22 -0700 Comment on attachment 312625 Align the structs Can we use alignas instead? 1318084 5 mitz 2017-06-11 16:30:25 -0700 (In reply to Sam Weinig from comment #4) > Comment on attachment 312625 [details] > Align the structs > > Can we use alignas instead? How? 1318096 6 sam 2017-06-11 18:23:15 -0700 I played around and couldn't figure out a way to use it that wasn't more verbose than this. 1318098 7 312625 commit-queue 2017-06-11 18:57:34 -0700 Comment on attachment 312625 Align the structs Clearing flags on attachment: 312625 Committed r218081: <http://trac.webkit.org/changeset/218081> 1318099 8 commit-queue 2017-06-11 18:57:36 -0700 All reviewed patches have been landed. Closing bug. 312625 2017-06-11 16:03:28 -0700 2017-06-11 18:57:34 -0700 Align the structs bug-173245-20170611160327.patch text/plain 3436 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODA3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA2LTExICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gVW5hbGlnbmVkIHBvaW50 ZXJzIGluIHN0YXRpYyBDTUJ1ZmZlckNhbGxiYWNrcyBzdHJ1Y3RzIGRlZmluZWQgaW4gV2ViQ29y ZURlY29tcHJlc3Npb25TZXNzaW9uLm1tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzMyNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkNvcmVEZWNvbXBy ZXNzaW9uU2Vzc2lvbi5tbToKKyAgICAgICAgKFdlYkNvcmU6OldlYkNvcmVEZWNvbXByZXNzaW9u U2Vzc2lvbjo6ZW5xdWV1ZVNhbXBsZSk6IFByZXBlbmQgNCBieXRlcyBvZiBwYWRkaW5nIHRvIHRo ZQorICAgICAgICAgIHN0cnVjdHMgc28gdGhhdCB0aGUgcG9pbnRlcnMgYXJlIHByb3Blcmx5IGFs aWduZWQuCisKIDIwMTctMDYtMTEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIxNzg3MCk6IE51bGwgZGVyZWYgdW5kZXIgUGFn ZU92ZXJsYXlDb250cm9sbGVyOjp1bmluc3RhbGxQYWdlT3ZlcmxheSB1c2luZyBmaW5kIGluIHBh Z2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkNvcmVE ZWNvbXByZXNzaW9uU2Vzc2lvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJDb3JlRGVjb21wcmVzc2lvblNlc3Npb24ubW0JKHJldmlz aW9uIDIxODA1NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dl YkNvcmVEZWNvbXByZXNzaW9uU2Vzc2lvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMTIzLDkgKzEy MywxOCBAQCB2b2lkIFdlYkNvcmVEZWNvbXByZXNzaW9uU2Vzc2lvbjo6ZW5xdWV1CiAgICAgaWYg KCFtX2RlY29tcHJlc3Npb25RdWV1ZSkKICAgICAgICAgbV9kZWNvbXByZXNzaW9uUXVldWUgPSBh ZG9wdE9TT2JqZWN0KGRpc3BhdGNoX3F1ZXVlX2NyZWF0ZSgiU291cmNlQnVmZmVyUHJpdmF0ZUFW Rk9iakMgRGVjb21wcmVzc2lvbiBRdWV1ZSIsIERJU1BBVENIX1FVRVVFX1NFUklBTCkpOwogCisg ICAgLy8gQ01CdWZmZXJDYWxsYmFja3MgY29udGFpbnMgNjQtYml0IHBvaW50ZXJzIHRoYXQgYXJl bid0IDgtYnl0ZSBhbGlnbmVkLiBUbyBzdXBwcmVzcyB0aGUgbGlua2VyCisgICAgLy8gd2Fybmlu ZyBhYm91dCB0aGlzLCB3ZSBwcmVwZW5kIDQgYnl0ZXMgb2YgcGFkZGluZyB3aGVuIGJ1aWxkaW5n IGZvciBtYWNPUy4KKyNpZiBQTEFURk9STShNQUMpCisgICAgY29uc3Qgc2l6ZV90IHBhZFNpemUg PSA0OworI2Vsc2UKKyAgICBjb25zdCBzaXplX3QgcGFkU2l6ZSA9IDA7CisjZW5kaWYKKwogICAg IGlmICghbV9wcm9kdWNlclF1ZXVlKSB7CiAgICAgICAgIENNQnVmZmVyUXVldWVSZWYgb3V0UXVl dWUgeyBudWxscHRyIH07Ci0gICAgICAgIENNQnVmZmVyQ2FsbGJhY2tzIGNhbGxiYWNrcyB7Cisj cHJhZ21hIHBhY2socHVzaCwgNCkKKyAgICAgICAgc3RydWN0IHsgdWludDhfdCBwYWRbcGFkU2l6 ZV07IENNQnVmZmVyQ2FsbGJhY2tzIGNhbGxiYWNrczsgfSBjYWxsYmFja3MgeyB7IH0sIHsKICAg ICAgICAgICAgIDAsCiAgICAgICAgICAgICBudWxscHRyLAogICAgICAgICAgICAgJmdldERlY29k ZVRpbWUsCkBAIC0xMzUsOCArMTQ0LDkgQEAgdm9pZCBXZWJDb3JlRGVjb21wcmVzc2lvblNlc3Np b246OmVucXVldQogICAgICAgICAgICAgJmNvbXBhcmVCdWZmZXJzLAogICAgICAgICAgICAgbnVs bHB0ciwKICAgICAgICAgICAgIG51bGxwdHIsCi0gICAgICAgIH07Ci0gICAgICAgIENNQnVmZmVy UXVldWVDcmVhdGUoa0NGQWxsb2NhdG9yRGVmYXVsdCwga01heGltdW1DYXBhY2l0eSwgJmNhbGxi YWNrcywgJm91dFF1ZXVlKTsKKyAgICAgICAgfSB9OworI3ByYWdtYSBwYWNrKHBvcCkKKyAgICAg ICAgQ01CdWZmZXJRdWV1ZUNyZWF0ZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBrTWF4aW11bUNhcGFj aXR5LCAmY2FsbGJhY2tzLmNhbGxiYWNrcywgJm91dFF1ZXVlKTsKICAgICAgICAgbV9wcm9kdWNl clF1ZXVlID0gYWRvcHRDRihvdXRRdWV1ZSk7CiAKICAgICAgICAgQ01CdWZmZXJRdWV1ZUluc3Rh bGxUcmlnZ2VyV2l0aEludGVnZXJUaHJlc2hvbGQobV9wcm9kdWNlclF1ZXVlLmdldCgpLCBtYXli ZUJlY29tZVJlYWR5Rm9yTW9yZU1lZGlhRGF0YUNhbGxiYWNrLCB0aGlzLCBrQ01CdWZmZXJRdWV1 ZVRyaWdnZXJfV2hlbkJ1ZmZlckNvdW50QmVjb21lc0xlc3NUaGFuLCBrTG93V2F0ZXJNYXJrLCAm bV9kaWRCZWNvbWVSZWFkeVRyaWdnZXIpOwpAQCAtMTQ0LDcgKzE1NCw4IEBAIHZvaWQgV2ViQ29y ZURlY29tcHJlc3Npb25TZXNzaW9uOjplbnF1ZXUKIAogICAgIGlmICghbV9jb25zdW1lclF1ZXVl KSB7CiAgICAgICAgIENNQnVmZmVyUXVldWVSZWYgb3V0UXVldWUgeyBudWxscHRyIH07Ci0gICAg ICAgIENNQnVmZmVyQ2FsbGJhY2tzIGNhbGxiYWNrcyB7CisjcHJhZ21hIHBhY2socHVzaCwgNCkK KyAgICAgICAgc3RydWN0IHsgdWludDhfdCBwYWRbcGFkU2l6ZV07IENNQnVmZmVyQ2FsbGJhY2tz IGNhbGxiYWNrczsgfSBjYWxsYmFja3MgeyB7IH0sIHsKICAgICAgICAgICAgIDAsCiAgICAgICAg ICAgICBudWxscHRyLAogICAgICAgICAgICAgJmdldERlY29kZVRpbWUsCkBAIC0xNTQsOCArMTY1 LDkgQEAgdm9pZCBXZWJDb3JlRGVjb21wcmVzc2lvblNlc3Npb246OmVucXVldQogICAgICAgICAg ICAgJmNvbXBhcmVCdWZmZXJzLAogICAgICAgICAgICAgbnVsbHB0ciwKICAgICAgICAgICAgIG51 bGxwdHIsCi0gICAgICAgIH07Ci0gICAgICAgIENNQnVmZmVyUXVldWVDcmVhdGUoa0NGQWxsb2Nh dG9yRGVmYXVsdCwga01heGltdW1DYXBhY2l0eSwgJmNhbGxiYWNrcywgJm91dFF1ZXVlKTsKKyAg ICAgICAgfSB9OworI3ByYWdtYSBwYWNrKHBvcCkKKyAgICAgICAgQ01CdWZmZXJRdWV1ZUNyZWF0 ZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBrTWF4aW11bUNhcGFjaXR5LCAmY2FsbGJhY2tzLmNhbGxi YWNrcywgJm91dFF1ZXVlKTsKICAgICAgICAgbV9jb25zdW1lclF1ZXVlID0gYWRvcHRDRihvdXRR dWV1ZSk7CiAgICAgfQogCg==