173241 2017-06-11 11:47:50 -0700 Switch off Legacy WebRTC API flag by default 2017-08-25 09:04:16 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue eric.carlson jonlee sam ultravistor oldest_to_newest 1318036 0 youennf 2017-06-11 11:47:50 -0700 Switch off Legacy WebRTC API flag by default 1318037 1 312615 youennf 2017-06-11 11:49:03 -0700 Created attachment 312615 Patch 1318040 2 312615 sam 2017-06-11 12:28:11 -0700 Comment on attachment 312615 Patch Seems fine, but you need to update. Does this really belong in experimental settings if it's off? 1318054 3 youennf 2017-06-11 14:54:02 -0700 Thanks for the review. (In reply to Sam Weinig from comment #2) > Comment on attachment 312615 [details] > Patch > > Seems fine, but you need to update. Does this really belong in experimental > settings if it's off? Some of the experimental features are activated by default, others are not. Plan is to remove that option altogether if we see that switching it off is fine. We could then get rid of any legacy API code. 1318122 4 312637 youennf 2017-06-11 23:46:01 -0700 Created attachment 312637 Patch for landing 1318597 5 312637 commit-queue 2017-06-13 01:19:39 -0700 Comment on attachment 312637 Patch for landing Clearing flags on attachment: 312637 Committed r218169: <http://trac.webkit.org/changeset/218169> 1318598 6 commit-queue 2017-06-13 01:19:41 -0700 All reviewed patches have been landed. Closing bug. 1342388 7 ultravistor 2017-08-25 08:05:35 -0700 Know this is too late but I'm not happy with this switch enabled by default. Already too many work has been required to make an alignment in video-related scripts across browsers which made harder for developers to move fast. e.g. Frequent change on autostart policy (this is getting better recently though), No MediaSourceExtension API support in iOS Safari, No h.264 support in Chrome Android etc. 1342391 8 youennf 2017-08-25 08:40:58 -0700 (In reply to Takahiro Ichihashi from comment #7) > Know this is too late but I'm not happy with this switch enabled by default. Providing legacy API support within WebKit would just add another flavor of well known but not well defined APIs. It makes it somehow easy at the beginning and painful at the end. adapter.js is providing legacy API on top of WebKit API. I think it will make a better job at unifying the behaviors of no-longer specified APIS between browsers. > Already too many work has been required to make an alignment in > video-related scripts across browsers which made harder for developers to > move fast. e.g. Frequent change on autostart policy (this is getting better > recently though), No MediaSourceExtension API support in iOS Safari, No > h.264 support in Chrome Android etc. The WebRTC community is working on fixing discrepancies between the different implementations. Agreed that it will take some time though. WebKit target is to support WebRTC 1.0 spec once it gets finalized. 1342392 9 eric.carlson 2017-08-25 08:42:53 -0700 (In reply to Takahiro Ichihashi from comment #7) > Know this is too late but I'm not happy with this switch enabled by default. > Already too many work has been required to make an alignment in > video-related scripts across browsers which made harder for developers to > move fast. e.g. Frequent change on autostart policy (this is getting better > recently though), No MediaSourceExtension API support in iOS Safari, No > h.264 support in Chrome Android etc. @ultravistor - note that adapter.js has been updated to work with Safari, so you can use it to decrease the cross-browser differences. 1342395 10 ultravistor 2017-08-25 09:04:16 -0700 > adapter.js is providing legacy API on top of WebKit API. > @ultravistor - note that adapter.js has been updated to work with Safari, so you can use it to decrease the cross-browser differences. Thanks, now I really get it (following sentences in your blog post). "Many sites polyfill API support through the open source adapter.js project. Updating to the latest release is one way to cover for the API gap, but we recommend switching to the APIs listed in the specification." I will take a look into the adapter.js and try to migrate some of their polyfills. https://github.com/webrtc/adapter > The WebRTC community is working on fixing discrepancies between the different implementations. > Agreed that it will take some time though. > WebKit target is to support WebRTC 1.0 spec once it gets finalized. Yes. Baseline is that we are all happy to have webrtc finally landed in most major browsers. Thanks for your hard work. 312615 2017-06-11 11:49:03 -0700 2017-06-11 23:45:57 -0700 Patch bug-173241-20170611194901.patch text/plain 1616 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzRkNzNjZTZmZDdlNGFj MzQ1Nzc0Zjc1OTI0ZGRmMGYwOTUzNDdjYy4uZDBmODZkNWRmNzYxNDJhYjZlMTFhYzBhYzU4ZTQ0 MmExOWRjODUwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA2LTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBTd2l0Y2ggb2ZmIExlZ2Fj eSBXZWJSVEMgQVBJIGZsYWcgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5o OgorCiAyMDE3LTA2LTA4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBnZXRVc2VyTWVkaWEgc2hvdWxkIG5vdCBiZSBwcm9tcHRlZCBhZ2FpbiBpZiB1c2VyIGRl bmllZCBhY2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJl bmNlc0RlZmluaXRpb25zLmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNE ZWZpbml0aW9ucy5oCmluZGV4IGM0ODJmNTdlZGU0MzU3YTI5MDVkM2UzZTQyZDlmOTExZGNjNTJm NjMuLjg1YmQwMzBjOWRlNTI4Mzg0OTZlZjZhMzQ4MTBlNjIzYzc1MDRkYTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKKysrIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaApAQCAtMzYx LDcgKzM2MSw3IEBACiAgICAgbWFjcm8oV2ViR0wyRW5hYmxlZCwgd2ViR0wyRW5hYmxlZCwgQm9v bCwgYm9vbCwgZmFsc2UsICJXZWJHTCAyLjAiLCAiV2ViR0wgMiBwcm90b3R5cGUiKSBcCiAgICAg bWFjcm8oV2ViR1BVRW5hYmxlZCwgd2ViR1BVRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICJX ZWJHUFUiLCAiV2ViR1BVIHByb3RvdHlwZSIpIFwKICAgICBtYWNybyhEaXNwbGF5Q29udGVudHNF bmFibGVkLCBkaXNwbGF5Q29udGVudHNFbmFibGVkLCBCb29sLCBib29sLCBmYWxzZSwgImRpc3Bs YXk6IGNvbnRlbnRzIiwgIkVuYWJsZSBDU1MgZGlzcGxheTogY29udGVudHMgc3VwcG9ydCIpIFwK LSAgICBtYWNybyhXZWJSVENMZWdhY3lBUElEaXNhYmxlZCwgd2ViUlRDTGVnYWN5QVBJRGlzYWJs ZWQsIEJvb2wsIGJvb2wsIGZhbHNlLCAiUmVtb3ZlIExlZ2FjeSBXZWJSVEMgQVBJIiwgIlJlbW92 ZSBMZWdhY3kgV2ViUlRDIEFQSSIpIFwKKyAgICBtYWNybyhXZWJSVENMZWdhY3lBUElEaXNhYmxl ZCwgd2ViUlRDTGVnYWN5QVBJRGlzYWJsZWQsIEJvb2wsIGJvb2wsIHRydWUsICJSZW1vdmUgTGVn YWN5IFdlYlJUQyBBUEkiLCAiUmVtb3ZlIExlZ2FjeSBXZWJSVEMgQVBJIikgXAogICAgIFwKIAog I2lmIFBMQVRGT1JNKENPQ09BKQo= 312637 2017-06-11 23:46:01 -0700 2017-06-13 01:19:39 -0700 Patch for landing bug-173241-20170612074550.patch text/plain 2291 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzYwNGM5MDFkODI5MzNi ZjY4ZjhjM2E1ZjJiMTFiY2U4MjFmMWM0Yi4uMDExYjJhYTg1MjhkOGYzODBlMDVlYzBkY2FkOWFl ZTA1ODMwN2ZmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA2LTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBTd2l0Y2ggb2ZmIExlZ2Fj eSBXZWJSVEMgQVBJIGZsYWcgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdl aW5pZy4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmg6CisK IDIwMTctMDYtMTEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjIxNzg3MCk6IE51bGwgZGVyZWYgdW5kZXIgUGFnZU92ZXJsYXlD b250cm9sbGVyOjp1bmluc3RhbGxQYWdlT3ZlcmxheSB1c2luZyBmaW5kIGluIHBhZ2UKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgg Yi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCmluZGV4 IDllZDc4ZGZkOTZhZGQzMjMyYWEyMTg3YjlhMGZkMzllOTkwOTIyMjYuLjExOTdmMmVmYTQ4OWFj OWFmZjhlMjg1M2JjNDNlMGNkMWY3NDdkNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaApAQCAtMzU2LDcgKzM1Niw3IEBACiAgICAg bWFjcm8oRGlzcGxheUNvbnRlbnRzRW5hYmxlZCwgZGlzcGxheUNvbnRlbnRzRW5hYmxlZCwgQm9v bCwgYm9vbCwgZmFsc2UsICJDU1MgZGlzcGxheTogY29udGVudHMiLCAiRW5hYmxlIENTUyBkaXNw bGF5OiBjb250ZW50cyBzdXBwb3J0IikgXAogICAgIG1hY3JvKFNwcmluZ1RpbWluZ0Z1bmN0aW9u RW5hYmxlZCwgc3ByaW5nVGltaW5nRnVuY3Rpb25FbmFibGVkLCBCb29sLCBib29sLCBERUZBVUxU X0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVELCAiQ1NTIFNwcmluZyBBbmltYXRpb25zIiwg IkNTUyBTcHJpbmcgQW5pbWF0aW9uIHByb3RvdHlwZSIpIFwKICAgICBtYWNybyhMaW5rUHJlbG9h ZEVuYWJsZWQsIGxpbmtQcmVsb2FkRW5hYmxlZCwgQm9vbCwgYm9vbCwgREVGQVVMVF9FWFBFUklN RU5UQUxfRkVBVFVSRVNfRU5BQkxFRCwgIkxpbmsgUHJlbG9hZCIsICJMaW5rIHByZWxvYWQgc3Vw cG9ydCIpIFwKLSAgICBtYWNybyhXZWJSVENMZWdhY3lBUElEaXNhYmxlZCwgd2ViUlRDTGVnYWN5 QVBJRGlzYWJsZWQsIEJvb2wsIGJvb2wsIGZhbHNlLCAiUmVtb3ZlIExlZ2FjeSBXZWJSVEMgQVBJ IiwgIlJlbW92ZSBMZWdhY3kgV2ViUlRDIEFQSSIpIFwKKyAgICBtYWNybyhXZWJSVENMZWdhY3lB UElEaXNhYmxlZCwgd2ViUlRDTGVnYWN5QVBJRGlzYWJsZWQsIEJvb2wsIGJvb2wsIERFRkFVTFRf RVhQRVJJTUVOVEFMX0ZFQVRVUkVTX0VOQUJMRUQsICJSZW1vdmUgTGVnYWN5IFdlYlJUQyBBUEki LCAiUmVtb3ZlIExlZ2FjeSBXZWJSVEMgQVBJIikgXAogICAgIG1hY3JvKFN1YnJlc291cmNlSW50 ZWdyaXR5RW5hYmxlZCwgc3VicmVzb3VyY2VJbnRlZ3JpdHlFbmFibGVkLCBCb29sLCBib29sLCBE RUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVELCAiU3VicmVzb3VyY2VJbnRlZ3Jp dHkiLCAiRW5hYmxlIFN1YnJlc291cmNlSW50ZWdyaXR5IikgXAogICAgIG1hY3JvKFN1YnRsZUNy eXB0b0VuYWJsZWQsIHN1YnRsZUNyeXB0b0VuYWJsZWQsIEJvb2wsIGJvb2wsIERFRkFVTFRfRVhQ RVJJTUVOVEFMX0ZFQVRVUkVTX0VOQUJMRUQsICJTdWJ0bGVDcnlwdG8iLCAiRW5hYmxlIFN1YnRs ZUNyeXB0byBzdXBwb3J0IikgXAogICAgIG1hY3JvKFZpZXdwb3J0Rml0RW5hYmxlZCwgdmlld3Bv cnRGaXRFbmFibGVkLCBCb29sLCBib29sLCBERUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19F TkFCTEVELCAiVmlld3BvcnQgRml0IiwgIkVuYWJsZSB2aWV3cG9ydC1maXQgdmlld3BvcnQgcGFy YW1ldGVyIikgXAo=