173227 2017-06-10 10:46:45 -0700 [JSC] Update RegExp.prototype.[@@search]] implementation according to the latest spec 2017-06-11 00:53:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki keith_miller mark.lam msaboff saam oldest_to_newest 1317907 0 ysuzuki 2017-06-10 10:46:45 -0700 [JSC] Update RegExp.prototype.[@@search]] implementation according to the latest spec 1317908 1 312574 ysuzuki 2017-06-10 10:48:34 -0700 Created attachment 312574 Patch 1317910 2 312574 mark.lam 2017-06-10 10:56:42 -0700 Comment on attachment 312574 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312574&action=review r=me with suggested ChangeLog change. > Source/JavaScriptCore/ChangeLog:10 > + The latest spec introduces slight change to RegExp.prototype.[@@search]. > + This patch applies this change. Basically, this change is done in the slow path of > + the RegExp.prototype[@@search]. Please include the spec url here for easy reference. 1317911 3 ysuzuki 2017-06-10 11:01:58 -0700 Committed r218051: <http://trac.webkit.org/changeset/218051> 1317916 4 ysuzuki 2017-06-10 11:35:27 -0700 Committed r218053: <http://trac.webkit.org/changeset/218053> 1317918 5 ysuzuki 2017-06-10 12:20:56 -0700 Committed r218054: <http://trac.webkit.org/changeset/218054> 1317973 6 ysuzuki 2017-06-11 00:53:31 -0700 Committed r218065: <http://trac.webkit.org/changeset/218065> 312574 2017-06-10 10:48:34 -0700 2017-06-10 10:56:42 -0700 Patch bug-173227-20170611024833.patch text/plain 4038 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MzNkMTdjZjQzODMwYWNiZGNmYThjODQzNzFjZGY3ZjhlYTBiN2FjLi5jMTBhZmYyZDc0ZmMzMDgy OTc4OGIyODhlNjlkMWYzMzJkZmRmOWRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wNi0xMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBVcGRhdGUgUmVnRXhwLnByb3RvdHlwZS5bQEBzZWFyY2hd XSBpbXBsZW1lbnRhdGlvbiBhY2NvcmRpbmcgdG8gdGhlIGxhdGVzdCBzcGVjCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMyMjcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbGF0ZXN0IHNwZWMgaW50 cm9kdWNlcyBzbGlnaHQgY2hhbmdlIHRvIFJlZ0V4cC5wcm90b3R5cGUuW0BAc2VhcmNoXS4KKyAg ICAgICAgVGhpcyBwYXRjaCBhcHBsaWVzIHRoaXMgY2hhbmdlLiBCYXNpY2FsbHksIHRoaXMgY2hh bmdlIGlzIGRvbmUgaW4gdGhlIHNsb3cgcGF0aCBvZgorICAgICAgICB0aGUgUmVnRXhwLnByb3Rv dHlwZVtAQHNlYXJjaF0uCisKKyAgICAgICAgKiBidWlsdGlucy9SZWdFeHBQcm90b3R5cGUuanM6 CisgICAgICAgIChzZWFyY2gpOgorCiAyMDE3LTA2LTA5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIFRocmVhZDo6Y3JlYXRlKCkgdG8gdGFrZSBpbiBh IFdURjo6RnVuY3Rpb24gaW5zdGVhZCBvZiBhIHN0ZDo6ZnVuY3Rpb24KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9SZWdFeHBQcm90b3R5cGUuanMgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBlLmpzCmluZGV4IDAxN2E4MWNk MTRkMTA4ODU3YmJjZTRhMzljZWQ1OTIyNjJlYWZmM2UuLmFmOWVmMzhlYWI4YTEwYmI5M2NkYjgw ZWNhNDRhOTg2NmE1OTA5ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWls dGlucy9SZWdFeHBQcm90b3R5cGUuanMKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0 aW5zL1JlZ0V4cFByb3RvdHlwZS5qcwpAQCAtMzE2LDE2ICszMTYsMjggQEAgZnVuY3Rpb24gc2Vh cmNoKHN0ckFyZykKIAogICAgIC8vIDQuIExldCBwcmV2aW91c0xhc3RJbmRleCBiZSA/IEdldChy eCwgImxhc3RJbmRleCIpLgogICAgIGxldCBwcmV2aW91c0xhc3RJbmRleCA9IHJlZ2V4cC5sYXN0 SW5kZXg7Ci0gICAgLy8gNS4gUGVyZm9ybSA/IFNldChyeCwgImxhc3RJbmRleCIsIDAsIHRydWUp LgotICAgIHJlZ2V4cC5sYXN0SW5kZXggPSAwOworCisgICAgLy8gNS5JZiBTYW1lVmFsdWUocHJl dmlvdXNMYXN0SW5kZXgsIDApIGlzIGZhbHNlLCB0aGVuCisgICAgLy8gNS5hLiBQZXJmb3JtID8g U2V0KHJ4LCAibGFzdEluZGV4IiwgMCwgdHJ1ZSkuCisgICAgLy8gRklYTUU6IEFkZCBTYW1lVmFs dWUgc3VwcG9ydC4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzIy NgorICAgIGlmIChwcmV2aW91c0xhc3RJbmRleCAhPT0gMCkKKyAgICAgICAgcmVnZXhwLmxhc3RJ bmRleCA9IDA7CisKICAgICAvLyA2LiBMZXQgcmVzdWx0IGJlID8gUmVnRXhwRXhlYyhyeCwgUyku CiAgICAgbGV0IHJlc3VsdCA9IEByZWdFeHBFeGVjKHJlZ2V4cCwgc3RyKTsKLSAgICAvLyA3LiBQ ZXJmb3JtID8gU2V0KHJ4LCAibGFzdEluZGV4IiwgcHJldmlvdXNMYXN0SW5kZXgsIHRydWUpLgot ICAgIHJlZ2V4cC5sYXN0SW5kZXggPSBwcmV2aW91c0xhc3RJbmRleDsKLSAgICAvLyA4LiBJZiBy ZXN1bHQgaXMgbnVsbCwgcmV0dXJuIC0xLgorCisgICAgLy8gNy4gTGV0IGN1cnJlbnRMYXN0SW5k ZXggYmUgPyBHZXQocngsICJsYXN0SW5kZXgiKS4KKyAgICAvLyA4LiBJZiBTYW1lVmFsdWUoY3Vy cmVudExhc3RJbmRleCwgcHJldmlvdXNMYXN0SW5kZXgpIGlzIGZhbHNlLCB0aGVuCisgICAgLy8g OC5hLiBQZXJmb3JtID8gU2V0KHJ4LCAibGFzdEluZGV4IiwgcHJldmlvdXNMYXN0SW5kZXgsIHRy dWUpLgorICAgIC8vIEZJWE1FOiBBZGQgU2FtZVZhbHVlIHN1cHBvcnQuIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMyMjYKKyAgICBpZiAocmVnZXhwLmxhc3RJbmRl eCAhPT0gcHJldmlvdXNMYXN0SW5kZXgpCisgICAgICAgIHJlZ2V4cC5sYXN0SW5kZXggPSBwcmV2 aW91c0xhc3RJbmRleDsKKworICAgIC8vIDkuIElmIHJlc3VsdCBpcyBudWxsLCByZXR1cm4gLTEu CiAgICAgaWYgKHJlc3VsdCA9PT0gbnVsbCkKICAgICAgICAgcmV0dXJuIC0xOwotICAgIC8vIDku IFJldHVybiA/IEdldChyZXN1bHQsICJpbmRleCIpLgorCisgICAgLy8gMTAuIFJldHVybiA/IEdl dChyZXN1bHQsICJpbmRleCIpLgogICAgIHJldHVybiByZXN1bHQuaW5kZXg7CiB9CiAKZGlmZiAt LWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjY5MzFj MWIyMWI3MDZhY2VmZDY3YWQ5OTViOTg0NDFhZWRjZmEzZS4uOTVlNzkzY2MyN2I1YTYxOTg2MDg2 NDJjNWNjZjZkZjY1OWM1OGNhZSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIv SlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNy0wNi0xMCAgWXVzdWtlIFN1 enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KKworICAgICAgICBbSlNDXSBVcGRhdGUgUmVn RXhwLnByb3RvdHlwZS5bQEBzZWFyY2hdXSBpbXBsZW1lbnRhdGlvbiBhY2NvcmRpbmcgdG8gdGhl IGxhdGVzdCBzcGVjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzMyMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVcGRhdGUgdGhlIHRlc3QuCisKKyAgICAgICAgKiBlczYvUHJveHlfaW50ZXJuYWxfZ2V0 X2NhbGxzX1JlZ0V4cC5wcm90b3R5cGVbU3ltYm9sLnNlYXJjaF0uanM6CisKIDIwMTctMDYtMDgg IEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQXNz ZW1ibHk6IFdlIHNob3VsZCBvbmx5IGNyZWF0ZSB3cmFwcGVycyBmb3IgZnVuY3Rpb25zIHRoYXQg Y2FuIGJlIGV4cG9ydGVkCmRpZmYgLS1naXQgYS9KU1Rlc3RzL2VzNi9Qcm94eV9pbnRlcm5hbF9n ZXRfY2FsbHNfUmVnRXhwLnByb3RvdHlwZVtTeW1ib2wuc2VhcmNoXS5qcyBiL0pTVGVzdHMvZXM2 L1Byb3h5X2ludGVybmFsX2dldF9jYWxsc19SZWdFeHAucHJvdG90eXBlW1N5bWJvbC5zZWFyY2hd LmpzCmluZGV4IGMxYTJlNTkzNDNkNjU5ZGFkZGZjYTY1YjRmMzYxZjBkNjMwMDEzNjIuLjVmNjhh ZTRlYjllNTUyMGJjYWJlYzU3ODBmZmZlNjMwNTI0NTcyY2QgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMv ZXM2L1Byb3h5X2ludGVybmFsX2dldF9jYWxsc19SZWdFeHAucHJvdG90eXBlW1N5bWJvbC5zZWFy Y2hdLmpzCisrKyBiL0pTVGVzdHMvZXM2L1Byb3h5X2ludGVybmFsX2dldF9jYWxsc19SZWdFeHAu cHJvdG90eXBlW1N5bWJvbC5zZWFyY2hdLmpzCkBAIC00LDcgKzQsNyBAQCBmdW5jdGlvbiB0ZXN0 KCkgewogdmFyIGdldCA9IFtdOwogdmFyIHAgPSBuZXcgUHJveHkoeyBleGVjOiBmdW5jdGlvbigp IHsgcmV0dXJuIG51bGw7IH0gfSwgeyBnZXQ6IGZ1bmN0aW9uKG8sIGspIHsgZ2V0LnB1c2goayk7 IHJldHVybiBvW2tdOyB9fSk7CiBSZWdFeHAucHJvdG90eXBlW1N5bWJvbC5zZWFyY2hdLmNhbGwo cCk7Ci1yZXR1cm4gZ2V0ICsgJycgPT09ICJsYXN0SW5kZXgsZXhlYyI7CityZXR1cm4gZ2V0ICsg JycgPT09ICJsYXN0SW5kZXgsZXhlYyxsYXN0SW5kZXgiOwogICAgICAgCiB9CiAK