<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>17321</bug_id>
          
          <creation_ts>2008-02-11 22:39:50 -0800</creation_ts>
          <short_desc>Fixes for a few wx issues</short_desc>
          <delta_ts>2008-02-13 09:51:20 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit wx</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Wx</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kevin Ollivier">kevino</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>70356</commentid>
    <comment_count>0</comment_count>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2008-02-11 22:39:50 -0800</bug_when>
    <thetext>These are a few bugfixes for the wx port. specifically:

- Make sure wx headers are included before windows.h so that it is properly configured

- Pass font info UTF8 string to the 8-bit friendly version of computeHash

- Fix for drawing origin when using wxGCDC (aka GDIPlus/Cairo/CoreGraphics mode)

- Update wxPython bindings after renaming of a wxWebKit event.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70357</commentid>
    <comment_count>1</comment_count>
      <attachid>19088</attachid>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2008-02-11 22:40:56 -0800</bug_when>
    <thetext>Created attachment 19088
Fixes for wx port bugs</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70513</commentid>
    <comment_count>2</comment_count>
      <attachid>19088</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-02-13 04:46:46 -0800</bug_when>
    <thetext>Comment on attachment 19088
Fixes for wx port bugs

All looks fine.

What is MSW?

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70537</commentid>
    <comment_count>3</comment_count>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2008-02-13 09:10:16 -0800</bug_when>
    <thetext>Sorry, MSW = MicroSoft Windows :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70542</commentid>
    <comment_count>4</comment_count>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2008-02-13 09:51:20 -0800</bug_when>
    <thetext>Landed in r30204. Thanks! </thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>19088</attachid>
            <date>2008-02-11 22:40:56 -0800</date>
            <delta_ts>2008-02-13 04:46:46 -0800</delta_ts>
            <desc>Fixes for wx port bugs</desc>
            <filename>small_wx_fixes.patch</filename>
            <type>text/plain</type>
            <size>4286</size>
            <attacher name="Kevin Ollivier">kevino</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YS5oCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0
YS5oCShyZXZpc2lvbiAzMDE1OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9u
dFBsYXRmb3JtRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC03Niw3ICs3Niw3IEBACiAgICAgICAg
IGNhc2UgVU5JTklUSUFMSVpFRDoKICAgICAgICAgICAgIHJldHVybiAwOwogICAgICAgICBjYXNl
IFZBTElEOgotICAgICAgICAgICAgcmV0dXJuIG1fZm9udEhhc2g7ICAgICAgICAgICAgICAKKyAg
ICAgICAgICAgIHJldHVybiBjb21wdXRlSGFzaCgpOyAgICAgICAgICAgICAgCiAgICAgICAgIH0K
ICAgICB9CiAKQEAgLTg5LDkgKzg5LDkgQEAKICAgICB9CiAgICAgCiAgICAgdW5zaWduZWQgY29t
cHV0ZUhhc2goKSBjb25zdCB7CisgICAgICAgIEFTU0VSVChtX2ZvbnQuT2soKSk7CiAgICAgICAg
IHd4Q2hhckJ1ZmZlciBjaGFyQnVmZmVyKG1fZm9udC5HZXROYXRpdmVGb250SW5mb0Rlc2MoKS5t
Yl9zdHIod3hDb252VVRGOCkpOwotICAgICAgICBjb25zdCBjaGFyKiBjb250ZW50cyA9IGNoYXJC
dWZmZXI7ICAgICAgICAKLSAgICAgICAgcmV0dXJuIFN0cmluZ0ltcGw6OmNvbXB1dGVIYXNoKCAo
VUNoYXIqKWNvbnRlbnRzLCBzdHJsZW4oY29udGVudHMpKTsKKyAgICAgICAgcmV0dXJuIFN0cmlu
Z0ltcGw6OmNvbXB1dGVIYXNoKGNoYXJCdWZmZXIuZGF0YSgpKTsKICAgICB9CiAKIHByaXZhdGU6
CkluZGV4OiBXZWJDb3JlL2NvbmZpZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY29uZmlnLmgJ
KHJldmlzaW9uIDMwMTU4KQorKysgV2ViQ29yZS9jb25maWcuaAkod29ya2luZyBjb3B5KQpAQCAt
NTQsNiArNTQsMTIgQEAKIAogI2VuZGlmIC8qIFBMQVRGT1JNKFdJTl9PUykgKi8KIAorLy8gT24g
TVNXLCB3eCBoZWFkZXJzIG5lZWQgdG8gYmUgaW5jbHVkZWQgYmVmb3JlIHdpbmRvd3MuaCBpcy4g
CisvLyBUaGUgb25seSB3YXkgd2UgY2FuIGFsd2F5cyBlbnN1cmUgdGhpcyBpcyBpZiB3ZSBpbmNs
dWRlIHd4IGhlcmUuIAorI2lmIFBMQVRGT1JNKFdYKQorI2luY2x1ZGUgPHd4L2RlZnMuaD4KKyNl
bmRpZgorCiAjaWYgIVBMQVRGT1JNKFNZTUJJQU4pCiAjZGVmaW5lIElNUE9SVF9DCiAjZGVmaW5l
IEVYUE9SVF9DCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl
L0NoYW5nZUxvZwkocmV2aXNpb24gMzAxNjEpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDA4LTAyLTExICBrZXZpbm8gIDxzZXQgRU1BSUxf
QUREUkVTUyBlbnZpcm9ubWVudCB2YXJpYWJsZT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBJbXBvcnQgd3gvZGVmcy5oIHRvIGtlZXAgd2luZG93cy5o
IGZyb20gdXNpbmcgQU5TSSBmdW5jdGlvbnMKKyAgICAgICAgKHNlZSBub3RlIGluIGZpbGUgZm9y
IG1vcmUgaW5mbykgYW5kIHVzZSB0aGUgOC1iaXQgc3RyaW5nIGZyaWVuZGx5CisgICAgICAgIHZl
cnNpb24gb2YgU3RyaW5nSW1wbDo6Y29tcHV0ZUhhc2ggc2luY2Ugd2UncmUgcGFzc2luZyBpdCB1
biBVVEY4CisgICAgICAgIHN0cmluZy4gQWxzbywgZG9uJ3QgY2FjaGUgdGhlIGhhc2ggcmVzdWx0
LgorCisgICAgICAgICogY29uZmlnLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd3gv
Rm9udFBsYXRmb3JtRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6
aGFzaCk6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRhOjpjb21wdXRlSGFzaCk6
CisKIDIwMDgtMDItMTEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYktpdC93eC9DaGFuZ2VMb2cKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gV2ViS2l0L3d4L0NoYW5nZUxvZwkocmV2aXNpb24gMzAxNTkpCisrKyBXZWJLaXQv
d3gvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMDItMTEg
IGtldmlubyAgPHNldCBFTUFJTF9BRERSRVNTIGVudmlyb25tZW50IHZhcmlhYmxlPgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEgY291cGxlIHF1aWNr
IHd4IGZpeGVzLgorCisgICAgICAgICogV2ViVmlldy5jcHA6CisgICAgICAgICh3eFdlYlZpZXc6
Ok9uUGFpbnQpOgorICAgICAgICBNYWtlIHN1cmUgd3hHQ0RDIGhhcyBpdHMgcGFpbnQgb3JpZ2lu
IHNldCBwcm9wZXJseSBhZnRlcgorICAgICAgICB0aGUgbW92ZSB0byB3eFdpbmRvdyBmb3Igc2Ny
b2xsaW5nLgorICAgICAgICAqIGJpbmRpbmdzL3B5dGhvbi93ZWJ2aWV3Lmk6CisgICAgICAgIFVw
ZGF0ZSB0aGUgd3hQeXRob24gYmluZGluZ3MgYWZ0ZXIgZXZlbnQgcmVuYW1lLgorCiAyMDA4LTAy
LTEwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBFcmljLgpJbmRleDogV2ViS2l0L3d4L1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp
dC93eC9XZWJWaWV3LmNwcAkocmV2aXNpb24gMzAxNTgpCisrKyBXZWJLaXQvd3gvV2ViVmlldy5j
cHAJKHdvcmtpbmcgY29weSkKQEAgLTQyMiw2ICs0MjIsOSBAQAogICAgICAgICAgICAgd3hSZWN0
IHBhaW50UmVjdCA9IEdldFVwZGF0ZVJlZ2lvbigpLkdldEJveCgpOwogCiAgICAgICAgICAgICBX
ZWJDb3JlOjpJbnRTaXplIG9mZnNldCA9IG1faW1wbC0+ZnJhbWVWaWV3LT5zY3JvbGxPZmZzZXQo
KTsKKyNpZiBVU0UoV1hHQykKKyAgICAgICAgICAgIGdjZGMuU2V0RGV2aWNlT3JpZ2luKC1vZmZz
ZXQud2lkdGgoKSwgLW9mZnNldC5oZWlnaHQoKSk7CisjZW5kaWYKICAgICAgICAgICAgIGRjLlNl
dERldmljZU9yaWdpbigtb2Zmc2V0LndpZHRoKCksIC1vZmZzZXQuaGVpZ2h0KCkpOwogICAgICAg
ICAgICAgcGFpbnRSZWN0Lk9mZnNldChvZmZzZXQud2lkdGgoKSwgb2Zmc2V0LmhlaWdodCgpKTsK
IApJbmRleDogV2ViS2l0L3d4L2JpbmRpbmdzL3B5dGhvbi93ZWJ2aWV3LmkKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gV2ViS2l0L3d4L2JpbmRpbmdzL3B5dGhvbi93ZWJ2aWV3LmkJKHJldmlzaW9uIDMwMTU4KQor
KysgV2ViS2l0L3d4L2JpbmRpbmdzL3B5dGhvbi93ZWJ2aWV3LmkJKHdvcmtpbmcgY29weSkKQEAg
LTQ3LDEzICs0NywxMyBAQAogJXB5dGhvbmNvZGUgeyBfX2RvY2ZpbHRlcl9fID0gd3guX19Eb2NG
aWx0ZXIoZ2xvYmFscygpKSB9CiAKICVjb25zdGFudCB3eEV2ZW50VHlwZSB3eEVWVF9XRUJWSUVX
X0JFRk9SRV9MT0FEOwotJWNvbnN0YW50IHd4RXZlbnRUeXBlIHd4RVZUX1dFQlZJRVdfU1RBVEVf
Q0hBTkdFRDsKKyVjb25zdGFudCB3eEV2ZW50VHlwZSB3eEVWVF9XRUJWSUVXX0xPQUQ7CiAlY29u
c3RhbnQgd3hFdmVudFR5cGUgd3hFVlRfV0VCVklFV19ORVdfV0lORE9XOwogJWNvbnN0YW50IHd4
RXZlbnRUeXBlIHd4RVZUX1dFQlZJRVdfUklHSFRfQ0xJQ0s7CiAKICVweXRob25jb2RlIHsKIEVW
VF9XRUJWSUVXX0JFRk9SRV9MT0FEID0gd3guUHlFdmVudEJpbmRlciggd3hFVlRfV0VCVklFV19C
RUZPUkVfTE9BRCApCi1FVlRfV0VCVklFV19TVEFURV9DSEFOR0VEID0gd3guUHlFdmVudEJpbmRl
ciggd3hFVlRfV0VCVklFV19TVEFURV9DSEFOR0VEICkKK0VWVF9XRUJWSUVXX0xPQUQgPSB3eC5Q
eUV2ZW50QmluZGVyKCB3eEVWVF9XRUJWSUVXX0xPQUQgKQogRVZUX1dFQlZJRVdfTkVXX1dJTkRP
VyA9IHd4LlB5RXZlbnRCaW5kZXIoIHd4RVZUX1dFQlZJRVdfTkVXX1dJTkRPVyApCiBFVlRfV0VC
VklFV19SSUdIVF9DTElDSyA9IHd4LlB5RXZlbnRCaW5kZXIoIHd4RVZUX1dFQlZJRVdfUklHSFRf
Q0xJQ0sgKQogfQo=
</data>
<flag name="review"
          id="8341"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>