173196 2017-06-09 18:01:33 -0700 REGRESSION (r217870): Null deref under PageOverlayController::uninstallPageOverlay using find in page 2017-06-11 09:03:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue simon.fraser wenson_hsieh oldest_to_newest 1317740 0 thorton 2017-06-09 18:01:33 -0700 REGRESSION (r217870): Null deref under PageOverlayController::uninstallPageOverlay using find in page 1317741 1 312521 thorton 2017-06-09 18:01:56 -0700 Created attachment 312521 Patch 1317745 2 thorton 2017-06-09 18:06:18 -0700 rdar://problem/32686871 1318001 3 312521 commit-queue 2017-06-11 09:03:45 -0700 Comment on attachment 312521 Patch Clearing flags on attachment: 312521 Committed r218068: <http://trac.webkit.org/changeset/218068> 1318002 4 commit-queue 2017-06-11 09:03:46 -0700 All reviewed patches have been landed. Closing bug. 312521 2017-06-09 18:01:56 -0700 2017-06-11 09:03:45 -0700 Patch bug-173196-20170609180155.patch text/plain 7146 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc1ODliZTQzNGUyMTc5 OTY0M2ZkYmQ5OTczM2ViZDJjN2VjNjAzOS4uNzZlMWNkNmYyMmU1MDg1ZDE0N2FkZWExNzQwNjUx YmQ1MWMzZWQ1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA2LTA5ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyMTc4NzApOiBOdWxsIGRlcmVmIHVuZGVyIFBhZ2VPdmVybGF5Q29udHJvbGxlcjo6dW5pbnN0 YWxsUGFnZU92ZXJsYXkgdXNpbmcgZmluZCBpbiBwYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMxOTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzMyNjg2ODcxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGFnZS9UZXh0SW5kaWNhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxp emVJbmRpY2F0b3IpOgorICAgICAgICAqIHBhZ2UvVGV4dEluZGljYXRvci5oOgorICAgICAgICBU aGUgY2hhbmdlIGluIHIyMTc4NzAgaGFkIGFuIGV4cGVjdGVkIGJ1dCBub3QgdGhvdWdodC10aHJv dWdoIHNpZGUtZWZmZWN0CisgICAgICAgIHRoYXQgeW91IGNhbm5vdCBjcmVhdGUgYSBUZXh0SW5k aWNhdG9yIGZvciBmYXItb2ZmLXNjcmVlbiBlbGVtZW50cy4gVGhpcworICAgICAgICBpcyBhIHBy b2JsZW0gZm9yIGZpbmQtaW4tcGFnZSwgd2hpY2ggdXNlcyBUZXh0SW5kaWNhdG9yIHRvIHBhaW50 IHRoZSB5ZWxsb3cKKyAgICAgICAgaGlnaGxpZ2h0IGJlZm9yZSBzY3JvbGxpbmcgaXQgaW50byB2 aWV3LgorCisgICAgICAgIEJyaW5nIGJhY2sgVGV4dEluZGljYXRvck9wdGlvbkRvTm90Q2xpcFRv VmlzaWJsZVJlY3QgYW5kIHJldmVydCB0byBpdCBmb3IKKyAgICAgICAgZmluZCBpbiBwYWdlLCBz aW5jZSBpdCBuZWVkcyBkaWZmZXJlbnQgYmVoYXZpb3IgdGhhbiBzb21ldGhpbmcgbGlrZQorICAg ICAgICBkcmFnIGFuZCBkcm9wLCB3aGljaCBhbHdheXMgb3BlcmF0ZXMgb24gY29udGVudCBuZWFy IHRoZSB2aXNpYmxlIHZpZXdwb3J0LgorCiAyMDE3LTA2LTA5ICBXZW5zb24gSHNpZWggIDx3ZW5z b25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1MgRG5EXSBBZGQgYSBob29rIHRvIHBl cmZvcm0gdHdvLXN0ZXAgZHJvcHMgaW4gZWRpdGFibGUgY29udGVudApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDhj MGFhNTk1MzRhYzc3NDBjYjc0OWQ3OWY1M2Y2NzliMjZiYTdhZDguLjZlNWMyMzFiMDUzM2Q5Zjhm MDNmMjBlYjRjYWJmMjRiOGQxZGFhZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAx Ny0wNi0wOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAg ICBSRUdSRVNTSU9OIChyMjE3ODcwKTogTnVsbCBkZXJlZiB1bmRlciBQYWdlT3ZlcmxheUNvbnRy b2xsZXI6OnVuaW5zdGFsbFBhZ2VPdmVybGF5IHVzaW5nIGZpbmQgaW4gcGFnZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTk2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zMjY4Njg3MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvRmluZENvbnRyb2xsZXJJ T1MubW06CisgICAgICAgIChXZWJLaXQ6OkZpbmRDb250cm9sbGVyOjp1cGRhdGVGaW5kSW5kaWNh dG9yKToKKyAgICAgICAgVGhlIHJlYXNvbiB0aGlzIGNhdXNlZCBhIGNyYXNoIGluc3RlYWQgb2Yg anVzdCBhIG1pc3NpbmcgaW5kaWNhdG9yCisgICAgICAgIGlzIHRoYXQgRmluZENvbnRyb2xsZXJJ T1Mgd291bGQgZWFybHkgcmV0dXJuIGFmdGVyIHVuaW5zdGFsbGluZworICAgICAgICB0aGUgb2xk IG92ZXJsYXksIGJlZm9yZSBpbnN0YWxsaW5nIGEgbmV3IG9uZSwgYW5kIGxlYXZlIG1faXNTaG93 aW5nRmluZEluZGljYXRvcgorICAgICAgICBzZXQgdG8gdHJ1ZS4gSW5zdGVhZCwgcmVzZXQgaXQg KGFuZCBtX2ZpbmRJbmRpY2F0b3JPdmVybGF5LCB3aGljaAorICAgICAgICB3ZSB3b3VsZCBuZXZl ciByZS11c2UgYnV0IG1pZ2h0IGFzIHdlbGwgYmUgZnJlZWQgaW1tZWRpYXRlbHkpLgorCisgICAg ICAgIFRoaXMgbGlrZWx5IGFscmVhZHkgY3Jhc2hlZCBpbiBvdGhlciBsZXNzIHJlcHJvZHVjaWJs ZSBjYXNlcyB3aGVyZSBhCisgICAgICAgIFRleHRJbmRpY2F0b3Igd2FzIG5vdCBjcmVhdGVkIGZv ciBhIGZpbmQgbWF0Y2gsIHNvIGNsZWFuIGl0IHVwLgorCiAyMDE3LTA2LTA5ICBXZW5zb24gSHNp ZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1MgRG5EXSBBZGQgYSBo b29rIHRvIHBlcmZvcm0gdHdvLXN0ZXAgZHJvcHMgaW4gZWRpdGFibGUgY29udGVudApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNhdG9yLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvVGV4dEluZGljYXRvci5jcHAKaW5kZXggY2JlYmEzZDU2MjkwNmFkNGUwODdlN2I5 NTI1YmQxY2YxZDIyMDA0ZC4uNTc3NDA0NWQ0YWYyNTQ3MTg5MDM5ZTFlOGY0ZTlmMGQ2NTY0MDM5 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNhdG9yLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0b3IuY3BwCkBAIC0zMDEsNyArMzAxLDEx IEBAIHN0YXRpYyBib29sIGluaXRpYWxpemVJbmRpY2F0b3IoVGV4dEluZGljYXRvckRhdGEmIGRh dGEsIEZyYW1lJiBmcmFtZSwgY29uc3QgUmFuCiAgICAgVmVjdG9yPEZsb2F0UmVjdD4gY2xpcHBl ZFRleHRSZWN0c0luRG9jdW1lbnRDb29yZGluYXRlczsKICAgICBWZWN0b3I8RmxvYXRSZWN0PiB0 ZXh0UmVjdHNJblJvb3RWaWV3Q29vcmRpbmF0ZXM7CiAgICAgZm9yIChjb25zdCBGbG9hdFJlY3Qm IHRleHRSZWN0IDogdGV4dFJlY3RzKSB7Ci0gICAgICAgIEZsb2F0UmVjdCBjbGlwcGVkVGV4dFJl Y3QgPSBpbnRlcnNlY3Rpb24odGV4dFJlY3QsIGNvbnRlbnRzQ2xpcFJlY3QpOworICAgICAgICBG bG9hdFJlY3QgY2xpcHBlZFRleHRSZWN0OworICAgICAgICBpZiAoZGF0YS5vcHRpb25zICYgVGV4 dEluZGljYXRvck9wdGlvbkRvTm90Q2xpcFRvVmlzaWJsZVJlY3QpCisgICAgICAgICAgICBjbGlw cGVkVGV4dFJlY3QgPSB0ZXh0UmVjdDsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgY2xpcHBl ZFRleHRSZWN0ID0gaW50ZXJzZWN0aW9uKHRleHRSZWN0LCBjb250ZW50c0NsaXBSZWN0KTsKICAg ICAgICAgaWYgKGNsaXBwZWRUZXh0UmVjdC5pc0VtcHR5KCkpCiAgICAgICAgICAgICBjb250aW51 ZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNhdG9yLmggYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0b3IuaAppbmRleCAxNzhiYTgzMDkzODU5MWI2 MzdlMzc5ZDE5YWM2ZTZjMjhiMTE5NDhmLi42ZjMwODg0ZmMyODc5N2YxODg3OGY2OTFhMTg5ZTk1 ODRlYzZmOWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0b3Iu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0b3IuaApAQCAtODEsMTcgKzgx LDIxIEBAIGVudW0gVGV4dEluZGljYXRvck9wdGlvbiA6IHVpbnQxNl90IHsKICAgICAvLyBJZiB0 aGlzIG9wdGlvbiBpcyBzZXQsIGV4cGFuZCB0aGUgY2xpcCByZWN0IG91dHdhcmQgc28gdGhhdCBz bGlnaHRseSBvZmZzY3JlZW4gY29udGVudCB3aWxsIGJlIGluY2x1ZGVkLgogICAgIFRleHRJbmRp Y2F0b3JPcHRpb25FeHBhbmRDbGlwQmV5b25kVmlzaWJsZVJlY3QgPSAxIDw8IDcsCiAKKyAgICAv LyBCeSBkZWZhdWx0LCBUZXh0SW5kaWNhdG9yIGNsaXBzIHRoZSBpbmRpY2F0ZWQgcmVjdHMgdG8g dGhlIHZpc2libGUgY29udGVudCByZWN0LgorICAgIC8vIElmIHRoaXMgb3B0aW9uIGlzIHNldCwg ZG8gbm90IGNsaXAgdG8gdGhlIHZpc2libGUgcmVjdC4KKyAgICBUZXh0SW5kaWNhdG9yT3B0aW9u RG9Ob3RDbGlwVG9WaXNpYmxlUmVjdCA9IDEgPDwgOCwKKwogICAgIC8vIEluY2x1ZGUgYW4gYWRk aXRpb25hbCBzbmFwc2hvdCBvZiBldmVyeXRoaW5nIGluIHZpZXcsIHdpdGggdGhlIGV4Y2VwdGlv biBvZiBub2RlcyB3aXRoaW4gdGhlIGN1cnJlbnRseSBzZWxlY3RlZCByYW5nZS4KLSAgICBUZXh0 SW5kaWNhdG9yT3B0aW9uSW5jbHVkZVNuYXBzaG90T2ZBbGxWaXNpYmxlQ29udGVudFdpdGhvdXRT ZWxlY3Rpb24gPSAxIDw8IDgsCisgICAgVGV4dEluZGljYXRvck9wdGlvbkluY2x1ZGVTbmFwc2hv dE9mQWxsVmlzaWJsZUNvbnRlbnRXaXRob3V0U2VsZWN0aW9uID0gMSA8PCA5LAogCiAgICAgLy8g QnkgZGVmYXVsdCwgVGV4dEluZGljYXRvciB1c2VzIHRleHQgcmVjdHMgdG8gc2l6ZSB0aGUgc25h cHNob3QuIEVuYWJsaW5nIHRoaXMgZmxhZyBjYXVzZXMgaXQgdG8gdXNlIHRoZSBib3VuZHMgb2Yg dGhlCiAgICAgLy8gc2VsZWN0aW9uIHJlY3RzIHRoYXQgd291bGQgZW5jbG9zZSB0aGUgZ2l2ZW4g UmFuZ2UgaW5zdGVhZC4KICAgICAvLyBDdXJyZW50bHksIHRoaXMgaXMgb25seSBzdXBwb3J0ZWQg b24gaU9TLgotICAgIFRleHRJbmRpY2F0b3JPcHRpb25Vc2VTZWxlY3Rpb25SZWN0Rm9yU2l6aW5n ID0gMSA8PCA5LAorICAgIFRleHRJbmRpY2F0b3JPcHRpb25Vc2VTZWxlY3Rpb25SZWN0Rm9yU2l6 aW5nID0gMSA8PCAxMCwKIAogICAgIC8vIENvbXB1dGUgYSBiYWNrZ3JvdW5kIGNvbG9yIHRvIHVz ZSB3aGVuIHJlbmRlcmluZyBhIHBsYXR0ZXIgYXJvdW5kIHRoZSBjb250ZW50IGltYWdlLCBmYWxs aW5nIGJhY2sgdG8gYSBkZWZhdWx0IGlmIHRoZQogICAgIC8vIGNvbnRlbnQncyBiYWNrZ3JvdW5k IGlzIHRvbyBjb21wbGV4IHRvIGJlIGNhcHR1cmVkIGJ5IGEgc2luZ2xlIGNvbG9yLgotICAgIFRl eHRJbmRpY2F0b3JPcHRpb25Db21wdXRlRXN0aW1hdGVkQmFja2dyb3VuZENvbG9yID0gMSA8PCAx MCwKKyAgICBUZXh0SW5kaWNhdG9yT3B0aW9uQ29tcHV0ZUVzdGltYXRlZEJhY2tncm91bmRDb2xv ciA9IDEgPDwgMTEsCiB9OwogdHlwZWRlZiB1aW50MTZfdCBUZXh0SW5kaWNhdG9yT3B0aW9uczsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9GaW5k Q29udHJvbGxlcklPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3Mv RmluZENvbnRyb2xsZXJJT1MubW0KaW5kZXggYWM2MzcwNTRkZWIwY2JjY2UwNGI4MGUzNTUzNzNh NzhhNDYyNjQ0MS4uOTUxOTM5OGM5MmI4ZjNiODM3YWMwMjhlNWY1MjcwMzcyMzg0MzlmMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9GaW5kQ29udHJv bGxlcklPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL0Zp bmRDb250cm9sbGVySU9TLm1tCkBAIC01MCw3ICs1MCw3IEBAIGNvbnN0IGludCBjb3JuZXJSYWRp dXMgPSAzOwogY29uc3QgaW50IHRvdGFsSG9yaXpvbnRhbE1hcmdpbiA9IDI7CiBjb25zdCBpbnQg dG90YWxWZXJ0aWNhbE1hcmdpbiA9IDE7CiAKLWNvbnN0IFRleHRJbmRpY2F0b3JPcHRpb25zIGZp bmRUZXh0SW5kaWNhdG9yT3B0aW9ucyA9IFRleHRJbmRpY2F0b3JPcHRpb25UaWdodGx5Rml0Q29u dGVudCB8IFRleHRJbmRpY2F0b3JPcHRpb25JbmNsdWRlTWFyZ2luSWZSYW5nZU1hdGNoZXNTZWxl Y3Rpb24gfCBUZXh0SW5kaWNhdG9yT3B0aW9uRXhwYW5kQ2xpcEJleW9uZFZpc2libGVSZWN0Owor Y29uc3QgVGV4dEluZGljYXRvck9wdGlvbnMgZmluZFRleHRJbmRpY2F0b3JPcHRpb25zID0gVGV4 dEluZGljYXRvck9wdGlvblRpZ2h0bHlGaXRDb250ZW50IHwgVGV4dEluZGljYXRvck9wdGlvbklu Y2x1ZGVNYXJnaW5JZlJhbmdlTWF0Y2hlc1NlbGVjdGlvbiB8IFRleHRJbmRpY2F0b3JPcHRpb25E b05vdENsaXBUb1Zpc2libGVSZWN0OwogCiBzdGF0aWMgQ29sb3IgaGlnaGxpZ2h0Q29sb3IoKQog ewpAQCAtOTMsOCArOTMsMTEgQEAgYm9vbCBGaW5kQ29udHJvbGxlcjo6dXBkYXRlRmluZEluZGlj YXRvcihGcmFtZSYgc2VsZWN0ZWRGcmFtZSwgYm9vbCBpc1Nob3dpbmdPdmUKICAgICAgICAgbV93 ZWJQYWdlLT5tYWluRnJhbWUoKS0+cGFnZU92ZXJsYXlDb250cm9sbGVyKCkudW5pbnN0YWxsUGFn ZU92ZXJsYXkoKm1fZmluZEluZGljYXRvck92ZXJsYXksIFBhZ2VPdmVybGF5OjpGYWRlTW9kZTo6 RG9Ob3RGYWRlKTsKIAogICAgIFJlZlB0cjxUZXh0SW5kaWNhdG9yPiB0ZXh0SW5kaWNhdG9yID0g VGV4dEluZGljYXRvcjo6Y3JlYXRlV2l0aFNlbGVjdGlvbkluRnJhbWUoc2VsZWN0ZWRGcmFtZSwg ZmluZFRleHRJbmRpY2F0b3JPcHRpb25zLCBUZXh0SW5kaWNhdG9yUHJlc2VudGF0aW9uVHJhbnNp dGlvbjo6Tm9uZSwgRmxvYXRTaXplKHRvdGFsSG9yaXpvbnRhbE1hcmdpbiwgdG90YWxWZXJ0aWNh bE1hcmdpbikpOwotICAgIGlmICghdGV4dEluZGljYXRvcikKKyAgICBpZiAoIXRleHRJbmRpY2F0 b3IpIHsKKyAgICAgICAgbV9maW5kSW5kaWNhdG9yT3ZlcmxheSA9IG51bGxwdHI7CisgICAgICAg IG1faXNTaG93aW5nRmluZEluZGljYXRvciA9IGZhbHNlOwogICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgfQogCiAgICAgbV9maW5kSW5kaWNhdG9yT3ZlcmxheUNsaWVudCA9IHN0ZDo6bWFrZV91 bmlxdWU8RmluZEluZGljYXRvck92ZXJsYXlDbGllbnRJT1M+KHNlbGVjdGVkRnJhbWUsIHRleHRJ bmRpY2F0b3IuZ2V0KCkpOwogICAgIG1fZmluZEluZGljYXRvck92ZXJsYXkgPSBQYWdlT3Zlcmxh eTo6Y3JlYXRlKCptX2ZpbmRJbmRpY2F0b3JPdmVybGF5Q2xpZW50LCBQYWdlT3ZlcmxheTo6T3Zl cmxheVR5cGU6OkRvY3VtZW50KTsK