173194 2017-06-09 16:45:27 -0700 Use WTF::Function instead of std::function in DataURLDecoder 2017-06-09 21:39:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen beidson buildbot koivisto sam oldest_to_newest 1317705 0 cdumez 2017-06-09 16:45:27 -0700 Use WTF::Function instead of std::function in DataURLDecoder, to avoid copying. 1317706 1 312510 cdumez 2017-06-09 16:46:18 -0700 Created attachment 312510 Patch 1317707 2 buildbot 2017-06-09 16:47:37 -0700 Attachment 312510 did not pass style-queue: ERROR: Source/WebCore/platform/network/DataURLDecoder.h:52: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1317760 3 312528 cdumez 2017-06-09 18:36:25 -0700 Created attachment 312528 Patch 1317761 4 buildbot 2017-06-09 18:38:30 -0700 Attachment 312528 did not pass style-queue: ERROR: Source/WebCore/platform/network/DataURLDecoder.h:52: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1317764 5 cdumez 2017-06-09 18:56:20 -0700 The Mac linking errors do not make sense. I think Mac-EWS bots are in a bad state. 1317827 6 312528 sam 2017-06-09 20:43:30 -0700 Comment on attachment 312528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312528&action=review > Source/WebCore/platform/network/DataURLDecoder.cpp:57 > + { } I prefer these on separate lines. 1317833 7 cdumez 2017-06-09 21:07:27 -0700 Committed r218039: <http://trac.webkit.org/changeset/218039> 1317840 8 cdumez 2017-06-09 21:39:45 -0700 Follow-up build fix in https://trac.webkit.org/r218040. 312510 2017-06-09 16:46:18 -0700 2017-06-09 18:36:23 -0700 Patch bug-173194-20170609164617.patch text/plain 3196 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNhMjMzYzZmZGFlYzdh ODE2YWM5NjI1ZWE2OWUzYzA1NmM3NTJjYy4uMzE4ZWM4NjA1YmVmMGZjZmJkMjZkODM0ODllZDJi OTkxNDI2MWJlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFdURjo6RnVuY3Rpb24g aW5zdGVhZCBvZiBzdGQ6OmZ1bmN0aW9uIGluIERhdGFVUkxEZWNvZGVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMxOTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgV1RGOjpGdW5jdGlvbiBpbnN0 ZWFkIG9mIHN0ZDo6ZnVuY3Rpb24gaW4gRGF0YVVSTERlY29kZXIgdG8gYXZvaWQgY29weWluZy4K KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RGF0YVVSTERlY29kZXI6OkRlY29kZVRhc2s6OkRlY29kZVRhc2spOgorICAg ICAgICAoV2ViQ29yZTo6RGF0YVVSTERlY29kZXI6OmNyZWF0ZURlY29kZVRhc2spOgorICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIuaDoKKwogMjAxNy0wNi0wOSAgSmVy IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYSBlbGVtZW50cyBh cmUgYWxsb3dlZCB0byBjb250aW51ZSB0byBsb2FkIG1lZGlhIGRhdGEgYWZ0ZXIgbmF2aWdhdGlv bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9EYXRhVVJMRGVj b2Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0RhdGFVUkxEZWNvZGVy LmNwcAppbmRleCBiMGYwNzA1NDgyOGE2ZDAwOTI2MjJjNzExOTM0MDU0MGE4NWE2YzNlLi41MzMx ZThiOWViY2M3YmQ1OGI4ZmJiMDYzZDNhZDRjMGI3MTdjMmFjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0RhdGFVUkxEZWNvZGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0RhdGFVUkxEZWNvZGVyLmNwcApAQCAtNDcsNiArNDcs MTUgQEAgc3RhdGljIFdvcmtRdWV1ZSYgZGVjb2RlUXVldWUoKQogc3RydWN0IERlY29kZVRhc2sg ewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgorICAgIERlY29kZVRhc2so Y29uc3QgU3RyaW5nJiB1cmxTdHJpbmcsIFN0cmluZ1ZpZXcmJiBlbmNvZGVkRGF0YSwgYm9vbCBp c0Jhc2U2NCwgY29uc3QgU2NoZWR1bGVDb250ZXh0JiBzY2hlZHVsZUNvbnRleHQsIERlY29kZUNv bXBsZXRpb25IYW5kbGVyJiYgY29tcGxldGlvbkhhbmRsZXIsIFJlc3VsdCYmIHJlc3VsdCkKKyAg ICAgICAgOiB1cmxTdHJpbmcodXJsU3RyaW5nLmlzb2xhdGVkQ29weSgpKQorICAgICAgICAsIGVu Y29kZWREYXRhKFdURk1vdmUoZW5jb2RlZERhdGEpKQorICAgICAgICAsIGlzQmFzZTY0KGlzQmFz ZTY0KQorICAgICAgICAsIHNjaGVkdWxlQ29udGV4dChzY2hlZHVsZUNvbnRleHQpCisgICAgICAg ICwgY29tcGxldGlvbkhhbmRsZXIoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpCisgICAgICAg ICwgcmVzdWx0KFdURk1vdmUocmVzdWx0KSkKKyAgICB7IH0KKwogICAgIGNvbnN0IFN0cmluZyB1 cmxTdHJpbmc7CiAgICAgY29uc3QgU3RyaW5nVmlldyBlbmNvZGVkRGF0YTsKICAgICBjb25zdCBi b29sIGlzQmFzZTY0OwpAQCAtMTM0LDE0ICsxNDMsMTQgQEAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0 cjxEZWNvZGVUYXNrPiBjcmVhdGVEZWNvZGVUYXNrKGNvbnN0IFVSTCYgdXJsLCBjb25zdCBTY2hl ZHUKICAgICBib29sIGlzQmFzZTY0ID0gaGVhZGVyLmVuZHNXaXRoSWdub3JpbmdBU0NJSUNhc2Uo U3RyaW5nVmlldyhiYXNlNjRTdHJpbmcpKTsKICAgICBhdXRvIG1lZGlhVHlwZSA9IChpc0Jhc2U2 NCA/IGhlYWRlci5zdWJzdHJpbmcoMCwgaGVhZGVyLmxlbmd0aCgpIC0gc3RybGVuKGJhc2U2NFN0 cmluZykpIDogaGVhZGVyKS50b1N0cmluZygpOwogCi0gICAgcmV0dXJuIHN0ZDo6bWFrZV91bmlx dWU8RGVjb2RlVGFzaz4oRGVjb2RlVGFzayB7Ci0gICAgICAgIHVybFN0cmluZy5pc29sYXRlZENv cHkoKSwKKyAgICByZXR1cm4gc3RkOjptYWtlX3VuaXF1ZTxEZWNvZGVUYXNrPigKKyAgICAgICAg dXJsU3RyaW5nLAogICAgICAgICBXVEZNb3ZlKGVuY29kZWREYXRhKSwKICAgICAgICAgaXNCYXNl NjQsCiAgICAgICAgIHNjaGVkdWxlQ29udGV4dCwKICAgICAgICAgV1RGTW92ZShjb21wbGV0aW9u SGFuZGxlciksCiAgICAgICAgIHBhcnNlTWVkaWFUeXBlKG1lZGlhVHlwZSkKLSAgICB9KTsKKyAg ICApOwogfQogCiBzdGF0aWMgdm9pZCBkZWNvZGVCYXNlNjQoRGVjb2RlVGFzayYgdGFzaykKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIuaAppbmRl eCBlNWRiMTU0MjY2ODc0NDI4NWM1YzhkMWMzM2JhZTUyZGU5NmJmY2E0Li44NjhmY2JjNzdjNGZk OTk4Mzk0YmZhYzVmZDYzMzlhM2QwNmY2MTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL0RhdGFVUkxEZWNvZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9EYXRhVVJMRGVjb2Rlci5oCkBAIC00OSw3ICs0OSw3IEBAIHN0cnVjdCBS ZXN1bHQgewogICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IGRhdGE7CiB9OwogCi11c2luZyBEZWNv ZGVDb21wbGV0aW9uSGFuZGxlciA9IHN0ZDo6ZnVuY3Rpb248dm9pZCAoc3RkOjpvcHRpb25hbDxS ZXN1bHQ+KT47Cit1c2luZyBEZWNvZGVDb21wbGV0aW9uSGFuZGxlciA9IEZ1bmN0aW9uPHZvaWQg KHN0ZDo6b3B0aW9uYWw8UmVzdWx0Pik+Owogc3RydWN0IFNjaGVkdWxlQ29udGV4dCB7CiAjaWYg SEFWRShSVU5MT09QX1RJTUVSKQogICAgIFNjaGVkdWxlUGFpckhhc2hTZXQgc2NoZWR1bGVkUGFp cnM7Cg== 312528 2017-06-09 18:36:25 -0700 2017-06-09 20:43:30 -0700 Patch bug-173194-20170609183623.patch text/plain 3157 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWUxMmU1YzRkMmI5NTZm NDE1ODZjNzFiZGE5N2UyMDJkMWVkMTVmZS4uYzQzYWI4NjNhNTYwMWQ2NWNiNWM5MzVhZDk4NGE0 OTBiMjQ0NTNlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFdURjo6RnVuY3Rpb24g aW5zdGVhZCBvZiBzdGQ6OmZ1bmN0aW9uIGluIERhdGFVUkxEZWNvZGVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMxOTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgV1RGOjpGdW5jdGlvbiBpbnN0 ZWFkIG9mIHN0ZDo6ZnVuY3Rpb24gaW4gRGF0YVVSTERlY29kZXIgdG8gYXZvaWQgY29weWluZy4K KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RGF0YVVSTERlY29kZXI6OkRlY29kZVRhc2s6OkRlY29kZVRhc2spOgorICAg ICAgICAoV2ViQ29yZTo6RGF0YVVSTERlY29kZXI6OmNyZWF0ZURlY29kZVRhc2spOgorICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIuaDoKKwogMjAxNy0wNi0wOSAgUnlh biBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMjE4MDAzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9EYXRhVVJMRGVjb2Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL0RhdGFVUkxEZWNvZGVyLmNwcAppbmRleCBiMGYwNzA1NDgyOGE2ZDAwOTI2MjJjNzExOTM0 MDU0MGE4NWE2YzNlLi41MzMxZThiOWViY2M3YmQ1OGI4ZmJiMDYzZDNhZDRjMGI3MTdjMmFjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0RhdGFVUkxEZWNvZGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0RhdGFVUkxEZWNvZGVy LmNwcApAQCAtNDcsNiArNDcsMTUgQEAgc3RhdGljIFdvcmtRdWV1ZSYgZGVjb2RlUXVldWUoKQog c3RydWN0IERlY29kZVRhc2sgewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGlj OgorICAgIERlY29kZVRhc2soY29uc3QgU3RyaW5nJiB1cmxTdHJpbmcsIFN0cmluZ1ZpZXcmJiBl bmNvZGVkRGF0YSwgYm9vbCBpc0Jhc2U2NCwgY29uc3QgU2NoZWR1bGVDb250ZXh0JiBzY2hlZHVs ZUNvbnRleHQsIERlY29kZUNvbXBsZXRpb25IYW5kbGVyJiYgY29tcGxldGlvbkhhbmRsZXIsIFJl c3VsdCYmIHJlc3VsdCkKKyAgICAgICAgOiB1cmxTdHJpbmcodXJsU3RyaW5nLmlzb2xhdGVkQ29w eSgpKQorICAgICAgICAsIGVuY29kZWREYXRhKFdURk1vdmUoZW5jb2RlZERhdGEpKQorICAgICAg ICAsIGlzQmFzZTY0KGlzQmFzZTY0KQorICAgICAgICAsIHNjaGVkdWxlQ29udGV4dChzY2hlZHVs ZUNvbnRleHQpCisgICAgICAgICwgY29tcGxldGlvbkhhbmRsZXIoV1RGTW92ZShjb21wbGV0aW9u SGFuZGxlcikpCisgICAgICAgICwgcmVzdWx0KFdURk1vdmUocmVzdWx0KSkKKyAgICB7IH0KKwog ICAgIGNvbnN0IFN0cmluZyB1cmxTdHJpbmc7CiAgICAgY29uc3QgU3RyaW5nVmlldyBlbmNvZGVk RGF0YTsKICAgICBjb25zdCBib29sIGlzQmFzZTY0OwpAQCAtMTM0LDE0ICsxNDMsMTQgQEAgc3Rh dGljIHN0ZDo6dW5pcXVlX3B0cjxEZWNvZGVUYXNrPiBjcmVhdGVEZWNvZGVUYXNrKGNvbnN0IFVS TCYgdXJsLCBjb25zdCBTY2hlZHUKICAgICBib29sIGlzQmFzZTY0ID0gaGVhZGVyLmVuZHNXaXRo SWdub3JpbmdBU0NJSUNhc2UoU3RyaW5nVmlldyhiYXNlNjRTdHJpbmcpKTsKICAgICBhdXRvIG1l ZGlhVHlwZSA9IChpc0Jhc2U2NCA/IGhlYWRlci5zdWJzdHJpbmcoMCwgaGVhZGVyLmxlbmd0aCgp IC0gc3RybGVuKGJhc2U2NFN0cmluZykpIDogaGVhZGVyKS50b1N0cmluZygpOwogCi0gICAgcmV0 dXJuIHN0ZDo6bWFrZV91bmlxdWU8RGVjb2RlVGFzaz4oRGVjb2RlVGFzayB7Ci0gICAgICAgIHVy bFN0cmluZy5pc29sYXRlZENvcHkoKSwKKyAgICByZXR1cm4gc3RkOjptYWtlX3VuaXF1ZTxEZWNv ZGVUYXNrPigKKyAgICAgICAgdXJsU3RyaW5nLAogICAgICAgICBXVEZNb3ZlKGVuY29kZWREYXRh KSwKICAgICAgICAgaXNCYXNlNjQsCiAgICAgICAgIHNjaGVkdWxlQ29udGV4dCwKICAgICAgICAg V1RGTW92ZShjb21wbGV0aW9uSGFuZGxlciksCiAgICAgICAgIHBhcnNlTWVkaWFUeXBlKG1lZGlh VHlwZSkKLSAgICB9KTsKKyAgICApOwogfQogCiBzdGF0aWMgdm9pZCBkZWNvZGVCYXNlNjQoRGVj b2RlVGFzayYgdGFzaykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvRGF0YVVSTERlY29kZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0 YVVSTERlY29kZXIuaAppbmRleCBlNWRiMTU0MjY2ODc0NDI4NWM1YzhkMWMzM2JhZTUyZGU5NmJm Y2E0Li44NjhmY2JjNzdjNGZkOTk4Mzk0YmZhYzVmZDYzMzlhM2QwNmY2MTBhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0RhdGFVUkxEZWNvZGVyLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9EYXRhVVJMRGVjb2Rlci5oCkBAIC00OSw3 ICs0OSw3IEBAIHN0cnVjdCBSZXN1bHQgewogICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IGRhdGE7 CiB9OwogCi11c2luZyBEZWNvZGVDb21wbGV0aW9uSGFuZGxlciA9IHN0ZDo6ZnVuY3Rpb248dm9p ZCAoc3RkOjpvcHRpb25hbDxSZXN1bHQ+KT47Cit1c2luZyBEZWNvZGVDb21wbGV0aW9uSGFuZGxl ciA9IEZ1bmN0aW9uPHZvaWQgKHN0ZDo6b3B0aW9uYWw8UmVzdWx0Pik+Owogc3RydWN0IFNjaGVk dWxlQ29udGV4dCB7CiAjaWYgSEFWRShSVU5MT09QX1RJTUVSKQogICAgIFNjaGVkdWxlUGFpckhh c2hTZXQgc2NoZWR1bGVkUGFpcnM7Cg==