173174 2017-06-09 11:37:42 -0700 Make sure we protect |this| in lambdas in WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver() 2017-06-09 15:17:40 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez bfulgham commit-queue darin webkit-bug-importer wilander oldest_to_newest 1317531 0 cdumez 2017-06-09 11:37:42 -0700 Make sure we protect |this| in lambdas in WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver(). 1317532 1 cdumez 2017-06-09 11:37:58 -0700 <rdar://problem/32598919> 1317536 2 312464 cdumez 2017-06-09 11:39:39 -0700 Created attachment 312464 Patch 1317542 3 312466 cdumez 2017-06-09 11:44:01 -0700 Created attachment 312466 Patch 1317547 4 312466 darin 2017-06-09 11:49:58 -0700 Comment on attachment 312466 Patch Looks good to me. After this change, though, WebResourceLoadStatisticsStore::processStatisticsAndDataRecords is the one remaining lambda that captures [this], but does not ref/deref it. The one passed to coreStore().processStatistics. Perhaps that function is guaranteed to run synchronously? 1317548 5 cdumez 2017-06-09 11:50:42 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 312466 [details] > Patch > > Looks good to me. > > After this change, though, > WebResourceLoadStatisticsStore::processStatisticsAndDataRecords is the one > remaining lambda that captures [this], but does not ref/deref it. The one > passed to coreStore().processStatistics. Perhaps that function is guaranteed > to run synchronously? That one is safe because it is synchronous. 1317550 6 312466 cdumez 2017-06-09 11:52:13 -0700 Comment on attachment 312466 Patch Clearing flags on attachment: 312466 Committed r218006: <http://trac.webkit.org/changeset/218006> 1317551 7 cdumez 2017-06-09 11:52:14 -0700 All reviewed patches have been landed. Closing bug. 1317663 8 cdumez 2017-06-09 15:17:40 -0700 Landed a follow-up fix in https://trac.webkit.org/r218022. 312464 2017-06-09 11:39:39 -0700 2017-06-09 11:44:00 -0700 Patch bug-173174-20170609113938.patch text/plain 2545 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWNmNDRhMjcxZmFkODI1 MjdmYjZlZjRiZDVmZWZjZWNmMmM2ZmM5ZC4uMTE1YjVmYjYzMzMxZGRiZjhhYTg1ZDY4NjU5YTBl ZDRjYWVjNjJhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTA2LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBzdXJlIHdlIHByb3Rl Y3QgfHRoaXN8IGluIGxhbWJkYXMgaW4gV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpy ZWdpc3RlclNoYXJlZFJlc291cmNlTG9hZE9ic2VydmVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzE3NAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzI1OTg5MTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpyZWdpc3RlclNo YXJlZFJlc291cmNlTG9hZE9ic2VydmVyKToKKworMjAxNy0wNi0wOSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIEF2b2lkIHNvbWUgcmVmIGNvdW50aW5nIGNodXJu IGluIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZQogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTY4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAK aW5kZXggODVmYzRkYTEyZDk0MDY4MzZlNjFjNTNmMjNhMzdlMGM1MjM1ZTA3My4uMTVkNWNmYWU4 OGYxMDZlZDYwMGU4NGZkZDBkZTA5ZmRkM2ExMTQ2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAK QEAgLTE4MCwxNyArMTgwLDE3IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3Jl OjpyZWdpc3RlclNoYXJlZFJlc291cmNlTG9hZE9ic2VydmVyKCkKICAgICAKICAgICBSZXNvdXJj ZUxvYWRPYnNlcnZlcjo6c2hhcmVkT2JzZXJ2ZXIoKS5zZXRTdGF0aXN0aWNzU3RvcmUobV9yZXNv dXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY29weVJlZigpKTsKICAgICBSZXNvdXJjZUxvYWRPYnNl cnZlcjo6c2hhcmVkT2JzZXJ2ZXIoKS5zZXRTdGF0aXN0aWNzUXVldWUobV9zdGF0aXN0aWNzUXVl dWUuY29weVJlZigpKTsKLSAgICBtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS0+c2V0Tm90 aWZpY2F0aW9uQ2FsbGJhY2soW3RoaXNdIHsKKyAgICBtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3NT dG9yZS0+c2V0Tm90aWZpY2F0aW9uQ2FsbGJhY2soW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtl UmVmKCp0aGlzKV0gewogICAgICAgICBpZiAobV9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUt PmlzRW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgcHJvY2Vzc1N0YXRpc3Rp Y3NBbmREYXRhUmVjb3JkcygpOwogICAgIH0pOwotICAgIG1fcmVzb3VyY2VMb2FkU3RhdGlzdGlj c1N0b3JlLT5zZXRXcml0ZVBlcnNpc3RlbnRTdG9yZUNhbGxiYWNrKFt0aGlzXSgpIHsKLSAgICAg ICAgbV9zdGF0aXN0aWNzUXVldWUtPmRpc3BhdGNoKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFr ZVJlZigqdGhpcyldIHsKKyAgICBtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS0+c2V0V3Jp dGVQZXJzaXN0ZW50U3RvcmVDYWxsYmFjayhbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYo KnRoaXMpXSgpIHsKKyAgICAgICAgbV9zdGF0aXN0aWNzUXVldWUtPmRpc3BhdGNoKFt0aGlzLCBw cm90ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0ZWRUaGlzKV0gewogICAgICAgICAgICAgd3Jp dGVTdG9yZVRvRGlzaygpOwogICAgICAgICB9KTsKICAgICB9KTsKLSAgICBtX3Jlc291cmNlTG9h ZFN0YXRpc3RpY3NTdG9yZS0+c2V0R3JhbmRmYXRoZXJFeGlzdGluZ1dlYnNpdGVEYXRhQ2FsbGJh Y2soW3RoaXNdKCkgeworICAgIG1fcmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLT5zZXRHcmFu ZGZhdGhlckV4aXN0aW5nV2Vic2l0ZURhdGFDYWxsYmFjayhbdGhpcywgcHJvdGVjdGVkVGhpcyA9 IG1ha2VSZWYoKnRoaXMpXSgpIHsKICAgICAgICAgZ3JhbmRmYXRoZXJFeGlzdGluZ1dlYnNpdGVE YXRhKCk7CiAgICAgfSk7CiAjaWYgUExBVEZPUk0oQ09DT0EpCg== 312466 2017-06-09 11:44:01 -0700 2017-06-09 11:52:13 -0700 Patch bug-173174-20170609114400.patch text/plain 2553 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4MDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWNmNDRhMjcxZmFkODI1 MjdmYjZlZjRiZDVmZWZjZWNmMmM2ZmM5ZC4uMTE1YjVmYjYzMzMxZGRiZjhhYTg1ZDY4NjU5YTBl ZDRjYWVjNjJhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTA2LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBzdXJlIHdlIHByb3Rl Y3QgfHRoaXN8IGluIGxhbWJkYXMgaW4gV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpy ZWdpc3RlclNoYXJlZFJlc291cmNlTG9hZE9ic2VydmVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzE3NAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzI1OTg5MTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpyZWdpc3RlclNo YXJlZFJlc291cmNlTG9hZE9ic2VydmVyKToKKworMjAxNy0wNi0wOSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIEF2b2lkIHNvbWUgcmVmIGNvdW50aW5nIGNodXJu IGluIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZQogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTY4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAK aW5kZXggODVmYzRkYTEyZDk0MDY4MzZlNjFjNTNmMjNhMzdlMGM1MjM1ZTA3My4uNWMyN2YzNWI1 MGJkZjkwOTY4MWQ5YTE3MmE5NjIzZWQ5MTczZWMyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAK QEAgLTE4MCwxNyArMTgwLDE3IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3Jl OjpyZWdpc3RlclNoYXJlZFJlc291cmNlTG9hZE9ic2VydmVyKCkKICAgICAKICAgICBSZXNvdXJj ZUxvYWRPYnNlcnZlcjo6c2hhcmVkT2JzZXJ2ZXIoKS5zZXRTdGF0aXN0aWNzU3RvcmUobV9yZXNv dXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY29weVJlZigpKTsKICAgICBSZXNvdXJjZUxvYWRPYnNl cnZlcjo6c2hhcmVkT2JzZXJ2ZXIoKS5zZXRTdGF0aXN0aWNzUXVldWUobV9zdGF0aXN0aWNzUXVl dWUuY29weVJlZigpKTsKLSAgICBtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS0+c2V0Tm90 aWZpY2F0aW9uQ2FsbGJhY2soW3RoaXNdIHsKKyAgICBtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3NT dG9yZS0+c2V0Tm90aWZpY2F0aW9uQ2FsbGJhY2soW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtl UmVmKCp0aGlzKV0gewogICAgICAgICBpZiAobV9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUt PmlzRW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgcHJvY2Vzc1N0YXRpc3Rp Y3NBbmREYXRhUmVjb3JkcygpOwogICAgIH0pOwotICAgIG1fcmVzb3VyY2VMb2FkU3RhdGlzdGlj c1N0b3JlLT5zZXRXcml0ZVBlcnNpc3RlbnRTdG9yZUNhbGxiYWNrKFt0aGlzXSgpIHsKLSAgICAg ICAgbV9zdGF0aXN0aWNzUXVldWUtPmRpc3BhdGNoKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFr ZVJlZigqdGhpcyldIHsKKyAgICBtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS0+c2V0V3Jp dGVQZXJzaXN0ZW50U3RvcmVDYWxsYmFjayhbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYo KnRoaXMpXSgpIG11dGFibGUgeworICAgICAgICBtX3N0YXRpc3RpY3NRdWV1ZS0+ZGlzcGF0Y2go W3RoaXMsIHByb3RlY3RlZFRoaXMgPSBXVEZNb3ZlKHByb3RlY3RlZFRoaXMpXSB7CiAgICAgICAg ICAgICB3cml0ZVN0b3JlVG9EaXNrKCk7CiAgICAgICAgIH0pOwogICAgIH0pOwotICAgIG1fcmVz b3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLT5zZXRHcmFuZGZhdGhlckV4aXN0aW5nV2Vic2l0ZURh dGFDYWxsYmFjayhbdGhpc10oKSB7CisgICAgbV9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUt PnNldEdyYW5kZmF0aGVyRXhpc3RpbmdXZWJzaXRlRGF0YUNhbGxiYWNrKFt0aGlzLCBwcm90ZWN0 ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldKCkgewogICAgICAgICBncmFuZGZhdGhlckV4aXN0aW5n V2Vic2l0ZURhdGEoKTsKICAgICB9KTsKICNpZiBQTEFURk9STShDT0NPQSkK