173137 2017-06-09 00:24:47 -0700 [GTK] Handle page download request in WebKitWebView directly 2017-06-10 23:28:13 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply buildbot gustavo mcatanzaro zan oldest_to_newest 1317253 0 cgarcia 2017-06-09 00:24:47 -0700 We don't need to pass through WebKitWebViewBase, since the base doesn't an implementation. 1317255 1 312400 cgarcia 2017-06-09 00:27:00 -0700 Created attachment 312400 Patch 1317259 2 buildbot 2017-06-09 00:28:34 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1317271 3 312400 zan 2017-06-09 01:00:32 -0700 Comment on attachment 312400 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312400&action=review > Source/WebKit2/ChangeLog:8 > + We don't need to pass through WebKitWebViewBase, since the base doesn't an implementation. You dropped a word there. 1317963 4 cgarcia 2017-06-10 23:28:13 -0700 Committed r218063: <http://trac.webkit.org/changeset/218063> 312400 2017-06-09 00:27:00 -0700 2017-06-09 01:00:32 -0700 Patch wk2-page-download.diff text/plain 7364 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMjRhZjQ4ZTMwNS4uZDc1ZDA3YmIwYWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNy0wNi0wOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gSGFuZGxlIHBhZ2UgZG93bmxvYWQgcmVxdWVzdCBp biBXZWJLaXRXZWJWaWV3IGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzMxMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZSBkb24ndCBuZWVkIHRvIHBhc3MgdGhyb3VnaCBXZWJLaXRXZWJW aWV3QmFzZSwgc2luY2UgdGhlIGJhc2UgZG9lc24ndCBhbiBpbXBsZW1lbnRhdGlvbi4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6UGFnZUNsaWVudEltcGw6OmhhbmRsZURvd25sb2FkUmVxdWVzdCk6CisgICAgICAgICog VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAgICh3ZWJraXRXZWJW aWV3Q29uc3RydWN0ZWQpOgorICAgICAgICAod2Via2l0V2ViVmlld0hhbmRsZURvd25sb2FkUmVx dWVzdCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3Bw OgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VTZXREb3dubG9hZFJlcXVlc3RIYW5kbGVyKTog RGVsZXRlZC4KKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlSGFuZGxlRG93bmxvYWRSZXF1ZXN0 KTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZVByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3UHJp dmF0ZS5oOgorCiAyMDE3LTA2LTA4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVc2UgYSBsYW1iZGEgaW4gd2Via2l0X2Nvb2tpZV9t YW5hZ2VyX2dldF9hY2NlcHRfcG9saWN5IGluc3RlYWQgb2YgdG9HZW5lcmljQ2FsbGJhY2tGdW5j dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNs aWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVu dEltcGwuY3BwCmluZGV4IGI2ZmI5YjhlNzNhLi4xNjZmMDAwMzY1MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcApAQCAtMjcy LDcgKzI3Miw4IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OnN0YXJ0RHJhZyhSZWY8U2VsZWN0aW9u RGF0YT4mJiBzZWxlY3Rpb24sIERyYWdPcGVyYXRpb24gZHJhCiAKIHZvaWQgUGFnZUNsaWVudElt cGw6OmhhbmRsZURvd25sb2FkUmVxdWVzdChEb3dubG9hZFByb3h5KiBkb3dubG9hZCkKIHsKLSAg ICB3ZWJraXRXZWJWaWV3QmFzZUhhbmRsZURvd25sb2FkUmVxdWVzdChXRUJLSVRfV0VCX1ZJRVdf QkFTRShtX3ZpZXdXaWRnZXQpLCBkb3dubG9hZCk7CisgICAgaWYgKFdFQktJVF9JU19XRUJfVklF VyhtX3ZpZXdXaWRnZXQpKQorICAgICAgICB3ZWJraXRXZWJWaWV3SGFuZGxlRG93bmxvYWRSZXF1 ZXN0KFdFQktJVF9XRUJfVklFVyhtX3ZpZXdXaWRnZXQpLCBkb3dubG9hZCk7CiB9CiAKIHZvaWQg UGFnZUNsaWVudEltcGw6OmRpZENvbW1pdExvYWRGb3JNYWluRnJhbWUoY29uc3QgU3RyaW5nJiAv KiBtaW1lVHlwZSAqLywgYm9vbCAvKiB1c2VDdXN0b21Db250ZW50UHJvdmlkZXIgKi8gKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcApp bmRleCBmNWQzYjI5M2VjMS4uNzZmNmM4Mzk4ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCkBAIC02MDEsMTIgKzYwMSw2IEBA IHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3UnVuRmlsZUNob29zZXIoV2ViS2l0V2ViVmll dyogd2ViVmlldywgV2ViS2l0RmlsZUNoCiAgICAgcmV0dXJuIFRSVUU7CiB9CiAKLXN0YXRpYyB2 b2lkIHdlYmtpdFdlYlZpZXdIYW5kbGVEb3dubG9hZFJlcXVlc3QoV2ViS2l0V2ViVmlld0Jhc2Uq IHdlYlZpZXdCYXNlLCBEb3dubG9hZFByb3h5KiBkb3dubG9hZFByb3h5KQotewotICAgIEdSZWZQ dHI8V2ViS2l0RG93bmxvYWQ+IGRvd25sb2FkID0gd2Via2l0V2ViQ29udGV4dEdldE9yQ3JlYXRl RG93bmxvYWQoZG93bmxvYWRQcm94eSk7Ci0gICAgd2Via2l0RG93bmxvYWRTZXRXZWJWaWV3KGRv d25sb2FkLmdldCgpLCBXRUJLSVRfV0VCX1ZJRVcod2ViVmlld0Jhc2UpKTsKLX0KLQogI2lmIFVT RShMSUJOT1RJRlkpCiBzdGF0aWMgY29uc3QgY2hhciogZ05vdGlmeU5vdGlmaWNhdGlvbklEID0g IndrLW5vdGlmeS1ub3RpZmljYXRpb24iOwogCkBAIC02OTUsOCArNjg5LDYgQEAgc3RhdGljIHZv aWQgd2Via2l0V2ViVmlld0NvbnN0cnVjdGVkKEdPYmplY3QqIG9iamVjdCkKICAgICAvLyBUaGUg cmVsYXRlZCB2aWV3IGlzIG9ubHkgdmFsaWQgZHVyaW5nIHRoZSBjb25zdHJ1Y3Rpb24uCiAgICAg cHJpdi0+cmVsYXRlZFZpZXcgPSBudWxscHRyOwogCi0gICAgd2Via2l0V2ViVmlld0Jhc2VTZXRE b3dubG9hZFJlcXVlc3RIYW5kbGVyKFdFQktJVF9XRUJfVklFV19CQVNFKHdlYlZpZXcpLCB3ZWJr aXRXZWJWaWV3SGFuZGxlRG93bmxvYWRSZXF1ZXN0KTsKLQogICAgIGF0dGFjaExvYWRlckNsaWVu dFRvVmlldyh3ZWJWaWV3KTsKICAgICBhdHRhY2hVSUNsaWVudFRvVmlldyh3ZWJWaWV3KTsKICAg ICBhdHRhY2hQb2xpY3lDbGllbnRUb1ZpZXcod2ViVmlldyk7CkBAIC0yMDQxLDYgKzIwMzMsMTMg QEAgdm9pZCB3ZWJraXRXZWJWaWV3TW91c2VUYXJnZXRDaGFuZ2VkKFdlYktpdFdlYlZpZXcqIHdl YlZpZXcsIGNvbnN0IFdlYkhpdFRlc3RSZXMKICAgICBnX3NpZ25hbF9lbWl0KHdlYlZpZXcsIHNp Z25hbHNbTU9VU0VfVEFSR0VUX0NIQU5HRURdLCAwLCBwcml2LT5tb3VzZVRhcmdldEhpdFRlc3RS ZXN1bHQuZ2V0KCksIG1vZGlmaWVycyk7CiB9CiAKK3ZvaWQgd2Via2l0V2ViVmlld0hhbmRsZURv d25sb2FkUmVxdWVzdChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBEb3dubG9hZFByb3h5KiBkb3du bG9hZFByb3h5KQoreworICAgIEFTU0VSVChkb3dubG9hZFByb3h5KTsKKyAgICBHUmVmUHRyPFdl YktpdERvd25sb2FkPiBkb3dubG9hZCA9IHdlYmtpdFdlYkNvbnRleHRHZXRPckNyZWF0ZURvd25s b2FkKGRvd25sb2FkUHJveHkpOworICAgIHdlYmtpdERvd25sb2FkU2V0V2ViVmlldyhkb3dubG9h ZC5nZXQoKSwgd2ViVmlldyk7Cit9CisKIHZvaWQgd2Via2l0V2ViVmlld1ByaW50RnJhbWUoV2Vi S2l0V2ViVmlldyogd2ViVmlldywgV2ViRnJhbWVQcm94eSogZnJhbWUpCiB7CiAgICAgYXV0byBw cmludE9wZXJhdGlvbiA9IGFkb3B0R1JlZih3ZWJraXRfcHJpbnRfb3BlcmF0aW9uX25ldyh3ZWJW aWV3KSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJWaWV3QmFzZS5jcHAKaW5kZXggOTI2NThlODQ3YjQuLmY5YjljYjU0MmQwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jh c2UuY3BwCkBAIC0xODksOCArMTg5LDYgQEAgc3RydWN0IF9XZWJLaXRXZWJWaWV3QmFzZVByaXZh dGUgewogICAgIEFjdGl2aXR5U3RhdGU6OkZsYWdzIGFjdGl2aXR5U3RhdGVGbGFnc1RvVXBkYXRl IHsgMCB9OwogICAgIFJ1bkxvb3A6OlRpbWVyPFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZT4gdXBk YXRlQWN0aXZpdHlTdGF0ZVRpbWVyOwogCi0gICAgV2ViS2l0V2ViVmlld0Jhc2VEb3dubG9hZFJl cXVlc3RIYW5kbGVyIGRvd25sb2FkSGFuZGxlciB7IDAgfTsKLQogI2lmIEVOQUJMRShGVUxMU0NS RUVOX0FQSSkKICAgICBib29sIGZ1bGxTY3JlZW5Nb2RlQWN0aXZlIHsgZmFsc2UgfTsKICAgICBX ZWJGdWxsU2NyZWVuQ2xpZW50R3RrIGZ1bGxTY3JlZW5DbGllbnQ7CkBAIC0xNDQ1LDE3ICsxNDQz LDYgQEAgYm9vbCB3ZWJraXRXZWJWaWV3QmFzZUlzSW5XaW5kb3coV2ViS2l0V2ViVmlld0Jhc2Uq IHdlYlZpZXdCYXNlKQogICAgIHJldHVybiB3ZWJWaWV3QmFzZS0+cHJpdi0+YWN0aXZpdHlTdGF0 ZSAmIEFjdGl2aXR5U3RhdGU6OklzSW5XaW5kb3c7CiB9CiAKLXZvaWQgd2Via2l0V2ViVmlld0Jh c2VTZXREb3dubG9hZFJlcXVlc3RIYW5kbGVyKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFz ZSwgV2ViS2l0V2ViVmlld0Jhc2VEb3dubG9hZFJlcXVlc3RIYW5kbGVyIGRvd25sb2FkSGFuZGxl cikKLXsKLSAgICB3ZWJWaWV3QmFzZS0+cHJpdi0+ZG93bmxvYWRIYW5kbGVyID0gZG93bmxvYWRI YW5kbGVyOwotfQotCi12b2lkIHdlYmtpdFdlYlZpZXdCYXNlSGFuZGxlRG93bmxvYWRSZXF1ZXN0 KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwgRG93bmxvYWRQcm94eSogZG93bmxvYWQp Ci17Ci0gICAgaWYgKHdlYlZpZXdCYXNlLT5wcml2LT5kb3dubG9hZEhhbmRsZXIpCi0gICAgICAg IHdlYlZpZXdCYXNlLT5wcml2LT5kb3dubG9hZEhhbmRsZXIod2ViVmlld0Jhc2UsIGRvd25sb2Fk KTsKLX0KLQogdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVNldElucHV0TWV0aG9kU3RhdGUoV2ViS2l0 V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlLCBib29sIGVuYWJsZWQpCiB7CiAgICAgd2Vi a2l0V2ViVmlld0Jhc2UtPnByaXYtPmlucHV0TWV0aG9kRmlsdGVyLnNldEVuYWJsZWQoZW5hYmxl ZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3QmFzZVByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFdlYlZpZXdCYXNlUHJpdmF0ZS5oCmluZGV4IDZmNWJhOWQwMmM1Li43ODExZDUyNjUyYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll d0Jhc2VQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKQEAgLTYzLDEwICs2Myw2IEBAIGJvb2wgd2Via2l0V2Vi Vmlld0Jhc2VJc0ZvY3VzZWQoV2ViS2l0V2ViVmlld0Jhc2UqKTsKIGJvb2wgd2Via2l0V2ViVmll d0Jhc2VJc1Zpc2libGUoV2ViS2l0V2ViVmlld0Jhc2UqKTsKIGJvb2wgd2Via2l0V2ViVmlld0Jh c2VJc0luV2luZG93KFdlYktpdFdlYlZpZXdCYXNlKik7CiAKLXR5cGVkZWYgdm9pZCAoKldlYktp dFdlYlZpZXdCYXNlRG93bmxvYWRSZXF1ZXN0SGFuZGxlcikgKFdlYktpdFdlYlZpZXdCYXNlKiwg V2ViS2l0OjpEb3dubG9hZFByb3h5Kik7Ci12b2lkIHdlYmtpdFdlYlZpZXdCYXNlU2V0RG93bmxv YWRSZXF1ZXN0SGFuZGxlcihXZWJLaXRXZWJWaWV3QmFzZSosIFdlYktpdFdlYlZpZXdCYXNlRG93 bmxvYWRSZXF1ZXN0SGFuZGxlcik7Ci12b2lkIHdlYmtpdFdlYlZpZXdCYXNlSGFuZGxlRG93bmxv YWRSZXF1ZXN0KFdlYktpdFdlYlZpZXdCYXNlKiwgV2ViS2l0OjpEb3dubG9hZFByb3h5Kik7Ci0K IHZvaWQgd2Via2l0V2ViVmlld0Jhc2VBZGRBdXRoZW50aWNhdGlvbkRpYWxvZyhXZWJLaXRXZWJW aWV3QmFzZSosIEd0a1dpZGdldCogYXV0aERpYWxvZyk7CiB2b2lkIHdlYmtpdFdlYlZpZXdCYXNl Q2FuY2VsQXV0aGVudGljYXRpb25EaWFsb2coV2ViS2l0V2ViVmlld0Jhc2UqKTsKIHZvaWQgd2Vi a2l0V2ViVmlld0Jhc2VBZGRXZWJJbnNwZWN0b3IoV2ViS2l0V2ViVmlld0Jhc2UqLCBHdGtXaWRn ZXQqIGluc3BlY3RvciwgV2ViS2l0OjpBdHRhY2htZW50U2lkZSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3UHJpdmF0ZS5oIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld1ByaXZhdGUuaAppbmRl eCAyNDBkNzMwODg0OS4uNDhmODhjZTNhNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld1ByaXZhdGUuaApAQCAtNDgsNiArNDgs NyBAQCBib29sIHdlYmtpdFdlYlZpZXdSdW5KYXZhU2NyaXB0QmVmb3JlVW5sb2FkQ29uZmlybShX ZWJLaXRXZWJWaWV3KiwgY29uc3QgQ1N0cmluZwogdm9pZCB3ZWJraXRXZWJWaWV3TWFrZVBlcm1p c3Npb25SZXF1ZXN0KFdlYktpdFdlYlZpZXcqLCBXZWJLaXRQZXJtaXNzaW9uUmVxdWVzdCopOwog dm9pZCB3ZWJraXRXZWJWaWV3TWFrZVBvbGljeURlY2lzaW9uKFdlYktpdFdlYlZpZXcqLCBXZWJL aXRQb2xpY3lEZWNpc2lvblR5cGUsIFdlYktpdFBvbGljeURlY2lzaW9uKik7CiB2b2lkIHdlYmtp dFdlYlZpZXdNb3VzZVRhcmdldENoYW5nZWQoV2ViS2l0V2ViVmlldyosIGNvbnN0IFdlYktpdDo6 V2ViSGl0VGVzdFJlc3VsdERhdGEmLCB1bnNpZ25lZCBtb2RpZmllcnMpOwordm9pZCB3ZWJraXRX ZWJWaWV3SGFuZGxlRG93bmxvYWRSZXF1ZXN0KFdlYktpdFdlYlZpZXcqLCBXZWJLaXQ6OkRvd25s b2FkUHJveHkqKTsKIHZvaWQgd2Via2l0V2ViVmlld1ByaW50RnJhbWUoV2ViS2l0V2ViVmlldyos IFdlYktpdDo6V2ViRnJhbWVQcm94eSopOwogdm9pZCB3ZWJraXRXZWJWaWV3UmVzb3VyY2VMb2Fk U3RhcnRlZChXZWJLaXRXZWJWaWV3KiwgV2ViS2l0OjpXZWJGcmFtZVByb3h5KiwgdWludDY0X3Qg cmVzb3VyY2VJZGVudGlmaWVyLCBXZWJLaXRVUklSZXF1ZXN0Kik7CiB2b2lkIHdlYmtpdFdlYlZp ZXdSdW5GaWxlQ2hvb3NlclJlcXVlc3QoV2ViS2l0V2ViVmlldyosIFdlYktpdEZpbGVDaG9vc2Vy UmVxdWVzdCopOwo=