173130 2017-06-08 22:54:35 -0700 Use WTF::getCurrentProcessID() instead of getpid(). 2017-06-13 12:50:43 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 daewoong.jang daewoong.jang achristensen ap commit-queue darin thorton ysuzuki oldest_to_newest 1317221 0 daewoong.jang 2017-06-08 22:54:35 -0700 Use WTF::getCurrentProcessID() instead of getpid(). 1317222 1 312387 daewoong.jang 2017-06-08 22:56:15 -0700 Created attachment 312387 patch 1317333 2 312387 commit-queue 2017-06-09 03:39:59 -0700 Comment on attachment 312387 patch Clearing flags on attachment: 312387 Committed r217975: <http://trac.webkit.org/changeset/217975> 1317334 3 commit-queue 2017-06-09 03:40:01 -0700 All reviewed patches have been landed. Closing bug. 1318519 4 ap 2017-06-12 18:14:40 -0700 Out of curiosity, what is the benefit of one over another here? 1318524 5 daewoong.jang 2017-06-12 18:36:54 -0700 (In reply to Alexey Proskuryakov from comment #4) > Out of curiosity, what is the benefit of one over another here? Now it can be compiled for more platforms(e.g. Windows). 1318527 6 ap 2017-06-12 18:52:44 -0700 This is WebKit2 code, and WebKit2 does not support Windows. That would be large undertaking, which should be discussed on webkit-dev before starting. 1318530 7 daewoong.jang 2017-06-12 18:59:43 -0700 (In reply to Alexey Proskuryakov from comment #6) > This is WebKit2 code, and WebKit2 does not support Windows. That would be > large undertaking, which should be discussed on webkit-dev before starting. You are right if we are going to support WebKit2 on Windows, but this patch does not intend to do such a thing. I think it would not be a harm to use existing platform abstraction of WTF. 1318750 8 achristensen 2017-06-13 12:50:43 -0700 This is like https://bugs.webkit.org/show_bug.cgi?id=172667#c8 I want to keep accepting patches like this, but discuss on webkit-dev before deciding if we want to officially support large amounts of code. 312387 2017-06-08 22:56:15 -0700 2017-06-09 03:39:59 -0700 patch bug173130.diff text/plain 1496 daewoong.jang SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzk2MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA2LTA4ICBEYWV3b29u ZyBKYW5nICA8ZGFld29vbmcuamFuZ0BuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFVzZSBXVEY6 OmdldEN1cnJlbnRQcm9jZXNzSUQoKSBpbnN0ZWFkIG9mIGdldHBpZCgpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMxMzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQVBJUHJv Y2Vzc1Bvb2xDb25maWd1cmF0aW9uLmg6CisKIDIwMTctMDYtMDggIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVzZSBBUEk6OkZvcm1D bGllbnQgaW5zdGVhZCBvZiB0aGUgQyBBUEkgaW4gV2ViS2l0Rm9ybUNsaWVudApJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9BUElQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0FQSVByb2Nlc3NQb29s Q29uZmlndXJhdGlvbi5oCShyZXZpc2lvbiAyMTc5NTQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0FQSVByb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBA IC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiQVBJT2JqZWN0LmgiCiAjaW5jbHVkZSAiQ2FjaGVN b2RlbC5oIgogI2luY2x1ZGUgIldlYnNpdGVEYXRhU3RvcmUuaCIKKyNpbmNsdWRlIDx3dGYvUHJv Y2Vzc0lELmg+CiAjaW5jbHVkZSA8d3RmL1JlZi5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4K ICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CkBAIC0xNjksNyArMTcwLDcgQEAgcHJpdmF0 ZToKICAgICBib29sIG1fYWx3YXlzUnVuc0F0QmFja2dyb3VuZFByaW9yaXR5IHsgZmFsc2UgfTsK ICAgICBib29sIG1fc2hvdWxkVGFrZVVJQmFja2dyb3VuZEFzc2VydGlvbiB7IHRydWUgfTsKICAg ICBib29sIG1fc2hvdWxkQ2FwdHVyZUF1ZGlvSW5VSVByb2Nlc3MgeyBmYWxzZSB9OwotICAgIHBp ZF90IG1fcHJlc2VudGluZ0FwcGxpY2F0aW9uUElEIHsgZ2V0cGlkKCkgfTsKKyAgICBwaWRfdCBt X3ByZXNlbnRpbmdBcHBsaWNhdGlvblBJRCB7IGdldEN1cnJlbnRQcm9jZXNzSUQoKSB9OwogI2lm IFBMQVRGT1JNKElPUykKICAgICBXVEY6OlN0cmluZyBtX2N0RGF0YUNvbm5lY3Rpb25TZXJ2aWNl VHlwZTsKICNlbmRpZgo=