173126 2017-06-08 20:33:40 -0700 Crash in -[WKWebView _initializeWithConfiguration:] 2017-06-09 15:09:06 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble buildbot commit-queue darin dbates eric.carlson jonlee koivisto mkwst oldest_to_newest 1317181 0 jer.noble 2017-06-08 20:33:40 -0700 Crash in -[WKWebView _initializeWithConfiguration:] 1317182 1 312374 jer.noble 2017-06-08 20:35:15 -0700 Created attachment 312374 Patch 1317279 2 312374 commit-queue 2017-06-09 01:05:35 -0700 Comment on attachment 312374 Patch Clearing flags on attachment: 312374 Committed r217967: <http://trac.webkit.org/changeset/217967> 1317280 3 commit-queue 2017-06-09 01:05:37 -0700 All reviewed patches have been landed. Closing bug. 1317376 4 matthew_hanson 2017-06-09 07:05:15 -0700 <rdar://problem/32664993> 1317561 5 312374 darin 2017-06-09 12:02:20 -0700 Comment on attachment 312374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312374&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:140 > NSString *_overrideContentSecurityPolicy; Looks like this has exactly the same problem as _mediaContentTypesRequiringHardwareSupport. Would you fix that, or would you like me to do it? > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:141 > + RetainPtr<NSString> _mediaContentTypesRequiringHardwareSupport; The setter should copy the string, not just retain it. 1317574 6 jer.noble 2017-06-09 12:29:15 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 312374 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312374&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:140 > > NSString *_overrideContentSecurityPolicy; > > Looks like this has exactly the same problem as > _mediaContentTypesRequiringHardwareSupport. Would you fix that, or would you > like me to do it? Sure I'll take care of it when I do the followup below: > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:141 > > + RetainPtr<NSString> _mediaContentTypesRequiringHardwareSupport; > > The setter should copy the string, not just retain it. Good catch! 1317603 7 jer.noble 2017-06-09 13:34:46 -0700 Reopening to attach new patch. 1317604 8 312484 jer.noble 2017-06-09 13:34:46 -0700 Created attachment 312484 Follow-up Patch 1317655 9 312484 commit-queue 2017-06-09 15:09:04 -0700 Comment on attachment 312484 Follow-up Patch Clearing flags on attachment: 312484 Committed r218021: <http://trac.webkit.org/changeset/218021> 1317656 10 commit-queue 2017-06-09 15:09:06 -0700 All reviewed patches have been landed. Closing bug. 312374 2017-06-08 20:35:15 -0700 2017-06-09 01:05:35 -0700 Patch bug-173126-20170608203514.patch text/plain 2048 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3ODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWNhOGYwY2QzODZiODE4 MmU4ZDAyY2Y2YjM2NTA4NTkyZDEyMDg3MS4uNThmN2Y5ZjNkOTJiNmVhYzVlYjcwNmU4ZmUwMDcz ZTc4YTJhMjY4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA2LTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIC1bV0tXZWJW aWV3IF9pbml0aWFsaXplV2l0aENvbmZpZ3VyYXRpb246XQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3Jhc2ggb2NjdXJzIHdoZW4gcGFzc2luZyBhbiBh dXRvcmVsZWFzZWQgTlNTdHJpbmcgaW50byBfc2V0TWVkaWFDb250ZW50VHlwZXNSZXF1aXJpbmdI YXJkd2FyZVN1cHBvcnQuCisgICAgICAgIFRoZSBpdmFyIHNob3VsZCBiZSBhIFJldGFpblB0ciBy YXRoZXIgdGhhbiBhIGJhcmUgTlNTdHJpbmcgKi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3Q29u ZmlndXJhdGlvbiBfbWVkaWFDb250ZW50VHlwZXNSZXF1aXJpbmdIYXJkd2FyZVN1cHBvcnRdKToK KwogMjAxNy0wNi0wNyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAg ICBDbGllbnRzIG9mIHRoZSBXSzIgQy1BUEkgZG9uJ3QgaGF2ZSB0aGVpciBtZWRpYUNvbnRlbnRU eXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydCBzZXR0aW5nIGluaXRpYWxpemVkIGNvcnJlY3Rs eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Q29uZmlndXJhdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQppbmRleCBmZjg4Y2I2ZjJmMTBmYmJjNjQ3NTdhYTM5 YzU4YzMzYmY5MWUyOTk3Li5jOTMxNGNiNThlZTQzYmM4YmY0ZjFiM2E3N2NmNTI0ZDU5Nzg3MzIx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d0NvbmZpZ3VyYXRpb24ubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLm1tCkBAIC0xMzgsNyArMTM4LDcgQEAgQGltcGxlbWVu dGF0aW9uIFdLV2ViVmlld0NvbmZpZ3VyYXRpb24gewogICAgIEJPT0wgX25lZWRzU3RvcmFnZUFj Y2Vzc0Zyb21GaWxlVVJMc1F1aXJrOwogCiAgICAgTlNTdHJpbmcgKl9vdmVycmlkZUNvbnRlbnRT ZWN1cml0eVBvbGljeTsKLSAgICBOU1N0cmluZyAqX21lZGlhQ29udGVudFR5cGVzUmVxdWlyaW5n SGFyZHdhcmVTdXBwb3J0OworICAgIFJldGFpblB0cjxOU1N0cmluZz4gX21lZGlhQ29udGVudFR5 cGVzUmVxdWlyaW5nSGFyZHdhcmVTdXBwb3J0OwogfQogCiAtIChpbnN0YW5jZXR5cGUpaW5pdApA QCAtODIzLDcgKzgyMyw3IEBAIC0gKHZvaWQpX3NldE92ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9s aWN5OihOU1N0cmluZyAqKW92ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9sCiAKIC0gKE5TU3RyaW5n ICopX21lZGlhQ29udGVudFR5cGVzUmVxdWlyaW5nSGFyZHdhcmVTdXBwb3J0CiB7Ci0gICAgcmV0 dXJuIF9tZWRpYUNvbnRlbnRUeXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydDsKKyAgICByZXR1 cm4gX21lZGlhQ29udGVudFR5cGVzUmVxdWlyaW5nSGFyZHdhcmVTdXBwb3J0LmdldCgpOwogfQog CiAtICh2b2lkKV9zZXRNZWRpYUNvbnRlbnRUeXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydDoo TlNTdHJpbmcgKiltZWRpYUNvbnRlbnRUeXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydAo= 312484 2017-06-09 13:34:46 -0700 2017-06-09 15:09:04 -0700 Follow-up Patch bug-173126-20170609133446.patch text/plain 3557 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3ODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNThmN2Y5ZjNkOTJiNmVh YzVlYjcwNmU4ZmUwMDczZTc4YTJhMjY4NS4uMmMwYWY4Y2YwZmRiZTZmN2JkNWY1N2U1MTM2NTVi YTIzZTljMTc0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA2LTA5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIC1bV0tXZWJW aWV3IF9pbml0aWFsaXplV2l0aENvbmZpZ3VyYXRpb246XQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTI2CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zMjY2NDk5Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGb2xsb3cgdXAgdG8gcHJldmlvdXMgZml4OyB3aGVuIHNldHRpbmcgTlNTdHJpbmcgcHJv cGVydGllcywgc3RvcmUgYSBjb3B5IG9mCisgICAgICAgIHRoZSBzdHJpbmcgcmF0aGVyIHRoYW4g dGhlIE5TU3RyaW5nIGl0c2VsZi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Q29uZmlndXJhdGlvbi5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlv biBjb3B5V2l0aFpvbmU6XSk6CisgICAgICAgICgtW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gX292 ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9saWN5XSk6CisgICAgICAgICgtW1dLV2ViVmlld0NvbmZp Z3VyYXRpb24gX3NldE92ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9saWN5Ol0pOgorICAgICAgICAo LVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIF9zZXRNZWRpYUNvbnRlbnRUeXBlc1JlcXVpcmluZ0hh cmR3YXJlU3VwcG9ydDpdKToKKwogMjAxNy0wNi0wOCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiAtW1dLV2ViVmlldyBfaW5pdGlhbGl6ZVdpdGhD b25maWd1cmF0aW9uOl0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQppbmRleCBjOTMxNGNiNThlZTQz YmM4YmY0ZjFiM2E3N2NmNTI0ZDU5Nzg3MzIxLi5mYTgzZDBmZjhlYzc3ZDFlMWM2NWEyNmQwNzZk MGY1YjRjZDAxZDE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLm1tCkBAIC0xMzcsNyArMTM3LDcg QEAgQGltcGxlbWVudGF0aW9uIFdLV2ViVmlld0NvbmZpZ3VyYXRpb24gewogI2VuZGlmCiAgICAg Qk9PTCBfbmVlZHNTdG9yYWdlQWNjZXNzRnJvbUZpbGVVUkxzUXVpcms7CiAKLSAgICBOU1N0cmlu ZyAqX292ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9saWN5OworICAgIFJldGFpblB0cjxOU1N0cmlu Zz4gX292ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9saWN5OwogICAgIFJldGFpblB0cjxOU1N0cmlu Zz4gX21lZGlhQ29udGVudFR5cGVzUmVxdWlyaW5nSGFyZHdhcmVTdXBwb3J0OwogfQogCkBAIC0z MzEsMTAgKzMzMSwxMCBAQCAtIChpZCljb3B5V2l0aFpvbmU6KE5TWm9uZSAqKXpvbmUKICAgICBj b25maWd1cmF0aW9uLT5fYXBwbGVQYXlFbmFibGVkID0gc2VsZi0+X2FwcGxlUGF5RW5hYmxlZDsK ICNlbmRpZgogICAgIGNvbmZpZ3VyYXRpb24tPl9uZWVkc1N0b3JhZ2VBY2Nlc3NGcm9tRmlsZVVS THNRdWlyayA9IHNlbGYtPl9uZWVkc1N0b3JhZ2VBY2Nlc3NGcm9tRmlsZVVSTHNRdWlyazsKLSAg ICBjb25maWd1cmF0aW9uLT5fb3ZlcnJpZGVDb250ZW50U2VjdXJpdHlQb2xpY3kgPSBzZWxmLT5f b3ZlcnJpZGVDb250ZW50U2VjdXJpdHlQb2xpY3k7CisgICAgY29uZmlndXJhdGlvbi0+X292ZXJy aWRlQ29udGVudFNlY3VyaXR5UG9saWN5ID0gYWRvcHROUyhbc2VsZi0+X292ZXJyaWRlQ29udGVu dFNlY3VyaXR5UG9saWN5IGNvcHlXaXRoWm9uZTp6b25lXSk7CiAKICAgICBjb25maWd1cmF0aW9u LT5fdXJsU2NoZW1lSGFuZGxlcnMuc2V0KGFkb3B0TlMoW3NlbGYuX3VybFNjaGVtZUhhbmRsZXJz IG11dGFibGVDb3B5V2l0aFpvbmU6em9uZV0pKTsKLSAgICBjb25maWd1cmF0aW9uLT5fbWVkaWFD b250ZW50VHlwZXNSZXF1aXJpbmdIYXJkd2FyZVN1cHBvcnQgPSBzZWxmLl9tZWRpYUNvbnRlbnRU eXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydDsKKyAgICBjb25maWd1cmF0aW9uLT5fbWVkaWFD b250ZW50VHlwZXNSZXF1aXJpbmdIYXJkd2FyZVN1cHBvcnQgPSBhZG9wdE5TKFtzZWxmLl9tZWRp YUNvbnRlbnRUeXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydCBjb3B5V2l0aFpvbmU6em9uZV0p OwogCiAgICAgcmV0dXJuIGNvbmZpZ3VyYXRpb247CiB9CkBAIC04MTMsMTIgKzgxMywxMiBAQCAt ICh2b2lkKV9zZXROZWVkc1N0b3JhZ2VBY2Nlc3NGcm9tRmlsZVVSTHNRdWlyazooQk9PTCluZWVk c0xvY2FsU3RvcmFnZVF1aXJrCiAKIC0gKE5TU3RyaW5nICopX292ZXJyaWRlQ29udGVudFNlY3Vy aXR5UG9saWN5CiB7Ci0gICAgcmV0dXJuIF9vdmVycmlkZUNvbnRlbnRTZWN1cml0eVBvbGljeTsK KyAgICByZXR1cm4gX292ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9saWN5LmdldCgpOwogfQogCiAt ICh2b2lkKV9zZXRPdmVycmlkZUNvbnRlbnRTZWN1cml0eVBvbGljeTooTlNTdHJpbmcgKilvdmVy cmlkZUNvbnRlbnRTZWN1cml0eVBvbGljeQogewotICAgIF9vdmVycmlkZUNvbnRlbnRTZWN1cml0 eVBvbGljeSA9IG92ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9saWN5OworICAgIF9vdmVycmlkZUNv bnRlbnRTZWN1cml0eVBvbGljeSA9IGFkb3B0TlMoW292ZXJyaWRlQ29udGVudFNlY3VyaXR5UG9s aWN5IGNvcHldKTsKIH0KIAogLSAoTlNTdHJpbmcgKilfbWVkaWFDb250ZW50VHlwZXNSZXF1aXJp bmdIYXJkd2FyZVN1cHBvcnQKQEAgLTgyOCw3ICs4MjgsNyBAQCAtIChOU1N0cmluZyAqKV9tZWRp YUNvbnRlbnRUeXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydAogCiAtICh2b2lkKV9zZXRNZWRp YUNvbnRlbnRUeXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydDooTlNTdHJpbmcgKiltZWRpYUNv bnRlbnRUeXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydAogewotICAgIF9tZWRpYUNvbnRlbnRU eXBlc1JlcXVpcmluZ0hhcmR3YXJlU3VwcG9ydCA9IG1lZGlhQ29udGVudFR5cGVzUmVxdWlyaW5n SGFyZHdhcmVTdXBwb3J0OworICAgIF9tZWRpYUNvbnRlbnRUeXBlc1JlcXVpcmluZ0hhcmR3YXJl U3VwcG9ydCA9IGFkb3B0TlMoW21lZGlhQ29udGVudFR5cGVzUmVxdWlyaW5nSGFyZHdhcmVTdXBw b3J0IGNvcHldKTsKIH0KIAogQGVuZAo=