173123 2017-06-08 17:10:02 -0700 Crash under -[WKWebView _updateVisibleContentRects] 2017-06-08 17:47:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser simon.fraser thorton oldest_to_newest 1317136 0 simon.fraser 2017-06-08 17:10:02 -0700 Crash under -[WKWebView _updateVisibleContentRects] 1317138 1 312362 simon.fraser 2017-06-08 17:11:14 -0700 Created attachment 312362 Patch 1317139 2 simon.fraser 2017-06-08 17:11:34 -0700 rdar://problem/32650112 1317143 3 312362 thorton 2017-06-08 17:15:53 -0700 Comment on attachment 312362 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312362&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:319 > +- (BOOL)_isValid Maybe adopt this in _webProcessIdentifier and _killWebProcess? This is definitely better than those, which don't do the nil check. 1317148 4 simon.fraser 2017-06-08 17:47:03 -0700 https://trac.webkit.org/r217956 312362 2017-06-08 17:11:14 -0700 2017-06-08 17:15:53 -0700 Patch bug-173123-20170608171114.patch text/plain 2468 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjcxYmJhMDk2ZDE3MTdm ZTMwYjkxNDZiOTM4Y2E2MzZjOWJjM2JjYy4uYzZlZmMzYmE0ZGMzZGM2ZGRlNGExMDA4NmRlYTBl NWNmMmRlNGM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA2LTA4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIHVuZGVy IC1bV0tXZWJWaWV3IF91cGRhdGVWaXNpYmxlQ29udGVudFJlY3RzXQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTIzCisgICAgICAgIHJkYXI6Ly9w cm9ibGVtLzMyNjUwMTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTWFrZSBzdXJlIHRoZSBXS1dlYlZpZXcgaXMgdmFsaWQgaW4gcGxhY2VzIHdoZXJl IHdlIGRpc3BhdGNoX2FzeW5jIG9yIHVzZQorICAgICAgICBhIHByZS1jb21taXQgaGFuZGxlci4K KworICAgICAgICBTcGVjdWxhdGl2ZSBmaXggZm9yIGEgcmFyZSBjcmFzaGVyLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmll dyBfaXNWYWxpZF0pOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2FkZFVwZGF0ZVZpc2libGVDb250 ZW50UmVjdFByZUNvbW1pdEhhbmRsZXJdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zY2hlZHVs ZVZpc2libGVDb250ZW50UmVjdFVwZGF0ZUFmdGVyU2Nyb2xsSW5WaWV3Ol0pOgorCiAyMDE3LTA2 LTA3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVz ZSBpbml0aWFsaXplcnMgaW4gV2ViUGFnZVByb3h5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IDdjNWMzZTJiNmU3MjYyYjhlOTUyMjBj MWQwMmVlNTRjMjE5MzU1ZmMuLjEyZDk4MmIzYmViMzc4YWQ4ZGE2OGYzNjQ1ZWFlOWU4YWI2Zjk3 ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tCkBAIC0zMTYsNiArMzE2LDExIEBAIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aEZyYW1lOihD R1JlY3QpZnJhbWUKICAgICByZXR1cm4gW3NlbGYgaW5pdFdpdGhGcmFtZTpmcmFtZSBjb25maWd1 cmF0aW9uOmFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1cmF0aW9uIGFsbG9jXSBpbml0XSkuZ2V0 KCldOwogfQogCistIChCT09MKV9pc1ZhbGlkCit7CisgICAgcmV0dXJuIF9wYWdlICYmIF9wYWdl LT5pc1ZhbGlkKCk7Cit9CisKICNpZiBQTEFURk9STShJT1MpCiBzdGF0aWMgaW50MzJfdCBkZXZp Y2VPcmllbnRhdGlvbkZvclVJSW50ZXJmYWNlT3JpZW50YXRpb24oVUlJbnRlcmZhY2VPcmllbnRh dGlvbiBvcmllbnRhdGlvbikKIHsKQEAgLTIzNTMsNiArMjM1OCw4IEBAIC0gKHZvaWQpX2FkZFVw ZGF0ZVZpc2libGVDb250ZW50UmVjdFByZUNvbW1pdEhhbmRsZXIKICAgICBhdXRvIHJldGFpbmVk U2VsZiA9IHJldGFpblB0cihzZWxmKTsKICAgICBbQ0FUcmFuc2FjdGlvbiBhZGRDb21taXRIYW5k bGVyOltyZXRhaW5lZFNlbGZdIHsKICAgICAgICAgV0tXZWJWaWV3ICp3ZWJWaWV3ID0gcmV0YWlu ZWRTZWxmLmdldCgpOworICAgICAgICBpZiAoIVt3ZWJWaWV3IF9pc1ZhbGlkXSkKKyAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgW3dlYlZpZXcgX3VwZGF0ZVZpc2libGVDb250ZW50UmVjdHNd OwogICAgICAgICB3ZWJWaWV3LT5faGFzU2NoZWR1bGVkVmlzaWJsZVJlY3RVcGRhdGUgPSBOTzsK ICAgICB9IGZvclBoYXNlOmtDQVRyYW5zYWN0aW9uUGhhc2VQcmVDb21taXRdOwpAQCAtMjM3Nyw2 ICsyMzg0LDggQEAgLSAodm9pZClfc2NoZWR1bGVWaXNpYmxlQ29udGVudFJlY3RVcGRhdGVBZnRl clNjcm9sbEluVmlldzooVUlTY3JvbGxWaWV3ICopc2Nyb2wKIAogICAgIGRpc3BhdGNoX2FzeW5j KGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIFtyZXRhaW5lZFNlbGYgPSByZXRhaW5QdHIoc2Vs ZildIHsKICAgICAgICAgV0tXZWJWaWV3ICp3ZWJWaWV3ID0gcmV0YWluZWRTZWxmLmdldCgpOwor ICAgICAgICBpZiAoIVt3ZWJWaWV3IF9pc1ZhbGlkXSkKKyAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgW3dlYlZpZXcgX2FkZFVwZGF0ZVZpc2libGVDb250ZW50UmVjdFByZUNvbW1pdEhhbmRs ZXJdOwogICAgIH0pOwogfQo=