173115 2017-06-08 14:50:02 -0700 [iOS] LowPowerModeNotifier notifies client on non-main thread 2017-06-08 19:59:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren koivisto rniwa webkit-bug-importer oldest_to_newest 1317071 0 cdumez 2017-06-08 14:50:02 -0700 LowPowerModeNotifier notifies client on non-main thread which clients do not expect and this is causing crashes. 1317072 1 cdumez 2017-06-08 14:50:19 -0700 <rdar://problem/32644703> 1317073 2 312348 cdumez 2017-06-08 14:53:35 -0700 Created attachment 312348 Patch 1317134 3 312348 rniwa 2017-06-08 17:05:18 -0700 Comment on attachment 312348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312348&action=review > Source/WebCore/platform/ios/LowPowerModeNotifierIOS.mm:64 > + dispatch_async(dispatch_get_main_queue(), ^ { Why don't we just use callOnMainThread?? 1317153 4 312348 cdumez 2017-06-08 18:08:42 -0700 Comment on attachment 312348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312348&action=review >> Source/WebCore/platform/ios/LowPowerModeNotifierIOS.mm:64 >> + dispatch_async(dispatch_get_main_queue(), ^ { > > Why don't we just use callOnMainThread?? We can but this is iOS specific code anyway. 1317161 5 312367 cdumez 2017-06-08 18:29:23 -0700 Created attachment 312367 Patch 1317164 6 312369 cdumez 2017-06-08 19:01:43 -0700 Created attachment 312369 Patch 1317177 7 rniwa 2017-06-08 19:52:47 -0700 (In reply to Chris Dumez from comment #4) > Comment on attachment 312348 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312348&action=review > > >> Source/WebCore/platform/ios/LowPowerModeNotifierIOS.mm:64 > >> + dispatch_async(dispatch_get_main_queue(), ^ { > > > > Why don't we just use callOnMainThread?? > > We can but this is iOS specific code anyway. Sure but I think using callOnMainThread here would make the code read better. 1317178 8 312369 commit-queue 2017-06-08 19:59:45 -0700 Comment on attachment 312369 Patch Clearing flags on attachment: 312369 Committed r217959: <http://trac.webkit.org/changeset/217959> 1317179 9 commit-queue 2017-06-08 19:59:46 -0700 All reviewed patches have been landed. Closing bug. 312348 2017-06-08 14:53:35 -0700 2017-06-08 18:29:21 -0700 Patch bug-173115-20170608145335.patch text/plain 1667 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ0NmI2OWE2YWQzYjc1 MjBlYjUxNmU4YzZjMzU1NDA1NmNhZWM3NC4uOGE0MGMwMDIyMjljZjYzYzhkZmYzNWQzNzhlMTRk OWQ2ZGY1YTc5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gTG93UG93ZXJNb2Rl Tm90aWZpZXIgbm90aWZpZXMgY2xpZW50IG9uIG5vbi1tYWluIHRocmVhZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTE1CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zMjY0NDcwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGUgaU9TJ3MgaW1wbGVtZW50YXRpb24gb2YgdGhlIExvd1Bvd2Vy TW9kZU5vdGlmaWVyIHRvIG1ha2Ugc3VyZQorICAgICAgICB3ZSBub3RpZnkgdGhlIGNsaWVudCBv ZiBsb3cgcG93ZXIgbW9kZSBjaGFuZ2VzIG9uIHRoZSBtYWluIHRocmVhZC4KKworICAgICAgICAq IHBsYXRmb3JtL2lvcy9Mb3dQb3dlck1vZGVOb3RpZmllcklPUy5tbToKKyAgICAgICAgKC1bV2Vi TG93UG93ZXJNb2RlT2JzZXJ2ZXIgX2RpZFJlY2VpdmVMb3dQb3dlck1vZGVDaGFuZ2VdKToKKwog MjAxNy0wNi0wNyAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBMYWls aSByZXN0YXVyYW50IG1lbnUgcGFnZSBkb2VzIG5vdCBkaXNwbGF5IGZ1bGwgbWVudQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0xvd1Bvd2VyTW9kZU5vdGlmaWVySU9T Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0xvd1Bvd2VyTW9kZU5vdGlmaWVySU9T Lm1tCmluZGV4IGZjY2Y0ZmE4MDMwN2ZiYmEwMDJjODM4MzdiOTZkZDU5MTg4ZmY0NjEuLjBhZGZk NjE3MTE5ZWU3NmY0NTA4OGMzNjZmNWU4NDAyYTc4ZjE3MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9Mb3dQb3dlck1vZGVOb3RpZmllcklPUy5tbQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvTG93UG93ZXJNb2RlTm90aWZpZXJJT1MubW0KQEAgLTYw LDcgKzYwLDEwIEBACiAtICh2b2lkKV9kaWRSZWNlaXZlTG93UG93ZXJNb2RlQ2hhbmdlCiB7CiAg ICAgX2lzTG93UG93ZXJNb2RlRW5hYmxlZCA9IFtOU1Byb2Nlc3NJbmZvIHByb2Nlc3NJbmZvXS5s b3dQb3dlck1vZGVFbmFibGVkOwotICAgIG5vdGlmeUxvd1Bvd2VyTW9kZUNoYW5nZWQoX25vdGlm aWVyLCBfaXNMb3dQb3dlck1vZGVFbmFibGVkKTsKKyAgICAvLyBXZSBuZWVkIHRvIG1ha2Ugc3Vy ZSB3ZSBub3RpZnkgdGhlIGNsaWVudCBvbiB0aGUgbWFpbiB0aHJlYWQuCisgICAgZGlzcGF0Y2hf YXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXiB7CisgICAgICAgIG5vdGlmeUxvd1Bv d2VyTW9kZUNoYW5nZWQoX25vdGlmaWVyLCBfaXNMb3dQb3dlck1vZGVFbmFibGVkKTsKKyAgICB9 KTsKIH0KIAogQGVuZAo= 312367 2017-06-08 18:29:23 -0700 2017-06-08 19:01:41 -0700 Patch bug-173115-20170608182920.patch text/plain 1944 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNlMGI5ZWYyNDc4NWUy ZjA0M2E4NGU1YjZmNGViNTkyZjUwNjEyNi4uMTI5NzZiMWM0NWI0MDgzMTM2MWU0OGRmMTYzZWZl OGVmYTNiMTU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gTG93UG93ZXJNb2Rl Tm90aWZpZXIgbm90aWZpZXMgY2xpZW50IG9uIG5vbi1tYWluIHRocmVhZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTE1CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zMjY0NDcwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2Eu CisKKyAgICAgICAgVXBkYXRlIGlPUydzIGltcGxlbWVudGF0aW9uIG9mIHRoZSBMb3dQb3dlck1v ZGVOb3RpZmllciB0byBtYWtlIHN1cmUKKyAgICAgICAgd2Ugbm90aWZ5IHRoZSBjbGllbnQgb2Yg bG93IHBvd2VyIG1vZGUgY2hhbmdlcyBvbiB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9pb3MvTG93UG93ZXJNb2RlTm90aWZpZXJJT1MubW06CisgICAgICAgICgtW1dlYkxv d1Bvd2VyTW9kZU9ic2VydmVyIF9kaWRSZWNlaXZlTG93UG93ZXJNb2RlQ2hhbmdlXSk6CisKIDIw MTctMDYtMDggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAg ICAgICBbQ29jb2FdIEV4cGFuZCBzeXN0ZW0tdWkgdG8gaW5jbHVkZSBldmVyeSBpdGVtIGluIHRo ZSBDb3JlIFRleHQgY2FzY2FkZSBsaXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvTG93UG93ZXJNb2RlTm90aWZpZXJJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvTG93UG93ZXJNb2RlTm90aWZpZXJJT1MubW0KaW5kZXggZmNjZjRmYTgwMzA3ZmJi YTAwMmM4MzgzN2I5NmRkNTkxODhmZjQ2MS4uNGFkZDk0N2Y1MDEzZmY1M2U3YjdkMDE4ZGM3ZWU1 MjNkNmU3OGExMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0xvd1Bv d2VyTW9kZU5vdGlmaWVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9M b3dQb3dlck1vZGVOb3RpZmllcklPUy5tbQpAQCAtMzAsNiArMzAsNyBAQAogCiAjaW1wb3J0ICJM b2dnaW5nLmgiCiAjaW1wb3J0IDxGb3VuZGF0aW9uL05TUHJvY2Vzc0luZm8uaD4KKyNpbXBvcnQg PHd0Zi9NYWluVGhyZWFkLmg+CiAKIEBpbnRlcmZhY2UgV2ViTG93UG93ZXJNb2RlT2JzZXJ2ZXIg OiBOU09iamVjdAogQHByb3BlcnR5IChub25hdG9taWMpIFdlYkNvcmU6Okxvd1Bvd2VyTW9kZU5v dGlmaWVyKiBub3RpZmllcjsKQEAgLTYwLDcgKzYxLDEwIEBAIC0gKHZvaWQpZGVhbGxvYwogLSAo dm9pZClfZGlkUmVjZWl2ZUxvd1Bvd2VyTW9kZUNoYW5nZQogewogICAgIF9pc0xvd1Bvd2VyTW9k ZUVuYWJsZWQgPSBbTlNQcm9jZXNzSW5mbyBwcm9jZXNzSW5mb10ubG93UG93ZXJNb2RlRW5hYmxl ZDsKLSAgICBub3RpZnlMb3dQb3dlck1vZGVDaGFuZ2VkKF9ub3RpZmllciwgX2lzTG93UG93ZXJN b2RlRW5hYmxlZCk7CisgICAgLy8gV2UgbmVlZCB0byBtYWtlIHN1cmUgd2Ugbm90aWZ5IHRoZSBj bGllbnQgb24gdGhlIG1haW4gdGhyZWFkLgorICAgIGNhbGxPbk1haW5UaHJlYWQoW19ub3RpZmll ciwgX2lzTG93UG93ZXJNb2RlRW5hYmxlZF0geworICAgICAgICBub3RpZnlMb3dQb3dlck1vZGVD aGFuZ2VkKF9ub3RpZmllciwgX2lzTG93UG93ZXJNb2RlRW5hYmxlZCk7CisgICAgfSk7CiB9CiAK IEBlbmQK 312369 2017-06-08 19:01:43 -0700 2017-06-08 19:59:45 -0700 Patch bug-173115-20170608190140.patch text/plain 1977 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNlMGI5ZWYyNDc4NWUy ZjA0M2E4NGU1YjZmNGViNTkyZjUwNjEyNi4uMTI5NzZiMWM0NWI0MDgzMTM2MWU0OGRmMTYzZWZl OGVmYTNiMTU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gTG93UG93ZXJNb2Rl Tm90aWZpZXIgbm90aWZpZXMgY2xpZW50IG9uIG5vbi1tYWluIHRocmVhZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMTE1CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zMjY0NDcwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2Eu CisKKyAgICAgICAgVXBkYXRlIGlPUydzIGltcGxlbWVudGF0aW9uIG9mIHRoZSBMb3dQb3dlck1v ZGVOb3RpZmllciB0byBtYWtlIHN1cmUKKyAgICAgICAgd2Ugbm90aWZ5IHRoZSBjbGllbnQgb2Yg bG93IHBvd2VyIG1vZGUgY2hhbmdlcyBvbiB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9pb3MvTG93UG93ZXJNb2RlTm90aWZpZXJJT1MubW06CisgICAgICAgICgtW1dlYkxv d1Bvd2VyTW9kZU9ic2VydmVyIF9kaWRSZWNlaXZlTG93UG93ZXJNb2RlQ2hhbmdlXSk6CisKIDIw MTctMDYtMDggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAg ICAgICBbQ29jb2FdIEV4cGFuZCBzeXN0ZW0tdWkgdG8gaW5jbHVkZSBldmVyeSBpdGVtIGluIHRo ZSBDb3JlIFRleHQgY2FzY2FkZSBsaXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvTG93UG93ZXJNb2RlTm90aWZpZXJJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvTG93UG93ZXJNb2RlTm90aWZpZXJJT1MubW0KaW5kZXggZmNjZjRmYTgwMzA3ZmJi YTAwMmM4MzgzN2I5NmRkNTkxODhmZjQ2MS4uY2Q2NGNhODY5MzY2NWNjMmM1ZGZjMjk4MjI3ZjNm ZTFlODBkZjE0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0xvd1Bv d2VyTW9kZU5vdGlmaWVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9M b3dQb3dlck1vZGVOb3RpZmllcklPUy5tbQpAQCAtMzAsNiArMzAsNyBAQAogCiAjaW1wb3J0ICJM b2dnaW5nLmgiCiAjaW1wb3J0IDxGb3VuZGF0aW9uL05TUHJvY2Vzc0luZm8uaD4KKyNpbXBvcnQg PHd0Zi9NYWluVGhyZWFkLmg+CiAKIEBpbnRlcmZhY2UgV2ViTG93UG93ZXJNb2RlT2JzZXJ2ZXIg OiBOU09iamVjdAogQHByb3BlcnR5IChub25hdG9taWMpIFdlYkNvcmU6Okxvd1Bvd2VyTW9kZU5v dGlmaWVyKiBub3RpZmllcjsKQEAgLTYwLDcgKzYxLDEwIEBAIC0gKHZvaWQpZGVhbGxvYwogLSAo dm9pZClfZGlkUmVjZWl2ZUxvd1Bvd2VyTW9kZUNoYW5nZQogewogICAgIF9pc0xvd1Bvd2VyTW9k ZUVuYWJsZWQgPSBbTlNQcm9jZXNzSW5mbyBwcm9jZXNzSW5mb10ubG93UG93ZXJNb2RlRW5hYmxl ZDsKLSAgICBub3RpZnlMb3dQb3dlck1vZGVDaGFuZ2VkKF9ub3RpZmllciwgX2lzTG93UG93ZXJN b2RlRW5hYmxlZCk7CisgICAgLy8gV2UgbmVlZCB0byBtYWtlIHN1cmUgd2Ugbm90aWZ5IHRoZSBj bGllbnQgb24gdGhlIG1haW4gdGhyZWFkLgorICAgIGNhbGxPbk1haW5UaHJlYWQoW25vdGlmaWVy ID0gX25vdGlmaWVyLCBpc0xvd1Bvd2VyTW9kZUVuYWJsZWQgPSBfaXNMb3dQb3dlck1vZGVFbmFi bGVkXSB7CisgICAgICAgIG5vdGlmeUxvd1Bvd2VyTW9kZUNoYW5nZWQobm90aWZpZXIsIGlzTG93 UG93ZXJNb2RlRW5hYmxlZCk7CisgICAgfSk7CiB9CiAKIEBlbmQK