173113 2017-06-08 14:42:17 -0700 Update Timer to take a WTF::Function instead of a std::function 2017-06-08 18:26:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 173125 1 cdumez cdumez achristensen beidson buildbot ggaren kling koivisto oldest_to_newest 1317060 0 cdumez 2017-06-08 14:42:17 -0700 Update Timer to take a WTF::Function instead of a std::function. 1317062 1 312346 cdumez 2017-06-08 14:43:30 -0700 Created attachment 312346 Patch 1317065 2 buildbot 2017-06-08 14:46:19 -0700 Attachment 312346 did not pass style-queue: ERROR: Source/WebCore/platform/GenericTaskQueue.cpp:50: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/Timer.h:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Timer.h:135: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Timer.h:157: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/Timer.h:197: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1317117 3 312346 cdumez 2017-06-08 16:05:10 -0700 Comment on attachment 312346 Patch Clearing flags on attachment: 312346 Committed r217954: <http://trac.webkit.org/changeset/217954> 1317118 4 cdumez 2017-06-08 16:05:12 -0700 All reviewed patches have been landed. Closing bug. 312346 2017-06-08 14:43:30 -0700 2017-06-08 16:05:10 -0700 Patch bug-173113-20170608144330.patch text/plain 2947 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ0NmI2OWE2YWQzYjc1 MjBlYjUxNmU4YzZjMzU1NDA1NmNhZWM3NC4uNjQyZWM3NmZjYjBjYTU4MmUzYWRjOTg2YTVmZjVl YjRlMzA4N2RjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA2LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIFRpbWVyIHRvIHRh a2UgYSBXVEY6OkZ1bmN0aW9uIGluc3RlYWQgb2YgYSBzdGQ6OmZ1bmN0aW9uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMxMTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgVGltZXIgdG8gdGFr ZSBhIFdURjo6RnVuY3Rpb24gaW5zdGVhZCBvZiBhIHN0ZDo6ZnVuY3Rpb24gYXMgd2UgcHJlZmVy CisgICAgICAgIHRvIHVzZSBXVEY6OkZ1bmN0aW9uIGluIFdlYktpdC4KKworICAgICAgICAqIHBs YXRmb3JtL0dlbmVyaWNUYXNrUXVldWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGFza0Rpc3Bh dGNoZXI8VGltZXI+OjpzaGFyZWRUaW1lcik6CisgICAgICAgICogcGxhdGZvcm0vVGltZXIuaDoK KyAgICAgICAgKFdlYkNvcmU6OlRpbWVyOjpUaW1lcik6CisgICAgICAgIChXZWJDb3JlOjpEZWZl cnJhYmxlT25lU2hvdFRpbWVyOjpEZWZlcnJhYmxlT25lU2hvdFRpbWVyKToKKwogMjAxNy0wNi0w NyAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBMYWlsaSByZXN0YXVy YW50IG1lbnUgcGFnZSBkb2VzIG5vdCBkaXNwbGF5IGZ1bGwgbWVudQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vR2VuZXJpY1Rhc2tRdWV1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9HZW5lcmljVGFza1F1ZXVlLmNwcAppbmRleCAzNzk0ZjFlZjFkMDFjZjVhZTYy MTFkYmU0NTg3MTk1M2E2MzRmMmFiLi4wYTY1NTIwNmI1MDgwZDY4ZDk4YTI0MzI0ZWRlMDcxNDQz OGVkOTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9HZW5lcmljVGFza1F1 ZXVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9HZW5lcmljVGFza1F1ZXVlLmNw cApAQCAtNDcsNyArNDcsNyBAQCB2b2lkIFRhc2tEaXNwYXRjaGVyPFRpbWVyPjo6cG9zdFRhc2so RnVuY3Rpb248dm9pZCgpPiYmIGZ1bmN0aW9uKQogVGltZXImIFRhc2tEaXNwYXRjaGVyPFRpbWVy Pjo6c2hhcmVkVGltZXIoKQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAgc3Rh dGljIE5ldmVyRGVzdHJveWVkPFRpbWVyPiB0aW1lcihUYXNrRGlzcGF0Y2hlcjxUaW1lcj46OnNo YXJlZFRpbWVyRmlyZWQpOworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxUaW1lcj4gdGltZXIo W10geyBUYXNrRGlzcGF0Y2hlcjxUaW1lcj46OnNoYXJlZFRpbWVyRmlyZWQoKTsgfSk7CiAgICAg cmV0dXJuIHRpbWVyLmdldCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9UaW1lci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVGltZXIuaAppbmRleCA0Yzc3 NGE0NDhiZjdjYWQwYzQ0YTVlZTY3ODZhZmY4NzBhZGM0YjMyLi5iM2UwNTFlNzAyZTNhOGFkNmYw ZTRkZGE3NzlkMzZlZTEzOGFkMzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9UaW1lci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RpbWVyLmgKQEAgLTI1LDcg KzI1LDcgQEAKIAogI3ByYWdtYSBvbmNlCiAKLSNpbmNsdWRlIDxmdW5jdGlvbmFsPgorI2luY2x1 ZGUgPHd0Zi9GdW5jdGlvbi5oPgogI2luY2x1ZGUgPHd0Zi9Nb25vdG9uaWNUaW1lLmg+CiAjaW5j bHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL09wdGlvbmFsLmg+CkBAIC0x MjEsNyArMTIxLDcgQEAgcHVibGljOgogICAgIHsKICAgICB9CiAKLSAgICBUaW1lcihzdGQ6OmZ1 bmN0aW9uPHZvaWQgKCk+IGZ1bmN0aW9uKQorICAgIFRpbWVyKFdURjo6RnVuY3Rpb248dm9pZCAo KT4mJiBmdW5jdGlvbikKICAgICAgICAgOiBtX2Z1bmN0aW9uKFdURk1vdmUoZnVuY3Rpb24pKQog ICAgIHsKICAgICB9CkBAIC0xMzIsNyArMTMyLDcgQEAgcHJpdmF0ZToKICAgICAgICAgbV9mdW5j dGlvbigpOwogICAgIH0KICAgICAKLSAgICBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IG1fZnVuY3Rp b247CisgICAgV1RGOjpGdW5jdGlvbjx2b2lkICgpPiBtX2Z1bmN0aW9uOwogfTsKIAogaW5saW5l IGJvb2wgVGltZXJCYXNlOjppc0FjdGl2ZSgpIGNvbnN0CkBAIC0xNTQsNyArMTU0LDcgQEAgcHVi bGljOgogICAgIHsKICAgICB9CiAKLSAgICBEZWZlcnJhYmxlT25lU2hvdFRpbWVyKHN0ZDo6ZnVu Y3Rpb248dm9pZCAoKT4gZnVuY3Rpb24sIFNlY29uZHMgZGVsYXkpCisgICAgRGVmZXJyYWJsZU9u ZVNob3RUaW1lcihXVEY6OkZ1bmN0aW9uPHZvaWQgKCk+JiYgZnVuY3Rpb24sIFNlY29uZHMgZGVs YXkpCiAgICAgICAgIDogbV9mdW5jdGlvbihXVEZNb3ZlKGZ1bmN0aW9uKSkKICAgICAgICAgLCBt X2RlbGF5KGRlbGF5KQogICAgICAgICAsIG1fc2hvdWxkUmVzdGFydFdoZW5UaW1lckZpcmVzKGZh bHNlKQpAQCAtMTk0LDcgKzE5NCw3IEBAIHByaXZhdGU6CiAgICAgICAgIG1fZnVuY3Rpb24oKTsK ICAgICB9CiAKLSAgICBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IG1fZnVuY3Rpb247CisgICAgV1RG OjpGdW5jdGlvbjx2b2lkICgpPiBtX2Z1bmN0aW9uOwogCiAgICAgU2Vjb25kcyBtX2RlbGF5Owog ICAgIGJvb2wgbV9zaG91bGRSZXN0YXJ0V2hlblRpbWVyRmlyZXM7Cg==