<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>173112</bug_id>
          
          <creation_ts>2017-06-08 14:39:52 -0700</creation_ts>
          <short_desc>[Cocoa] Modernize some internal initializers to use instancetype instead of id</short_desc>
          <delta_ts>2017-06-15 20:55:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Joseph Pecoraro">joepeck</assigned_to>
          <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>joepeck</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1317058</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2017-06-08 14:39:52 -0700</bug_when>
    <thetext>Modernize some internal initializers to use instancetype instead of id</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1317059</commentid>
    <comment_count>1</comment_count>
      <attachid>312344</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2017-06-08 14:41:06 -0700</bug_when>
    <thetext>Created attachment 312344
[PATCH] Proposed Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1318295</commentid>
    <comment_count>2</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2017-06-12 11:13:57 -0700</bug_when>
    <thetext>Bump!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319847</commentid>
    <comment_count>3</comment_count>
      <attachid>312344</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-06-15 20:25:49 -0700</bug_when>
    <thetext>Comment on attachment 312344
[PATCH] Proposed Fix

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319854</commentid>
    <comment_count>4</comment_count>
      <attachid>312344</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-15 20:55:47 -0700</bug_when>
    <thetext>Comment on attachment 312344
[PATCH] Proposed Fix

Clearing flags on attachment: 312344

Committed r218379: &lt;http://trac.webkit.org/changeset/218379&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1319855</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-06-15 20:55:48 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>312344</attachid>
            <date>2017-06-08 14:41:06 -0700</date>
            <delta_ts>2017-06-15 20:55:47 -0700</delta_ts>
            <desc>[PATCH] Proposed Fix</desc>
            <filename>woop-1.patch</filename>
            <type>text/plain</type>
            <size>3134</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0SW50ZXJuYWwu
aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0SW50ZXJuYWwuaAppbmRleCA1
MzA4ZmJiOTJmYS4uYjM3Y2ZhNDQxNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9BUEkvSlNDb250ZXh0SW50ZXJuYWwuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ
L0pTQ29udGV4dEludGVybmFsLmgKQEAgLTU5LDcgKzU5LDcgQEAgcHJpdmF0ZToKIAogQGludGVy
ZmFjZSBKU0NvbnRleHQoSW50ZXJuYWwpCiAKLS0gKGlkKWluaXRXaXRoR2xvYmFsQ29udGV4dFJl
ZjooSlNHbG9iYWxDb250ZXh0UmVmKWNvbnRleHQ7CistIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhH
bG9iYWxDb250ZXh0UmVmOihKU0dsb2JhbENvbnRleHRSZWYpY29udGV4dDsKIAogLSAodm9pZClu
b3RpZnlFeGNlcHRpb246KEpTVmFsdWVSZWYpZXhjZXB0aW9uOwogLSAoSlNWYWx1ZSAqKXZhbHVl
RnJvbU5vdGlmeUV4Y2VwdGlvbjooSlNWYWx1ZVJlZilleGNlcHRpb247CmRpZmYgLS1naXQgYS9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTV3JhcHBlck1hcC5oIGIvU291cmNlL0phdmFTY3Jp
cHRDb3JlL0FQSS9KU1dyYXBwZXJNYXAuaAppbmRleCAwNDZjYzQyOGQwNS4uNmMxOGM2NGI0Yzcg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXcmFwcGVyTWFwLmgKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1dyYXBwZXJNYXAuaApAQCAtMzEsNyArMzEs
NyBAQAogCiBAaW50ZXJmYWNlIEpTV3JhcHBlck1hcCA6IE5TT2JqZWN0CiAKLS0gKGlkKWluaXRX
aXRoR2xvYmFsQ29udGV4dFJlZjooSlNHbG9iYWxDb250ZXh0UmVmKWNvbnRleHQ7CistIChpbnN0
YW5jZXR5cGUpaW5pdFdpdGhHbG9iYWxDb250ZXh0UmVmOihKU0dsb2JhbENvbnRleHRSZWYpY29u
dGV4dDsKIAogLSAoSlNWYWx1ZSAqKWpzV3JhcHBlckZvck9iamVjdDooaWQpb2JqZWN0IGluQ29u
dGV4dDooSlNDb250ZXh0ICopY29udGV4dDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp
cHRDb3JlL0FQSS9KU1dyYXBwZXJNYXAubW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pT
V3JhcHBlck1hcC5tbQppbmRleCA3ZDhiNmY4ZjE4Ni4uMDBlOGMxZTc5MWEgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXcmFwcGVyTWFwLm1tCisrKyBiL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9BUEkvSlNXcmFwcGVyTWFwLm1tCkBAIC0zNzEsNyArMzcxLDcgQEAgc3Rh
dGljIHZvaWQgY29weVByb3RvdHlwZVByb3BlcnRpZXMoSlNDb250ZXh0ICpjb250ZXh0LCBDbGFz
cyBvYmpjQ2xhc3MsIFByb3RvY28KICAgICBKU0M6OldlYWs8SlNDOjpKU09iamVjdD4gbV9jb25z
dHJ1Y3RvcjsKIH0KIAotLSAoaWQpaW5pdEZvckNsYXNzOihDbGFzcyljbHM7CistIChpbnN0YW5j
ZXR5cGUpaW5pdEZvckNsYXNzOihDbGFzcyljbHM7CiAtIChKU0M6OkpTT2JqZWN0ICopd3JhcHBl
ckZvck9iamVjdDooaWQpb2JqZWN0IGluQ29udGV4dDooSlNDb250ZXh0ICopY29udGV4dDsKIC0g
KEpTQzo6SlNPYmplY3QgKiljb25zdHJ1Y3RvckluQ29udGV4dDooSlNDb250ZXh0ICopY29udGV4
dDsKIC0gKEpTQzo6SlNPYmplY3QgKilwcm90b3R5cGVJbkNvbnRleHQ6KEpTQ29udGV4dCAqKWNv
bnRleHQ7CkBAIC0zODAsNyArMzgwLDcgQEAgc3RhdGljIHZvaWQgY29weVByb3RvdHlwZVByb3Bl
cnRpZXMoSlNDb250ZXh0ICpjb250ZXh0LCBDbGFzcyBvYmpjQ2xhc3MsIFByb3RvY28KIAogQGlt
cGxlbWVudGF0aW9uIEpTT2JqQ0NsYXNzSW5mbwogCi0tIChpZClpbml0Rm9yQ2xhc3M6KENsYXNz
KWNscworLSAoaW5zdGFuY2V0eXBlKWluaXRGb3JDbGFzczooQ2xhc3MpY2xzCiB7CiAgICAgc2Vs
ZiA9IFtzdXBlciBpbml0XTsKICAgICBpZiAoIXNlbGYpCkBAIC01NTIsNyArNTUyLDcgQEAgdHlw
ZWRlZiBzdGQ6OnBhaXI8SlNDOjpKU09iamVjdCosIEpTQzo6SlNPYmplY3QqPiBDb25zdHJ1Y3Rv
clByb3RvdHlwZVBhaXI7CiAgICAgTlNNYXBUYWJsZSAqbV9jYWNoZWRPYmpDV3JhcHBlcnM7CiB9
CiAKLS0gKGlkKWluaXRXaXRoR2xvYmFsQ29udGV4dFJlZjooSlNHbG9iYWxDb250ZXh0UmVmKWNv
bnRleHQKKy0gKGluc3RhbmNldHlwZSlpbml0V2l0aEdsb2JhbENvbnRleHRSZWY6KEpTR2xvYmFs
Q29udGV4dFJlZiljb250ZXh0CiB7CiAgICAgc2VsZiA9IFtzdXBlciBpbml0XTsKICAgICBpZiAo
IXNlbGYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5YWM1MzJhNDAzMC4uMWZlMGZiYTBj
NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3LTA2LTA4
ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgW0NvY29h
XSBNb2Rlcm5pemUgc29tZSBpbnRlcm5hbCBpbml0aWFsaXplcnMgdG8gdXNlIGluc3RhbmNldHlw
ZSBpbnN0ZWFkIG9mIGlkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xNzMxMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIEFQSS9KU0NvbnRleHRJbnRlcm5hbC5oOgorICAgICAgICAqIEFQSS9KU1dyYXBw
ZXJNYXAuaDoKKyAgICAgICAgKiBBUEkvSlNXcmFwcGVyTWFwLm1tOgorICAgICAgICAoLVtKU09i
akNDbGFzc0luZm8gaW5pdEZvckNsYXNzOl0pOgorICAgICAgICAoLVtKU1dyYXBwZXJNYXAgaW5p
dFdpdGhHbG9iYWxDb250ZXh0UmVmOl0pOgorCisyMDE3LTA2LTA4ICBKb3NlcGggUGVjb3Jhcm8g
IDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgW0NvY29hXSBKU1dyYXBwZXJNYXAgbGVh
a3MgZm9yIGFsbCBKU0NvbnRleHRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xNzMxMTAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyNjAyMTk4Pgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>