173110 2017-06-08 14:17:26 -0700 [Cocoa] JSWrapperMap leaks for all JSContexts 2017-06-08 15:24:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck buildbot commit-queue ggaren joepeck keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1317047 0 joepeck 2017-06-08 14:17:26 -0700 Summary: JSWrapperMap leaks for all JSContexts Test: /* * shell> xcrun clang -framework Foundation -framework JavaScriptCore js-leak.m */ #import <Foundation/Foundation.h> #import <JavaScriptCore/JavaScriptCore.h> int main() { @autoreleasepool { [[[JSContext alloc] init] autorelease]; } [[NSRunLoop mainRunLoop] run]; return 0; } Steps to Reproduce: 1. $ xcrun clang -framework Foundation -framework JavaScriptCore js-leak.m 2. $ MallocStackLogging=1 DYLD_FRAMEWORK_PATH=$build/Release ./a.out 3. $ leaks `pidof a.out` => Leaks Leak: Leak: 0x7f9b18100ce0 size=32 zone: DefaultMallocZone_0x10ecb8000 JSWrapperMap ObjC JavaScriptCore 0x0e58d0f5 0x001d8001 0x181008d0 0x00007f9b ..X............. 0x186125c0 0x00007f9b 0x18100ec0 0x00007f9b .%a............. Call stack: [thread 0x7fffb956e3c0]: | start | main | -[JSContext initWithVirtualMachine:] JSContext.mm:79 | -[JSContext ensureWrapperMap] JSContext.mm:57 | _objc_rootAlloc | class_createInstance | calloc 1317048 1 joepeck 2017-06-08 14:17:40 -0700 <rdar://problem/32602198> 1317052 2 312342 joepeck 2017-06-08 14:23:42 -0700 Created attachment 312342 [PATCH] Proposed Fix 1317069 3 312342 ggaren 2017-06-08 14:48:03 -0700 Comment on attachment 312342 [PATCH] Proposed Fix r=me 1317091 4 312342 commit-queue 2017-06-08 15:24:14 -0700 Comment on attachment 312342 [PATCH] Proposed Fix Clearing flags on attachment: 312342 Committed r217952: <http://trac.webkit.org/changeset/217952> 1317092 5 commit-queue 2017-06-08 15:24:16 -0700 All reviewed patches have been landed. Closing bug. 312342 2017-06-08 14:23:42 -0700 2017-06-08 15:24:14 -0700 [PATCH] Proposed Fix leak-1.patch text/plain 1405 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0Lm1tIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHQubW0KaW5kZXggYTllMzY2NjU5YzUuLjVi MTAwYzc1ZTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4 dC5tbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4dC5tbQpAQCAtNTMs OCArNTMsMTAgQEAKIAogLSAodm9pZCllbnN1cmVXcmFwcGVyTWFwCiB7Ci0gICAgaWYgKCF0b0pT KFtzZWxmIEpTR2xvYmFsQ29udGV4dFJlZl0pLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCktPndyYXBw ZXJNYXAoKSkKLSAgICAgICAgW1tKU1dyYXBwZXJNYXAgYWxsb2NdIGluaXRXaXRoR2xvYmFsQ29u dGV4dFJlZjpbc2VsZiBKU0dsb2JhbENvbnRleHRSZWZdXTsKKyAgICBpZiAoIXRvSlMoW3NlbGYg SlNHbG9iYWxDb250ZXh0UmVmXSktPmxleGljYWxHbG9iYWxPYmplY3QoKS0+d3JhcHBlck1hcCgp KSB7CisgICAgICAgIC8vIFRoZSBtYXAgd2lsbCBiZSByZXRhaW5lZCBieSB0aGUgR2xvYmFsT2Jq ZWN0IGluIGluaXRpYWxpemF0aW9uLgorICAgICAgICBbW1tKU1dyYXBwZXJNYXAgYWxsb2NdIGlu aXRXaXRoR2xvYmFsQ29udGV4dFJlZjpbc2VsZiBKU0dsb2JhbENvbnRleHRSZWZdXSByZWxlYXNl XTsKKyAgICB9CiB9CiAKIC0gKGluc3RhbmNldHlwZSlpbml0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZwppbmRleCAyZTI4YThmOTFiYi4uOWFjNTMyYTQwMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTA4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBKU1dyYXBwZXJNYXAgbGVha3MgZm9yIGFs bCBKU0NvbnRleHRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzMxMTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyNjAyMTk4PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQVBJL0pTQ29udGV4dC5t bToKKyAgICAgICAgKC1bSlNDb250ZXh0IGVuc3VyZVdyYXBwZXJNYXBdKToKKyAgICAgICAgRW5z dXJlIHRoaXMgYWxsb2NhdGlvbiBnZXRzIHJlbGVhc2VkLgorCiAyMDE3LTA2LTA2ICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCByb2xs b3V0IHIyMTc4MDcuIENhdXNlZCBhIHRlc3QgdG8gY3Jhc2guCg==