173109 2017-06-08 13:55:00 -0700 Use WTF::Function more in SpeculativeLoadManager 2017-06-08 14:37:55 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen buildbot cgarcia commit-queue ggaren koivisto oldest_to_newest 1317035 0 cdumez 2017-06-08 13:55:00 -0700 Use WTF::Function more in SpeculativeLoadManager. 1317036 1 312339 cdumez 2017-06-08 13:55:49 -0700 Created attachment 312339 Patch 1317037 2 buildbot 2017-06-08 13:57:21 -0700 Attachment 312339 did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:568: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1317056 3 312339 commit-queue 2017-06-08 14:37:53 -0700 Comment on attachment 312339 Patch Clearing flags on attachment: 312339 Committed r217947: <http://trac.webkit.org/changeset/217947> 1317057 4 commit-queue 2017-06-08 14:37:55 -0700 All reviewed patches have been landed. Closing bug. 312339 2017-06-08 13:55:49 -0700 2017-06-08 14:37:53 -0700 Patch bug-173109-20170608135548.patch text/plain 5778 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzYzN2ZlYzRkMDRjMGQ0 NzA0NDZkYzJlMWIzMDZiZTI1YjVmMTM1ZS4uMmM3MjBlNGUyYzRjZjgzNTdlNDhjZDZkNTZkNTdi NmU0OWRlOTczMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA2LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFdURjo6RnVuY3Rpb24g bW9yZSBpbiBTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMxMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgV1RGOjpGdW5jdGlvbiBtb3JlIGluIFNwZWN1bGF0 aXZlTG9hZE1hbmFnZXIuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3Jr Q2FjaGVTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29y a0NhY2hlOjpTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjpQZW5kaW5nRnJhbWVMb2FkOjpjcmVhdGUp OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6 OlBlbmRpbmdGcmFtZUxvYWQ6OlBlbmRpbmdGcmFtZUxvYWQpOgorICAgICAgICAoV2ViS2l0OjpO ZXR3b3JrQ2FjaGU6OlNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnJlZ2lzdGVyTG9hZCk6CisgICAg ICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6U3BlY3VsYXRpdmVMb2FkTWFuYWdlcjo6cmV0cmll dmVTdWJyZXNvdXJjZXNFbnRyeSk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5oOgorCiAyMDE3LTA2LTA4ICBZb3Vlbm4g RmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBnZXRVc2VyTWVkaWEgcmVxdWVz dCBzaG91bGQgbm90IGJlIGFsbG93ZWQgZm9yIGJhY2tncm91bmQgdGFicyB1bmxlc3MgdGhlIHRh YiBpcyBhbHJlYWR5IGNhcHR1cmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2 ZUxvYWRNYW5hZ2VyLmNwcAppbmRleCA5YmExZGUxNGI5M2VmMjVkNTRkMTc1OWFlMTcyZTI2MmE3 NmU4ZmNlLi42NmY4YjkyZjBkY2JjMjExYWY4NDA2ZmRjMzVjM2YxZTc3NWJjOTIzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVj dWxhdGl2ZUxvYWRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyLmNwcApAQCAtMTU5LDcg KzE1OSw3IEBAIHByaXZhdGU6CiAKIGNsYXNzIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OlBlbmRp bmdGcmFtZUxvYWQgOiBwdWJsaWMgUmVmQ291bnRlZDxQZW5kaW5nRnJhbWVMb2FkPiB7CiBwdWJs aWM6Ci0gICAgc3RhdGljIFJlZjxQZW5kaW5nRnJhbWVMb2FkPiBjcmVhdGUoU3RvcmFnZSYgc3Rv cmFnZSwgY29uc3QgS2V5JiBtYWluUmVzb3VyY2VLZXksIHN0ZDo6ZnVuY3Rpb248dm9pZCgpPiYm IGxvYWRDb21wbGV0aW9uSGFuZGxlcikKKyAgICBzdGF0aWMgUmVmPFBlbmRpbmdGcmFtZUxvYWQ+ IGNyZWF0ZShTdG9yYWdlJiBzdG9yYWdlLCBjb25zdCBLZXkmIG1haW5SZXNvdXJjZUtleSwgV1RG OjpGdW5jdGlvbjx2b2lkKCk+JiYgbG9hZENvbXBsZXRpb25IYW5kbGVyKQogICAgIHsKICAgICAg ICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUGVuZGluZ0ZyYW1lTG9hZChzdG9yYWdlLCBtYWluUmVz b3VyY2VLZXksIFdURk1vdmUobG9hZENvbXBsZXRpb25IYW5kbGVyKSkpOwogICAgIH0KQEAgLTIw Myw3ICsyMDMsNyBAQCBwdWJsaWM6CiAgICAgfQogCiBwcml2YXRlOgotICAgIFBlbmRpbmdGcmFt ZUxvYWQoU3RvcmFnZSYgc3RvcmFnZSwgY29uc3QgS2V5JiBtYWluUmVzb3VyY2VLZXksIHN0ZDo6 ZnVuY3Rpb248dm9pZCgpPiYmIGxvYWRDb21wbGV0aW9uSGFuZGxlcikKKyAgICBQZW5kaW5nRnJh bWVMb2FkKFN0b3JhZ2UmIHN0b3JhZ2UsIGNvbnN0IEtleSYgbWFpblJlc291cmNlS2V5LCBXVEY6 OkZ1bmN0aW9uPHZvaWQoKT4mJiBsb2FkQ29tcGxldGlvbkhhbmRsZXIpCiAgICAgICAgIDogbV9z dG9yYWdlKHN0b3JhZ2UpCiAgICAgICAgICwgbV9tYWluUmVzb3VyY2VLZXkobWFpblJlc291cmNl S2V5KQogICAgICAgICAsIG1fbG9hZENvbXBsZXRpb25IYW5kbGVyKFdURk1vdmUobG9hZENvbXBs ZXRpb25IYW5kbGVyKSkKQEAgLTIzOCw3ICsyMzgsNyBAQCBwcml2YXRlOgogICAgIFN0b3JhZ2Um IG1fc3RvcmFnZTsKICAgICBLZXkgbV9tYWluUmVzb3VyY2VLZXk7CiAgICAgVmVjdG9yPHN0ZDo6 dW5pcXVlX3B0cjxTdWJyZXNvdXJjZUxvYWQ+PiBtX3N1YnJlc291cmNlTG9hZHM7Ci0gICAgc3Rk OjpmdW5jdGlvbjx2b2lkKCk+IG1fbG9hZENvbXBsZXRpb25IYW5kbGVyOworICAgIFdURjo6RnVu Y3Rpb248dm9pZCgpPiBtX2xvYWRDb21wbGV0aW9uSGFuZGxlcjsKICAgICBIeXN0ZXJlc2lzQWN0 aXZpdHkgbV9sb2FkSHlzdGVyZXNpc0FjdGl2aXR5OwogICAgIHN0ZDo6dW5pcXVlX3B0cjxTdWJy ZXNvdXJjZXNFbnRyeT4gbV9leGlzdGluZ0VudHJ5OwogICAgIGJvb2wgbV9kaWRGaW5pc2hMb2Fk IHsgZmFsc2UgfTsKQEAgLTM3NywxNCArMzc3LDE0IEBAIHZvaWQgU3BlY3VsYXRpdmVMb2FkTWFu YWdlcjo6cmVnaXN0ZXJMb2FkKGNvbnN0IEdsb2JhbEZyYW1lSUQmIGZyYW1lSUQsIGNvbnN0IFJl CiAgICAgICAgIEFTU0VSVCghbV9wZW5kaW5nRnJhbWVMb2Fkcy5jb250YWlucyhmcmFtZUlEKSk7 CiAKICAgICAgICAgLy8gU3RhcnQgdHJhY2tpbmcgbG9hZHMgaW4gdGhpcyBmcmFtZS4KLSAgICAg ICAgUmVmUHRyPFBlbmRpbmdGcmFtZUxvYWQ+IHBlbmRpbmdGcmFtZUxvYWQgPSBQZW5kaW5nRnJh bWVMb2FkOjpjcmVhdGUobV9zdG9yYWdlLCByZXNvdXJjZUtleSwgW3RoaXMsIGZyYW1lSURdIHsK KyAgICAgICAgYXV0byBwZW5kaW5nRnJhbWVMb2FkID0gUGVuZGluZ0ZyYW1lTG9hZDo6Y3JlYXRl KG1fc3RvcmFnZSwgcmVzb3VyY2VLZXksIFt0aGlzLCBmcmFtZUlEXSB7CiAgICAgICAgICAgICBi b29sIHdhc1JlbW92ZWQgPSBtX3BlbmRpbmdGcmFtZUxvYWRzLnJlbW92ZShmcmFtZUlEKTsKICAg ICAgICAgICAgIEFTU0VSVF9VTlVTRUQod2FzUmVtb3ZlZCwgd2FzUmVtb3ZlZCk7CiAgICAgICAg IH0pOwotICAgICAgICBtX3BlbmRpbmdGcmFtZUxvYWRzLmFkZChmcmFtZUlELCBwZW5kaW5nRnJh bWVMb2FkKTsKKyAgICAgICAgbV9wZW5kaW5nRnJhbWVMb2Fkcy5hZGQoZnJhbWVJRCwgcGVuZGlu Z0ZyYW1lTG9hZC5jb3B5UmVmKCkpOwogCiAgICAgICAgIC8vIFJldHJpZXZlIHRoZSBzdWJyZXNv dXJjZXMgZW50cnkgaWYgaXQgZXhpc3RzIHRvIHN0YXJ0IHNwZWN1bGF0aXZlIHJldmFsaWRhdGlv biBhbmQgdG8gdXBkYXRlIGl0LgotICAgICAgICByZXRyaWV2ZVN1YnJlc291cmNlc0VudHJ5KHJl c291cmNlS2V5LCBbdGhpcywgZnJhbWVJRCwgcGVuZGluZ0ZyYW1lTG9hZF0oc3RkOjp1bmlxdWVf cHRyPFN1YnJlc291cmNlc0VudHJ5PiBlbnRyeSkgeworICAgICAgICByZXRyaWV2ZVN1YnJlc291 cmNlc0VudHJ5KHJlc291cmNlS2V5LCBbdGhpcywgZnJhbWVJRCwgcGVuZGluZ0ZyYW1lTG9hZCA9 IFdURk1vdmUocGVuZGluZ0ZyYW1lTG9hZCldKHN0ZDo6dW5pcXVlX3B0cjxTdWJyZXNvdXJjZXNF bnRyeT4gZW50cnkpIHsKICAgICAgICAgICAgIGlmIChlbnRyeSkKICAgICAgICAgICAgICAgICBz dGFydFNwZWN1bGF0aXZlUmV2YWxpZGF0aW9uKGZyYW1lSUQsICplbnRyeSk7CiAKQEAgLTU2NSw3 ICs1NjUsNyBAQCB2b2lkIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnN0YXJ0U3BlY3VsYXRpdmVS ZXZhbGlkYXRpb24oY29uc3QgR2xvYmFsRnJhbWVJRCYgZgogICAgIH0KIH0KIAotdm9pZCBTcGVj dWxhdGl2ZUxvYWRNYW5hZ2VyOjpyZXRyaWV2ZVN1YnJlc291cmNlc0VudHJ5KGNvbnN0IEtleSYg c3RvcmFnZUtleSwgc3RkOjpmdW5jdGlvbjx2b2lkIChzdGQ6OnVuaXF1ZV9wdHI8U3VicmVzb3Vy Y2VzRW50cnk+KT4mJiBjb21wbGV0aW9uSGFuZGxlcikKK3ZvaWQgU3BlY3VsYXRpdmVMb2FkTWFu YWdlcjo6cmV0cmlldmVTdWJyZXNvdXJjZXNFbnRyeShjb25zdCBLZXkmIHN0b3JhZ2VLZXksIFdU Rjo6RnVuY3Rpb248dm9pZCAoc3RkOjp1bmlxdWVfcHRyPFN1YnJlc291cmNlc0VudHJ5Pik+JiYg Y29tcGxldGlvbkhhbmRsZXIpCiB7CiAgICAgQVNTRVJUKHN0b3JhZ2VLZXkudHlwZSgpID09ICJS ZXNvdXJjZSIpOwogICAgIGF1dG8gc3VicmVzb3VyY2VzU3RvcmFnZUtleSA9IG1ha2VTdWJyZXNv dXJjZXNLZXkoc3RvcmFnZUtleSwgbV9zdG9yYWdlLnNhbHQoKSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxv YWRNYW5hZ2VyLmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3Jr Q2FjaGVTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyLmgKaW5kZXggZTljNjIxYTkxOGE4ZmQwNzk1ZTQy M2NmNjFiOWM5MGE4MDcwODQ1NC4uNThkN2ZhNmMzYmE0YjUyYTM5NzE2MDExNGVhODE5ZmJjNjYw YjA0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIuaApA QCAtNjQsNyArNjQsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgcmV0cmlldmVFbnRyeUZyb21TdG9y YWdlKGNvbnN0IFN1YnJlc291cmNlSW5mbyYsIFJldHJpZXZlQ29tcGxldGlvbkhhbmRsZXImJik7 CiAgICAgdm9pZCByZXZhbGlkYXRlU3VicmVzb3VyY2UoY29uc3QgU3VicmVzb3VyY2VJbmZvJiwg c3RkOjp1bmlxdWVfcHRyPEVudHJ5PiwgY29uc3QgR2xvYmFsRnJhbWVJRCYpOwogICAgIGJvb2wg c2F0aXNmeVBlbmRpbmdSZXF1ZXN0cyhjb25zdCBLZXkmLCBFbnRyeSopOwotICAgIHZvaWQgcmV0 cmlldmVTdWJyZXNvdXJjZXNFbnRyeShjb25zdCBLZXkmIHN0b3JhZ2VLZXksIHN0ZDo6ZnVuY3Rp b248dm9pZCAoc3RkOjp1bmlxdWVfcHRyPFN1YnJlc291cmNlc0VudHJ5Pik+JiYpOworICAgIHZv aWQgcmV0cmlldmVTdWJyZXNvdXJjZXNFbnRyeShjb25zdCBLZXkmIHN0b3JhZ2VLZXksIFdURjo6 RnVuY3Rpb248dm9pZCAoc3RkOjp1bmlxdWVfcHRyPFN1YnJlc291cmNlc0VudHJ5Pik+JiYpOwog ICAgIHZvaWQgc3RhcnRTcGVjdWxhdGl2ZVJldmFsaWRhdGlvbihjb25zdCBHbG9iYWxGcmFtZUlE JiwgU3VicmVzb3VyY2VzRW50cnkmKTsKIAogICAgIHN0YXRpYyBib29sIGNhblVzZVByZWxvYWRl ZEVudHJ5KGNvbnN0IFByZWxvYWRlZEVudHJ5JiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1 ZXN0JiBhY3R1YWxSZXF1ZXN0KTsK