173108 2017-06-08 10:49:35 -0700 [WebRTC] enableMockMediaEndpoint() is only used for the OpenWebRTC backend. 2017-06-08 15:36:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez alex aperez bugs-noreply eric.carlson lforschler youennf oldest_to_newest 1316971 0 clopez 2017-06-08 10:49:35 -0700 It seems enableMockMediaEndpoint() is only needed when using the OpenWebRTC backend (is not needed with libwebrtc). 1316986 1 312323 clopez 2017-06-08 11:04:50 -0700 Created attachment 312323 Patch inital patch: lets test EWS 1317017 2 312323 aperez 2017-06-08 12:58:46 -0700 Comment on attachment 312323 Patch Informally reviewed, and I'd say it's a r+ 1317093 3 312323 clopez 2017-06-08 15:24:35 -0700 Comment on attachment 312323 Patch All EWS are fine with this.. so asking for formal review now 1317102 4 312323 clopez 2017-06-08 15:36:52 -0700 Comment on attachment 312323 Patch Clearing flags on attachment: 312323 Committed r217953: <http://trac.webkit.org/changeset/217953> 1317103 5 clopez 2017-06-08 15:36:56 -0700 All reviewed patches have been landed. Closing bug. 312323 2017-06-08 11:04:50 -0700 2017-06-08 15:36:52 -0700 Patch bug-173108-20170608200449.patch text/plain 2344 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM3MWJkOTZiNGVmYmI3 NzQ4NzU3N2QxMGZhNzk1MWY5ODAwMTJlZi4uNDg5NTM5MGRmMjMzMzUxMzEwMGU1NGFiNGM1MmNl ZmYzZTgyMjI2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA4ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtX ZWJSVENdIGVuYWJsZU1vY2tNZWRpYUVuZHBvaW50KCkgaXMgb25seSB1c2VkIGZvciB0aGUgT3Bl bldlYlJUQyBiYWNrZW5kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTczMTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHRlc3Rpbmcv SW50ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6SW50ZXJuYWxzKToK KyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6ZW5hYmxlTW9ja01lZGlhRW5kcG9pbnQpOgor ICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmg6CisKIDIwMTctMDYtMDggIEplciBOb2JsZSAg PGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgVGFrZSB0aGUgbWVkaWFDb250ZW50VHlw ZXNSZXF1aXJpbmdIYXJkd2FyZVN1cHBvcnQgU2V0dGluZyBpbnRvIGFjY291bnQgd2hlbiBhbnN3 ZXJpbmcgSFRNTE1lZGlhRWxlbWVudDo6Y2FuUGxheVR5cGUoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9J bnRlcm5hbHMuY3BwCmluZGV4IDJjNDM0MGMzNWQzZDNkMjY5MmM5NWQ4YzBhNjgyMzNiMzA4Mjc0 YTEuLmEyN2ZiNjUxODQzYjRhN2VjOGNkYTA3YmEwNTlmZWE2N2MzY2UzNzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS90ZXN0aW5nL0ludGVybmFscy5jcHAKQEAgLTQ3Nyw3ICs0NzcsNyBAQCBJbnRlcm5hbHM6Oklu dGVybmFscyhEb2N1bWVudCYgZG9jdW1lbnQpCiAjZW5kaWYKIAogI2lmIEVOQUJMRShXRUJfUlRD KQotI2lmIFBMQVRGT1JNKEdUSykKKyNpZiBVU0UoT1BFTldFQlJUQykKICAgICBlbmFibGVNb2Nr TWVkaWFFbmRwb2ludCgpOwogI2VuZGlmCiAjaWYgVVNFKExJQldFQlJUQykKQEAgLTEyNjQsMTMg KzEyNjQsMTIgQEAgdm9pZCBJbnRlcm5hbHM6OmVuYWJsZU1vY2tTcGVlY2hTeW50aGVzaXplcigp CiAKICNpZiBFTkFCTEUoV0VCX1JUQykKIAorI2lmIFVTRShPUEVOV0VCUlRDKQogdm9pZCBJbnRl cm5hbHM6OmVuYWJsZU1vY2tNZWRpYUVuZHBvaW50KCkKIHsKLSAgICBpZiAoIUxpYldlYlJUQ1By b3ZpZGVyOjp3ZWJSVENBdmFpbGFibGUoKSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgTWVkaWFF bmRwb2ludDo6Y3JlYXRlID0gTW9ja01lZGlhRW5kcG9pbnQ6OmNyZWF0ZTsKIH0KKyNlbmRpZgog CiB2b2lkIEludGVybmFsczo6ZW11bGF0ZVJUQ1BlZXJDb25uZWN0aW9uUGxhdGZvcm1FdmVudChS VENQZWVyQ29ubmVjdGlvbiYgY29ubmVjdGlvbiwgY29uc3QgU3RyaW5nJiBhY3Rpb24pCiB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oIGIvU291cmNlL1dl YkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaAppbmRleCA3Y2ZmZjQyYTcyYzZkNmYzODcxYjkwOTYw NWRhMjEzOTQ0NDEyYzYxLi41ZTQ5ZGYxOTQwZmQ2OWY1YjhjZTE0ZDQ0YmJmNjE3YzUwZDEwMmI3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKQEAgLTQyNiw3ICs0MjYsOSBAQCBwdWJs aWM6CiAjZW5kaWYKIAogI2lmIEVOQUJMRShXRUJfUlRDKQorI2lmIFVTRShPUEVOV0VCUlRDKQog ICAgIHZvaWQgZW5hYmxlTW9ja01lZGlhRW5kcG9pbnQoKTsKKyNlbmRpZgogICAgIHZvaWQgZW11 bGF0ZVJUQ1BlZXJDb25uZWN0aW9uUGxhdGZvcm1FdmVudChSVENQZWVyQ29ubmVjdGlvbiYsIGNv bnN0IFN0cmluZyYgYWN0aW9uKTsKICAgICB2b2lkIHVzZU1vY2tSVENQZWVyQ29ubmVjdGlvbkZh Y3RvcnkoY29uc3QgU3RyaW5nJik7CiAgICAgdm9pZCBzZXRJQ0VDYW5kaWRhdGVGaWx0ZXJpbmco Ym9vbCk7Cg==