173093 2017-06-08 04:29:07 -0700 Gardening, fix more specific linter error 2017-06-08 06:24:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner webkit-unassigned clopez commit-queue cturner oldest_to_newest 1316861 0 cturner 2017-06-08 04:29:07 -0700 Gardening, fix more specific linter error 1316862 1 312290 cturner 2017-06-08 04:29:27 -0700 Created attachment 312290 Patch 1316863 2 312291 cturner 2017-06-08 04:34:07 -0700 Created attachment 312291 Patch 1316874 3 312291 clopez 2017-06-08 05:53:35 -0700 Comment on attachment 312291 Patch Note that to fix those warnings, usually what should be done is not to remove the expectation for Debug builds, but make the generic one be specific to Release: --- a/LayoutTests/platform/gtk/TestExpectations +++ b/LayoutTests/platform/gtk/TestExpectations @@ -994,7 +994,7 @@ webkit.org/b/141700 fast/dom/Element/getClientRects.html [ Failure ] webkit.org/b/141700 fast/dom/Range/getClientRects.html [ Failure ] webkit.org/b/141705 media/video-fullscreeen-only-controls.html [ Failure ] -webkit.org/b/141709 http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html [ Failure ] +webkit.org/b/141709 [ Release ] http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html [ Failure ] webkit.org/b/141709 http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html [ Failure ] webkit.org/b/141831 svg/animations/animate-text-nested-transforms.html [ Failure ] However, in this case you comment that it not longer crashes on Debug builds, so then is right to just remove the expectation for Debug. 1316875 4 312291 clopez 2017-06-08 05:54:55 -0700 Comment on attachment 312291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312291&action=review > LayoutTests/ChangeLog:7 > + > + Reviewed by NOBODY (OOPS!). > + Also, for gardening commits its not needed review. Next time you upload a gardening patch, change that line by something that contains the unreviewed word like: "Unreviewed GTK gardening." And ask any committer to cq+ the patch. 1316876 5 312291 clopez 2017-06-08 05:56:31 -0700 Comment on attachment 312291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312291&action=review > LayoutTests/ChangeLog:4 > + Test gardening > + https://bugs.webkit.org/show_bug.cgi?id=173093 Also next time include the [GTK] tag at the beginning of the the title if the gardening is specific to the GTK port. 1316877 6 312291 clopez 2017-06-08 05:57:05 -0700 Comment on attachment 312291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312291&action=review > LayoutTests/ChangeLog:9 > + Commit 40ba0c40a added a crash expectation for the following test, but did so in a manner > + that failed linter checks: And don't reference commits by git hash, but by SVN number. WebKit uses SVN. 1316878 7 312291 clopez 2017-06-08 05:58:03 -0700 Comment on attachment 312291 Patch Too much minor things.. I guess... Can you please upload the patch again correcting those minor issues I commented above? Tahnkls 1316883 8 312298 cturner 2017-06-08 06:11:19 -0700 Created attachment 312298 Patch 1316884 9 312298 clopez 2017-06-08 06:18:30 -0700 Comment on attachment 312298 Patch Thanks 1316887 10 312298 commit-queue 2017-06-08 06:24:29 -0700 Comment on attachment 312298 Patch Clearing flags on attachment: 312298 Committed r217929: <http://trac.webkit.org/changeset/217929> 1316888 11 commit-queue 2017-06-08 06:24:31 -0700 All reviewed patches have been landed. Closing bug. 312290 2017-06-08 04:29:27 -0700 2017-06-08 04:34:02 -0700 Patch bug-173093-20170608122925.patch text/plain 2157 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTI3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTJlY2NhOWQ0OGFhOWEyNmU5MzRj NzZhZTI2NTA5MTM5MWViZDNmNy4uZWFlNzFlYTMyY2E1Yzc5ZmY5NzFmMjNkNjZkN2VkYmUzZmEw MGI0NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA2LTA4ICBDaGFybGllIFR1cm5lciAg PGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24g KE9PUFMhKS4KKyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbW1pdCA0MGJhMGM0MGEgYWRk ZWQgYSBjcmFzaCBleHBlY3RhdGlvbiBmb3IgdGhlIGZvbGxvd2luZyB0ZXN0LCBidXQgZGlkIHNv IGluIGEgbWFubmVyCisgICAgICAgIHRoYXQgZmFpbGVkIGxpbnRlciBjaGVja3M6CisKKyAgICAg ICAgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6MTMwMiBNb3JlIHNw ZWNpZmljIGVudHJ5IGZvcgorICAgICAgICAgICBodHRwL3Rlc3RzL3NlY3VyaXR5L1hGcmFtZU9w dGlvbnMveC1mcmFtZS1vcHRpb25zLWRlbnktbXVsdGlwbGUtY2xpZW50cy5odG1sIG9uIGxpbmUK KyAgICAgICAgICAgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6OTky IG92ZXJyaWRlcyBsaW5lIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z OjEzMDIuCisgICAgICAgICAgIGh0dHAvdGVzdHMvc2VjdXJpdHkvWEZyYW1lT3B0aW9ucy94LWZy YW1lLW9wdGlvbnMtZGVueS1tdWx0aXBsZS1jbGllbnRzLmh0bWwKKworICAgICAgICBGdXJ0aGVy bW9yZSwgdGhpcyB0ZXN0IG5vIGxvbmdlciBjcmFzaGVzIGluIERlYnVnIGJ1aWxkcywgaXQgZmFp bHMgZHVlIHRvIHdoaXRlc3BhY2UKKyAgICAgICAgb2RkaXRpZXMgdGhhdCBhcmUgYWRkcmVzc2Vk IGJ5IHdlYmtpdC5vcmcvYi8xNDE3MDkgKHVucmV2aWV3ZWQpCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNy0wNi0wNyAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgSGlnaCBTaWVycmEgc3VwcG9ydCB0byBX ZWJLaXQgdG9vbHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5k ZXggMzljODE1ZTAwYTA4ZTdhYjhjNzNkYWZkOWYxOGVkZjZkMDU2MmViNS4uZDU1YjBmNmY3ZmIy NTRmM2UzNzdhMjU3Y2Y3ZGRhZGJhNWRiNTRmYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEzMDQsOCArMTMwNCw2IEBAIHdlYmtpdC5vcmcvYi8xMTA2 OTUgaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1vcmlnaW4tbG9jYWwtc3RvcmFnZS1hbGxvd2Vk Lmh0bWwKIHdlYmtpdC5vcmcvYi8xMTA2OTUgaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1vcmln aW4tbG9jYWwtc3RvcmFnZS5odG1sIFsgQ3Jhc2ggUGFzcyBdCiB3ZWJraXQub3JnL2IvMTEwNjk1 IGh0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3Mtb3JpZ2luLXBsdWdpbi1hbGxvd2VkLmh0bWwgWyBD cmFzaCBQYXNzIF0KIAotd2Via2l0Lm9yZy9iLzExMTkwMiBbIERlYnVnIF0gaHR0cC90ZXN0cy9z ZWN1cml0eS9YRnJhbWVPcHRpb25zL3gtZnJhbWUtb3B0aW9ucy1kZW55LW11bHRpcGxlLWNsaWVu dHMuaHRtbCBbIENyYXNoIF0KLQogd2Via2l0Lm9yZy9iLzExODQyMiBbIERlYnVnIF0gaHR0cC90 ZXN0cy9zZWN1cml0eS9YRnJhbWVPcHRpb25zL3gtZnJhbWUtb3B0aW9ucy1jYWNoZWQuaHRtbCBb IENyYXNoIFBhc3MgXQogCiB3ZWJraXQub3JnL2IvMTE4NDIzIGh0dHAvdGVzdHMvbWlzYy9pZnJh bWUtcmVwYXJlbnRpbmctaWQtY29sbGlzaW9uLmh0bWwgWyBDcmFzaCBQYXNzIF0K 312291 2017-06-08 04:34:07 -0700 2017-06-08 06:11:14 -0700 Patch bug-173093-20170608123406.patch text/plain 2159 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTI3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTJlY2NhOWQ0OGFhOWEyNmU5MzRj NzZhZTI2NTA5MTM5MWViZDNmNy4uNjAyYzQ4MGZkY2E5MTA2NTllMGNhMjRjNjE4ZDdhODFkOWI5 MWUwNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA2LTA4ICBDaGFybGllIFR1cm5lciAg PGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBUZXN0IGdhcmRlbmluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMDkzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tbWl0IDQwYmEwYzQwYSBh ZGRlZCBhIGNyYXNoIGV4cGVjdGF0aW9uIGZvciB0aGUgZm9sbG93aW5nIHRlc3QsIGJ1dCBkaWQg c28gaW4gYSBtYW5uZXIKKyAgICAgICAgdGhhdCBmYWlsZWQgbGludGVyIGNoZWNrczoKKworICAg ICAgICBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoxMzAyIE1vcmUg c3BlY2lmaWMgZW50cnkgZm9yCisgICAgICAgICAgIGh0dHAvdGVzdHMvc2VjdXJpdHkvWEZyYW1l T3B0aW9ucy94LWZyYW1lLW9wdGlvbnMtZGVueS1tdWx0aXBsZS1jbGllbnRzLmh0bWwgb24gbGlu ZQorICAgICAgICAgICBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczo5 OTIgb3ZlcnJpZGVzIGxpbmUgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlv bnM6MTMwMi4KKyAgICAgICAgICAgaHR0cC90ZXN0cy9zZWN1cml0eS9YRnJhbWVPcHRpb25zL3gt ZnJhbWUtb3B0aW9ucy1kZW55LW11bHRpcGxlLWNsaWVudHMuaHRtbAorCisgICAgICAgIEZ1cnRo ZXJtb3JlLCB0aGlzIHRlc3Qgbm8gbG9uZ2VyIGNyYXNoZXMgaW4gRGVidWcgYnVpbGRzLCBpdCBm YWlscyBkdWUgdG8gd2hpdGVzcGFjZQorICAgICAgICBvZGRpdGllcyB0aGF0IGFyZSBhZGRyZXNz ZWQgYnkgd2Via2l0Lm9yZy9iLzE0MTcwOSAodW5yZXZpZXdlZCkKKworICAgICAgICAqIHBsYXRm b3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3LTA2LTA3ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBIaWdoIFNpZXJyYSBzdXBwb3J0IHRv IFdlYktpdCB0b29scwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpp bmRleCAzOWM4MTVlMDBhMDhlN2FiOGM3M2RhZmQ5ZjE4ZWRmNmQwNTYyZWI1Li5kNTViMGY2Zjdm YjI1NGYzZTM3N2EyNTdjZjdkZGFkYmE1ZGI1NGZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTMwNCw4ICsxMzA0LDYgQEAgd2Via2l0Lm9yZy9iLzEx MDY5NSBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLW9yaWdpbi1sb2NhbC1zdG9yYWdlLWFsbG93 ZWQuaHRtbAogd2Via2l0Lm9yZy9iLzExMDY5NSBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLW9y aWdpbi1sb2NhbC1zdG9yYWdlLmh0bWwgWyBDcmFzaCBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xMTA2 OTUgaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1vcmlnaW4tcGx1Z2luLWFsbG93ZWQuaHRtbCBb IENyYXNoIFBhc3MgXQogCi13ZWJraXQub3JnL2IvMTExOTAyIFsgRGVidWcgXSBodHRwL3Rlc3Rz L3NlY3VyaXR5L1hGcmFtZU9wdGlvbnMveC1mcmFtZS1vcHRpb25zLWRlbnktbXVsdGlwbGUtY2xp ZW50cy5odG1sIFsgQ3Jhc2ggXQotCiB3ZWJraXQub3JnL2IvMTE4NDIyIFsgRGVidWcgXSBodHRw L3Rlc3RzL3NlY3VyaXR5L1hGcmFtZU9wdGlvbnMveC1mcmFtZS1vcHRpb25zLWNhY2hlZC5odG1s IFsgQ3Jhc2ggUGFzcyBdCiAKIHdlYmtpdC5vcmcvYi8xMTg0MjMgaHR0cC90ZXN0cy9taXNjL2lm cmFtZS1yZXBhcmVudGluZy1pZC1jb2xsaXNpb24uaHRtbCBbIENyYXNoIFBhc3MgXQo= 312298 2017-06-08 06:11:19 -0700 2017-06-08 06:24:29 -0700 Patch bug-173093-20170608141118.patch text/plain 2154 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTI3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTJlY2NhOWQ0OGFhOWEyNmU5MzRj NzZhZTI2NTA5MTM5MWViZDNmNy4uNDg3NmZiNTBjNTAxMWQ3NTkwZDNiNzcxNjc4NzU5NjNmODI2 M2IwNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA2LTA4ICBDaGFybGllIFR1cm5lciAg PGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBUZXN0IGdhcmRlbmluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMDkzCisKKyAg ICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLgorCisgICAgICAgIHIxNDcyMDEgYWRkZWQg YSBjcmFzaCBleHBlY3RhdGlvbiBmb3IgdGhlIGZvbGxvd2luZyB0ZXN0LCBidXQgZGlkIHNvIGlu IGEgbWFubmVyCisgICAgICAgIHRoYXQgZmFpbGVkIGxpbnRlciBjaGVja3M6CisKKyAgICAgICAg TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6MTMwMiBNb3JlIHNwZWNp ZmljIGVudHJ5IGZvcgorICAgICAgICAgICBodHRwL3Rlc3RzL3NlY3VyaXR5L1hGcmFtZU9wdGlv bnMveC1mcmFtZS1vcHRpb25zLWRlbnktbXVsdGlwbGUtY2xpZW50cy5odG1sIG9uIGxpbmUKKyAg ICAgICAgICAgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6OTkyIG92 ZXJyaWRlcyBsaW5lIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOjEz MDIuCisgICAgICAgICAgIGh0dHAvdGVzdHMvc2VjdXJpdHkvWEZyYW1lT3B0aW9ucy94LWZyYW1l LW9wdGlvbnMtZGVueS1tdWx0aXBsZS1jbGllbnRzLmh0bWwKKworICAgICAgICBGdXJ0aGVybW9y ZSwgdGhpcyB0ZXN0IG5vIGxvbmdlciBjcmFzaGVzIGluIERlYnVnIGJ1aWxkcywgaXQgZmFpbHMg ZHVlIHRvIHdoaXRlc3BhY2UKKyAgICAgICAgb2RkaXRpZXMgdGhhdCBhcmUgYWRkcmVzc2VkIGJ5 IHdlYmtpdC5vcmcvYi8xNDE3MDkgKHVucmV2aWV3ZWQpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n dGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNy0wNi0wNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAg PGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgSGlnaCBTaWVycmEgc3VwcG9ydCB0byBXZWJL aXQgdG9vbHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0 YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg MzljODE1ZTAwYTA4ZTdhYjhjNzNkYWZkOWYxOGVkZjZkMDU2MmViNS4uZDU1YjBmNmY3ZmIyNTRm M2UzNzdhMjU3Y2Y3ZGRhZGJhNWRiNTRmYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMKQEAgLTEzMDQsOCArMTMwNCw2IEBAIHdlYmtpdC5vcmcvYi8xMTA2OTUg aHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1vcmlnaW4tbG9jYWwtc3RvcmFnZS1hbGxvd2VkLmh0 bWwKIHdlYmtpdC5vcmcvYi8xMTA2OTUgaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1vcmlnaW4t bG9jYWwtc3RvcmFnZS5odG1sIFsgQ3Jhc2ggUGFzcyBdCiB3ZWJraXQub3JnL2IvMTEwNjk1IGh0 dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3Mtb3JpZ2luLXBsdWdpbi1hbGxvd2VkLmh0bWwgWyBDcmFz aCBQYXNzIF0KIAotd2Via2l0Lm9yZy9iLzExMTkwMiBbIERlYnVnIF0gaHR0cC90ZXN0cy9zZWN1 cml0eS9YRnJhbWVPcHRpb25zL3gtZnJhbWUtb3B0aW9ucy1kZW55LW11bHRpcGxlLWNsaWVudHMu aHRtbCBbIENyYXNoIF0KLQogd2Via2l0Lm9yZy9iLzExODQyMiBbIERlYnVnIF0gaHR0cC90ZXN0 cy9zZWN1cml0eS9YRnJhbWVPcHRpb25zL3gtZnJhbWUtb3B0aW9ucy1jYWNoZWQuaHRtbCBbIENy YXNoIFBhc3MgXQogCiB3ZWJraXQub3JnL2IvMTE4NDIzIGh0dHAvdGVzdHMvbWlzYy9pZnJhbWUt cmVwYXJlbnRpbmctaWQtY29sbGlzaW9uLmh0bWwgWyBDcmFzaCBQYXNzIF0K