173085 2017-06-07 20:29:39 -0700 Crash inside InsertNodeBeforeCommand via InsertParagraphSeparatorCommand 2017-06-08 19:13:08 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa darin enrica sam thorton wenson_hsieh oldest_to_newest 1316795 0 rniwa 2017-06-07 20:29:39 -0700 #0 0x113068d70 in WebCore::Node::treeScope() const (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x4d70) #1 0x113068d38 in WebCore::Node::document() const (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x4d38) #2 0x1140172d6 in WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand(WTF::RefPtr<WebCore::Node>&&, WTF::RefPtr<WebCore::Node>&&, WebCore::ShouldAssumeContentIsAlwaysEditable, WebCore::EditAction) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0xfb32d6) #3 0x1133d03af in WebCore::InsertNodeBeforeCommand::create(WTF::RefPtr<WebCore::Node>&&, WTF::RefPtr<WebCore::Node>&&, WebCore::ShouldAssumeContentIsAlwaysEditable, WebCore::EditAction) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x36c3af) #4 0x1133d0147 in WebCore::CompositeEditCommand::insertNodeBefore(WTF::PassRefPtr<WebCore::Node>, WTF::PassRefPtr<WebCore::Node>, WebCore::ShouldAssumeContentIsAlwaysEditable) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x36c147) #5 0x114019dd6 in WebCore::InsertParagraphSeparatorCommand::doApply() (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0xfb5dd6) #6 0x1133ced57 in WebCore::CompositeEditCommand::applyCommandToComposite(WTF::PassRefPtr<WebCore::EditCommand>) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x36ad57) #7 0x1133cfdc8 in WebCore::CompositeEditCommand::insertParagraphSeparator(bool, bool) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x36bdc8) #8 0x115789540 in WebCore::ReplaceSelectionCommand::doApply() (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x2725540) #9 0x1133cdcea in WebCore::CompositeEditCommand::apply() (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x369cea) #10 0x11393e06f in WebCore::executeInsertFragment(WebCore::Frame&, WTF::PassRefPtr<WebCore::DocumentFragment>) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x8da06f) #11 0x11393e350 in WebCore::executeInsertNode(WebCore::Frame&, WTF::Ref<WebCore::Node>&&) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x8da350) #12 0x113937fc1 in WebCore::executeInsertHorizontalRule(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x8d3fc1) #13 0x113934e57 in WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x8d0e57) #14 0x1137cb329 in WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) (/Users/singi/safari/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore+0x767329) 1316800 1 312270 rniwa 2017-06-07 20:35:55 -0700 Created attachment 312270 Fixes the bug 1316801 2 312271 rniwa 2017-06-07 20:37:19 -0700 Created attachment 312271 Updated the change log 1316802 3 rniwa 2017-06-07 20:37:31 -0700 <rdar://problem/32575059> 1317074 4 312271 wenson_hsieh 2017-06-08 14:54:50 -0700 Comment on attachment 312271 Updated the change log View in context: https://bugs.webkit.org/attachment.cgi?id=312271&action=review > Source/WebCore/ChangeLog:5 > + Is there a radar link we can include? > Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:198 > + if (visiblePos.isNull()) Nit - Can we move this to right after we create visiblePos, so we don't have to calculateStyleBeforeInsertion() unnecessarily in the case that visiblePos.isNull()? 1317168 5 rniwa 2017-06-08 19:11:45 -0700 (In reply to Wenson Hsieh from comment #4) > Comment on attachment 312271 [details] > Updated the change log > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312271&action=review > > > Source/WebCore/ChangeLog:5 > > + > > Is there a radar link we can include? Added. > > Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:198 > > + if (visiblePos.isNull()) > > Nit - Can we move this to right after we create visiblePos, so we don't have > to calculateStyleBeforeInsertion() unnecessarily in the case that > visiblePos.isNull()? Fixed. 1317169 6 rniwa 2017-06-08 19:13:08 -0700 Committed r217958: <http://trac.webkit.org/changeset/217958> 312270 2017-06-07 20:35:55 -0700 2017-06-07 20:37:18 -0700 Fixes the bug bug-173085-20170607203554.patch text/plain 4336 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzkxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTA3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluc2lkZSBJbnNlcnRO b2RlQmVmb3JlQ29tbWFuZCB2aWEgSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMDg1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZWRpdGlu Zy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS1pbi1lbXB0eS1kb2N1bWVudC1jcmFz aC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0luc2VydFBhcmFncmFwaFNlcGFyYXRvckNvbW1h bmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFu ZDo6ZG9BcHBseSk6CisKIDIwMTctMDYtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBDU1NTdHlsZVJ1bGUuc3R5bGUgLyBDU1NQYWdlUnVsZS5zdHlsZSAvIENT U0tleWZyYW1lUnVsZS5zdHlsZSBzaG91bGQgYmUgc2V0dGFibGUKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2VkaXRpbmcvSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21t YW5kLmNwcAkocmV2aXNpb24gMjE3OTEzKQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbnNl cnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk0LDYg KzE5NCw5IEBAIHZvaWQgSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZDo6ZG8KIAogICAg IC8vLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCiAgICAgLy8gUHJlcGFyZSBmb3IgbW9yZSBnZW5lcmFsIGNhc2VzLgor ICAgIAorICAgIGlmICh2aXNpYmxlUG9zLmlzTnVsbCgpKQorICAgICAgICByZXR1cm47CiAKICAg ICBib29sIGlzRmlyc3RJbkJsb2NrID0gaXNTdGFydE9mQmxvY2sodmlzaWJsZVBvcyk7CiAgICAg Ym9vbCBpc0xhc3RJbkJsb2NrID0gaXNFbmRPZkJsb2NrKHZpc2libGVQb3MpOwpAQCAtMjY2LDkg KzI2OSw4IEBAIHZvaWQgSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZDo6ZG8KICAgICAg ICAgICAgIC8vIHN0YXJ0QmxvY2sgc2hvdWxkIGFsd2F5cyBoYXZlIGNoaWxkcmVuLCBvdGhlcndp c2UgaXNMYXN0SW5CbG9jayB3b3VsZCBiZSB0cnVlIGFuZCBpdCdzIGhhbmRsZWQgYWJvdmUuCiAg ICAgICAgICAgICBBU1NFUlQoc3RhcnRCbG9jay0+Zmlyc3RDaGlsZCgpKTsKICAgICAgICAgICAg IHJlZk5vZGUgPSBzdGFydEJsb2NrLT5maXJzdENoaWxkKCk7Ci0gICAgICAgIH0KLSAgICAgICAg ZWxzZSBpZiAoaW5zZXJ0aW9uUG9zaXRpb24uZGVwcmVjYXRlZE5vZGUoKSA9PSBzdGFydEJsb2Nr ICYmIG5lc3ROZXdCbG9jaykgewotICAgICAgICAgICAgcmVmTm9kZSA9IHN0YXJ0QmxvY2stPnRy YXZlcnNlVG9DaGlsZEF0KGluc2VydGlvblBvc2l0aW9uLmRlcHJlY2F0ZWRFZGl0aW5nT2Zmc2V0 KCkpOworICAgICAgICB9IGVsc2UgaWYgKGluc2VydGlvblBvc2l0aW9uLmNvbnRhaW5lck5vZGUo KSA9PSBzdGFydEJsb2NrICYmIG5lc3ROZXdCbG9jaykgeworICAgICAgICAgICAgcmVmTm9kZSA9 IHN0YXJ0QmxvY2stPnRyYXZlcnNlVG9DaGlsZEF0KGluc2VydGlvblBvc2l0aW9uLmNvbXB1dGVP ZmZzZXRJbkNvbnRhaW5lck5vZGUoKSk7CiAgICAgICAgICAgICBBU1NFUlQocmVmTm9kZSk7IC8v IG11c3QgYmUgdHJ1ZSBvciB3ZSdkIGJlIGluIHRoZSBlbmQgb2YgYmxvY2sgY2FzZQogICAgICAg ICB9IGVsc2UKICAgICAgICAgICAgIHJlZk5vZGUgPSBpbnNlcnRpb25Qb3NpdGlvbi5kZXByZWNh dGVkTm9kZSgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjE3OTEzKQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDYtMDcgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ3Jhc2ggaW5zaWRlIEluc2Vy dE5vZGVCZWZvcmVDb21tYW5kIHZpYSBJbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMwODUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIHJl Z3Jlc2lvbiB0ZXN0LgorCisgICAgICAgICogZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6 b250YWwtcnVsZS1pbi1lbXB0eS1kb2N1bWVudC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtaW4tZW1w dHktZG9jdW1lbnQtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTctMDYtMDcgIERldmluIFJvdXNz byAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBDb250 ZXh0TWVudSBpdGVtIHRvIGxvZyBXZWJTb2NrZXQgb2JqZWN0IHRvIGNvbnNvbGUKSW5kZXg6IExh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtaW4tZW1w dHktZG9jdW1lbnQtY3Jhc2gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtaW4tZW1wdHktZG9jdW1l bnQtY3Jhc2gtZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2VkaXRp bmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtaW4tZW1wdHktZG9jdW1lbnQtY3Jh c2gtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEgQEAKK1BBU1MuIFdlYktp dCBkaWQgbm90IGNyYXNoLgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5z ZXJ0LWhvcml6b250YWwtcnVsZS1pbi1lbXB0eS1kb2N1bWVudC1jcmFzaC5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1 bGUtaW4tZW1wdHktZG9jdW1lbnQtY3Jhc2guaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRU ZXN0cy9lZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaG9yaXpvbnRhbC1ydWxlLWluLWVtcHR5LWRv Y3VtZW50LWNyYXNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyMSBAQAorPGh0bWw+ Cis8aGVhZD4KKzxzY3JpcHQ+CitmdW5jdGlvbiBydW5UZXN0KCkKK3sKKyAgIGRvY3VtZW50LmV4 ZWNDb21tYW5kKCJzZWxlY3RBbGwiLCB0cnVlKTsKKyAgIGRvY3VtZW50WydkZXNpZ25Nb2RlJ10g PSAnb24nOworICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImluc2VydEhvcml6b250YWxSdWxlIiwg dHJ1ZSk7CisgICBkb2N1bWVudC5ib2R5LnJlcGxhY2VXaXRoKGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoJ2RpdicpKTsKKyAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJpbnNlcnRIb3Jpem9udGFsUnVs ZSIsIHRydWUpOworICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgdGVzdFJ1bm5l ci5kdW1wQXNUZXh0KCk7CisgICAgICAgZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50LnRleHRDb250 ZW50ID0gJ1BBU1MuIFdlYktpdCBkaWQgbm90IGNyYXNoLic7CisgICB9Cit9Cit3aW5kb3cub25s b2FkID0gcnVuVGVzdDsKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8L2JvZHk+Cis8L2h0 bWw+Cg== 312271 2017-06-07 20:37:19 -0700 2017-06-08 19:12:04 -0700 Updated the change log bug-173085-20170607203718.patch text/plain 4586 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzkxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA2LTA3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluc2lkZSBJbnNlcnRO b2RlQmVmb3JlQ29tbWFuZCB2aWEgSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMDg1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNyYXNoIHdh cyBjYXVzZWQgYnkgdGhlIGNvbmRpdGlvbiB0byBjaGVjayBmb3Igc3BlY2lhbCBjYXNlcyBmYWls aW5nIHdoZW4gdmlzaWJsZVBvcyBpcyBudWxsLgorICAgICAgICBFeGl0IGVhcmx5IGluIHRoZXNl IGV4dHJlbWUgY2FzZXMuCisKKyAgICAgICAgQWxzbyByZXBsYWNlZCB0aGUgdXNlIG9mIGRlcHJl Y2F0ZWROb2RlIGFuZCBkZXByZWNhdGVkRWRpdGluZ09mZnNldCB0byBtb2Rlcm4gaWRpb21zLgor CisgICAgICAgIFRlc3Q6IGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUt aW4tZW1wdHktZG9jdW1lbnQtY3Jhc2guaHRtbAorCisgICAgICAgICogZWRpdGluZy9JbnNlcnRQ YXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc2VydFBh cmFncmFwaFNlcGFyYXRvckNvbW1hbmQ6OmRvQXBwbHkpOgorCiAyMDE3LTA2LTA3ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQ1NTU3R5bGVSdWxlLnN0eWxlIC8g Q1NTUGFnZVJ1bGUuc3R5bGUgLyBDU1NLZXlmcmFtZVJ1bGUuc3R5bGUgc2hvdWxkIGJlIHNldHRh YmxlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0luc2VydFBhcmFncmFwaFNlcGFyYXRv ckNvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0 UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZC5jcHAJKHJldmlzaW9uIDIxNzkxMykKKysrIFNvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQ29tbWFuZC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE5NCw2ICsxOTQsOSBAQCB2b2lkIEluc2VydFBhcmFncmFwaFNlcGFy YXRvckNvbW1hbmQ6OmRvCiAKICAgICAvLy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogICAgIC8vIFByZXBhcmUgZm9y IG1vcmUgZ2VuZXJhbCBjYXNlcy4KKyAgICAKKyAgICBpZiAodmlzaWJsZVBvcy5pc051bGwoKSkK KyAgICAgICAgcmV0dXJuOwogCiAgICAgYm9vbCBpc0ZpcnN0SW5CbG9jayA9IGlzU3RhcnRPZkJs b2NrKHZpc2libGVQb3MpOwogICAgIGJvb2wgaXNMYXN0SW5CbG9jayA9IGlzRW5kT2ZCbG9jayh2 aXNpYmxlUG9zKTsKQEAgLTI2Niw5ICsyNjksOCBAQCB2b2lkIEluc2VydFBhcmFncmFwaFNlcGFy YXRvckNvbW1hbmQ6OmRvCiAgICAgICAgICAgICAvLyBzdGFydEJsb2NrIHNob3VsZCBhbHdheXMg aGF2ZSBjaGlsZHJlbiwgb3RoZXJ3aXNlIGlzTGFzdEluQmxvY2sgd291bGQgYmUgdHJ1ZSBhbmQg aXQncyBoYW5kbGVkIGFib3ZlLgogICAgICAgICAgICAgQVNTRVJUKHN0YXJ0QmxvY2stPmZpcnN0 Q2hpbGQoKSk7CiAgICAgICAgICAgICByZWZOb2RlID0gc3RhcnRCbG9jay0+Zmlyc3RDaGlsZCgp OwotICAgICAgICB9Ci0gICAgICAgIGVsc2UgaWYgKGluc2VydGlvblBvc2l0aW9uLmRlcHJlY2F0 ZWROb2RlKCkgPT0gc3RhcnRCbG9jayAmJiBuZXN0TmV3QmxvY2spIHsKLSAgICAgICAgICAgIHJl Zk5vZGUgPSBzdGFydEJsb2NrLT50cmF2ZXJzZVRvQ2hpbGRBdChpbnNlcnRpb25Qb3NpdGlvbi5k ZXByZWNhdGVkRWRpdGluZ09mZnNldCgpKTsKKyAgICAgICAgfSBlbHNlIGlmIChpbnNlcnRpb25Q b3NpdGlvbi5jb250YWluZXJOb2RlKCkgPT0gc3RhcnRCbG9jayAmJiBuZXN0TmV3QmxvY2spIHsK KyAgICAgICAgICAgIHJlZk5vZGUgPSBzdGFydEJsb2NrLT50cmF2ZXJzZVRvQ2hpbGRBdChpbnNl cnRpb25Qb3NpdGlvbi5jb21wdXRlT2Zmc2V0SW5Db250YWluZXJOb2RlKCkpOwogICAgICAgICAg ICAgQVNTRVJUKHJlZk5vZGUpOyAvLyBtdXN0IGJlIHRydWUgb3Igd2UnZCBiZSBpbiB0aGUgZW5k IG9mIGJsb2NrIGNhc2UKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICByZWZOb2RlID0gaW5z ZXJ0aW9uUG9zaXRpb24uZGVwcmVjYXRlZE5vZGUoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzkx MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTA2LTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAg ICAgIENyYXNoIGluc2lkZSBJbnNlcnROb2RlQmVmb3JlQ29tbWFuZCB2aWEgSW5zZXJ0UGFyYWdy YXBoU2VwYXJhdG9yQ29tbWFuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTczMDg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNpb24gdGVzdC4KKworICAgICAgICAqIGVkaXRpbmcv aW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtaW4tZW1wdHktZG9jdW1lbnQtY3Jhc2gt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQt aG9yaXpvbnRhbC1ydWxlLWluLWVtcHR5LWRvY3VtZW50LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAy MDE3LTA2LTA3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBBZGQgQ29udGV4dE1lbnUgaXRlbSB0byBsb2cgV2ViU29ja2V0IG9iamVj dCB0byBjb25zb2xlCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9pbnNlcnQt aG9yaXpvbnRhbC1ydWxlLWluLWVtcHR5LWRvY3VtZW50LWNyYXNoLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaG9yaXpvbnRh bC1ydWxlLWluLWVtcHR5LWRvY3VtZW50LWNyYXNoLWV4cGVjdGVkLnR4dAkobm9uZXhpc3RlbnQp CisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaG9yaXpvbnRhbC1ydWxl LWluLWVtcHR5LWRvY3VtZW50LWNyYXNoLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxIEBACitQQVNTLiBXZWJLaXQgZGlkIG5vdCBjcmFzaC4KSW5kZXg6IExheW91dFRlc3Rz L2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtaW4tZW1wdHktZG9jdW1l bnQtY3Jhc2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGlu Zy9pbnNlcnQtaG9yaXpvbnRhbC1ydWxlLWluLWVtcHR5LWRvY3VtZW50LWNyYXNoLmh0bWwJKG5v bmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6 b250YWwtcnVsZS1pbi1lbXB0eS1kb2N1bWVudC1jcmFzaC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMjEgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorZnVuY3Rpb24gcnVuVGVz dCgpCit7CisgICBkb2N1bWVudC5leGVjQ29tbWFuZCgic2VsZWN0QWxsIiwgdHJ1ZSk7CisgICBk b2N1bWVudFsnZGVzaWduTW9kZSddID0gJ29uJzsKKyAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJp bnNlcnRIb3Jpem9udGFsUnVsZSIsIHRydWUpOworICAgZG9jdW1lbnQuYm9keS5yZXBsYWNlV2l0 aChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKSk7CisgICBkb2N1bWVudC5leGVjQ29tbWFu ZCgiaW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCB0cnVlKTsKKyAgIGlmICh3aW5kb3cudGVzdFJ1bm5l cikgeworICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgIGRvY3VtZW50LmRv Y3VtZW50RWxlbWVudC50ZXh0Q29udGVudCA9ICdQQVNTLiBXZWJLaXQgZGlkIG5vdCBjcmFzaC4n OworICAgfQorfQord2luZG93Lm9ubG9hZCA9IHJ1blRlc3Q7Cis8L3NjcmlwdD4KKzwvaGVhZD4K Kzxib2R5PgorPC9ib2R5PgorPC9odG1sPgo=